From: jprocter <Jim Procter>
Date: Fri, 21 May 2010 10:07:17 +0000 (+0000)
Subject: comment about trapping OOMs
X-Git-Tag: Release_2_6~218
X-Git-Url: http://source.jalview.org/gitweb/?a=commitdiff_plain;h=756dd0708adb5f8a98958ce127593f191dfd75b1;p=jalview.git

comment about trapping OOMs
---

diff --git a/src/jalview/ws/JobStateSummary.java b/src/jalview/ws/JobStateSummary.java
index 0983dc0..e6d176a 100644
--- a/src/jalview/ws/JobStateSummary.java
+++ b/src/jalview/ws/JobStateSummary.java
@@ -54,8 +54,8 @@ public class JobStateSummary
    * @param OutputHeader
    * @param j
    */
-  public void updateJobPanelState(WebserviceInfo wsInfo, String OutputHeader,
-          AWsJob j)
+  public void updateJobPanelState(WebserviceInfo wsInfo,
+          String OutputHeader, AWsJob j)
   {
     if (j.submitted)
     {
@@ -108,7 +108,16 @@ public class JobStateSummary
       wsInfo.appendProgressText(j.jobnum, progheader);
       if (j.hasStatus())
       {
+        // Could try to squash OOMs here, but it usually doesn't help - there probably won't be
+        // enough memory to handle the results later on anyway.
+        // try {
         wsInfo.appendProgressText(j.jobnum, j.getStatus());
+        // } catch (OutOfMemoryError e)
+        // {
+        // System.err.println("Out of memory when displaying status. Squashing error.");
+        // wsInfo.appendProgressText(j.jobnum,
+        // "..\n(Out of memory when displaying status)\n");
+        // }
       }
     }
     else