From: Jim Procter <jprocter@issues.jalview.org>
Date: Tue, 2 May 2017 13:17:23 +0000 (+0100)
Subject: JAL-2424 fixme’s removed
X-Git-Tag: Release_2_10_2~3^2~105^2~2^2~6
X-Git-Url: http://source.jalview.org/gitweb/?a=commitdiff_plain;h=a7d1a5ed63200f60f5365322e0711ddb05563409;p=jalview.git

JAL-2424 fixme’s removed
---

diff --git a/test/jalview/analysis/scoremodels/FeatureDistanceModelTest.java b/test/jalview/analysis/scoremodels/FeatureDistanceModelTest.java
index 6df8a66..0577fae 100644
--- a/test/jalview/analysis/scoremodels/FeatureDistanceModelTest.java
+++ b/test/jalview/analysis/scoremodels/FeatureDistanceModelTest.java
@@ -264,9 +264,6 @@ public class FeatureDistanceModelTest
     assertEquals(distances.getValue(0, 0), 0d);
     assertEquals(distances.getValue(1, 1), 0d);
 
-    // these left to fail pending resolution of
-    // JAL-2424 (computing score as 5/6, should be 5/5)
-    // see also PCATest.testComputeSimilarity_featureDistances()
     assertEquals(distances.getValue(0, 1), 1d,
             "expected identical pairs. (check normalisation for similarity score)");
     assertEquals(distances.getValue(1, 0), 1d);
@@ -305,7 +302,6 @@ public class FeatureDistanceModelTest
     /*
      * exclude gaps
      * score = 3 + 3 + 0 + 0 + 0 + 0 = 6/6
-    // FIXME out by 1 error in cpwidth JAL-2424 - dividing by 7
      */
     params = new SimilarityParams(true, true, false, true);
     distances = sm.findDistances(view, params);