From: James Procter <j.procter@dundee.ac.uk>
Date: Fri, 10 Feb 2023 16:26:37 +0000 (+0000)
Subject: Fix for JAL-4126 - don’t automatically create a threshold line when no threshold... 
X-Git-Tag: Release_2_11_3_0~23^2~2^2~1
X-Git-Url: http://source.jalview.org/gitweb/?a=commitdiff_plain;h=e7623d0a250b5d4908c45d50f52a78be4e339ce7;p=jalview.git

Fix for JAL-4126 - don’t automatically create a threshold line when no threshold line is needed when reconstructing the annotation colour scheme from a project file
---

diff --git a/src/jalview/project/Jalview2XML.java b/src/jalview/project/Jalview2XML.java
index c8f9be6..c900c06 100644
--- a/src/jalview/project/Jalview2XML.java
+++ b/src/jalview/project/Jalview2XML.java
@@ -5094,7 +5094,10 @@ public class Jalview2XML
               + annotationId);
       return null;
     }
-    if (matchedAnnotation.getThreshold() == null)
+    // belt-and-braces create a threshold line if the 
+    // colourscheme needs one but the matchedAnnotation doesn't have one
+    if (safeInt(viewAnnColour.getAboveThreshold()) != 0
+            && matchedAnnotation.getThreshold() == null)
     {
       matchedAnnotation.setThreshold(
               new GraphLine(safeFloat(viewAnnColour.getThreshold()),