From: Jim Procter <jprocter@issues.jalview.org>
Date: Tue, 13 Feb 2018 16:16:04 +0000 (+0000)
Subject: JAL-2780 scan all test IDs before testing and reporting test failures - currently... 
X-Git-Tag: Release_2_10_4~68^2
X-Git-Url: http://source.jalview.org/gitweb/?a=commitdiff_plain;h=refs%2Fheads%2Fbugs%2FJAL-2780_JAL-2781_pdbnegativenums;p=jalview.git

JAL-2780 scan all test IDs before testing and reporting test failures - currently failing for 4im2 and Resnum==0 (seq pos 0)
---

diff --git a/test/jalview/ws/PDBSequenceFetcherTest.java b/test/jalview/ws/PDBSequenceFetcherTest.java
index 9efcef2..cc3dca8 100644
--- a/test/jalview/ws/PDBSequenceFetcherTest.java
+++ b/test/jalview/ws/PDBSequenceFetcherTest.java
@@ -132,6 +132,7 @@ public class PDBSequenceFetcherTest
   private void testRetrieveProteinSeqFromPDB() throws Exception
   {
     List<DbSourceProxy> sps = sf.getSourceProxy("PDB");
+    StringBuilder errors = new StringBuilder();
     for (TestRetrieveObject str : toRetrieve)
     {
       AlignmentI response = sps.get(0).getSequenceRecords(str.id);
@@ -174,11 +175,11 @@ public class PDBSequenceFetcherTest
             lastp = sq.findPosition(col - 1);
           }
         }
-        if (errors.length() > 0)
-        {
-          Assert.fail(errors.toString());
-        }
       }
     }
+    if (errors.length() > 0)
+    {
+      Assert.fail(errors.toString());
+    }
   }
 }