From 3303ad135025ac8b36ebb95f52d113a7b7df5444 Mon Sep 17 00:00:00 2001 From: Ben Soares Date: Wed, 8 Mar 2023 15:12:50 +0000 Subject: [PATCH] JAL-629 improved comment and return speed of StringUtils.replaceLast() --- src/jalview/util/StringUtils.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/jalview/util/StringUtils.java b/src/jalview/util/StringUtils.java index 7e1b8ad..efaf3e2 100644 --- a/src/jalview/util/StringUtils.java +++ b/src/jalview/util/StringUtils.java @@ -600,6 +600,7 @@ public class StringUtils /* * implementation of String.replaceLast. + * Replaces only the last occurrence of toReplace in string with replacement. */ public static String replaceLast(String string, String toReplace, String replacement) @@ -607,8 +608,10 @@ public class StringUtils int pos = string.lastIndexOf(toReplace); if (pos > -1) { - return string.substring(0, pos) + replacement - + string.substring(pos + toReplace.length()); + return new StringBuilder().append(string.substring(0, pos)) + .append(replacement) + .append(string.substring(pos + toReplace.length())) + .toString(); } else { -- 1.7.10.2