From 728cc74b3df1bfb78de1a2a42c3ca81fe6e89c89 Mon Sep 17 00:00:00 2001 From: Jim Procter Date: Mon, 17 Feb 2020 12:28:40 +0000 Subject: [PATCH] JAL-3187 better semantics for feature settings closed event handler --- src/jalview/controller/FeatureSettingsControllerGuiI.java | 2 +- src/jalview/gui/FeatureSettings.java | 4 ++-- src/jalview/gui/SplitFrame.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/jalview/controller/FeatureSettingsControllerGuiI.java b/src/jalview/controller/FeatureSettingsControllerGuiI.java index 758df93..237e944 100644 --- a/src/jalview/controller/FeatureSettingsControllerGuiI.java +++ b/src/jalview/controller/FeatureSettingsControllerGuiI.java @@ -27,6 +27,6 @@ public interface FeatureSettingsControllerGuiI AlignViewControllerGuiI getAlignframe(); - void closeFeatureSettings(); + void featureSettings_isClosed(); } diff --git a/src/jalview/gui/FeatureSettings.java b/src/jalview/gui/FeatureSettings.java index 4dca630..961ff14 100644 --- a/src/jalview/gui/FeatureSettings.java +++ b/src/jalview/gui/FeatureSettings.java @@ -406,7 +406,7 @@ public class FeatureSettings extends JPanel public void internalFrameClosed( javax.swing.event.InternalFrameEvent evt) { - closeFeatureSettings(); + featureSettings_isClosed(); }; }); frame.setLayer(JLayeredPane.PALETTE_LAYER); @@ -423,7 +423,7 @@ public class FeatureSettings extends JPanel } @Override - public void closeFeatureSettings() + public void featureSettings_isClosed() { fr.removePropertyChangeListener(change); change = null; diff --git a/src/jalview/gui/SplitFrame.java b/src/jalview/gui/SplitFrame.java index 6d5bd34..513303f 100644 --- a/src/jalview/gui/SplitFrame.java +++ b/src/jalview/gui/SplitFrame.java @@ -953,7 +953,7 @@ public class SplitFrame extends GSplitFrame implements SplitContainerI if (fsettings != null) { featureSettingsPanels.removeTabAt(tab); - fsettings.closeFeatureSettings(); + fsettings.featureSettings_isClosed(); } else { -- 1.7.10.2