From 7d92d3994908aae709e7c85cc5e1a1c4775907ed Mon Sep 17 00:00:00 2001
From: Jim Procter <jprocter@issues.jalview.org>
Date: Fri, 5 Feb 2021 17:07:18 +0000
Subject: [PATCH] JAL-3746 JAL-3813 NOIDENTIFIERSSERVICE preference disables
 jalview pinging www.jalview.org/services/identifiers to get
 a list of URL link templates for viewing database
 crossreferences

---
 src/jalview/bin/Cache.java                  |    7 ++++++-
 src/jalview/gui/Desktop.java                |   26 +++++++++++++++++---------
 src/jalview/ws/utils/UrlDownloadClient.java |    5 -----
 3 files changed, 23 insertions(+), 15 deletions(-)

diff --git a/src/jalview/bin/Cache.java b/src/jalview/bin/Cache.java
index adfd206..8eef930 100755
--- a/src/jalview/bin/Cache.java
+++ b/src/jalview/bin/Cache.java
@@ -198,8 +198,13 @@ import jalview.ws.sifts.SiftsSettings;
  * <li>CHIMERA_PATH specify full path to Chimera program (if non-standard)</li>
  * <li>ID_ORG_HOSTURL location of jalview service providing identifiers.org urls
  * </li>
- * 
  * <li>NONEWS - when set disables Jalview News from automatically appearing</li>
+ * <li>NOHTMLTEMPLATES - when set, the
+ * https://github.com/jalview/exporter-templates/tree/master/biojs repository is
+ * not downloaded automatically</li>
+ * <li>NOIDENTIFIERSSERVICE - when set, jalview won't automatically download
+ * available URL linkouts via www.jalview.org/services/identifiers</li>
+ * <li>
  * </ul>
  * Deprecated settings:
  * <ul>
diff --git a/src/jalview/gui/Desktop.java b/src/jalview/gui/Desktop.java
index c713a94..429a2c1 100644
--- a/src/jalview/gui/Desktop.java
+++ b/src/jalview/gui/Desktop.java
@@ -582,20 +582,28 @@ public class Desktop extends jalview.jbgui.GDesktop
     }).start();
   }
 
-  public void getIdentifiersOrgData() {
-    if (Cache.getProperty("NOIDENTIFIERSSERVICE") == null) {
-      // Thread off the identifiers fetcher
-      new Thread(new Runnable() {
+  public void getIdentifiersOrgData()
+  {
+    if (Cache.getProperty("NOIDENTIFIERSSERVICE") == null)
+    {// Thread off the identifiers fetcher
+      new Thread(new Runnable()
+      {
         @Override
-        public void run() {
+        public void run()
+        {
           jalview.bin.Console.debug("Downloading data from identifiers.org");
-          try {
-            UrlDownloadClient.download(IdOrgSettings.getUrl(), IdOrgSettings.getDownloadLocation());
-          } catch (IOException e) {
-            jalview.bin.Console.debug("Exception downloading identifiers.org data" + e.getMessage());
+          try
+          {
+            UrlDownloadClient.download(IdOrgSettings.getUrl(),
+                    IdOrgSettings.getDownloadLocation());
+          } catch (IOException e)
+          {
+            jalview.bin.Console.debug("Exception downloading identifiers.org data"
+                    + e.getMessage());
           }
         }
       }).start();
+      ;
     }
   }
 
diff --git a/src/jalview/ws/utils/UrlDownloadClient.java b/src/jalview/ws/utils/UrlDownloadClient.java
index 58632f2..235d271 100644
--- a/src/jalview/ws/utils/UrlDownloadClient.java
+++ b/src/jalview/ws/utils/UrlDownloadClient.java
@@ -36,11 +36,6 @@ import java.nio.file.StandardCopyOption;
 
 public class UrlDownloadClient
 {
-  public UrlDownloadClient()
-  {
-
-  }
-
   /**
    * Download and save a file from a URL
    * 
-- 
1.7.10.2