From cb250d2031d928304db5bed196f5bdf816ad79d6 Mon Sep 17 00:00:00 2001 From: Jim Procter Date: Mon, 4 Apr 2016 15:48:42 +0100 Subject: [PATCH] JAL-2001 - note about possible side effect on JalviewLite.selectIn due to refactored columnSelection - maybe need a test here --- src/jalview/bin/JalviewLite.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/jalview/bin/JalviewLite.java b/src/jalview/bin/JalviewLite.java index ae84ba5..095cfd3 100644 --- a/src/jalview/bin/JalviewLite.java +++ b/src/jalview/bin/JalviewLite.java @@ -459,6 +459,9 @@ public class JalviewLite extends Applet implements if (csel != null) { List cs = csel.getSelected(); + // note - the following actually clears cs as well, since + // csel.getSelected returns a reference. Need to check if we need to + // have a concurrentModification exception thrown here csel.clear(); for (Integer selectedCol : cs) { -- 1.7.10.2