From eeb9907df14f1015db254a87bcc8db35e10ba02d Mon Sep 17 00:00:00 2001 From: gmungoc Date: Thu, 9 Feb 2017 09:01:13 +0000 Subject: [PATCH] JAL-2371 skip upper-casing consensus as it already is --- src/jalview/schemes/Blosum62ColourScheme.java | 5 ++--- src/jalview/schemes/PIDColourScheme.java | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/jalview/schemes/Blosum62ColourScheme.java b/src/jalview/schemes/Blosum62ColourScheme.java index 53670e3..f35b886 100755 --- a/src/jalview/schemes/Blosum62ColourScheme.java +++ b/src/jalview/schemes/Blosum62ColourScheme.java @@ -54,10 +54,9 @@ public class Blosum62ColourScheme extends ResidueColourScheme String consensusResidue, float pid) { /* - * compare as upper case; note toUpperCase does nothing - * if the string is already uppercase + * compare as upper case; note consensusResidue is + * always computed as uppercase */ - consensusResidue = consensusResidue.toUpperCase(); if ('a' <= res && res <= 'z') { res -= ('a' - 'A'); diff --git a/src/jalview/schemes/PIDColourScheme.java b/src/jalview/schemes/PIDColourScheme.java index f213abe..657d6b0 100755 --- a/src/jalview/schemes/PIDColourScheme.java +++ b/src/jalview/schemes/PIDColourScheme.java @@ -47,10 +47,9 @@ public class PIDColourScheme extends ResidueColourScheme String consensusResidue, float pid) { /* - * make everything uppercase; note this does nothing - * if consensusResidue is already uppercase + * compare as upper case; note consensusResidue is + * always computed as uppercase */ - consensusResidue = consensusResidue.toUpperCase(); if ('a' <= c && c <= 'z') { c -= ('a' - 'A'); -- 1.7.10.2