From 68f3676bed58ab5f4fdfbd71dcaf4e1ed61d380f Mon Sep 17 00:00:00 2001 From: gmungoc Date: Fri, 15 Sep 2017 15:03:34 +0100 Subject: [PATCH] JAL-2728 use right denominator for min/max ratio calculations --- src/jalview/gui/SplitFrame.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/jalview/gui/SplitFrame.java b/src/jalview/gui/SplitFrame.java index d28bb14..c23ed7c 100644 --- a/src/jalview/gui/SplitFrame.java +++ b/src/jalview/gui/SplitFrame.java @@ -228,19 +228,19 @@ public class SplitFrame extends GSplitFrame implements SplitContainerI * two sequences visible in the top panel */ int topPanelHeight = topFrame.getHeight(); + int bottomPanelHeight = bottomFrame.getHeight(); int topSequencesHeight = topFrame.alignPanel.getSeqPanel().seqCanvas .getHeight(); int topPanelMinHeight = topPanelHeight - Math.max(0, topSequencesHeight - 2 * topViewport.getCharHeight()); - int myHeight = getHeight(); - double minRatio = topPanelMinHeight / (double) myHeight; + double totalHeight = (double) topPanelHeight + bottomPanelHeight; + double minRatio = topPanelMinHeight / totalHeight; /* * calculate the maximum ratio that leaves at least * two sequences visible in the bottom panel */ - int bottomPanelHeight = bottomFrame.getHeight(); int bottomSequencesHeight = bottomFrame.alignPanel.getSeqPanel().seqCanvas .getHeight(); int bottomPanelMinHeight = bottomPanelHeight @@ -248,7 +248,7 @@ public class SplitFrame extends GSplitFrame implements SplitContainerI 0, bottomSequencesHeight - 2 * bottomViewport.getCharHeight()); - double maxRatio = (myHeight - bottomPanelMinHeight) / (double) myHeight; + double maxRatio = (totalHeight - bottomPanelMinHeight) / totalHeight; /* * estimate ratio of (topFrameContent / bottomFrameContent) -- 1.7.10.2