JAL-3608 Changes from code review CR-JAL-236
authorBen Soares <b.soares@dundee.ac.uk>
Tue, 7 Jul 2020 23:47:55 +0000 (00:47 +0100)
committerJim Procter <jprocter@issues.jalview.org>
Wed, 12 Aug 2020 10:14:30 +0000 (11:14 +0100)
 Conflicts:
src/jalview/bin/Jalview.java

src/jalview/bin/Jalview.java

index 35b21df..e2c9c1b 100755 (executable)
@@ -817,27 +817,22 @@ public class Jalview
 
   private static boolean setCrossPlatformLookAndFeel()
   {
-    boolean set = false;
-    try
-    {
-      UIManager.setLookAndFeel(
-              UIManager.getCrossPlatformLookAndFeelClassName());
-      set = true;
-    } catch (Exception ex)
-    {
-      Cache.log.error("Unexpected Look and Feel Exception");
-      Cache.log.error(ex.getMessage());
-      Cache.log.debug(Cache.getStackTraceString(ex));
-    }
-    return set;
+    return setGenericLookAndFeel(false);
   }
 
   private static boolean setSystemLookAndFeel()
   {
+    return setGenericLookAndFeel(true);
+  }
+
+  private static boolean setGenericLookAndFeel(boolean system)
+  {
     boolean set = false;
     try
     {
-      UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName());
+      UIManager.setLookAndFeel(
+              system ? UIManager.getSystemLookAndFeelClassName()
+                      : UIManager.getCrossPlatformLookAndFeelClassName());
       set = true;
     } catch (Exception ex)
     {