From: Ben Soares <b.soares@dundee.ac.uk>
Date: Thu, 13 Aug 2020 22:05:00 +0000 (+0100)
Subject: JAL-3597 Increased heap passmark to <= 45MB and report smallest of failed attempts... 
X-Git-Tag: Release_2_11_1_1~13^2~12^2
X-Git-Url: http://source.jalview.org/gitweb/?p=jalview.git;a=commitdiff_plain;h=167b39c275206a252a8115997616995e6353a869

JAL-3597 Increased heap passmark to <= 45MB and report smallest of failed attempts heap size
---

diff --git a/test/jalview/gui/FreeUpMemoryTest.java b/test/jalview/gui/FreeUpMemoryTest.java
index 09ee560..3a5a9e4 100644
--- a/test/jalview/gui/FreeUpMemoryTest.java
+++ b/test/jalview/gui/FreeUpMemoryTest.java
@@ -90,7 +90,7 @@ public class FreeUpMemoryTest
   /*
    * maximum retained heap usage (in MB) for a passing test
    */
-  private static int MAX_RESIDUAL_HEAP = 38;
+  private static int MAX_RESIDUAL_HEAP = 45;
 
   /**
    * Configure (read-only) Jalview property settings for test
@@ -134,7 +134,7 @@ public class FreeUpMemoryTest
     long freeMemory = Runtime.getRuntime().freeMemory();
     long usedMemory = availableMemory - freeMemory;
 
-    return (int) (usedMemory/ ONE_MB);
+    return (int) (usedMemory / ONE_MB);
   }
 
   /**
@@ -150,6 +150,7 @@ public class FreeUpMemoryTest
      * NB there is no guarantee when, or whether, it will do so
      */
     long usedMemory = 0L;
+    Long minUsedMemory = null;
     int gcCount = 0;
     while (gcCount < 3)
     {
@@ -157,6 +158,10 @@ public class FreeUpMemoryTest
       System.gc();
       waitFor(1500);
       usedMemory = getUsedMemory();
+      if (minUsedMemory == null || usedMemory < minUsedMemory)
+      {
+        minUsedMemory = usedMemory;
+      }
       if (usedMemory < expectedMax)
       {
         break;
@@ -171,9 +176,9 @@ public class FreeUpMemoryTest
      * - take a heap dump and identify large objects in the heap and their referers
      * - fix code as necessary to null the references on close
      */
-    System.out
-            .println("Used memory after " + gcCount + " call(s) to gc() = "
-                    + usedMemory + "MB (should be <=" + expectedMax + ")");
+    System.out.println("(Minimum) Used memory after " + gcCount
+            + " call(s) to gc() = " + minUsedMemory + "MB (should be <="
+            + expectedMax + ")");
     assertTrue(usedMemory <= expectedMax, String.format(
             "Used memory %d should be less than %d (Recommend running test manually to verify)",
             usedMemory, expectedMax));