Merge branch 'features/JAL-2360colourSchemeApplicability' into

[jalview.git] / src / jalview / appletgui / AlignFrame.java

diff --git a/src/jalview/appletgui/AlignFrame.java b/src/jalview/appletgui/AlignFrame.java
index cfd3d00..9876bb3 100644 (file)
--- a/src/jalview/appletgui/AlignFrame.java
+++ b/src/jalview/appletgui/AlignFrame.java
@@ -65,7 +65,6 @@ import jalview.schemes.NucleotideColourScheme;
 import jalview.schemes.PIDColourScheme;
 import jalview.schemes.PurinePyrimidineColourScheme;
 import jalview.schemes.RNAHelicesColour;
-import jalview.schemes.RNAHelicesColourChooser;
 import jalview.schemes.StrandColourScheme;
 import jalview.schemes.TCoffeeColourScheme;
 import jalview.schemes.TaylorColourScheme;
@@ -2632,27 +2631,30 @@ public class AlignFrame extends EmbmenuFrame implements ActionListener,
   @Override
   public void changeColour(ColourSchemeI cs)
   {
-
+    // FIXME threshold, conservation, increment belong inside
+    // AlignmentColourScheme and/or ViewStyleI, not ColourSchemeI
     if (cs != null)
     {
       if (viewport.getAbovePIDThreshold())
       {
         viewport.setThreshold(SliderPanel.setPIDSliderSource(alignPanel,
-                cs, "Background"));
+                viewport.getViewportColourScheme(), "Background"));
       }
 
       if (viewport.getConservationSelected())
       {
-        cs.setConservationApplied(true);
+        // cs.setConservationApplied(true);
         viewport.setIncrement(SliderPanel.setConservationSlider(alignPanel,
-                cs, "Background"));
-      }
-      else
-      {
-        cs.setConservationApplied(false);
+                viewport.getViewportColourScheme(), "Background"));
       }
+      // else
+      // {
+      // cs.setConservationApplied(false);
+      // }
     }
     viewport.setGlobalColourScheme(cs);
+    viewport.getViewportColourScheme().setConservationApplied(
+            viewport.getConservationSelected());
 
     alignPanel.paintAlignment(true);
   }
@@ -2663,7 +2665,7 @@ public class AlignFrame extends EmbmenuFrame implements ActionListener,
             && viewport.getGlobalColourScheme() != null)
     {
       SliderPanel.setPIDSliderSource(alignPanel,
-              viewport.getGlobalColourScheme(), "Background");
+              viewport.getViewportColourScheme(), "Background");
       SliderPanel.showPIDSlider();
     }
   }
@@ -2674,7 +2676,7 @@ public class AlignFrame extends EmbmenuFrame implements ActionListener,
             && viewport.getGlobalColourScheme() != null)
     {
       SliderPanel.setConservationSlider(alignPanel,
-              viewport.getGlobalColourScheme(), "Background");
+              viewport.getViewportColourScheme(), "Background");
       SliderPanel.showConservationSlider();
     }
   }