JAL-3010 cache synonyms for Sequence Ontology terms

[jalview.git] / src / jalview / datamodel / ontology / OntologyBase.java

diff --git a/src/jalview/datamodel/ontology/OntologyBase.java b/src/jalview/datamodel/ontology/OntologyBase.java
index 22dc37e..b19d9bc 100644 (file)
--- a/src/jalview/datamodel/ontology/OntologyBase.java
+++ b/src/jalview/datamodel/ontology/OntologyBase.java
@@ -95,6 +95,7 @@ public abstract class OntologyBase implements OntologyI
    *          candidate terms to 'capture' in ontology groupings
    * @return
    */
+  @Override
   public Map<String, List<String>> findSequenceOntologyGroupings(
           String givenTerm, List<String> targetTerms)
   {
@@ -102,7 +103,11 @@ public abstract class OntologyBase implements OntologyI
     Collections.sort(sortedTypes);
   
     Map<String, List<String>> parents = new HashMap<>();
-  
+    if (!isValidTerm(givenTerm))
+    {
+      return parents;
+    }
+
     /*
      * method: 
      * walk up featureType and all of its parents
@@ -111,6 +116,7 @@ public abstract class OntologyBase implements OntologyI
      */
     List<String> candidates = new ArrayList<>();
     SequenceOntologyI so = SequenceOntologyFactory.getInstance();
+
     candidates.add(givenTerm);
     while (!candidates.isEmpty())
     {