JAL-3518 removed unneeded override in ChimeraCommands

[jalview.git] / src / jalview / ext / rbvi / chimera / ChimeraCommands.java

diff --git a/src/jalview/ext/rbvi/chimera/ChimeraCommands.java b/src/jalview/ext/rbvi/chimera/ChimeraCommands.java
index 43cdeb1..780308d 100644 (file)
--- a/src/jalview/ext/rbvi/chimera/ChimeraCommands.java
+++ b/src/jalview/ext/rbvi/chimera/ChimeraCommands.java
@@ -36,6 +36,7 @@ import jalview.util.ColorUtils;
  * Routines for generating Chimera commands for Jalview/Chimera binding
  * 
  * @author JimP
+ * @see https://www.cgl.ucsf.edu/chimera/current/docs/UsersGuide/framecommand.html
  * 
  */
 public class ChimeraCommands extends StructureCommandsBase
@@ -102,6 +103,7 @@ public class ChimeraCommands extends StructureCommandsBase
    * </pre>
    * 
    * @param featureMap
+   * @param binding
    * @return
    */
   @Override
@@ -221,41 +223,6 @@ public class ChimeraCommands extends StructureCommandsBase
   }
 
   @Override
-  public List<StructureCommandI> showChains(List<String> toShow)
-  {
-    /*
-     * Construct a chimera command like
-     * 
-     * ~display #*;~ribbon #*;ribbon :.A,:.B
-     */
-    StringBuilder cmd = new StringBuilder(64);
-    boolean first = true;
-    for (String chain : toShow)
-    {
-      String[] tokens = chain.split(":");
-      if (tokens.length == 2)
-      {
-        String showChainCmd = tokens[0] + ":." + tokens[1];
-        if (!first)
-        {
-          cmd.append(",");
-        }
-        cmd.append(showChainCmd);
-        first = false;
-      }
-    }
-
-    /*
-     * could append ";focus" to this command to resize the display to fill the
-     * window, but it looks more helpful not to (easier to relate chains to the
-     * whole)
-     */
-    final String command = "~display #*; ~ribbon #*; ribbon :"
-            + cmd.toString();
-    return Arrays.asList(new StructureCommand(command));
-  }
-
-  @Override
   public List<StructureCommandI> superposeStructures(AtomSpecModel ref,
           AtomSpecModel spec)
   {
@@ -388,42 +355,39 @@ public class ChimeraCommands extends StructureCommandsBase
     return new StructureCommand("open " + file);
   }
 
-  /**
-   * Overrides the default method to concatenate colour commands into one
-   */
   @Override
-  public List<StructureCommandI> colourBySequence(
-          Map<Object, AtomSpecModel> colourMap)
+  public StructureCommandI openSession(String filepath)
+  {
+    // https://www.cgl.ucsf.edu/chimera/current/docs/UsersGuide/filetypes.html
+    // this version of the command has no dependency on file extension
+    return new StructureCommand("open chimera:" + filepath);
+  }
+
+  @Override
+  public StructureCommandI showStructures(AtomSpecModel restrictTo)
   {
-    List<StructureCommandI> commands = new ArrayList<>();
-    StringBuilder sb = new StringBuilder(colourMap.size() * 20);
-    boolean first = true;
-    for (Object key : colourMap.keySet())
+    if (restrictTo == null)
     {
-      Color colour = (Color) key;
-      final AtomSpecModel colourData = colourMap.get(colour);
-      StructureCommandI command = getColourCommand(colourData, colour);
-      if (!first)
-      {
-        sb.append(getCommandSeparator());
-      }
-      first = false;
-      sb.append(command.getCommand());
+      return new StructureCommand("ribbon");
     }
 
-    commands.add(new StructureCommand(sb.toString()));
-    return commands;
+    String atomSpec = getAtomSpec(restrictTo, false);
+    String cmd = "ribbon " + atomSpec;
+    return new StructureCommand(cmd);
   }
 
   @Override
-  public StructureCommandI openSession(String filepath)
+  public StructureCommandI hideChain(String modelId, String chainId)
   {
-    // https://www.cgl.ucsf.edu/chimera/current/docs/UsersGuide/filetypes.html
-    // this version of the command has no dependency on file extension
-    return new StructureCommand("open chimera:" + filepath);
+    String what = "#" + modelId + ":." + chainId;
+    return new StructureCommand("~ribbon " + what + ";~display " + what);
   }
 
   @Override
+  public StructureCommandI hideAll()
+  {
+    return new StructureCommand("~display; ~ribbon");
+  }
   public StructureCommandI closeViewer()
   {
     return CLOSE_CHIMERA;