Merge branch 'develop' into feature/JAL-3551Pymol

[jalview.git] / src / jalview / urls / IdentifiersUrlProvider.java

diff --git a/src/jalview/urls/IdentifiersUrlProvider.java b/src/jalview/urls/IdentifiersUrlProvider.java
index 0988e7d..07eb23e 100644 (file)
--- a/src/jalview/urls/IdentifiersUrlProvider.java
+++ b/src/jalview/urls/IdentifiersUrlProvider.java
@@ -25,20 +25,18 @@ import static jalview.util.UrlConstants.DB_ACCESSION;
 import static jalview.util.UrlConstants.DELIM;
 import static jalview.util.UrlConstants.SEP;
 
+import jalview.util.JSONUtils;
 import jalview.util.UrlLink;
 
-import java.io.FileNotFoundException;
 import java.io.FileReader;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Map;
 import java.util.StringTokenizer;
 
-import org.json.simple.JSONArray;
-import org.json.simple.JSONObject;
-import org.json.simple.parser.JSONParser;
 import org.json.simple.parser.ParseException;
 
 /**
@@ -65,7 +63,7 @@ public class IdentifiersUrlProvider extends UrlProviderImpl
   public IdentifiersUrlProvider(String cachedUrlList)
   {
     urls = readIdentifiers(IdOrgSettings.getDownloadLocation());
-    selectedUrls = new ArrayList<String>();
+    selectedUrls = new ArrayList<>();
     checkSelectionMatchesUrls(cachedUrlList);
   }
 
@@ -76,18 +74,20 @@ public class IdentifiersUrlProvider extends UrlProviderImpl
    *          name of identifiers.org download file
    * @return hashmap of identifiers.org data, keyed by MIRIAM id
    */
-  private HashMap<String, UrlLink> readIdentifiers(String idFileName)
+  @SuppressWarnings("unchecked")
+private HashMap<String, UrlLink> readIdentifiers(String idFileName)
   {
-    JSONParser parser = new JSONParser();
-
     // identifiers.org data
-    HashMap<String, UrlLink> idData = new HashMap<String, UrlLink>();
+    HashMap<String, UrlLink> idData = new HashMap<>();
 
+    String errorMessage = null;
     try
     {
+       // NOTE: THIS WILL FAIL IN SWINGJS BECAUSE IT INVOLVES A FILE READER
+    
       FileReader reader = new FileReader(idFileName);
       String key = "";
-      JSONObject obj = (JSONObject) parser.parse(reader);
+      Map<String, Object> obj = (Map<String, Object>) JSONUtils.parse(reader);
       if (obj.containsKey(ID_ORG_KEY))
       {
         key = ID_ORG_KEY;
@@ -103,12 +103,12 @@ public class IdentifiersUrlProvider extends UrlProviderImpl
         return idData;
       }
 
-      JSONArray jsonarray = (JSONArray) obj.get(key);
+      List<Object> jsonarray = (List<Object>) obj.get(key);
 
       // loop over each entry in JSON array and build HashMap entry
       for (int i = 0; i < jsonarray.size(); i++)
       {
-        JSONObject item = (JSONObject) jsonarray.get(i);
+        Map<String, Object> item = (Map<String, Object>) jsonarray.get(i);
 
         String url = (String) item.get("url") + "/" + DELIM + DB_ACCESSION
                 + DELIM;
@@ -116,18 +116,20 @@ public class IdentifiersUrlProvider extends UrlProviderImpl
                 (String) item.get("prefix"));
         idData.put((String) item.get("id"), link);
       }
-    } catch (FileNotFoundException e)
-    {
-      e.printStackTrace();
-      idData.clear();
-    } catch (IOException e)
+    } catch (IOException | ParseException e)
     {
-      e.printStackTrace();
+      // unnecessary e.printStackTrace();
+      // Note how in JavaScript we can grab the first bytes from any file reader. 
+      // Typical report here is "NetworkError" because the file does not exist.
+      // "https://." is coming from System.getProperty("user.home"), but this could
+      // be set by the page developer to anything, of course.
+      errorMessage = e.toString();
       idData.clear();
-    } catch (ParseException e)
+    }
+    // BH 2018 -- added more valuable report
+    if (errorMessage != null)
     {
-      e.printStackTrace();
-      idData.clear();
+      System.err.println("IdentifiersUrlProvider: cannot read " + idFileName + ": " + errorMessage);
     }
     return idData;
   }
@@ -193,7 +195,7 @@ public class IdentifiersUrlProvider extends UrlProviderImpl
   @Override
   public List<String> getLinksForMenu()
   {
-    List<String> links = new ArrayList<String>();
+    List<String> links = new ArrayList<>();
     for (String key : selectedUrls)
     {
       links.add(urls.get(key).toStringWithTarget());
@@ -210,7 +212,7 @@ public class IdentifiersUrlProvider extends UrlProviderImpl
   @Override
   public void setUrlData(List<UrlLinkDisplay> links)
   {
-    selectedUrls = new ArrayList<String>();
+    selectedUrls = new ArrayList<>();
 
     Iterator<UrlLinkDisplay> it = links.iterator();
     while (it.hasNext())