JAL-3741 http to https (and jar to jvp for exampleFile defaults!)
[jalview.git] / src / jalview / io / JSONFile.java
index 9402562..0e3cca7 100644 (file)
@@ -1,6 +1,6 @@
 /*
- * Jalview - A Sequence Alignment Editor and Viewer (Version 2.9.0b1)
- * Copyright (C) 2015 The Jalview Authors
+ * Jalview - A Sequence Alignment Editor and Viewer ($$Version-Rel$$)
+ * Copyright (C) $$Year-Rel$$ The Jalview Authors
  * 
  * This file is part of Jalview.
  * 
@@ -26,12 +26,13 @@ import jalview.api.AlignViewportI;
 import jalview.api.AlignmentViewPanel;
 import jalview.api.ComplexAlignFile;
 import jalview.api.FeatureRenderer;
+import jalview.api.FeatureSettingsModelI;
 import jalview.api.FeaturesDisplayedI;
 import jalview.bin.BuildDetails;
 import jalview.datamodel.AlignmentAnnotation;
 import jalview.datamodel.AlignmentI;
 import jalview.datamodel.Annotation;
-import jalview.datamodel.ColumnSelection;
+import jalview.datamodel.HiddenColumns;
 import jalview.datamodel.HiddenSequences;
 import jalview.datamodel.Sequence;
 import jalview.datamodel.SequenceFeature;
@@ -45,8 +46,12 @@ import jalview.json.binding.biojson.v1.ColourSchemeMapper;
 import jalview.json.binding.biojson.v1.SequenceFeaturesPojo;
 import jalview.json.binding.biojson.v1.SequenceGrpPojo;
 import jalview.json.binding.biojson.v1.SequencePojo;
+import jalview.renderer.seqfeatures.FeatureColourFinder;
 import jalview.schemes.ColourSchemeProperty;
-import jalview.schemes.UserColourScheme;
+import jalview.schemes.JalviewColourScheme;
+import jalview.schemes.ResidueColourScheme;
+import jalview.util.ColorUtils;
+import jalview.util.Format;
 import jalview.viewmodel.seqfeatures.FeaturesDisplayed;
 
 import java.awt.Color;
@@ -66,14 +71,10 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
 {
   private static String version = new BuildDetails().getVersion();
 
-  private String webstartUrl = "http://www.jalview.org/services/launchApp";
+  private String webstartUrl = "https://www.jalview.org/services/launchApp";
 
   private String application = "Jalview";
 
-  public static final String FILE_EXT = "json";
-
-  public static final String FILE_DESC = "JSON";
-
   private String globalColourScheme;
 
   private boolean showSeqFeatures;
@@ -84,9 +85,7 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
 
   private FeatureRenderer fr;
 
-  private List<int[]> hiddenColumns;
-
-  private ColumnSelection columnSelection;
+  private HiddenColumns hiddenColumns;
 
   private List<String> hiddenSeqRefs;
 
@@ -104,9 +103,10 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
     super(source);
   }
 
-  public JSONFile(String inFile, String type) throws IOException
+  public JSONFile(String inFile, DataSourceType sourceType)
+          throws IOException
   {
-    super(inFile, type);
+    super(inFile, sourceType);
   }
 
   @Override
@@ -117,7 +117,7 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
   }
 
   @Override
-  public String print()
+  public String print(SequenceI[] sqs, boolean jvsuffix)
   {
     String jsonOutput = null;
     try
@@ -170,7 +170,7 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
       }
 
       int count = 0;
-      for (SequenceI seq : seqs)
+      for (SequenceI seq : sqs)
       {
         StringBuilder name = new StringBuilder();
         name.append(seq.getName()).append("/").append(seq.getStart())
@@ -217,17 +217,18 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
       {
         // These color schemes require annotation, disable them if annotations
         // are not exported
-        if (globalColourScheme.equalsIgnoreCase("RNA Helices")
-                || globalColourScheme.equalsIgnoreCase("T-COFFEE SCORES"))
+        if (globalColourScheme
+                .equalsIgnoreCase(JalviewColourScheme.RNAHelices.toString())
+                || globalColourScheme.equalsIgnoreCase(
+                        JalviewColourScheme.TCoffee.toString()))
         {
-          jsonAlignmentPojo.setGlobalColorScheme("None");
+          jsonAlignmentPojo.setGlobalColorScheme(ResidueColourScheme.NONE);
         }
       }
 
       if (exportSettings.isExportFeatures())
       {
-        jsonAlignmentPojo
-                .setSeqFeatures(sequenceFeatureToJsonPojo(seqs, fr));
+        jsonAlignmentPojo.setSeqFeatures(sequenceFeatureToJsonPojo(sqs));
       }
 
       if (exportSettings.isExportGroups() && seqGroups != null
@@ -238,7 +239,7 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
           SequenceGrpPojo seqGrpPojo = new SequenceGrpPojo();
           seqGrpPojo.setGroupName(seqGrp.getName());
           seqGrpPojo.setColourScheme(ColourSchemeProperty
-                  .getColourName(seqGrp.cs));
+                  .getColourName(seqGrp.getColourScheme()));
           seqGrpPojo.setColourText(seqGrp.getColourText());
           seqGrpPojo.setDescription(seqGrp.getDescription());
           seqGrpPojo.setDisplayBoxes(seqGrp.getDisplayBoxes());
@@ -277,17 +278,8 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
     // hidden column business
     if (getViewport().hasHiddenColumns())
     {
-      List<int[]> hiddenCols = getViewport().getColumnSelection()
-              .getHiddenColumns();
-      StringBuilder hiddenColsBuilder = new StringBuilder();
-      for (int[] range : hiddenCols)
-      {
-        hiddenColsBuilder.append(";").append(range[0]).append("-")
-                .append(range[1]);
-      }
-
-      hiddenColsBuilder.deleteCharAt(0);
-      hiddenSections[0] = hiddenColsBuilder.toString();
+      hiddenSections[0] = getViewport().getAlignment().getHiddenColumns()
+              .regionsToString(";", "-");
     }
 
     // hidden rows/seqs business
@@ -316,46 +308,50 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
     return hiddenSections;
   }
 
-  public List<SequenceFeaturesPojo> sequenceFeatureToJsonPojo(
-          List<SequenceI> seqs, FeatureRenderer fr)
+  protected List<SequenceFeaturesPojo> sequenceFeatureToJsonPojo(
+          SequenceI[] sqs)
   {
     displayedFeatures = (fr == null) ? null : fr.getFeaturesDisplayed();
-    List<SequenceFeaturesPojo> sequenceFeaturesPojo = new ArrayList<SequenceFeaturesPojo>();
-    for (SequenceI seq : seqs)
+    List<SequenceFeaturesPojo> sequenceFeaturesPojo = new ArrayList<>();
+    if (sqs == null)
     {
-      SequenceI dataSetSequence = seq.getDatasetSequence();
-      SequenceFeature[] seqFeatures = (dataSetSequence == null) ? null
-              : seq.getDatasetSequence().getSequenceFeatures();
+      return sequenceFeaturesPojo;
+    }
 
-      seqFeatures = (seqFeatures == null) ? seq.getSequenceFeatures()
-              : seqFeatures;
-      if (seqFeatures == null)
-      {
-        continue;
-      }
+    FeatureColourFinder finder = new FeatureColourFinder(fr);
+
+    String[] visibleFeatureTypes = displayedFeatures == null ? null
+            : displayedFeatures.getVisibleFeatures().toArray(
+                    new String[displayedFeatures.getVisibleFeatureCount()]);
 
+    for (SequenceI seq : sqs)
+    {
+      /*
+       * get all features currently visible (and any non-positional features)
+       */
+      List<SequenceFeature> seqFeatures = seq.getFeatures().getAllFeatures(
+              visibleFeatureTypes);
       for (SequenceFeature sf : seqFeatures)
       {
-        if (displayedFeatures != null
-                && displayedFeatures.isVisible(sf.getType()))
-        {
-          SequenceFeaturesPojo jsonFeature = new SequenceFeaturesPojo(
-                  String.valueOf(seq.hashCode()));
-
-          String featureColour = (fr == null) ? null : jalview.util.Format
-                  .getHexString(fr.findFeatureColour(Color.white, seq,
-                          seq.findIndex(sf.getBegin())));
-          jsonFeature.setXstart(seq.findIndex(sf.getBegin()) - 1);
-          jsonFeature.setXend(seq.findIndex(sf.getEnd()));
-          jsonFeature.setType(sf.getType());
-          jsonFeature.setDescription(sf.getDescription());
-          jsonFeature.setLinks(sf.links);
-          jsonFeature.setOtherDetails(sf.otherDetails);
-          jsonFeature.setScore(sf.getScore());
-          jsonFeature.setFillColor(featureColour);
-          jsonFeature.setFeatureGroup(sf.getFeatureGroup());
-          sequenceFeaturesPojo.add(jsonFeature);
-        }
+        SequenceFeaturesPojo jsonFeature = new SequenceFeaturesPojo(
+                String.valueOf(seq.hashCode()));
+
+        String featureColour = (fr == null) ? null : Format
+                .getHexString(finder.findFeatureColour(Color.white, seq,
+                        seq.findIndex(sf.getBegin())));
+        int xStart = sf.getBegin() == 0 ? 0
+                : seq.findIndex(sf.getBegin()) - 1;
+        int xEnd = sf.getEnd() == 0 ? 0 : seq.findIndex(sf.getEnd());
+        jsonFeature.setXstart(xStart);
+        jsonFeature.setXend(xEnd);
+        jsonFeature.setType(sf.getType());
+        jsonFeature.setDescription(sf.getDescription());
+        jsonFeature.setLinks(sf.links);
+        jsonFeature.setOtherDetails(sf.otherDetails);
+        jsonFeature.setScore(sf.getScore());
+        jsonFeature.setFillColor(featureColour);
+        jsonFeature.setFeatureGroup(sf.getFeatureGroup());
+        sequenceFeaturesPojo.add(jsonFeature);
       }
     }
     return sequenceFeaturesPojo;
@@ -364,7 +360,7 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
   public static List<AlignmentAnnotationPojo> annotationToJsonPojo(
           Vector<AlignmentAnnotation> annotations)
   {
-    List<AlignmentAnnotationPojo> jsonAnnotations = new ArrayList<AlignmentAnnotationPojo>();
+    List<AlignmentAnnotationPojo> jsonAnnotations = new ArrayList<>();
     if (annotations == null)
     {
       return jsonAnnotations;
@@ -409,8 +405,8 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
           annotationPojo.setDisplayCharacter(displayChar);
           if (annotation.colour != null)
           {
-            annotationPojo.setColour(jalview.util.Format
-                    .getHexString(annotation.colour));
+            annotationPojo.setColour(
+                    jalview.util.Format.getHexString(annotation.colour));
           }
           alignAnnotPojo.getAnnotations().add(annotationPojo);
         }
@@ -454,17 +450,17 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
       {
         globalColourScheme = (String) jvSettingsJsonObj
                 .get("globalColorScheme");
-        Boolean showFeatures = Boolean.valueOf(jvSettingsJsonObj.get(
-                "showSeqFeatures").toString());
+        Boolean showFeatures = Boolean.valueOf(
+                jvSettingsJsonObj.get("showSeqFeatures").toString());
         setShowSeqFeatures(showFeatures);
         parseHiddenSeqRefsAsList(jvSettingsJsonObj);
         parseHiddenCols(jvSettingsJsonObj);
       }
 
-      hiddenSequences = new ArrayList<SequenceI>();
-      seqMap = new Hashtable<String, Sequence>();
-      for (Iterator<JSONObject> sequenceIter = seqJsonArray.iterator(); sequenceIter
-              .hasNext();)
+      hiddenSequences = new ArrayList<>();
+      seqMap = new Hashtable<>();
+      for (Iterator<JSONObject> sequenceIter = seqJsonArray
+              .iterator(); sequenceIter.hasNext();)
       {
         JSONObject sequence = sequenceIter.next();
         String sequcenceString = sequence.get("seq").toString();
@@ -484,28 +480,28 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
 
       parseFeatures(jsonSeqArray);
 
-      for (Iterator<JSONObject> seqGrpIter = seqGrpJsonArray.iterator(); seqGrpIter
-              .hasNext();)
+      for (Iterator<JSONObject> seqGrpIter = seqGrpJsonArray
+              .iterator(); seqGrpIter.hasNext();)
       {
         JSONObject seqGrpObj = seqGrpIter.next();
         String grpName = seqGrpObj.get("groupName").toString();
         String colourScheme = seqGrpObj.get("colourScheme").toString();
         String description = (seqGrpObj.get("description") == null) ? null
                 : seqGrpObj.get("description").toString();
-        boolean displayBoxes = Boolean.valueOf(seqGrpObj
-                .get("displayBoxes").toString());
-        boolean displayText = Boolean.valueOf(seqGrpObj.get("displayText")
-                .toString());
-        boolean colourText = Boolean.valueOf(seqGrpObj.get("colourText")
-                .toString());
-        boolean showNonconserved = Boolean.valueOf(seqGrpObj.get(
-                "showNonconserved").toString());
+        boolean displayBoxes = Boolean
+                .valueOf(seqGrpObj.get("displayBoxes").toString());
+        boolean displayText = Boolean
+                .valueOf(seqGrpObj.get("displayText").toString());
+        boolean colourText = Boolean
+                .valueOf(seqGrpObj.get("colourText").toString());
+        boolean showNonconserved = Boolean
+                .valueOf(seqGrpObj.get("showNonconserved").toString());
         int startRes = Integer
                 .valueOf(seqGrpObj.get("startRes").toString());
         int endRes = Integer.valueOf(seqGrpObj.get("endRes").toString());
         JSONArray sequenceRefs = (JSONArray) seqGrpObj.get("sequenceRefs");
 
-        ArrayList<SequenceI> grpSeqs = new ArrayList<SequenceI>();
+        ArrayList<SequenceI> grpSeqs = new ArrayList<>();
         if (sequenceRefs.size() > 0)
         {
           Iterator<String> seqHashIter = sequenceRefs.iterator();
@@ -521,23 +517,23 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
         }
         SequenceGroup seqGrp = new SequenceGroup(grpSeqs, grpName, null,
                 displayBoxes, displayText, colourText, startRes, endRes);
-        seqGrp.cs = ColourSchemeMapper.getJalviewColourScheme(colourScheme,
-                seqGrp);
+        seqGrp.setColourScheme(ColourSchemeMapper
+                .getJalviewColourScheme(colourScheme, seqGrp));
         seqGrp.setShowNonconserved(showNonconserved);
         seqGrp.setDescription(description);
         this.seqGroups.add(seqGrp);
 
       }
 
-      for (Iterator<JSONObject> alAnnotIter = alAnnotJsonArray.iterator(); alAnnotIter
-              .hasNext();)
+      for (Iterator<JSONObject> alAnnotIter = alAnnotJsonArray
+              .iterator(); alAnnotIter.hasNext();)
       {
         JSONObject alAnnot = alAnnotIter.next();
         JSONArray annotJsonArray = (JSONArray) alAnnot.get("annotations");
         Annotation[] annotations = new Annotation[annotJsonArray.size()];
         int count = 0;
-        for (Iterator<JSONObject> annotIter = annotJsonArray.iterator(); annotIter
-                .hasNext();)
+        for (Iterator<JSONObject> annotIter = annotJsonArray
+                .iterator(); annotIter.hasNext();)
         {
           JSONObject annot = annotIter.next();
           if (annot == null)
@@ -546,59 +542,64 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
           }
           else
           {
-            float val = annot.get("value") == null ? null : Float
-                    .valueOf(annot.get("value").toString());
-            String desc = annot.get("description") == null ? null : annot
-                    .get("description").toString();
+            float val = annot.get("value") == null ? null
+                    : Float.valueOf(annot.get("value").toString());
+            String desc = annot.get("description") == null ? null
+                    : annot.get("description").toString();
             char ss = annot.get("secondaryStructure") == null
                     || annot.get("secondaryStructure").toString()
-                            .equalsIgnoreCase("u0000") ? ' ' : annot
-                    .get("secondaryStructure").toString().charAt(0);
+                            .equalsIgnoreCase("u0000") ? ' '
+                                    : annot.get("secondaryStructure")
+                                            .toString().charAt(0);
             String displayChar = annot.get("displayCharacter") == null ? ""
                     : annot.get("displayCharacter").toString();
 
             annotations[count] = new Annotation(displayChar, desc, ss, val);
             if (annot.get("colour") != null)
             {
-              Color color = UserColourScheme.getColourFromString(annot.get(
-                      "colour").toString());
+              Color color = ColorUtils
+                      .parseColourString(annot.get("colour").toString());
               annotations[count].colour = color;
             }
           }
           ++count;
         }
 
-        AlignmentAnnotation alignAnnot = new AlignmentAnnotation(alAnnot
-                .get("label").toString(), alAnnot.get("description")
-                .toString(), annotations);
-        alignAnnot.graph = (alAnnot.get("graphType") == null) ? 0 : Integer
-                .valueOf(alAnnot.get("graphType").toString());
+        AlignmentAnnotation alignAnnot = new AlignmentAnnotation(
+                alAnnot.get("label").toString(),
+                alAnnot.get("description").toString(), annotations);
+        alignAnnot.graph = (alAnnot.get("graphType") == null) ? 0
+                : Integer.valueOf(alAnnot.get("graphType").toString());
 
         JSONObject diplaySettings = (JSONObject) alAnnot
                 .get("annotationSettings");
         if (diplaySettings != null)
         {
 
-          alignAnnot.scaleColLabel = (diplaySettings.get("scaleColLabel") == null) ? false
-                  : Boolean.valueOf(diplaySettings.get("scaleColLabel")
-                          .toString());
+          alignAnnot.scaleColLabel = (diplaySettings
+                  .get("scaleColLabel") == null) ? false
+                          : Boolean.valueOf(diplaySettings
+                                  .get("scaleColLabel").toString());
           alignAnnot.showAllColLabels = (diplaySettings
-                  .get("showAllColLabels") == null) ? true : Boolean
-                  .valueOf(diplaySettings.get("showAllColLabels")
-                          .toString());
+                  .get("showAllColLabels") == null) ? true
+                          : Boolean.valueOf(diplaySettings
+                                  .get("showAllColLabels").toString());
           alignAnnot.centreColLabels = (diplaySettings
                   .get("centreColLabels") == null) ? true
-                  : Boolean.valueOf(diplaySettings.get("centreColLabels")
-                          .toString());
-          alignAnnot.belowAlignment = (diplaySettings.get("belowAlignment") == null) ? false
-                  : Boolean.valueOf(diplaySettings.get("belowAlignment")
-                          .toString());
-          alignAnnot.visible = (diplaySettings.get("visible") == null) ? true
-                  : Boolean.valueOf(diplaySettings.get("visible")
-                          .toString());
-          alignAnnot.hasIcons = (diplaySettings.get("hasIcon") == null) ? true
-                  : Boolean.valueOf(diplaySettings.get("hasIcon")
-                          .toString());
+                          : Boolean.valueOf(diplaySettings
+                                  .get("centreColLabels").toString());
+          alignAnnot.belowAlignment = (diplaySettings
+                  .get("belowAlignment") == null) ? false
+                          : Boolean.valueOf(diplaySettings
+                                  .get("belowAlignment").toString());
+          alignAnnot.visible = (diplaySettings.get("visible") == null)
+                  ? true
+                  : Boolean.valueOf(
+                          diplaySettings.get("visible").toString());
+          alignAnnot.hasIcons = (diplaySettings.get("hasIcon") == null)
+                  ? true
+                  : Boolean.valueOf(
+                          diplaySettings.get("hasIcon").toString());
 
         }
         if (alAnnot.get("score") != null)
@@ -607,11 +608,12 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
                   .valueOf(alAnnot.get("score").toString());
         }
 
-        String calcId = (alAnnot.get("calcId") == null) ? "" : alAnnot.get(
-                "calcId").toString();
+        String calcId = (alAnnot.get("calcId") == null) ? ""
+                : alAnnot.get("calcId").toString();
         alignAnnot.setCalcId(calcId);
-        String seqHash = (alAnnot.get("sequenceRef") != null) ? alAnnot
-                .get("sequenceRef").toString() : null;
+        String seqHash = (alAnnot.get("sequenceRef") != null)
+                ? alAnnot.get("sequenceRef").toString()
+                : null;
 
         Sequence sequence = (seqHash != null) ? seqMap.get(seqHash) : null;
         if (sequence != null)
@@ -639,7 +641,7 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
 
   public void parseHiddenSeqRefsAsList(JSONObject jvSettingsJson)
   {
-    hiddenSeqRefs = new ArrayList<String>();
+    hiddenSeqRefs = new ArrayList<>();
     String hiddenSeqs = (String) jvSettingsJson.get("hiddenSeqs");
     if (hiddenSeqs != null && !hiddenSeqs.isEmpty())
     {
@@ -656,12 +658,12 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
     String hiddenCols = (String) jvSettingsJson.get("hiddenCols");
     if (hiddenCols != null && !hiddenCols.isEmpty())
     {
-      columnSelection = new ColumnSelection();
+      hiddenColumns = new HiddenColumns();
       String[] rangeStrings = hiddenCols.split(";");
       for (String rangeString : rangeStrings)
       {
         String[] range = rangeString.split("-");
-        columnSelection.hideColumns(Integer.valueOf(range[0]),
+        hiddenColumns.hideColumns(Integer.valueOf(range[0]),
                 Integer.valueOf(range[1]));
       }
     }
@@ -673,20 +675,31 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
     if (jsonSeqFeatures != null)
     {
       displayedFeatures = new FeaturesDisplayed();
-      for (Iterator<JSONObject> seqFeatureItr = jsonSeqFeatures.iterator(); seqFeatureItr
-              .hasNext();)
+      for (Iterator<JSONObject> seqFeatureItr = jsonSeqFeatures
+              .iterator(); seqFeatureItr.hasNext();)
       {
         JSONObject jsonFeature = seqFeatureItr.next();
         Long begin = (Long) jsonFeature.get("xStart");
         Long end = (Long) jsonFeature.get("xEnd");
         String type = (String) jsonFeature.get("type");
         String featureGrp = (String) jsonFeature.get("featureGroup");
-        String descripiton = (String) jsonFeature.get("description");
+        String description = (String) jsonFeature.get("description");
         String seqRef = (String) jsonFeature.get("sequenceRef");
         Float score = Float.valueOf(jsonFeature.get("score").toString());
 
         Sequence seq = seqMap.get(seqRef);
-        SequenceFeature sequenceFeature = new SequenceFeature();
+
+        /*
+         * begin/end of 0 is for a non-positional feature
+         */
+        int featureBegin = begin.intValue() == 0 ? 0 : seq
+                .findPosition(begin.intValue());
+        int featureEnd = end.intValue() == 0 ? 0 : seq.findPosition(end
+                .intValue()) - 1;
+
+        SequenceFeature sequenceFeature = new SequenceFeature(type,
+                description, featureBegin, featureEnd, score, featureGrp);
+
         JSONArray linksJsonArray = (JSONArray) jsonFeature.get("links");
         if (linksJsonArray != null && linksJsonArray.size() > 0)
         {
@@ -697,18 +710,14 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
             sequenceFeature.addLink(link);
           }
         }
-        sequenceFeature.setFeatureGroup(featureGrp);
-        sequenceFeature.setScore(score);
-        sequenceFeature.setDescription(descripiton);
-        sequenceFeature.setType(type);
-        sequenceFeature.setBegin(seq.findPosition(begin.intValue()));
-        sequenceFeature.setEnd(seq.findPosition(end.intValue()) - 1);
+
         seq.addSequenceFeature(sequenceFeature);
         displayedFeatures.setVisible(type);
       }
     }
   }
 
+  @Override
   public String getGlobalColourScheme()
   {
     return globalColourScheme;
@@ -730,8 +739,13 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
     this.displayedFeatures = displayedFeatures;
   }
 
+  @Override
   public void configureForView(AlignmentViewPanel avpanel)
   {
+    if (avpanel == null)
+    {
+      return;
+    }
     super.configureForView(avpanel);
     AlignViewportI viewport = avpanel.getAlignViewport();
     AlignmentI alignment = viewport.getAlignment();
@@ -741,20 +755,24 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
     fr = avpanel.cloneFeatureRenderer();
 
     // Add non auto calculated annotation to AlignFile
-    for (AlignmentAnnotation annot : annots)
+    if (annots != null)
     {
-      if (annot != null && !annot.autoCalculated)
+      for (AlignmentAnnotation annot : annots)
       {
-        annotations.add(annot);
+        if (annot != null && !annot.autoCalculated)
+        {
+          annotations.add(annot);
+        }
       }
     }
-    globalColourScheme = ColourSchemeProperty.getColourName(viewport
-            .getGlobalColourScheme());
+    globalColourScheme = ColourSchemeProperty
+            .getColourName(viewport.getGlobalColourScheme());
     setDisplayedFeatures(viewport.getFeaturesDisplayed());
     showSeqFeatures = viewport.isShowSequenceFeatures();
 
   }
 
+  @Override
   public boolean isShowSeqFeatures()
   {
     return showSeqFeatures;
@@ -770,21 +788,18 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
     return annotations;
   }
 
-  public List<int[]> getHiddenColumns()
+  @Override
+  public HiddenColumns getHiddenColumns()
   {
     return hiddenColumns;
   }
 
-  public ColumnSelection getColumnSelection()
+  public void setHiddenColumns(HiddenColumns hidden)
   {
-    return columnSelection;
-  }
-
-  public void setColumnSelection(ColumnSelection columnSelection)
-  {
-    this.columnSelection = columnSelection;
+    this.hiddenColumns = hidden;
   }
 
+  @Override
   public SequenceI[] getHiddenSequences()
   {
     if (hiddenSequences == null || hiddenSequences.isEmpty())
@@ -864,4 +879,19 @@ public class JSONFile extends AlignFile implements ComplexAlignFile
       this.exportJalviewSettings = exportJalviewSettings;
     }
   }
+
+  /**
+   * Returns a descriptor for suitable feature display settings with
+   * <ul>
+   * <li>ResNums or insertions features visible</li>
+   * <li>insertions features coloured red</li>
+   * <li>ResNum features coloured by label</li>
+   * <li>Insertions displayed above (on top of) ResNums</li>
+   * </ul>
+   */
+  @Override
+  public FeatureSettingsModelI getFeatureColourScheme()
+  {
+    return new PDBFeatureSettings();
+  }
 }