### Other improvements
- <!-- JAL-4250 --> Secondary structure annotation glyphs are rendered anti-aliasing when enabled
- <!-- JAL-325 --> Helix and Sheet glyphs vertically centered with respect to grey coil secondary structure annotation track
-- <!-- JAL-4253 --> Lower line of the sequence group border does not align with vertical and background residue box
+- <!-- JAL-4317 --> feature should be displayed when its rendering and filtering settings are adjusted
- <!-- JAL-4250 --> Updated JFreeSVG (https://www.jfree.org/jfreesvg) from 2.1 to 3.4.3
- <!-- JAL-3119 --> Name of alignment and view included in overview window's title
- <!-- JAL-4213 --> "add reference annotation" add all positions in reference annotation tracks, not just positions in the currently highlighted columns/selection range
- <!-- JAL-4206 --> Improved file chooser's 'recent files' view and added filter for 'All known alignment files'
- <!-- JAL-4206 --> Relative files added to recent files list via import from command line are selected when Jalview opened from same location
- <!-- JAL-4308 --> Reduce number of database crossreferences shown in tooltip
+- <!-- JAL-4315 --> Drag and drop feature colours file on an alignment to quickly apply feature settings
- <!-- JAL-3676 --> Allow log level configuration via Jalview's Java Console, and a Copy to Clipboard button
### Development and Deployment
- <!-- JAL-4182 --> reference annotation not correctly transferred to alignment containing a sub-sequence when a selection is active
- <!-- JAL-4177 --> Can press 'Add' or 'New View' multiple times when manually adding and viewing a 3D structure via structure chooser
- <!-- JAL-4133 --> Jalview project does not preserve font aspect ratio when Viewport is zoomed with mouse
+- <!-- JAL-4253 --> Lower line of the sequence group border does not align with vertical and background residue box
- <!-- JAL-4128 --> Resizing overview quickly with solid-drags enabled causes exception
- <!-- JAL-4150 --> Sequences copied to clipboard from within Jalview cannot be pasted via the desktop's popup menu to a new alignment window
- <!-- JAL-2528, JAL-1713 --> Overview window is saved in project file, and state of 'show hidden regions' is preserved.
* Object[] { String,SequenceI}
*/
ArrayList<Object[]> filesmatched = new ArrayList<>();
- ArrayList<Object> filesnotmatched = new ArrayList<>();
+ ArrayList<Object[]> filesnotmatched = new ArrayList<>();
for (int i = 0; i < files.size(); i++)
{
// BH 2018
}
mtch = idm.findAllIdMatches(pdbfn);
}
+ FileFormatI type=null;
if (mtch != null)
{
- FileFormatI type;
try
{
type = new IdentifyFile().identify(file, protocol);
}
// File wasn't named like one of the sequences or wasn't a PDB
// file.
- filesnotmatched.add(file);
+ filesnotmatched.add(new Object[] { file, protocol, type});
}
}
int assocfiles = 0;
*/
for (Object[] o : filesmatched)
{
- filesnotmatched.add(o[0]);
+ filesnotmatched.add(new Object[] { o[0], o[1]});
}
}
}
{
return;
}
- for (Object fn : filesnotmatched)
+ for (Object[] fn : filesnotmatched)
{
- loadJalviewDataFile(fn, null, null, null);
+ loadJalviewDataFile(fn[0], (DataSourceType) fn[1], (FileFormatI)fn[2], null);
}
}
{
format = new IdentifyFile().identify(file, sourceType);
}
- if (FileFormat.ScoreMatrix == format)
+ if (FileFormat.FeatureSettings == format)
+ {
+ if (featureSettings != null)
+ {
+ featureSettings.load(file, sourceType);
+ }
+ else
+ {
+ FeatureSettings.loadFeatureSettingsFile(getFeatureRenderer(),
+ fileObject, sourceType);
+ }
+ }
+ else if (FileFormat.ScoreMatrix == format)
{
ScoreMatrixFile sm = new ScoreMatrixFile(
new FileParse(file, sourceType));
import java.io.InputStreamReader;
import java.io.OutputStreamWriter;
import java.io.PrintWriter;
+import java.io.Reader;
import java.util.Arrays;
import java.util.Comparator;
import java.util.HashMap;
import jalview.datamodel.features.FeatureMatcherSetI;
import jalview.gui.Help.HelpId;
import jalview.gui.JalviewColourChooser.ColourChooserListener;
+import jalview.io.DataSourceType;
+import jalview.io.FileParse;
import jalview.io.JalviewFileChooser;
import jalview.io.JalviewFileView;
import jalview.schemes.FeatureColour;
chooser.showOpenDialog(this);
}
+ public static boolean loadFeatureSettingsFile(FeatureRenderer fr,
+ File file) throws Exception
+ {
+ InputStreamReader in = new InputStreamReader(new FileInputStream(file),
+ "UTF-8");
+ return loadFeatureSettingsFile(fr, in);
+ }
+
+ public static void loadFeatureSettingsFile(
+ FeatureRenderer featureRenderer, Object fileObject,
+ DataSourceType sourceType) throws Exception
+ {
+ FileParse fp = new FileParse(fileObject, sourceType);
+ loadFeatureSettingsFile(featureRenderer, fp.getReader());
+ }
+
+ private static boolean loadFeatureSettingsFile(FeatureRenderer fr,
+ Reader in) throws Exception
+ {
+ JAXBContext jc = JAXBContext.newInstance("jalview.xml.binding.jalview");
+ javax.xml.bind.Unmarshaller um = jc.createUnmarshaller();
+ XMLStreamReader streamReader = XMLInputFactory.newInstance()
+ .createXMLStreamReader(in);
+ JAXBElement<JalviewUserColours> jbe = um.unmarshal(streamReader,
+ JalviewUserColours.class);
+ JalviewUserColours jucs = jbe.getValue();
+
+ // JalviewUserColours jucs = JalviewUserColours.unmarshal(in);
+
+ /*
+ * load feature colours
+ */
+ for (int i = jucs.getColour().size() - 1; i >= 0; i--)
+ {
+ Colour newcol = jucs.getColour().get(i);
+ FeatureColourI colour = jalview.project.Jalview2XML
+ .parseColour(newcol);
+ fr.setColour(newcol.getName(), colour);
+ fr.setOrder(newcol.getName(), i / (float) jucs.getColour().size());
+ }
+
+ /*
+ * load feature filters; loaded filters will replace any that are
+ * currently defined, other defined filters are left unchanged
+ */
+ for (int i = 0; i < jucs.getFilter().size(); i++)
+ {
+ Filter filterModel = jucs.getFilter().get(i);
+ String featureType = filterModel.getFeatureType();
+ FeatureMatcherSetI filter = jalview.project.Jalview2XML
+ .parseFilter(featureType, filterModel.getMatcherSet());
+ if (!filter.isEmpty())
+ {
+ fr.setFeatureFilter(featureType, filter);
+ }
+ }
+ return true;
+ }
+
/**
* Loads feature colours and filters from XML stored in the given file
*
*/
void load(File file)
{
+ load(file, DataSourceType.FILE);
+ }
+
+ /**
+ * Loads feature colours and filters from XML at a specified source
+ *
+ * @param file
+ * - string or file or other object that allows FileParse to be
+ * created
+ */
+ void load(Object file, DataSourceType sourceType)
+ {
try
{
- InputStreamReader in = new InputStreamReader(
- new FileInputStream(file), "UTF-8");
-
- JAXBContext jc = JAXBContext
- .newInstance("jalview.xml.binding.jalview");
- javax.xml.bind.Unmarshaller um = jc.createUnmarshaller();
- XMLStreamReader streamReader = XMLInputFactory.newInstance()
- .createXMLStreamReader(in);
- JAXBElement<JalviewUserColours> jbe = um.unmarshal(streamReader,
- JalviewUserColours.class);
- JalviewUserColours jucs = jbe.getValue();
-
- // JalviewUserColours jucs = JalviewUserColours.unmarshal(in);
-
- /*
- * load feature colours
- */
- for (int i = jucs.getColour().size() - 1; i >= 0; i--)
- {
- Colour newcol = jucs.getColour().get(i);
- FeatureColourI colour = jalview.project.Jalview2XML
- .parseColour(newcol);
- fr.setColour(newcol.getName(), colour);
- fr.setOrder(newcol.getName(), i / (float) jucs.getColour().size());
- }
-
- /*
- * load feature filters; loaded filters will replace any that are
- * currently defined, other defined filters are left unchanged
- */
- for (int i = 0; i < jucs.getFilter().size(); i++)
- {
- Filter filterModel = jucs.getFilter().get(i);
- String featureType = filterModel.getFeatureType();
- FeatureMatcherSetI filter = jalview.project.Jalview2XML
- .parseFilter(featureType, filterModel.getMatcherSet());
- if (!filter.isEmpty())
- {
- fr.setFeatureFilter(featureType, filter);
- }
- }
-
+ loadFeatureSettingsFile(fr, file, sourceType);
/*
* update feature settings table
*/
}
} catch (Exception ex)
{
- jalview.bin.Console.outPrintln("Error loading User Colour File\n" + ex);
+ jalview.bin.Console
+ .outPrintln("Error loading User Colour File\n" + ex);
}
}
*/
String ttl = MessageManager
.formatMessage("label.select_colour_for", type);
+ Object last=(Boolean)table.getValueAt(selectedRow, SHOW_COLUMN);
+ table.setValueAt(Boolean.TRUE, selectedRow, SHOW_COLUMN);
ColourChooserListener listener = new ColourChooserListener()
{
@Override
{
currentColor = new FeatureColour(c);
table.setValueAt(currentColor, rowSelected, COLOUR_COLUMN);
+ table.setValueAt(Boolean.TRUE, selectedRow, SHOW_COLUMN);
fireEditingStopped();
}
@Override
public void cancel()
{
+ table.setValueAt(last, selectedRow, SHOW_COLUMN);
fireEditingStopped();
}
};
/*
* variable colour and filters dialog
*/
- chooser = new FeatureTypeSettings(fr, type);
+ boolean last=(Boolean)table.getValueAt(selectedRow, SHOW_COLUMN);
+ table.setValueAt(Boolean.TRUE, selectedRow, SHOW_COLUMN);
+ chooser = new FeatureTypeSettings(fr, type,last);
if (!Platform.isJS())
/**
* Java only
{
if (button == e.getSource())
{
- FeatureTypeSettings chooser = new FeatureTypeSettings(fr, type);
+ boolean last = fr.getFeaturesDisplayed().isVisible(type);
+ ((FeatureTableModel) table.getModel()).setValueAt(Boolean.TRUE, rowSelected, SHOW_COLUMN);
+ FeatureTypeSettings chooser = new FeatureTypeSettings(fr, type,last);
chooser.addActionListener(this);
chooser.setRequestFocusEnabled(true);
chooser.requestFocus();
.getData()[rowSelected];
data[COLOUR_COLUMN] = currentColor;
data[FILTER_COLUMN] = currentFilter;
+ data[SHOW_COLUMN] = fr.getFeaturesDisplayed().isVisible(type);
+
fireEditingStopped();
// SwingJS needs an explicit repaint() here,
// rather than relying upon no validation having
refreshDisplay();
}
}
-
class FeatureIcon implements Icon
{
FeatureColourI gcol;
git://source.jalview.org / jalview.git / commitdiff