Merge branch 'hotfix/JAL-1521' into Release_2_8_2_Branch

[jalview.git] / src / MCview / PDBChain.java

diff --git a/src/MCview/PDBChain.java b/src/MCview/PDBChain.java
index 92a573c..c9301e8 100755 (executable)
--- a/src/MCview/PDBChain.java
+++ b/src/MCview/PDBChain.java
@@ -1,19 +1,22 @@
 /*
- * Jalview - A Sequence Alignment Editor and Viewer (Version 2.6)
- * Copyright (C) 2010 J Procter, AM Waterhouse, G Barton, M Clamp, S Searle
+ * Jalview - A Sequence Alignment Editor and Viewer (Version 2.8.2)
+ * Copyright (C) 2014 The Jalview Authors
  * 
  * This file is part of Jalview.
  * 
  * Jalview is free software: you can redistribute it and/or
  * modify it under the terms of the GNU General Public License 
- * as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
- * 
+ * as published by the Free Software Foundation, either version 3
+ * of the License, or (at your option) any later version.
+ *  
  * Jalview is distributed in the hope that it will be useful, but 
  * WITHOUT ANY WARRANTY; without even the implied warranty 
  * of MERCHANTABILITY or FITNESS FOR A PARTICULAR 
  * PURPOSE.  See the GNU General Public License for more details.
  * 
- * You should have received a copy of the GNU General Public License along with Jalview.  If not, see <http://www.gnu.org/licenses/>.
+ * You should have received a copy of the GNU General Public License
+ * along with Jalview.  If not, see <http://www.gnu.org/licenses/>.
+ * The Jalview Authors are detailed in the 'AUTHORS' file.
  */
 package MCview;
 
@@ -98,17 +101,22 @@ public class PDBChain
 
   /**
    * Annotate the residues with their corresponding positions in s1 using the
-   * alignment in as
+   * alignment in as NOTE: This clears all atom.alignmentMapping values on the
+   * structure.
    * 
    * @param as
    * @param s1
-   * @return last position in s1 for the last position in the chain
    */
   public void makeExactMapping(AlignSeq as, SequenceI s1)
   {
     int pdbpos = as.getSeq2Start() - 2;
     int alignpos = s1.getStart() + as.getSeq1Start() - 3;
-
+    // first clear out any old alignmentMapping values:
+    for (Atom atom : (Vector<Atom>) atoms)
+    {
+      atom.alignmentMapping = -1;
+    }
+    // and now trace the alignment onto the atom set.
     for (int i = 0; i < as.astr1.length(); i++)
     {
       if (as.astr1.charAt(i) != '-')
@@ -244,6 +252,7 @@ public class PDBChain
   {
     int count = 0;
     Object symbol;
+    boolean deoxyn = false;
     boolean nucleotide = false;
     StringBuffer seq = new StringBuffer();
     Vector resFeatures = new Vector();
@@ -298,8 +307,13 @@ public class PDBChain
       if ((symbol = ResidueProperties.getAA3Hash().get(tmpat.resName)) == null)
       {
         String nucname = tmpat.resName.trim();
+        // use the aaIndex rather than call 'toLower' - which would take a bit
+        // more time.
+        deoxyn = nucname.length() == 2
+                && ResidueProperties.aaIndex[nucname.charAt(0)] == ResidueProperties.aaIndex['D'];
         if (tmpat.name.equalsIgnoreCase("CA")
-                || ResidueProperties.nucleotideIndex[nucname.charAt(0)] == -1)
+                || ResidueProperties.nucleotideIndex[nucname
+                        .charAt((deoxyn ? 1 : 0))] == -1)
         {
           seq.append("X");
           // System.err.println("PDBReader:Null aa3Hash for " +
@@ -309,7 +323,7 @@ public class PDBChain
         {
           // nucleotide flag
           nucleotide = true;
-          seq.append(nucname.charAt(0));
+          seq.append(nucname.charAt((deoxyn ? 1 : 0)));
         }
       }
       else