JAL-1990 suggested revision to separate references to UI components from datamodel...

[jalview.git] / src / jalview / appletgui / AppletJmolBinding.java

diff --git a/src/jalview/appletgui/AppletJmolBinding.java b/src/jalview/appletgui/AppletJmolBinding.java
index 7844f57..0234a1e 100644 (file)
--- a/src/jalview/appletgui/AppletJmolBinding.java
+++ b/src/jalview/appletgui/AppletJmolBinding.java
@@ -24,6 +24,7 @@ import jalview.api.AlignmentViewPanel;
 import jalview.datamodel.PDBEntry;
 import jalview.datamodel.SequenceI;
 import jalview.ext.jmol.JalviewJmolBinding;
+import jalview.gui.IProgressIndicator;
 import jalview.structure.StructureSelectionManager;
 
 import java.awt.Container;
@@ -34,7 +35,6 @@ import javajs.awt.Dimension;
 import org.jmol.api.JmolAppConsoleInterface;
 import org.jmol.console.AppletConsole;
 import org.jmol.java.BS;
-import org.jmol.popup.JmolAwtPopup;
 
 class AppletJmolBinding extends JalviewJmolBinding
 {
@@ -88,7 +88,7 @@ class AppletJmolBinding extends JalviewJmolBinding
       appletJmolBinding.showConsole(true);
     }
 
-    appletJmolBinding.history.append("\n" + strEcho);
+    appletJmolBinding.addToHistory(strEcho);
   }
 
   @Override
@@ -97,7 +97,7 @@ class AppletJmolBinding extends JalviewJmolBinding
     if (appletJmolBinding.history != null && strStatus != null
             && !strStatus.equals("Script completed"))
     {
-      appletJmolBinding.history.append("\n" + strStatus);
+      appletJmolBinding.addToHistory(strStatus);
     }
   }
 
@@ -114,12 +114,14 @@ class AppletJmolBinding extends JalviewJmolBinding
     appletJmolBinding.updateTitleAndMenus();
   }
 
+  @Override
   public void updateColours(Object source)
   {
     AlignmentPanel ap = (AlignmentPanel) source;
-    colourBySequence(ap.av.isShowSequenceFeatures(), ap);
+    colourBySequence(ap);
   }
 
+  @Override
   public void showUrl(String url)
   {
     try
@@ -134,9 +136,8 @@ class AppletJmolBinding extends JalviewJmolBinding
   public void newJmolPopup(boolean translateLocale, String menuName,
           boolean asPopup)
   {
-    jmolpopup = new JmolAwtPopup(); // is this used?
-    jmolpopup.jpiInitialize((viewer), menuName);
-
+    // jmolpopup = new JmolAwtPopup(); // is this used?
+    // jmolpopup.jpiInitialize((viewer), menuName);
   }
 
   @Override
@@ -145,6 +146,7 @@ class AppletJmolBinding extends JalviewJmolBinding
     // do nothing.
   }
 
+  @Override
   public void selectionChanged(BS arg0)
   {
     // TODO Auto-generated method stub
@@ -197,4 +199,11 @@ class AppletJmolBinding extends JalviewJmolBinding
     // TODO Auto-generated method stub
     return null;
   }
+
+  @Override
+  protected IProgressIndicator getIProgressIndicator()
+  {
+    // no progress indicators on the applet
+    return null;
+  }
 }