Remove empty() from feature ToolTip
[jalview.git] / src / jalview / appletgui / SeqPanel.java
index 87e9bec..5ecc613 100755 (executable)
@@ -1,6 +1,6 @@
 /*\r
  * Jalview - A Sequence Alignment Editor and Viewer\r
- * Copyright (C) 2005 AM Waterhouse, J Procter, G Barton, M Clamp, S Searle\r
+ * Copyright (C) 2006 AM Waterhouse, J Procter, G Barton, M Clamp, S Searle\r
  *\r
  * This program is free software; you can redistribute it and/or\r
  * modify it under the terms of the GNU General Public License\r
@@ -25,6 +25,8 @@ import java.awt.event.*;
 import jalview.datamodel.*;\r
 import jalview.schemes.*;\r
 \r
+import java.util.Vector;\r
+\r
 public class SeqPanel\r
     extends Panel implements MouseMotionListener, MouseListener\r
 {\r
@@ -185,7 +187,7 @@ public class SeqPanel
        SequenceGroup sg = av.selectionGroup;\r
        //Find the top and bottom of this group\r
        int min = av.alignment.getHeight(), max = 0;\r
-       for(int i=0; i<sg.getSize(); i++)\r
+       for(int i=0; i<sg.getSize(false); i++)\r
        {\r
          int index = av.alignment.findIndex( sg.getSequenceAt(i) );\r
          if(index > max)\r
@@ -221,7 +223,7 @@ public class SeqPanel
        else\r
        {\r
          // Now add any sequences between min and max\r
-         sg.sequences.removeAllElements();\r
+         sg.getSequences(false).removeAllElements();\r
          for (int i = min; i < max; i++)\r
          {\r
            sg.addSequence(av.alignment.getSequenceAt(i), false);\r
@@ -312,6 +314,7 @@ public class SeqPanel
                      ")");\r
        }\r
      }\r
+\r
      ap.alignFrame.statusBar.setText(text.toString());\r
 \r
     }\r
@@ -319,17 +322,20 @@ public class SeqPanel
      {\r
        lastMousePress = evt.getPoint();\r
 \r
+       //For now, ignore the mouseWheel font resizing on Macs\r
+       //As the Button2_mask always seems to be true\r
        if ( (evt.getModifiers() & InputEvent.BUTTON2_MASK) ==\r
-         InputEvent.BUTTON2_MASK)\r
+         InputEvent.BUTTON2_MASK && !av.MAC)\r
        {\r
          mouseWheelPressed = true;\r
          return;\r
        }\r
 \r
-       if (evt.isShiftDown() || evt.isAltDown() ||\r
-           evt.isControlDown())\r
+       if (evt.isShiftDown()\r
+           || evt.isControlDown()\r
+           || evt.isAltDown())\r
        {\r
-         if (evt.isAltDown() || evt.isControlDown())\r
+         if (evt.isControlDown() || evt.isAltDown())\r
          {\r
            groupEditing = true;\r
          }\r
@@ -409,6 +415,8 @@ public class SeqPanel
 \r
 \r
       int cwidth = seqCanvas.getWrappedCanvasWidth(getSize().width);\r
+      if(cwidth<1)\r
+        return 0;\r
 \r
       wrappedBlock = y / cHeight;\r
       wrappedBlock += av.getStartRes() / cwidth;\r
@@ -421,6 +429,9 @@ public class SeqPanel
       res = (x / av.getCharWidth()) + av.getStartRes();\r
   }\r
 \r
+  if(av.hasHiddenColumns)\r
+          res = av.getColumnSelection().adjustForHiddenColumns(res);\r
+\r
   return res;\r
 \r
  }\r
@@ -442,11 +453,17 @@ public class SeqPanel
 \r
        y -= hgap;\r
 \r
-     seq = ( (y % cHeight) / av.getCharHeight());\r
+     seq = Math.min( (y % cHeight) / av.getCharHeight(),\r
+                     av.alignment.getHeight() -1);\r
+     if(seq<0)\r
+       seq = 0;\r
    }\r
    else\r
    {\r
-     seq = (y / av.getCharHeight()) + av.getStartSeq();\r
+     seq = Math.min( (y / av.getCharHeight()) + av.getStartSeq(),\r
+                     av.alignment.getHeight() -1);\r
+     if(seq<0)\r
+       seq = 0;\r
    }\r
 \r
    return seq;\r
@@ -516,11 +533,9 @@ public class SeqPanel
 \r
     if (obj != null)\r
     {\r
-\r
       if (obj != "")\r
       {\r
-        text.append(obj + " (" +\r
-                    av.getAlignment().getSequenceAt(seq).findPosition(res) + ")");\r
+        text.append(obj + " (" + sequence.findPosition(res) + ")");\r
       }\r
     }\r
 \r
@@ -529,54 +544,74 @@ public class SeqPanel
       seqCanvas.pdbCanvas.highlightRes(sequence.findPosition(res));\r
     }\r
 \r
+    ap.alignFrame.statusBar.setText(text.toString());\r
+\r
 \r
     // use aa to see if the mouse pointer is on a\r
     if (av.showSequenceFeatures\r
         && sequence.getSequenceFeatures()!=null\r
         && av.featuresDisplayed!=null)\r
     {\r
+      StringBuffer featureText = new StringBuffer();\r
+      Vector allFeatures = getAllFeaturesAtRes(sequence, sequence.findPosition(res));\r
+\r
       int index = 0;\r
-      sequence.getSequenceFeatures();\r
-      boolean first = true;\r
-      while (index < sequence.getSequenceFeatures().length)\r
+      while (index < allFeatures.size())\r
       {\r
-        SequenceFeature sf = sequence.getSequenceFeatures()[index];\r
-        if (sf.getBegin() <= sequence.findPosition(res) &&\r
-            sf.getEnd() >= sequence.findPosition(res))\r
+        SequenceFeature sf = (SequenceFeature) allFeatures.elementAt(index);\r
+\r
+        featureText.append(sf.getType()+" "+sf.begin+":"+sf.end);\r
+\r
+        if (sf.getDescription() != null)\r
+          featureText.append(" " + sf.getDescription());\r
+\r
+        if (sf.getValue("status") != null )\r
         {\r
-          if(!av.featuresDisplayed.containsKey(sf.getType()))\r
-           {\r
-             index++;\r
-             continue;\r
-           }\r
+          String status = sf.getValue("status").toString();\r
+          if(status.length()>0)\r
+            featureText.append(" (" + sf.getValue("status") + ")");\r
+        }\r
+        featureText.append("\n");\r
+\r
+        index++;\r
+      }\r
 \r
-          if(first)\r
-          {\r
-            text.append(" Sequence Feature:");\r
-            first = false;\r
-          }\r
 \r
-          text.append(" "+sf.getType());\r
+        if (tooltip == null)\r
+          tooltip = new Tooltip(featureText.toString(), seqCanvas);\r
+        else\r
+          tooltip.setTip(featureText.toString());\r
+\r
+        tooltip.repaint();\r
 \r
-          if(sf.getDescription()!=null)\r
-            text.append(" "+sf.getDescription());\r
+    }\r
+  }\r
 \r
-          if (sf.getStatus()!=null && sf.getStatus().length() > 0)\r
+  Vector getAllFeaturesAtRes(SequenceI seq, int res)\r
+  {\r
+    Vector allFeatures = new Vector();\r
+    int index = 0;\r
+    if(seq.getSequenceFeatures()!=null)\r
+    {\r
+      while (index < seq.getSequenceFeatures().length)\r
+      {\r
+        SequenceFeature sf = seq.getSequenceFeatures()[index];\r
+        if (sf.getBegin() <= res &&\r
+            sf.getEnd() >= res)\r
+        {\r
+          if (av.featuresDisplayed.containsKey(sf.getType()))\r
           {\r
-            text.append(" (" + sf.getStatus() + ")");\r
+            allFeatures.addElement(sf);\r
           }\r
-          text.append("; ");\r
         }\r
-\r
         index++;\r
-\r
       }\r
     }\r
-\r
-     ap.alignFrame.statusBar.setText(text.toString());\r
-\r
+    return allFeatures;\r
   }\r
 \r
+  Tooltip tooltip;\r
+\r
   public void mouseDragged(MouseEvent evt)\r
   {\r
     if (mouseWheelPressed)\r
@@ -667,184 +702,221 @@ public class SeqPanel
   }\r
 \r
   synchronized void editSequence(boolean insertGap, int startres)\r
-    {\r
-      int fixedLeft = -1;\r
-      int fixedRight = -1;\r
-      boolean fixedColumns = false;\r
-      SequenceGroup sg = av.getSelectionGroup();\r
+  {\r
+    int fixedLeft = -1;\r
+    int fixedRight = -1;\r
+    boolean fixedColumns = false;\r
+    SequenceGroup sg = av.getSelectionGroup();\r
 \r
-      if(groupEditing && sg==null)\r
-        return;\r
 \r
-        SequenceI seq = av.alignment.getSequenceAt(startseq);\r
-        StringBuffer message = new StringBuffer();\r
-        if (groupEditing)\r
-           message.append("Edit group:");\r
-        else\r
-            message.append("Edit sequence: "+seq.getName());\r
+      if (!groupEditing && av.hasHiddenRows)\r
+      {\r
+        if (av.alignment.getSequenceAt(startseq).getHiddenSequences() != null)\r
+        {\r
+          groupEditing = true;\r
+        }\r
+      }\r
 \r
-       if(insertGap)\r
-         message.append(" insert ");\r
-       else\r
-         message.append(" delete ");\r
+      //No group, but the sequence may represent a group\r
+      if (groupEditing\r
+          && sg == null\r
+          && av.alignment.getSequenceAt(startseq).getHiddenSequences() == null)\r
+      {\r
+        groupEditing = false;\r
+      }\r
+\r
+      SequenceI seq = av.alignment.getSequenceAt(startseq);\r
+      StringBuffer message = new StringBuffer();\r
+      if (groupEditing)\r
+         message.append("Edit group:");\r
+      else\r
+         message.append("Edit sequence: "+seq.getName());\r
+\r
+     if(insertGap)\r
+       message.append(" insert ");\r
+     else\r
+       message.append(" delete ");\r
+\r
+     message.append(Math.abs(startres-lastres)+" gaps.");\r
+     ap.alignFrame.statusBar.setText(message.toString());\r
 \r
-       message.append(Math.abs(startres-lastres)+" gaps.");\r
-       ap.alignFrame.statusBar.setText(message.toString());\r
 \r
+      //Are we editing within a selection group?\r
+      if (groupEditing\r
+          || (sg != null && sg.getSequences(true).contains(seq)))\r
+      {\r
+        fixedColumns = true;\r
 \r
-        //Are we editing within a selection group?\r
-        if (groupEditing\r
-            || (sg != null && sg.sequences.contains(seq)))\r
+        //sg might be null as the user may only see 1 sequence,\r
+        //but the sequence represents a group\r
+        if (sg == null)\r
         {\r
-          fixedColumns = true;\r
+          sg = new SequenceGroup(null, null, false, false, false, 0,\r
+                                 av.alignment.getWidth()-1);\r
+          sg.addSequence(av.alignment.getSequenceAt(startseq), false);\r
+        }\r
 \r
-          fixedLeft = sg.getStartRes();\r
-          fixedRight = sg.getEndRes();\r
+        fixedLeft = sg.getStartRes();\r
+        fixedRight = sg.getEndRes();\r
 \r
-          if (   (startres < fixedLeft && lastres >= fixedLeft)\r
-              || (startres >= fixedLeft && lastres < fixedLeft)\r
-              || (startres > fixedRight && lastres <=fixedRight)\r
-              || (startres <= fixedRight && lastres > fixedRight))\r
+        if (   (startres < fixedLeft && lastres >= fixedLeft)\r
+            || (startres >= fixedLeft && lastres < fixedLeft)\r
+            || (startres > fixedRight && lastres <=fixedRight)\r
+            || (startres <= fixedRight && lastres > fixedRight))\r
+        {\r
+          endEditing();\r
+          return;\r
+        }\r
+\r
+        if (fixedLeft > startres)\r
+        {\r
+          fixedRight = fixedLeft - 1;\r
+          fixedLeft = 0;\r
+        }\r
+        else if (fixedRight < startres)\r
+        {\r
+          fixedLeft = fixedRight;\r
+          fixedRight = -1;\r
+        }\r
+      }\r
+\r
+\r
+      if(av.hasHiddenColumns )\r
+      {\r
+          fixedColumns = true;\r
+          int y1 = av.getColumnSelection().getHiddenBoundaryLeft(startres);\r
+          int y2 = av.getColumnSelection().getHiddenBoundaryRight(startres);\r
+\r
+          if ( (insertGap && startres > y1 && lastres < y1)\r
+              || (!insertGap && startres < y2 && lastres > y2))\r
           {\r
             endEditing();\r
             return;\r
           }\r
 \r
-          if (fixedLeft > startres)\r
+          //System.out.print(y1+" "+y2+" "+fixedLeft+" "+fixedRight+"~~");\r
+          //Selection spans a hidden region\r
+          if(fixedLeft<y1 && (fixedRight>y2 || fixedRight==-1))\r
           {\r
-            fixedRight = fixedLeft - 1;\r
-            fixedLeft = 0;\r
-          }\r
-          else if (fixedRight < startres)\r
-          {\r
-            fixedLeft = fixedRight;\r
-            fixedRight = -1;\r
+            if(startres>=y2)\r
+            {\r
+              fixedLeft = y2;\r
+            }\r
+            else\r
+            {\r
+             fixedRight = y2 - 1;\r
+           }\r
           }\r
-        }\r
+      }\r
 \r
 \r
-        if (groupEditing)\r
+      if (groupEditing)\r
+      {\r
+        // drag to right\r
+        if (insertGap)\r
         {\r
-          // drag to right\r
-          if (insertGap)\r
-          {\r
-              //If the user has selected the whole sequence, and is dragging to\r
-              // the right, we can still extend the alignment and selectionGroup\r
-              if(sg.getStartRes() == 0 && sg.getEndRes() + 1 == av.alignment.getWidth())\r
-              {\r
-                sg.setEndRes(av.alignment.getWidth() + startres - lastres);\r
-                fixedRight = sg.getEndRes();\r
-              }\r
+            //If the user has selected the whole sequence, and is dragging to\r
+            // the right, we can still extend the alignment and selectionGroup\r
+            if(   sg.getStartRes() == 0\r
+                  && sg.getEndRes() == fixedRight\r
+                  && sg.getEndRes() == av.alignment.getWidth()-1\r
+               )\r
+            {\r
+              sg.setEndRes(av.alignment.getWidth() + startres - lastres);\r
+              fixedRight = sg.getEndRes();\r
+            }\r
 \r
-            // Is it valid with fixed columns??\r
-            // Find the next gap before the end\r
-            // of the visible region boundary\r
-            boolean blank = false;\r
-            for (fixedRight = fixedRight;\r
-                 fixedRight > lastres;\r
-                 fixedRight--)\r
+          // Is it valid with fixed columns??\r
+          // Find the next gap before the end\r
+          // of the visible region boundary\r
+          boolean blank = false;\r
+          for (fixedRight = fixedRight;\r
+               fixedRight > lastres;\r
+               fixedRight--)\r
+          {\r
+            blank = true;\r
+            for (int s = 0; s < sg.getSize(true); s++)\r
             {\r
-              blank = true;\r
-              for (int s = 0; s < sg.getSize(); s++)\r
+              seq = (SequenceI)sg.getSequences(true).elementAt(s);\r
+              for (int j = 0; j < startres - lastres; j++)\r
               {\r
-                seq = sg.getSequenceAt(s);\r
-                for (int j = 0; j < startres - lastres; j++)\r
+                if (!jalview.util.Comparison.isGap(\r
+                    seq.getCharAt(fixedRight - j)))\r
                 {\r
-                  if (!jalview.util.Comparison.isGap(\r
-                      seq.getCharAt(fixedRight - j)))\r
-                  {\r
-                    blank = false;\r
-                    break;\r
-                  }\r
+                  blank = false;\r
+                  break;\r
                 }\r
               }\r
-              if (blank)\r
-                break;\r
             }\r
+            if (blank)\r
+              break;\r
+          }\r
 \r
-            if (!blank)\r
+          if (!blank)\r
+          {\r
+            if(sg.getSize(false) == av.alignment.getHeight()  )\r
             {\r
-              if(sg.getSize() == av.alignment.getHeight())\r
-              {\r
-                //We can still insert gaps if the selectionGroup\r
-                //contains all the sequences\r
-                sg.setEndRes(sg.getEndRes()+startres-lastres);\r
-                fixedRight = av.alignment.getWidth()+startres-lastres;\r
-              }\r
-              else\r
+              if((av.hasHiddenColumns\r
+                  && startres<av.getColumnSelection().getHiddenBoundaryRight(startres)))\r
               {\r
                 endEditing();\r
                 return;\r
               }\r
-            }\r
-          }\r
-\r
-\r
-          // drag to left\r
-          else if(!insertGap)\r
-          {\r
-            /// Are we able to delete?\r
-            // ie are all columns blank?\r
-\r
-            for (int s = 0; s < sg.getSize(); s++)\r
-            {\r
-              seq = sg.getSequenceAt(s);\r
 \r
-              for (int j = startres; j < lastres; j++)\r
+              int alWidth = av.alignment.getWidth();\r
+              if(av.hasHiddenRows)\r
               {\r
-                if (seq.getSequence().length() <= j)\r
-                {\r
-                  continue;\r
-                }\r
-\r
-                if (!jalview.util.Comparison.isGap(\r
-                    seq.getSequence().charAt(j)))\r
-                {\r
-                  // Not a gap, block edit not valid\r
-                  endEditing();\r
-                  return;\r
-                }\r
+                int hwidth = av.alignment.getHiddenSequences().getWidth();\r
+                if(hwidth>alWidth)\r
+                  alWidth = hwidth;\r
               }\r
+              //We can still insert gaps if the selectionGroup\r
+              //contains all the sequences\r
+              sg.setEndRes(sg.getEndRes()+startres-lastres);\r
+              fixedRight = alWidth+startres-lastres;\r
+            }\r
+            else\r
+            {\r
+              endEditing();\r
+              return;\r
             }\r
           }\r
+        }\r
 \r
 \r
-          for (int i = 0; i < sg.getSize(); i++)\r
+        // drag to left\r
+        else if(!insertGap)\r
+        {\r
+          /// Are we able to delete?\r
+          // ie are all columns blank?\r
+\r
+          for (int s = 0; s < sg.getSize(true); s++)\r
           {\r
-            seq = sg.getSequenceAt(i);\r
+            seq = (SequenceI)sg.getSequences(true).elementAt(s);\r
 \r
-            if (insertGap)\r
+            for (int j = startres; j < lastres; j++)\r
             {\r
-              // dragging to the right\r
-              for (int j = lastres; j < startres; j++)\r
+              if (seq.getSequence().length() <= j)\r
               {\r
-                if (fixedColumns && fixedRight != -1)\r
-                {\r
-                  insertChar(j, seq, fixedRight);\r
-                }\r
-                else\r
-                  insertChar(j, seq);\r
+                continue;\r
               }\r
-            }\r
-            else\r
-            {\r
-              // dragging to the left\r
-              for (int j = lastres; j > startres; j--)\r
+\r
+              if (!jalview.util.Comparison.isGap(\r
+                  seq.getSequence().charAt(j)))\r
               {\r
-                if (fixedColumns && fixedRight != -1)\r
-                {\r
-                  deleteChar(startres, seq, fixedRight);\r
-                }\r
-                else\r
-                {\r
-                  deleteChar(startres, seq);\r
-                }\r
+                // Not a gap, block edit not valid\r
+                endEditing();\r
+                return;\r
               }\r
             }\r
           }\r
         }\r
-        else /////Editing a single sequence///////////\r
+\r
+\r
+        for (int i = 0; i < sg.getSize(true); i++)\r
         {\r
+          seq = (SequenceI) sg.getSequences(true).elementAt(i);\r
+\r
           if (insertGap)\r
           {\r
             // dragging to the right\r
@@ -852,18 +924,7 @@ public class SeqPanel
             {\r
               if (fixedColumns && fixedRight != -1)\r
               {\r
-                if (sg.getStartRes() == 0\r
-                    && sg.getEndRes() + 1 == av.alignment.getWidth()\r
-                    && !jalview.util.Comparison.isGap(seq.getCharAt(fixedRight)))\r
-                {\r
-                  //Single sequence edit, whole sequence selected,\r
-                  //extend the selection group\r
-                  sg.setEndRes(av.alignment.getWidth() -1 + startres - lastres);\r
-                  fixedColumns = false;\r
-                  insertChar(j, seq);\r
-                }\r
-                else\r
-                  insertChar(j, seq, fixedRight);\r
+                insertChar(j, seq, fixedRight);\r
               }\r
               else\r
                 insertChar(j, seq);\r
@@ -885,10 +946,42 @@ public class SeqPanel
             }\r
           }\r
         }\r
+      }\r
+      else /////Editing a single sequence///////////\r
+      {\r
+        if (insertGap)\r
+        {\r
+          // dragging to the right\r
+          for (int j = lastres; j < startres; j++)\r
+          {\r
+            if (fixedColumns && fixedRight != -1)\r
+            {\r
+                insertChar(j, seq, fixedRight);\r
+            }\r
+            else\r
+              insertChar(j, seq);\r
+          }\r
+        }\r
+        else\r
+        {\r
+          // dragging to the left\r
+          for (int j = lastres; j > startres; j--)\r
+          {\r
+            if (fixedColumns && fixedRight != -1)\r
+            {\r
+              deleteChar(startres, seq, fixedRight);\r
+            }\r
+            else\r
+            {\r
+              deleteChar(startres, seq);\r
+            }\r
+          }\r
+        }\r
+      }\r
 \r
-        lastres = startres;\r
-        seqCanvas.repaint();\r
-    }\r
+      lastres = startres;\r
+      seqCanvas.repaint();\r
+  }\r
 \r
 \r
     /**\r
@@ -901,7 +994,7 @@ public class SeqPanel
     {\r
         seq.insertCharAt(j, av.getGapCharacter());\r
         seqEditOccurred = true;\r
-    }\r
+   }\r
 \r
     void insertChar(int j, SequenceI seq, int fixedColumn)\r
     {\r
@@ -943,7 +1036,6 @@ public class SeqPanel
             "End editing: Tried removing residue " + seq.getCharAt(j));\r
         return;\r
       }\r
-\r
       seq.deleteCharAt(j);\r
       seq.insertCharAt(fixedColumn, av.getGapCharacter());\r
       seqEditOccurred = true;\r
@@ -1032,7 +1124,7 @@ public class SeqPanel
       }\r
     }\r
 \r
-    else if (!stretchGroup.sequences.contains(sequence)\r
+    else if (!stretchGroup.getSequences(false).contains(sequence)\r
              || stretchGroup.getStartRes() > res\r
              || stretchGroup.getEndRes() < res)\r
     {\r
@@ -1048,57 +1140,76 @@ public class SeqPanel
               allGroups[i].getEndRes() >= res)\r
           {\r
             stretchGroup = allGroups[i];\r
-            av.setSelectionGroup(stretchGroup);\r
             break;\r
           }\r
         }\r
       }\r
+      av.setSelectionGroup(stretchGroup);\r
     }\r
 \r
-    if (stretchGroup == null)\r
-    {\r
-      // define a new group here\r
-      SequenceGroup sg = new SequenceGroup();\r
-      sg.setStartRes(res);\r
-      sg.setEndRes(res);\r
-      sg.addSequence(sequence, false);\r
-      av.setSelectionGroup(sg);\r
-      stretchGroup = sg;\r
-\r
-      if (av.getConservationSelected())\r
-      {\r
-        SliderPanel.setConservationSlider(ap, av.getGlobalColourScheme(),\r
-                                          "Background");\r
-      }\r
-      if (av.getAbovePIDThreshold())\r
-      {\r
-        SliderPanel.setPIDSliderSource(ap, av.getGlobalColourScheme(),\r
-                                       "Background");\r
-      }\r
-\r
-    }\r
 \r
     // DETECT RIGHT MOUSE BUTTON IN AWT\r
-    else if ( (evt.getModifiers() & InputEvent.BUTTON3_MASK) ==\r
+    if ( (evt.getModifiers() & InputEvent.BUTTON3_MASK) ==\r
              InputEvent.BUTTON3_MASK)\r
     {\r
-      APopupMenu popup = new APopupMenu(ap, null, null);\r
+      Vector allFeatures = getAllFeaturesAtRes(sequence,\r
+                                               sequence.findPosition(res));\r
+\r
+      Vector links = null;\r
+      if(allFeatures!=null)\r
+      {\r
+        for (int i = 0; i < allFeatures.size(); i++)\r
+        {\r
+          SequenceFeature sf = (SequenceFeature) allFeatures.elementAt(i);\r
+          if (sf.links != null)\r
+          {\r
+            links = new Vector();\r
+            for (int j = 0; j < sf.links.size(); j++)\r
+            {\r
+              links.addElement(sf.links.elementAt(j));\r
+            }\r
+          }\r
+        }\r
+      }\r
+      APopupMenu popup = new APopupMenu(ap, null, links);\r
       this.add(popup);\r
       popup.show(this, evt.getX(), evt.getY());\r
+      ap.repaint();\r
+      return;\r
     }\r
 \r
-    if (stretchGroup != null && stretchGroup.getEndRes() == res)\r
+    if (av.cursorMode)\r
     {\r
-      // Edit end res position of selected group\r
-      changeEndRes = true;\r
+      seqCanvas.cursorX = findRes(evt);\r
+      seqCanvas.cursorY = findSeq(evt);\r
+      seqCanvas.repaint();\r
+      return;\r
     }\r
 \r
-    else if (stretchGroup != null && stretchGroup.getStartRes() == res)\r
-    {\r
-      // Edit end res position of selected group\r
-      changeStartRes = true;\r
-    }\r
+      //Only if left mouse button do we want to change group sizes\r
 \r
+      if (stretchGroup == null)\r
+      {\r
+        // define a new group here\r
+        SequenceGroup sg = new SequenceGroup();\r
+        sg.setStartRes(res);\r
+        sg.setEndRes(res);\r
+        sg.addSequence(sequence, false);\r
+        av.setSelectionGroup(sg);\r
+        stretchGroup = sg;\r
+\r
+        if (av.getConservationSelected())\r
+        {\r
+          SliderPanel.setConservationSlider(ap, av.getGlobalColourScheme(),\r
+                                            "Background");\r
+        }\r
+        if (av.getAbovePIDThreshold())\r
+        {\r
+          SliderPanel.setPIDSliderSource(ap, av.getGlobalColourScheme(),\r
+                                         "Background");\r
+        }\r
+\r
+      }\r
   }\r
 \r
   public void doMouseReleasedDefineMode(MouseEvent evt)\r
@@ -1112,8 +1223,8 @@ public class SeqPanel
     {\r
       if (stretchGroup.cs instanceof ClustalxColourScheme)\r
       {\r
-        ( (ClustalxColourScheme) stretchGroup.cs).resetClustalX(stretchGroup.\r
-            sequences,\r
+        ( (ClustalxColourScheme) stretchGroup.cs).resetClustalX(\r
+            stretchGroup.getSequences(true),\r
             stretchGroup.getWidth());\r
       }\r
 \r
@@ -1216,7 +1327,7 @@ public class SeqPanel
 \r
           Sequence nextSeq = (Sequence) av.getAlignment().getSequenceAt(oldSeq);\r
 \r
-          if (stretchGroup.sequences.contains(nextSeq))\r
+          if (stretchGroup.getSequences(false).contains(nextSeq))\r
           {\r
               stretchGroup.deleteSequence(seq, false);\r
           }\r
@@ -1274,6 +1385,28 @@ public class SeqPanel
     }\r
   }\r
 \r
+  void scrollCanvas(MouseEvent evt)\r
+  {\r
+    if(evt==null)\r
+    {\r
+      if(scrollThread!=null)\r
+      {\r
+        scrollThread.running = false;\r
+        scrollThread = null;\r
+      }\r
+      mouseDragging = false;\r
+    }\r
+    else\r
+    {\r
+      if (scrollThread == null)\r
+        scrollThread = new ScrollThread();\r
+\r
+      mouseDragging = true;\r
+      scrollThread.setEvent(evt);\r
+    }\r
+\r
+    }\r
+\r
   // this class allows scrolling off the bottom of the visible alignment\r
   class ScrollThread\r
       extends Thread\r
@@ -1317,12 +1450,12 @@ public class SeqPanel
 \r
           if (mouseDragging && evt.getX() < 0)\r
           {\r
-            running = ap.scrollRight(true);\r
+            running = ap.scrollRight(false);\r
           }\r
 \r
           else if (mouseDragging && evt.getX() >= getSize().width)\r
           {\r
-            running = ap.scrollRight(false);\r
+            running = ap.scrollRight(true);\r
           }\r
         }\r
 \r