Hidden representatives moved from sequence to viewport
[jalview.git] / src / jalview / appletgui / SeqPanel.java
index 6869964..89e2086 100755 (executable)
@@ -1,6 +1,6 @@
 /*\r
  * Jalview - A Sequence Alignment Editor and Viewer\r
- * Copyright (C) 2005 AM Waterhouse, J Procter, G Barton, M Clamp, S Searle\r
+ * Copyright (C) 2006 AM Waterhouse, J Procter, G Barton, M Clamp, S Searle\r
  *\r
  * This program is free software; you can redistribute it and/or\r
  * modify it under the terms of the GNU General Public License\r
@@ -24,6 +24,7 @@ import java.awt.event.*;
 \r
 import jalview.datamodel.*;\r
 import jalview.schemes.*;\r
+import jalview.commands.*;\r
 \r
 import java.util.Vector;\r
 \r
@@ -60,6 +61,8 @@ public class SeqPanel
   boolean mouseWheelPressed = false;\r
   Point lastMousePress;\r
 \r
+  EditCommand editCommand;\r
+\r
   public SeqPanel(AlignViewport avp, AlignmentPanel p)\r
   {\r
     this.av = avp;\r
@@ -78,13 +81,20 @@ public class SeqPanel
 \r
   void endEditing()\r
   {\r
+    if (editCommand!=null && editCommand.getSize() > 0)\r
+    {\r
+      ap.alignFrame.addHistoryItem(editCommand);\r
+      av.firePropertyChange("alignment", null,\r
+                            av.getAlignment().getSequences());\r
+    }\r
+\r
     startseq = -1;\r
     lastres = -1;\r
-    seqEditOccurred = false;\r
     editingSeqs = false;\r
     groupEditing = false;\r
     keyboardNo1 = null;\r
     keyboardNo2 = null;\r
+     editCommand = null;\r
    }\r
 \r
    void setCursorRow()\r
@@ -128,6 +138,24 @@ public class SeqPanel
    {\r
      seqCanvas.cursorX += dx;\r
      seqCanvas.cursorY += dy;\r
+     if (av.hasHiddenColumns && !av.colSel.isVisible(seqCanvas.cursorX))\r
+     {\r
+       int original = seqCanvas.cursorX - dx;\r
+       int maxWidth = av.alignment.getWidth();\r
+\r
+       while(!av.colSel.isVisible(seqCanvas.cursorX)\r
+             && seqCanvas.cursorX<maxWidth\r
+             && seqCanvas.cursorX>0)\r
+       {\r
+         seqCanvas.cursorX += dx;\r
+       }\r
+\r
+       if(seqCanvas.cursorX>=maxWidth\r
+          || !av.colSel.isVisible(seqCanvas.cursorX) )\r
+       {\r
+         seqCanvas.cursorX = original;\r
+       }\r
+      }\r
      scrollToVisible();\r
    }\r
 \r
@@ -159,13 +187,13 @@ public class SeqPanel
        {\r
          ap.scrollUp(false);\r
        }\r
-       while (seqCanvas.cursorX < av.startRes)\r
+       while (seqCanvas.cursorX < av.colSel.adjustForHiddenColumns(av.startRes))\r
        {\r
 \r
          if (!ap.scrollRight(false))\r
            break;\r
        }\r
-       while (seqCanvas.cursorX > av.endRes)\r
+       while (seqCanvas.cursorX > av.colSel.adjustForHiddenColumns(av.endRes))\r
        {\r
          if (!ap.scrollRight(true))\r
            break;\r
@@ -187,7 +215,7 @@ public class SeqPanel
        SequenceGroup sg = av.selectionGroup;\r
        //Find the top and bottom of this group\r
        int min = av.alignment.getHeight(), max = 0;\r
-       for(int i=0; i<sg.getSize(false); i++)\r
+       for(int i=0; i<sg.getSize(); i++)\r
        {\r
          int index = av.alignment.findIndex( sg.getSequenceAt(i) );\r
          if(index > max)\r
@@ -223,7 +251,7 @@ public class SeqPanel
        else\r
        {\r
          // Now add any sequences between min and max\r
-         sg.getSequences(false).removeAllElements();\r
+         sg.getSequences(null).removeAllElements();\r
          for (int i = min; i < max; i++)\r
          {\r
            sg.addSequence(av.alignment.getSequenceAt(i), false);\r
@@ -246,24 +274,20 @@ public class SeqPanel
 \r
    void insertGapAtCursor(boolean group)\r
    {\r
-     ap.alignFrame.addHistoryItem(new HistoryItem("Edit Sequence",\r
-                                                  av.alignment, HistoryItem.EDIT));\r
      groupEditing = group;\r
      startseq = seqCanvas.cursorY;\r
      lastres = seqCanvas.cursorX;\r
      editSequence(true, seqCanvas.cursorX+getKeyboardNo(keyboardNo1));\r
-     editOccurred();\r
+     endEditing();\r
    }\r
 \r
    void deleteGapAtCursor(boolean group)\r
    {\r
-     ap.alignFrame.addHistoryItem(new HistoryItem("Edit Sequence",\r
-                                                  av.alignment, HistoryItem.EDIT));\r
      groupEditing = group;\r
      startseq = seqCanvas.cursorY;\r
      lastres = seqCanvas.cursorX+getKeyboardNo(keyboardNo1);\r
      editSequence(false, seqCanvas.cursorX);\r
-     editOccurred();\r
+     endEditing();\r
    }\r
 \r
    void numberPressed(char value)\r
@@ -322,17 +346,20 @@ public class SeqPanel
      {\r
        lastMousePress = evt.getPoint();\r
 \r
+       //For now, ignore the mouseWheel font resizing on Macs\r
+       //As the Button2_mask always seems to be true\r
        if ( (evt.getModifiers() & InputEvent.BUTTON2_MASK) ==\r
-         InputEvent.BUTTON2_MASK)\r
+         InputEvent.BUTTON2_MASK && !av.MAC)\r
        {\r
          mouseWheelPressed = true;\r
          return;\r
        }\r
 \r
-       if (evt.isShiftDown() || evt.isAltDown() ||\r
-           evt.isControlDown())\r
+       if (evt.isShiftDown()\r
+           || evt.isControlDown()\r
+           || evt.isAltDown())\r
        {\r
-         if (evt.isAltDown() || evt.isControlDown())\r
+         if (evt.isControlDown() || evt.isAltDown())\r
          {\r
            groupEditing = true;\r
          }\r
@@ -351,8 +378,6 @@ public class SeqPanel
        if(seq<0 || res<0)\r
          return;\r
 \r
-       ap.alignFrame.addHistoryItem(new HistoryItem("Edit Sequence",\r
-                                                          av.alignment, HistoryItem.EDIT));\r
 \r
          if ((seq < av.getAlignment().getHeight()) &&\r
                  (res < av.getAlignment().getSequenceAt(seq).getLength()))\r
@@ -383,8 +408,6 @@ public class SeqPanel
        return;\r
     }\r
 \r
-     editOccurred();\r
-\r
      endEditing();\r
      ap.repaint();\r
   }\r
@@ -412,6 +435,8 @@ public class SeqPanel
 \r
 \r
       int cwidth = seqCanvas.getWrappedCanvasWidth(getSize().width);\r
+      if(cwidth<1)\r
+        return 0;\r
 \r
       wrappedBlock = y / cHeight;\r
       wrappedBlock += av.getStartRes() / cwidth;\r
@@ -424,6 +449,9 @@ public class SeqPanel
       res = (x / av.getCharWidth()) + av.getStartRes();\r
   }\r
 \r
+  if(av.hasHiddenColumns)\r
+          res = av.getColumnSelection().adjustForHiddenColumns(res);\r
+\r
   return res;\r
 \r
  }\r
@@ -445,11 +473,17 @@ public class SeqPanel
 \r
        y -= hgap;\r
 \r
-     seq = ( (y % cHeight) / av.getCharHeight());\r
+     seq = Math.min( (y % cHeight) / av.getCharHeight(),\r
+                     av.alignment.getHeight() -1);\r
+     if(seq<0)\r
+       seq = 0;\r
    }\r
    else\r
    {\r
-     seq = (y / av.getCharHeight()) + av.getStartSeq();\r
+     seq = Math.min( (y / av.getCharHeight()) + av.getStartSeq(),\r
+                     av.alignment.getHeight() -1);\r
+     if(seq<0)\r
+       seq = 0;\r
    }\r
 \r
    return seq;\r
@@ -458,8 +492,6 @@ public class SeqPanel
 \r
   public void doMousePressed(MouseEvent evt)\r
   {\r
-    ap.alignFrame.addHistoryItem(new HistoryItem(\r
-        "Edit Sequence", av.alignment, HistoryItem.EDIT));\r
 \r
     int seq = findSeq(evt);\r
     int res = findRes(evt);\r
@@ -519,11 +551,9 @@ public class SeqPanel
 \r
     if (obj != null)\r
     {\r
-\r
       if (obj != "")\r
       {\r
-        text.append(obj + " (" +\r
-                    av.getAlignment().getSequenceAt(seq).findPosition(res) + ")");\r
+        text.append(obj + " (" + sequence.findPosition(res) + ")");\r
       }\r
     }\r
 \r
@@ -532,6 +562,8 @@ public class SeqPanel
       seqCanvas.pdbCanvas.highlightRes(sequence.findPosition(res));\r
     }\r
 \r
+    ap.alignFrame.statusBar.setText(text.toString());\r
+\r
 \r
     // use aa to see if the mouse pointer is on a\r
     if (av.showSequenceFeatures\r
@@ -553,7 +585,9 @@ public class SeqPanel
 \r
         if (sf.getValue("status") != null )\r
         {\r
-          featureText.append(" (" + sf.getValue("status") + ")");\r
+          String status = sf.getValue("status").toString();\r
+          if(status.length()>0)\r
+            featureText.append(" (" + sf.getValue("status") + ")");\r
         }\r
         featureText.append("\n");\r
 \r
@@ -568,14 +602,11 @@ public class SeqPanel
 \r
         tooltip.repaint();\r
 \r
-     //   text.append(" Sequence Feature:");\r
-     //   text.append(featureText);\r
-\r
     }\r
-\r
-\r
-     ap.alignFrame.statusBar.setText(text.toString());\r
-\r
+    else if (tooltip != null)\r
+     {\r
+       tooltip.setTip("");\r
+     }\r
   }\r
 \r
   Vector getAllFeaturesAtRes(SequenceI seq, int res)\r
@@ -693,250 +724,339 @@ public class SeqPanel
   }\r
 \r
   synchronized void editSequence(boolean insertGap, int startres)\r
-    {\r
-      int fixedLeft = -1;\r
-      int fixedRight = -1;\r
-      boolean fixedColumns = false;\r
-      SequenceGroup sg = av.getSelectionGroup();\r
+  {\r
+    int fixedLeft = -1;\r
+    int fixedRight = -1;\r
+    boolean fixedColumns = false;\r
+    SequenceGroup sg = av.getSelectionGroup();\r
 \r
-      if(groupEditing && sg==null)\r
-        return;\r
+    SequenceI seq = av.alignment.getSequenceAt(startseq);\r
 \r
-        SequenceI seq = av.alignment.getSequenceAt(startseq);\r
-        StringBuffer message = new StringBuffer();\r
-        if (groupEditing)\r
-           message.append("Edit group:");\r
-        else\r
-            message.append("Edit sequence: "+seq.getName());\r
+      if (!groupEditing && av.hasHiddenRows)\r
+      {\r
+        if (av.hiddenRepSequences!=null\r
+            && av.hiddenRepSequences.containsKey(seq))\r
+        {\r
+          sg = (SequenceGroup)av.hiddenRepSequences.get(seq);\r
+          groupEditing = true;\r
+          }\r
+      }\r
+\r
+      StringBuffer message = new StringBuffer();\r
+      if (groupEditing)\r
+      {\r
+        message.append("Edit group:");\r
+        if (editCommand == null)\r
+          editCommand = new EditCommand("Edit Group");\r
+      }\r
+      else\r
+       {\r
+         message.append("Edit sequence: " + seq.getName());\r
+         String label = seq.getName();\r
+         if(label.length()>10)\r
+           label = label.substring(0,10);\r
+         if(editCommand==null)\r
+           editCommand = new EditCommand("Edit "+label);\r
+       }\r
+\r
+     if(insertGap)\r
+       message.append(" insert ");\r
+     else\r
+       message.append(" delete ");\r
+\r
+     message.append(Math.abs(startres-lastres)+" gaps.");\r
+     ap.alignFrame.statusBar.setText(message.toString());\r
 \r
-       if(insertGap)\r
-         message.append(" insert ");\r
-       else\r
-         message.append(" delete ");\r
 \r
-       message.append(Math.abs(startres-lastres)+" gaps.");\r
-       ap.alignFrame.statusBar.setText(message.toString());\r
+      //Are we editing within a selection group?\r
+      if (groupEditing\r
+          || (sg != null && sg.getSequences(av.hiddenRepSequences).contains(seq)))\r
+      {\r
+        fixedColumns = true;\r
+\r
+        //sg might be null as the user may only see 1 sequence,\r
+        //but the sequence represents a group\r
+        if (sg == null)\r
+        {\r
+          sg = (SequenceGroup) av.hiddenRepSequences.get(seq);\r
+        }\r
 \r
+        fixedLeft = sg.getStartRes();\r
+        fixedRight = sg.getEndRes();\r
 \r
-        //Are we editing within a selection group?\r
-        if (groupEditing\r
-            || (sg != null && sg.getSequences(false).contains(seq)))\r
+        if (   (startres < fixedLeft && lastres >= fixedLeft)\r
+            || (startres >= fixedLeft && lastres < fixedLeft)\r
+            || (startres > fixedRight && lastres <=fixedRight)\r
+            || (startres <= fixedRight && lastres > fixedRight))\r
         {\r
-          fixedColumns = true;\r
+          endEditing();\r
+          return;\r
+        }\r
+\r
+        if (fixedLeft > startres)\r
+        {\r
+          fixedRight = fixedLeft - 1;\r
+          fixedLeft = 0;\r
+        }\r
+        else if (fixedRight < startres)\r
+        {\r
+          fixedLeft = fixedRight;\r
+          fixedRight = -1;\r
+        }\r
+      }\r
+\r
 \r
-          fixedLeft = sg.getStartRes();\r
-          fixedRight = sg.getEndRes();\r
+      if(av.hasHiddenColumns )\r
+      {\r
+          fixedColumns = true;\r
+          int y1 = av.getColumnSelection().getHiddenBoundaryLeft(startres);\r
+          int y2 = av.getColumnSelection().getHiddenBoundaryRight(startres);\r
 \r
-          if (   (startres < fixedLeft && lastres >= fixedLeft)\r
-              || (startres >= fixedLeft && lastres < fixedLeft)\r
-              || (startres > fixedRight && lastres <=fixedRight)\r
-              || (startres <= fixedRight && lastres > fixedRight))\r
+          if ( (insertGap && startres > y1 && lastres < y1)\r
+              || (!insertGap && startres < y2 && lastres > y2))\r
           {\r
             endEditing();\r
             return;\r
           }\r
 \r
-          if (fixedLeft > startres)\r
-          {\r
-            fixedRight = fixedLeft - 1;\r
-            fixedLeft = 0;\r
-          }\r
-          else if (fixedRight < startres)\r
+          //System.out.print(y1+" "+y2+" "+fixedLeft+" "+fixedRight+"~~");\r
+          //Selection spans a hidden region\r
+          if(fixedLeft<y1 && (fixedRight>y2 || fixedRight==-1))\r
           {\r
-            fixedLeft = fixedRight;\r
-            fixedRight = -1;\r
+            if(startres>=y2)\r
+            {\r
+              fixedLeft = y2;\r
+            }\r
+            else\r
+            {\r
+             fixedRight = y2 - 1;\r
+           }\r
           }\r
-        }\r
+      }\r
 \r
 \r
-        if (groupEditing)\r
+      if (groupEditing)\r
+      {\r
+        Vector vseqs = sg.getSequences(av.hiddenRepSequences);\r
+        int g, groupSize = vseqs.size();\r
+        SequenceI[] groupSeqs = new SequenceI[groupSize];\r
+        for (g = 0; g < groupSeqs.length; g++)\r
+          groupSeqs[g] = (SequenceI) vseqs.elementAt(g);\r
+\r
+        // drag to right\r
+        if (insertGap)\r
         {\r
-          // drag to right\r
-          if (insertGap)\r
+            //If the user has selected the whole sequence, and is dragging to\r
+            // the right, we can still extend the alignment and selectionGroup\r
+            if(   sg.getStartRes() == 0\r
+                  && sg.getEndRes() == fixedRight\r
+                  && sg.getEndRes() == av.alignment.getWidth()-1\r
+               )\r
+            {\r
+              sg.setEndRes(av.alignment.getWidth() + startres - lastres);\r
+              fixedRight = sg.getEndRes();\r
+            }\r
+\r
+          // Is it valid with fixed columns??\r
+          // Find the next gap before the end\r
+          // of the visible region boundary\r
+          boolean blank = false;\r
+          for (fixedRight = fixedRight;\r
+               fixedRight > lastres;\r
+               fixedRight--)\r
           {\r
-              //If the user has selected the whole sequence, and is dragging to\r
-              // the right, we can still extend the alignment and selectionGroup\r
-              if(sg.getStartRes() == 0 && sg.getEndRes() + 1 == av.alignment.getWidth())\r
-              {\r
-                sg.setEndRes(av.alignment.getWidth() + startres - lastres);\r
-                fixedRight = sg.getEndRes();\r
-              }\r
+            blank = true;\r
 \r
-            // Is it valid with fixed columns??\r
-            // Find the next gap before the end\r
-            // of the visible region boundary\r
-            boolean blank = false;\r
-            for (fixedRight = fixedRight;\r
-                 fixedRight > lastres;\r
-                 fixedRight--)\r
+            for (g = 0; g < groupSize; g++)\r
             {\r
-              blank = true;\r
-              for (int s = 0; s < sg.getSize(false); s++)\r
+              for (int j = 0; j < startres - lastres; j++)\r
               {\r
-                seq = sg.getSequenceAt(s);\r
-                for (int j = 0; j < startres - lastres; j++)\r
+                if (!jalview.util.Comparison.isGap(\r
+                    groupSeqs[g].getCharAt(fixedRight - j)))\r
                 {\r
-                  if (!jalview.util.Comparison.isGap(\r
-                      seq.getCharAt(fixedRight - j)))\r
-                  {\r
-                    blank = false;\r
-                    break;\r
-                  }\r
+                  blank = false;\r
+                  break;\r
                 }\r
               }\r
-              if (blank)\r
-                break;\r
             }\r
+            if (blank)\r
+              break;\r
+          }\r
 \r
-            if (!blank)\r
+          if (!blank)\r
+          {\r
+            if(sg.getSize() == av.alignment.getHeight()  )\r
             {\r
-              if(sg.getSize(false) == av.alignment.getHeight())\r
-              {\r
-                //We can still insert gaps if the selectionGroup\r
-                //contains all the sequences\r
-                sg.setEndRes(sg.getEndRes()+startres-lastres);\r
-                fixedRight = av.alignment.getWidth()+startres-lastres;\r
-              }\r
-              else\r
+              if((av.hasHiddenColumns\r
+                  && startres<av.getColumnSelection().getHiddenBoundaryRight(startres)))\r
               {\r
                 endEditing();\r
                 return;\r
               }\r
+\r
+              int alWidth = av.alignment.getWidth();\r
+              if(av.hasHiddenRows)\r
+              {\r
+                int hwidth = av.alignment.getHiddenSequences().getWidth();\r
+                if(hwidth>alWidth)\r
+                  alWidth = hwidth;\r
+              }\r
+              //We can still insert gaps if the selectionGroup\r
+              //contains all the sequences\r
+              sg.setEndRes(sg.getEndRes()+startres-lastres);\r
+              fixedRight = alWidth+startres-lastres;\r
+            }\r
+            else\r
+            {\r
+              endEditing();\r
+              return;\r
             }\r
           }\r
+        }\r
 \r
 \r
-          // drag to left\r
-          else if(!insertGap)\r
-          {\r
-            /// Are we able to delete?\r
-            // ie are all columns blank?\r
+        // drag to left\r
+        else if(!insertGap)\r
+        {\r
+          /// Are we able to delete?\r
+          // ie are all columns blank?\r
 \r
-            for (int s = 0; s < sg.getSize(false); s++)\r
+          for (g = 0; g < groupSize; g++)\r
+          {\r
+            for (int j = startres; j < lastres; j++)\r
             {\r
-              seq = sg.getSequenceAt(s);\r
-\r
-              for (int j = startres; j < lastres; j++)\r
+              if (groupSeqs[g].getLength() <= j)\r
               {\r
-                if (seq.getSequence().length() <= j)\r
-                {\r
-                  continue;\r
-                }\r
+                continue;\r
+              }\r
 \r
-                if (!jalview.util.Comparison.isGap(\r
-                    seq.getSequence().charAt(j)))\r
-                {\r
-                  // Not a gap, block edit not valid\r
-                  endEditing();\r
-                  return;\r
-                }\r
+              if (!jalview.util.Comparison.isGap(\r
+                  groupSeqs[g].getCharAt(j)))\r
+              {\r
+                // Not a gap, block edit not valid\r
+                endEditing();\r
+                return;\r
               }\r
             }\r
           }\r
+        }\r
 \r
-\r
-          for (int i = 0; i < sg.getSize(false); i++)\r
+          if (insertGap)\r
           {\r
-            seq = sg.getSequenceAt(i);\r
-\r
-            if (insertGap)\r
+            // dragging to the right\r
+            if (fixedColumns && fixedRight != -1)\r
             {\r
-              // dragging to the right\r
               for (int j = lastres; j < startres; j++)\r
               {\r
-                if (fixedColumns && fixedRight != -1)\r
-                {\r
-                  insertChar(j, seq, fixedRight);\r
-                }\r
-                else\r
-                  insertChar(j, seq);\r
+                  insertChar(j, groupSeqs, fixedRight);\r
               }\r
             }\r
             else\r
             {\r
-              // dragging to the left\r
+              editCommand.appendEdit(EditCommand.INSERT_GAP,\r
+                                     groupSeqs,\r
+                                     startres, startres-lastres,\r
+                                     av.getGapCharacter(),\r
+                                     true);\r
+            }\r
+          }\r
+          else\r
+          {\r
+            // dragging to the left\r
+            if (fixedColumns && fixedRight != -1)\r
+            {\r
               for (int j = lastres; j > startres; j--)\r
               {\r
-                if (fixedColumns && fixedRight != -1)\r
-                {\r
-                  deleteChar(startres, seq, fixedRight);\r
-                }\r
-                else\r
-                {\r
-                  deleteChar(startres, seq);\r
-                }\r
+                deleteChar(startres, groupSeqs, fixedRight);\r
               }\r
             }\r
+            else\r
+              editCommand.appendEdit(EditCommand.DELETE_GAP,\r
+                                     groupSeqs,\r
+                                     startres, lastres - startres,\r
+                                     av.getGapCharacter(),\r
+                                     true);\r
+\r
           }\r
-        }\r
-        else /////Editing a single sequence///////////\r
+      }\r
+      else /////Editing a single sequence///////////\r
+      {\r
+        if (insertGap)\r
         {\r
-          if (insertGap)\r
+          // dragging to the right\r
+          if (fixedColumns && fixedRight != -1)\r
           {\r
-            // dragging to the right\r
             for (int j = lastres; j < startres; j++)\r
             {\r
-              if (fixedColumns && fixedRight != -1)\r
-              {\r
-                if (sg.getStartRes() == 0\r
-                    && sg.getEndRes() + 1 == av.alignment.getWidth()\r
-                    && !jalview.util.Comparison.isGap(seq.getCharAt(fixedRight)))\r
-                {\r
-                  //Single sequence edit, whole sequence selected,\r
-                  //extend the selection group\r
-                  sg.setEndRes(av.alignment.getWidth() -1 + startres - lastres);\r
-                  fixedColumns = false;\r
-                  insertChar(j, seq);\r
-                }\r
-                else\r
-                  insertChar(j, seq, fixedRight);\r
-              }\r
-              else\r
-                insertChar(j, seq);\r
+              insertChar(j, new SequenceI[]{seq}, fixedRight);\r
             }\r
           }\r
           else\r
           {\r
-            // dragging to the left\r
+            editCommand.appendEdit(EditCommand.INSERT_GAP,\r
+                                   new SequenceI[]\r
+                                   {seq},\r
+                                   lastres, startres-lastres,\r
+                                   av.getGapCharacter(),\r
+                                   true);\r
+          }\r
+        }\r
+        else\r
+        {\r
+          // dragging to the left\r
+          if (fixedColumns && fixedRight != -1)\r
+          {\r
             for (int j = lastres; j > startres; j--)\r
             {\r
-              if (fixedColumns && fixedRight != -1)\r
-              {\r
-                deleteChar(startres, seq, fixedRight);\r
-              }\r
-              else\r
+              if (!jalview.util.Comparison.isGap(seq.getCharAt(startres)))\r
               {\r
-                deleteChar(startres, seq);\r
+                endEditing();\r
+                break;\r
               }\r
+              deleteChar(startres, new SequenceI[]{seq}, fixedRight);\r
+            }\r
+          }\r
+          else\r
+          {\r
+            //could be a keyboard edit trying to delete none gaps\r
+            int max=0;\r
+            for(int m = startres; m<lastres; m++)\r
+            {\r
+              if(!jalview.util.Comparison.isGap(seq.getCharAt(m)))\r
+                break;\r
+              max++;\r
+            }\r
+\r
+            if (max>0)\r
+            {\r
+              editCommand.appendEdit(EditCommand.DELETE_GAP,\r
+                                     new SequenceI[]\r
+                                     {seq},\r
+                                     startres, max,\r
+                                     av.getGapCharacter(),\r
+                                     true);\r
             }\r
           }\r
         }\r
+      }\r
 \r
-        lastres = startres;\r
-        seqCanvas.repaint();\r
-    }\r
+      lastres = startres;\r
+      seqCanvas.repaint();\r
+  }\r
 \r
 \r
-    /**\r
-     * DOCUMENT ME!\r
-     *\r
-     * @param j DOCUMENT ME!\r
-     * @param seq DOCUMENT ME!\r
-     */\r
-    void insertChar(int j, SequenceI seq)\r
-    {\r
-        seq.insertCharAt(j, av.getGapCharacter());\r
-        seqEditOccurred = true;\r
-    }\r
 \r
-    void insertChar(int j, SequenceI seq, int fixedColumn)\r
+  void insertChar(int j, SequenceI [] seq, int fixedColumn)\r
+  {\r
+    int blankColumn = fixedColumn;\r
+    for(int s=0; s<seq.length; s++)\r
     {\r
       //Find the next gap before the end of the visible region boundary\r
       //If lastCol > j, theres a boundary after the gap insertion\r
-      int blankColumn = fixedColumn;\r
+\r
       for (blankColumn = fixedColumn; blankColumn > j; blankColumn--)\r
       {\r
-        if (jalview.util.Comparison.isGap(seq.getCharAt(blankColumn)))\r
+        if (jalview.util.Comparison.isGap(seq[s].getCharAt(blankColumn)))\r
         {\r
           //Theres a space, so break and insert the gap\r
           break;\r
@@ -945,82 +1065,41 @@ public class SeqPanel
 \r
       if (blankColumn <= j)\r
       {\r
+        blankColumn = fixedColumn;\r
         endEditing();\r
         return;\r
       }\r
-\r
-      if (!jalview.util.Comparison.isGap(seq.getCharAt(blankColumn)))\r
-      {\r
-        //Just Checking\r
-        System.out.println("Tried removing residue (INSERT)"+seq.getCharAt(fixedColumn));\r
-        return;\r
-      }\r
-\r
-      seq.deleteCharAt(blankColumn);\r
-      seq.insertCharAt(j, av.getGapCharacter());\r
-      seqEditOccurred = true;\r
     }\r
 \r
-    void deleteChar(int j, SequenceI seq, int fixedColumn)\r
-    {\r
-      if (!jalview.util.Comparison.isGap(seq.getCharAt(j)))\r
-      {\r
-        ap.alignFrame.statusBar.setText(\r
-            "End editing: Tried removing residue " + seq.getCharAt(j));\r
-        return;\r
-      }\r
-\r
-      seq.deleteCharAt(j);\r
-      seq.insertCharAt(fixedColumn, av.getGapCharacter());\r
-      seqEditOccurred = true;\r
-    }\r
+    editCommand.appendEdit(EditCommand.DELETE_GAP,\r
+                           seq,\r
+                           blankColumn, 1, av.getGapCharacter(), true);\r
 \r
-    /**\r
-     * DOCUMENT ME!\r
-     *\r
-     * @param j DOCUMENT ME!\r
-     * @param seq DOCUMENT ME!\r
-     */\r
-    void deleteChar(int j, SequenceI seq)\r
-    {\r
-      if (!jalview.util.Comparison.isGap(seq.getCharAt(j)))\r
-      {\r
-        ap.alignFrame.statusBar.setText(\r
-            "End editing: Tried removing residue " + seq.getCharAt(j));\r
-        return;\r
-      }\r
+    editCommand.appendEdit(EditCommand.INSERT_GAP,\r
+                           seq,\r
+                           j, 1, av.getGapCharacter(),\r
+                           true);\r
 \r
-        seq.deleteCharAt(j);\r
-        seqEditOccurred = true;\r
-        seqCanvas.repaint();\r
-    }\r
+  }\r
 \r
-    /**\r
-     * DOCUMENT ME!\r
-     *\r
-     * @param i DOCUMENT ME!\r
-     */\r
-    void editOccurred()\r
-    {\r
-      if (!seqEditOccurred)\r
-      {\r
-        ap.alignFrame.historyList.pop();\r
-        ap.alignFrame.updateEditMenuBar();\r
-      }\r
+  void deleteChar(int j, SequenceI [] seq, int fixedColumn)\r
+  {\r
 \r
-      endEditing();\r
+    editCommand.appendEdit(EditCommand.DELETE_GAP,\r
+                           seq,\r
+                           j, 1, av.getGapCharacter(), true);\r
 \r
-      av.firePropertyChange("alignment", null,av.getAlignment().getSequences());\r
+    editCommand.appendEdit(EditCommand.INSERT_GAP,\r
+                           seq,\r
+                           fixedColumn, 1, av.getGapCharacter(), true);\r
+  }\r
 \r
-    }\r
 \r
 //////////////////////////////////////////\r
 /////Everything below this is for defining the boundary of the rubberband\r
 //////////////////////////////////////////\r
   public void doMousePressedDefineMode(MouseEvent evt)\r
   {\r
-\r
-\r
     if (scrollThread != null)\r
     {\r
       scrollThread.running = false;\r
@@ -1058,7 +1137,7 @@ public class SeqPanel
       }\r
     }\r
 \r
-    else if (!stretchGroup.getSequences(false).contains(sequence)\r
+    else if (!stretchGroup.getSequences(null).contains(sequence)\r
              || stretchGroup.getStartRes() > res\r
              || stretchGroup.getEndRes() < res)\r
     {\r
@@ -1081,15 +1160,6 @@ public class SeqPanel
       av.setSelectionGroup(stretchGroup);\r
     }\r
 \r
-    if (av.cursorMode)\r
-    {\r
-      seqCanvas.cursorX = findRes(evt);\r
-      seqCanvas.cursorY = findSeq(evt);\r
-      seqCanvas.repaint();\r
-      return;\r
-    }\r
-\r
-\r
 \r
     // DETECT RIGHT MOUSE BUTTON IN AWT\r
     if ( (evt.getModifiers() & InputEvent.BUTTON3_MASK) ==\r
@@ -1118,9 +1188,17 @@ public class SeqPanel
       this.add(popup);\r
       popup.show(this, evt.getX(), evt.getY());\r
       ap.repaint();\r
+      return;\r
     }\r
-    else\r
+\r
+    if (av.cursorMode)\r
     {\r
+      seqCanvas.cursorX = findRes(evt);\r
+      seqCanvas.cursorY = findSeq(evt);\r
+      seqCanvas.repaint();\r
+      return;\r
+    }\r
+\r
       //Only if left mouse button do we want to change group sizes\r
 \r
       if (stretchGroup == null)\r
@@ -1145,19 +1223,6 @@ public class SeqPanel
         }\r
 \r
       }\r
-\r
-      if (stretchGroup != null && stretchGroup.getEndRes() == res)\r
-      {\r
-        // Edit end res position of selected group\r
-        changeEndRes = true;\r
-      }\r
-\r
-      else if (stretchGroup != null && stretchGroup.getStartRes() == res)\r
-      {\r
-        // Edit end res position of selected group\r
-        changeStartRes = true;\r
-      }\r
-    }\r
   }\r
 \r
   public void doMouseReleasedDefineMode(MouseEvent evt)\r
@@ -1172,10 +1237,17 @@ public class SeqPanel
       if (stretchGroup.cs instanceof ClustalxColourScheme)\r
       {\r
         ( (ClustalxColourScheme) stretchGroup.cs).resetClustalX(\r
-            stretchGroup.getSequences(true),\r
+            stretchGroup.getSequences(av.hiddenRepSequences),\r
             stretchGroup.getWidth());\r
       }\r
 \r
+      if (stretchGroup.cs instanceof Blosum62ColourScheme\r
+          || stretchGroup.cs instanceof PIDColourScheme\r
+          || stretchGroup.cs.conservationApplied()\r
+          || stretchGroup.cs.getThreshold() > 0)\r
+        stretchGroup.recalcConservation();\r
+\r
+\r
       if (stretchGroup.cs.conservationApplied())\r
       {\r
         SliderPanel.setConservationSlider(ap, stretchGroup.cs,\r
@@ -1191,7 +1263,7 @@ public class SeqPanel
     changeEndRes = false;\r
     changeStartRes = false;\r
     stretchGroup = null;\r
-    PaintRefresher.Refresh(av.alignment);\r
+    PaintRefresher.Refresh(ap, av.getSequenceSetId());\r
     ap.repaint();\r
   }\r
 \r
@@ -1216,7 +1288,7 @@ public class SeqPanel
         y = av.alignment.getHeight() -1;\r
       }\r
 \r
-      if(res>av.alignment.getWidth())\r
+      if(res>=av.alignment.getWidth())\r
         res = av.alignment.getWidth()-1;\r
 \r
       if (stretchGroup.getEndRes() == res)\r
@@ -1275,7 +1347,7 @@ public class SeqPanel
 \r
           Sequence nextSeq = (Sequence) av.getAlignment().getSequenceAt(oldSeq);\r
 \r
-          if (stretchGroup.getSequences(false).contains(nextSeq))\r
+          if (stretchGroup.getSequences(null).contains(nextSeq))\r
           {\r
               stretchGroup.deleteSequence(seq, false);\r
           }\r
@@ -1333,6 +1405,28 @@ public class SeqPanel
     }\r
   }\r
 \r
+  void scrollCanvas(MouseEvent evt)\r
+  {\r
+    if(evt==null)\r
+    {\r
+      if(scrollThread!=null)\r
+      {\r
+        scrollThread.running = false;\r
+        scrollThread = null;\r
+      }\r
+      mouseDragging = false;\r
+    }\r
+    else\r
+    {\r
+      if (scrollThread == null)\r
+        scrollThread = new ScrollThread();\r
+\r
+      mouseDragging = true;\r
+      scrollThread.setEvent(evt);\r
+    }\r
+\r
+    }\r
+\r
   // this class allows scrolling off the bottom of the visible alignment\r
   class ScrollThread\r
       extends Thread\r
@@ -1376,12 +1470,12 @@ public class SeqPanel
 \r
           if (mouseDragging && evt.getX() < 0)\r
           {\r
-            running = ap.scrollRight(true);\r
+            running = ap.scrollRight(false);\r
           }\r
 \r
           else if (mouseDragging && evt.getX() >= getSize().width)\r
           {\r
-            running = ap.scrollRight(false);\r
+            running = ap.scrollRight(true);\r
           }\r
         }\r
 \r