more efficient highlighting and selection display JAL-469

[jalview.git] / src / jalview / appletgui / SeqPanel.java

diff --git a/src/jalview/appletgui/SeqPanel.java b/src/jalview/appletgui/SeqPanel.java
index e6ed8f2..dfc236e 100755 (executable)
--- a/src/jalview/appletgui/SeqPanel.java
+++ b/src/jalview/appletgui/SeqPanel.java
@@ -639,11 +639,15 @@ public class SeqPanel extends Panel implements MouseMotionListener,
 
   public void highlightSequence(SearchResults results)
   {
-    seqCanvas.highlightSearchResults(results);
     if (av.followHighlight)
     {
-      ap.scrollToPosition(results);
+      if (ap.scrollToPosition(results, false))
+      {
+        // ap.invalidate();
+      }
     }
+    seqCanvas.highlightSearchResults(results);
+
   }
 
   public void updateColours(SequenceI seq, int index)
@@ -1683,6 +1687,7 @@ public class SeqPanel extends Panel implements MouseMotionListener,
       }
     }
   }
+
   /**
    * modify current selection according to a received message.
    */
@@ -1693,9 +1698,8 @@ public class SeqPanel extends Panel implements MouseMotionListener,
     // handles selection messages...
     // TODO: extend config options to allow user to control if selections may be
     // shared between viewports.
-    if (av!=null && (av == source
-            || !av.followSelection
-            || (source instanceof AlignViewport && ((AlignViewport) source)
+    if (av != null
+            && (av == source || !av.followSelection || (source instanceof AlignViewport && ((AlignViewport) source)
                     .getSequenceSetId().equals(av.getSequenceSetId()))))
     {
       return;
@@ -1708,13 +1712,15 @@ public class SeqPanel extends Panel implements MouseMotionListener,
     if (av.selectionGroup == null || !av.isSelectionGroupChanged())
     {
       SequenceGroup sgroup = null;
-      if (seqsel != null)
+      if (seqsel != null && seqsel.getSize()>0)
       {
         if (av.alignment == null)
         {
-          System.out.println("Selection message: alignviewport av SeqSetId="
-                  + av.getSequenceSetId() + " ViewId=" + av.getViewId()
-                  + " 's alignment is NULL! returning immediatly.");
+          System.out
+                  .println("Selection message: alignviewport av SeqSetId="
+                          + av.getSequenceSetId() + " ViewId="
+                          + av.getViewId()
+                          + " 's alignment is NULL! returning immediatly.");
           return;
         }
         sgroup = seqsel.intersect(av.alignment,
@@ -1768,9 +1774,8 @@ public class SeqPanel extends Panel implements MouseMotionListener,
     }
     if (repaint)
     {
-      // probably finessing with multiple redraws here
-      PaintRefresher.Refresh(this, av.getSequenceSetId());
-      // ap.paintAlignment(false);
+      ap.repaint();
+      //ap.paintAlignment(false);
     }
   }