: new String(entry.getVersion())),
(entry.getAccessionId() == null ? ""
: new String(entry.getAccessionId())),
- (entry.getMap() == null ? null : new Mapping(entry.getMap())));
+ (entry.getMap() == null ? null : new Mapping(entry.getMap())),entry.isCanonical());
}
@Override
return true;
}
+ boolean improved=false;
/*
* source must either match or be both null
*/
return false;
}
+ if (!isCanonicalAccession && other.isCanonical())
+ {
+ isCanonicalAccession = true;
+ improved = true;
+ }
+ else
+ {
+ if (isCanonicalAccession && !other.isCanonical())
+ {
+ // other is not an authoritative source of canonical accessions
+ return false;
+ }
+ }
/*
* if my version is null, "0" or "source:0" then replace with other version,
* otherwise the versions have to match
if (version != null && (otherVersion == null
|| !version.equalsIgnoreCase(otherVersion)))
{
- return false;
+ // FIXME: there may be a problem with old version strings not allowing
+ // updating of dbrefentries
+ return improved;
}
}
/*
- * if I have no mapping, take that of the other dbref
+ * if I have no mapping, take that of the other dbref
+ * - providing it had a version and so do I
*/
if (map == null)
{