import java.util.ArrayList;
import java.util.Arrays;
+import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
*/
public class SequenceFeatures implements SequenceFeaturesI
{
-
/*
* map from feature type to structured store of features for that type
* null types are permitted (but not a good idea!)
*/
- private Map<String, FeatureStoreI> featureStore;
-
- /**
- * original NCList-based IntervalStore
- */
- private final static int INTERVAL_STORE_NCLIST = 0;
-
- /**
- * linked-list deferred-sort IntervalStore - experimental only; unused
- */
- private final static int INTERVAL_STORE_LINKED_LIST_NO_PRESORT = 1;
-
- /**
- * linked-list IntervalStore option for JavaScript
- */
- private final static int INTERVAL_STORE_LINKED_LIST = -1;
-
- /**
- * mode for Java or JavaScript; can be set differently for testing, but
- * default is LINKED_LIST for JalviewJS and NCLIST for Java
- */
- private final int INTERVAL_STORE_MODE = (
- // true || //
- Platform.isJS() ? //
- INTERVAL_STORE_LINKED_LIST //
- : INTERVAL_STORE_NCLIST//
- );
+ private Map<String, FeatureStore> featureStore;
/**
* Constructor
* ? wrap as a synchronized map for add and delete operations
*/
// featureStore = Collections
- // .synchronizedSortedMap(new TreeMap<String, FeatureStoreI>());
+ // .synchronizedSortedMap(new TreeMap<String, FeatureStore>());
featureStore = new TreeMap<>();
}
if (featureStore.get(type) == null)
{
- featureStore.put(type, newFeatureStore());
+ featureStore.put(type, new FeatureStore());
}
return featureStore.get(type).addFeature(sf);
}
- private FeatureStoreI newFeatureStore()
- {
- switch (INTERVAL_STORE_MODE)
- {
- default:
- case INTERVAL_STORE_NCLIST:
- return new FeatureStoreImpl(true);
- case INTERVAL_STORE_LINKED_LIST_NO_PRESORT:
- return new FeatureStoreImpl(false);
- case INTERVAL_STORE_LINKED_LIST:
- return new FeatureStoreJS();
- }
- }
-
/**
* {@inheritDoc}
*/
String... type)
{
List<SequenceFeature> result = new ArrayList<>();
- for (FeatureStoreI featureSet : varargToTypes(type))
+ for (FeatureStore featureSet : varargToTypes(type))
{
- // System.err.println("SF findFeature " + System.currentTimeMillis()
- // + " " + from + " " + to + " "
- // + featureSet.getPositionalFeatures().get(0).type);
- //
- result.addAll(featureSet.findOverlappingFeatures(from, to, null));
+ featureSet.findFeatures(from, to, result);
}
return result;
}
{
int result = 0;
- for (FeatureStoreI featureSet : varargToTypes(type))
+ for (FeatureStore featureSet : varargToTypes(type))
{
result += featureSet.getFeatureCount(positional);
}
{
int result = 0;
- for (FeatureStoreI featureSet : varargToTypes(type))
+ for (FeatureStore featureSet : varargToTypes(type))
{
result += featureSet.getTotalFeatureLength();
}
{
List<SequenceFeature> result = new ArrayList<>();
- for (FeatureStoreI featureSet : varargToTypes(type))
+ for (FeatureStore featureSet : varargToTypes(type))
{
featureSet.getPositionalFeatures(result);
}
* @param type
* @return
*/
- protected Iterable<FeatureStoreI> varargToTypes(String... type)
+ protected Iterable<FeatureStore> varargToTypes(String... type)
{
if (type == null || type.length == 0)
{
return featureStore.values();
}
- List<FeatureStoreI> types = new ArrayList<>();
+ List<FeatureStore> types = new ArrayList<>();
List<String> args = Arrays.asList(type);
- for (Entry<String, FeatureStoreI> featureType : featureStore.entrySet())
+ for (Entry<String, FeatureStore> featureType : featureStore.entrySet())
{
if (args.contains(featureType.getKey()))
{
{
List<SequenceFeature> result = new ArrayList<>();
- for (FeatureStoreI featureSet : varargToTypes(type))
+ for (FeatureStore featureSet : varargToTypes(type))
{
featureSet.getContactFeatures(result);
}
{
List<SequenceFeature> result = new ArrayList<>();
- for (FeatureStoreI featureSet : varargToTypes(type))
+ for (FeatureStore featureSet : varargToTypes(type))
{
featureSet.getNonPositionalFeatures(result);
}
@Override
public boolean delete(SequenceFeature sf)
{
- for (FeatureStoreI featureSet : featureStore.values())
+ for (FeatureStore featureSet : featureStore.values())
{
if (featureSet.delete(sf))
{
@Override
public boolean hasFeatures()
{
- for (FeatureStoreI featureSet : featureStore.values())
+ for (FeatureStore featureSet : featureStore.values())
{
if (!featureSet.isEmpty())
{
public Set<String> getFeatureGroups(boolean positionalFeatures,
String... type)
{
- Set<String> groups = new HashSet<>();
+ // BH 2020.03.21 This is the set that orders the list of groups
+ // at the top of the FeatureSettings panel.
+ Set<String> groups = Platform.getJavaOrderedHashSet();
- for (FeatureStoreI featureSet : varargToTypes(type))
+ for (FeatureStore featureSet : varargToTypes(type))
{
groups.addAll(featureSet.getFeatureGroups(positionalFeatures));
}
public Set<String> getFeatureTypesForGroups(boolean positionalFeatures,
String... groups)
{
- Set<String> result = new HashSet<>();
+ // BH 2020.03.21 This set is the one that sets the initial ordering for
+ // feature rendering. We set it to new HashSet<>(16,0.75) to force it to
+ // be backed by a Java hash-ordered HashMap instead of a JavaScript Map.
+ Set<String> result = Platform.getJavaOrderedHashSet();
- for (Entry<String, FeatureStoreI> featureType : featureStore.entrySet())
+ for (Entry<String, FeatureStore> featureType : featureStore.entrySet())
{
Set<String> featureGroups = featureType.getValue()
.getFeatureGroups(positionalFeatures);
@Override
public Set<String> getFeatureTypes(String... soTerm)
{
- Set<String> types = new HashSet<>();
- for (Entry<String, FeatureStoreI> entry : featureStore.entrySet())
+ Set<String> types = new HashSet<>(15, 0.75f);
+ for (Entry<String, FeatureStore> entry : featureStore.entrySet())
{
String type = entry.getKey();
if (!entry.getValue().isEmpty() && isOntologyTerm(type, soTerm))
public static void sortFeatures(List<? extends IntervalI> features,
final boolean forwardStrand)
{
- IntervalI.sortIntervals(features, forwardStrand);
+ Collections.sort(features,
+ forwardStrand ? IntervalI.COMPARE_BEGIN_ASC
+ : IntervalI.COMPARE_END_DESC);
}
/**
String group, String... type)
{
List<SequenceFeature> result = new ArrayList<>();
- for (FeatureStoreI featureSet : varargToTypes(type))
+ for (FeatureStore featureSet : varargToTypes(type))
{
if (featureSet.getFeatureGroups(positional).contains(group))
{
public boolean shiftFeatures(int fromPosition, int shiftBy)
{
boolean modified = false;
- for (FeatureStoreI fs : featureStore.values())
+ for (FeatureStore fs : featureStore.values())
{
modified |= fs.shiftFeatures(fromPosition, shiftBy);
}
featureStore.clear();
}
- /**
- * Simplified find for features associated with a given position.
- *
- * JavaScript set to not use IntervalI, but easily testable by setting false
- * to true in javadoc
- *
- * FeatureRenderer has checked already that featureStore does contain type.
- *
- * @author Bob Hanson 2019.07.30
- */
@Override
public List<SequenceFeature> findFeatures(int pos, String type,
List<SequenceFeature> list)
{
- FeatureStoreI fs = featureStore.get(type);
- return fs.findOverlappingFeatures(pos, pos, list);
+ FeatureStore fs = featureStore.get(type);
+ if (fs == null)
+ {
+ return list == null ? new ArrayList<>() : list;
+ }
+ return fs.findFeatures(pos, pos, list);
}
- // Chrome; developer console closed
-
- // BH 2019.08.01 useIntervalStore true, redraw false:
- // Platform: timer mark 13.848 0.367 overviewrender 16000 pixels row:14
- // Platform: timer mark 15.391 0.39 overviewrender 16000 pixels row:14
- // Platform: timer mark 16.498 0.39 overviewrender 16000 pixels row:14
- // Platform: timer mark 17.596 0.401 overviewrender 16000 pixels row:14
- // Platform: timer mark 18.738 0.363 overviewrender 16000 pixels row:14
- // Platform: timer mark 19.659 0.358 overviewrender 16000 pixels row:14
- // Platform: timer mark 20.737 0.359 overviewrender 16000 pixels row:14
- // Platform: timer mark 21.797 0.391 overviewrender 16000 pixels row:14
- // Platform: timer mark 22.851 0.361 overviewrender 16000 pixels row:14
- // Platform: timer mark 24.019 0.395 overviewrender 16000 pixels row:14
-
- // BH 2019.08.01 useIntervalStore false, redraw false:
- // Platform: timer mark 19.011 0.181 overviewrender 16000 pixels row:14
- // Platform: timer mark 20.311 0.183 overviewrender 16000 pixels row:14
- // Platform: timer mark 21.368 0.175 overviewrender 16000 pixels row:14
- // Platform: timer mark 22.347 0.178 overviewrender 16000 pixels row:14
- // Platform: timer mark 23.605 0.216 overviewrender 16000 pixels row:14
- // Platform: timer mark 24.836 0.191 overviewrender 16000 pixels row:14
- // Platform: timer mark 26.016 0.181 overviewrender 16000 pixels row:14
- // Platform: timer mark 27.278 0.178 overviewrender 16000 pixels row:14
- // Platform: timer mark 28.158 0.181 overviewrender 16000 pixels row:14
- // Platform: timer mark 29.227 0.196 overviewrender 16000 pixels row:14
- // Platform: timer mark 30.1 0.171 overviewrender 16000 pixels row:14
- // Platform: timer mark 31.684 0.196 overviewrender 16000 pixels row:14
- // Platform: timer mark 32.779 0.18 overviewrender 16000 pixels row:14
- // Platform: timer mark 52.355 0.185 overviewrender 16000 pixels row:14
- // Platform: timer mark 53.829 0.186 overviewrender 16000 pixels row:14
-
- /**
- * @author Bob Hanson 2019.08.01
- */
@Override
public boolean hasFeatures(String type)
{
- return featureStore.containsKey(type);
+ return featureStore.containsKey(type)
+ && !featureStore.get(type).isEmpty();
}
}