JAL-3529 test updated for revised signature of getDBRefs()

[jalview.git] / src / jalview / ext / ensembl / EnsemblFeatures.java

diff --git a/src/jalview/ext/ensembl/EnsemblFeatures.java b/src/jalview/ext/ensembl/EnsemblFeatures.java
index 6a0d67c..e28cc7f 100644 (file)
--- a/src/jalview/ext/ensembl/EnsemblFeatures.java
+++ b/src/jalview/ext/ensembl/EnsemblFeatures.java
@@ -27,6 +27,7 @@ import jalview.datamodel.SequenceFeature;
 import jalview.datamodel.SequenceI;
 import jalview.io.gff.SequenceOntologyI;
 import jalview.util.JSONUtils;
+import jalview.util.Platform;
 
 import java.io.BufferedReader;
 import java.io.IOException;
@@ -90,12 +91,14 @@ class EnsemblFeatures extends EnsemblRestClient
   public AlignmentI getSequenceRecords(String query) throws IOException
   {
     // TODO: use a vararg String... for getSequenceRecords instead?
+         
     List<String> queries = new ArrayList<>();
     queries.add(query);
     SequenceI seq = parseFeaturesJson(queries);
     if (seq == null)
        return null;
     return new Alignment(new SequenceI[] { seq });
+
   }
 
   /**
@@ -106,20 +109,18 @@ class EnsemblFeatures extends EnsemblRestClient
    * @return
    */
   @SuppressWarnings("unchecked")
-private SequenceI parseFeaturesJson(List<String> queries)
+  private SequenceI parseFeaturesJson(List<String> queries)
   {
-         
-         
     SequenceI seq = new Sequence("Dummy", "");
-
     try
     {
-       
       Iterator<Object> rvals = (Iterator<Object>) getJSON(null, queries, -1, MODE_ITERATOR, null);
       if (rvals == null)
+      {
          return null;
+      }
       while (rvals.hasNext())
-      {
+      {          
         try
         {
           Map<String, Object> obj = (Map<String, Object>) rvals.next();
@@ -128,6 +129,7 @@ private SequenceI parseFeaturesJson(List<String> queries)
           int end = Integer.parseInt(obj.get("end").toString());
           String source = obj.get("source").toString();
           String strand = obj.get("strand").toString();
+          Object phase = obj.get("phase");
           String alleles = JSONUtils
                   .arrayToStringList((List<Object>) obj.get("alleles"));
           String clinSig = JSONUtils
@@ -147,12 +149,16 @@ private SequenceI parseFeaturesJson(List<String> queries)
           {
             type = SequenceOntologyI.CDS;
           }
-          
+
           String desc = getFirstNotNull(obj, "alleles", "external_name",
                   JSON_ID);
           SequenceFeature sf = new SequenceFeature(type, desc, start, end,
                   source);
           sf.setStrand("1".equals(strand) ? "+" : "-");
+          if (phase != null)
+          {
+            sf.setPhase(phase.toString());
+          }
           setFeatureAttribute(sf, obj, "id");
           setFeatureAttribute(sf, obj, "Parent");
           setFeatureAttribute(sf, obj, "consequence_type");
@@ -160,6 +166,7 @@ private SequenceI parseFeaturesJson(List<String> queries)
           sf.setValue("clinical_significance", clinSig);
 
           seq.addSequenceFeature(sf);
+          
         } catch (Throwable t)
         {
           // ignore - keep trying other features
@@ -174,31 +181,33 @@ private SequenceI parseFeaturesJson(List<String> queries)
     return seq;
   }
 
-  
-/**
-   * Returns the first non-null attribute found (if any) as a string
+  /**
+   * Returns the first non-null attribute found (if any) as a string, formatted
+   * suitably for display as feature description or tooltip. Answers null if
+   * none of the attribute keys is present.
    * 
    * @param obj
    * @param keys
    * @return
    */
+  @SuppressWarnings("unchecked")
   protected String getFirstNotNull(Map<String, Object> obj, String... keys)
   {
-    String desc = null;
-
     for (String key : keys)
     {
       Object val = obj.get(key);
       if (val != null)
       {
-        String s = val.toString();
+        String s = val instanceof List<?>
+                ? JSONUtils.arrayToStringList((List<Object>) val)
+                : val.toString();
         if (!s.isEmpty())
         {
           return s;
         }
       }
     }
-    return desc;
+    return null;
   }
 
   /**