remove system.out
[jalview.git] / src / jalview / gui / AlignFrame.java
index 2a323ef..b730c0f 100755 (executable)
@@ -13,7 +13,7 @@
  * GNU General Public License for more details.\r
  *\r
  * You should have received a copy of the GNU General Public License\r
- * along with this program; if not, write to the Free Software\r
+ * along with this program; if not, write to the Free Softwarechang\r
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA\r
  */\r
 package jalview.gui;\r
@@ -68,6 +68,17 @@ public class AlignFrame
   {\r
     viewport = new AlignViewport(al);\r
 \r
+    if(viewport.vconsensus==null)\r
+    {\r
+      //Out of memory caluclating consensus.\r
+      BLOSUM62Colour.setEnabled(false);\r
+      PIDColour.setEnabled(false);\r
+      conservationMenuItem.setEnabled(false);\r
+      modifyConservation.setEnabled(false);\r
+      abovePIDThreshold.setEnabled(false);\r
+      modifyPID.setEnabled(false);\r
+    }\r
+\r
     alignPanel = new AlignmentPanel(this, viewport);\r
     alignPanel.annotationPanel.adjustPanelHeight();\r
     alignPanel.annotationSpaceFillerHolder.setPreferredSize(alignPanel.\r
@@ -76,32 +87,36 @@ public class AlignFrame
         getPreferredSize());\r
     alignPanel.setAnnotationVisible(viewport.getShowAnnotation());\r
 \r
+    String sortby = jalview.bin.Cache.getDefault("SORT_ALIGNMENT", "No sort");\r
+\r
+    if(sortby.equals("Id"))\r
+      sortIDMenuItem_actionPerformed(null);\r
+    else if(sortby.equals("Pairwise Identity"))\r
+      sortPairwiseMenuItem_actionPerformed(null);\r
+\r
     getContentPane().add(alignPanel, java.awt.BorderLayout.CENTER);\r
 \r
-    addInternalFrameListener(new InternalFrameAdapter()\r
+    viewport.addPropertyChangeListener(new PropertyChangeListener()\r
     {\r
-      public void internalFrameActivated(InternalFrameEvent evt)\r
-      {\r
-        javax.swing.SwingUtilities.invokeLater(new Runnable()\r
-        {\r
-          public void run()\r
-          {\r
-            alignPanel.requestFocus();\r
-          }\r
-        });\r
-      }\r
-    });\r
+     public void propertyChange(PropertyChangeEvent evt)\r
+     {\r
+       if (evt.getPropertyName().equals("alignment"))\r
+       {\r
+         alignmentChanged();\r
+       }\r
+     }\r
+   });\r
+\r
+\r
     addServiceListeners();\r
   }\r
 \r
   /* Set up intrinsic listeners for dynamically generated GUI bits. */\r
   private void addServiceListeners()\r
   {\r
-\r
-    final AlignFrame thisFrame = this;\r
     final java.beans.PropertyChangeListener thisListener;\r
     // Do this once to get current state\r
-    thisFrame.BuildWebServiceMenu();\r
+    BuildWebServiceMenu();\r
     Desktop.discoverer.addPropertyChangeListener(\r
         thisListener = new java.beans.PropertyChangeListener()\r
     {\r
@@ -111,7 +126,7 @@ public class AlignFrame
         if (evt.getPropertyName().equals("services"))\r
         {\r
           // System.out.println("Rebuilding web service menu");\r
-          thisFrame.BuildWebServiceMenu();\r
+          BuildWebServiceMenu();\r
         }\r
       }\r
     });\r
@@ -123,6 +138,7 @@ public class AlignFrame
       {\r
         // System.out.println("deregistering discoverer listener");\r
         Desktop.discoverer.removePropertyChangeListener(thisListener);\r
+        closeMenuItem_actionPerformed(null);\r
       }\r
       ;\r
     });\r
@@ -264,7 +280,8 @@ public class AlignFrame
       {\r
         java.io.PrintWriter out = new java.io.PrintWriter(\r
             new java.io.FileWriter(file));\r
-        out.println(output);\r
+\r
+        out.print(output);\r
         out.close();\r
         return true;\r
       }\r
@@ -348,6 +365,7 @@ public class AlignFrame
   {\r
     try\r
     {\r
+      PaintRefresher.components.remove(viewport.alignment);\r
       this.setClosed(true);\r
     }\r
     catch (Exception ex)\r
@@ -409,6 +427,7 @@ public class AlignFrame
     redoList.push(new HistoryItem(hi.getDescription(), viewport.alignment,\r
                                   HistoryItem.HIDE));\r
     restoreHistoryItem(hi);\r
+    viewport.firePropertyChange("alignment", null, viewport.getAlignment().getSequences());\r
   }\r
 \r
   /**\r
@@ -421,9 +440,7 @@ public class AlignFrame
     HistoryItem hi = (HistoryItem) redoList.pop();\r
     restoreHistoryItem(hi);\r
     updateEditMenuBar();\r
-    viewport.updateConsensus();\r
-    alignPanel.repaint();\r
-    alignPanel.repaint();\r
+    viewport.firePropertyChange("alignment", null, viewport.getAlignment().getSequences());\r
   }\r
 \r
   // used by undo and redo\r
@@ -468,9 +485,6 @@ public class AlignFrame
 \r
     updateEditMenuBar();\r
 \r
-    viewport.updateConsensus();\r
-    viewport.updateConservation();\r
-    alignPanel.repaint();\r
     viewport.firePropertyChange("alignment", null,\r
                                 viewport.getAlignment().getSequences());\r
   }\r
@@ -546,15 +560,16 @@ public class AlignFrame
   {\r
     if (viewport.getSelectionGroup() == null)\r
     {\r
+      System.out.println("null here");\r
       return;\r
     }\r
 \r
     SequenceGroup sg = viewport.getSelectionGroup();\r
 \r
     Clipboard c = Toolkit.getDefaultToolkit().getSystemClipboard();\r
-    StringBuffer buffer = new StringBuffer();\r
 \r
     Hashtable orderedSeqs = new Hashtable();\r
+    SequenceI [] seqs = new SequenceI[sg.getSize()];\r
 \r
     for (int i = 0; i < sg.getSize(); i++)\r
     {\r
@@ -584,6 +599,8 @@ public class AlignFrame
           index++;\r
         }\r
       }\r
+\r
+\r
       //FIND START RES\r
       //Returns residue following index if gap\r
       startRes = seq.findPosition(sg.getStartRes());\r
@@ -606,14 +623,13 @@ public class AlignFrame
         endRes += seq.getStart() - 1;\r
       }\r
 \r
-      buffer.append(seq.getName() + "\t" +\r
-                    startRes + "\t" +\r
-                    endRes + "\t" +\r
-                    seq.getSequence(sg.getStartRes(),\r
-                                    sg.getEndRes() + 1) + "\n");\r
+      seqs[i] = new Sequence(seq.getName(),\r
+                             seq.getSequence(sg.getStartRes(), sg.getEndRes()+1),\r
+                             startRes,\r
+                             endRes);\r
     }\r
 \r
-    c.setContents(new StringSelection(buffer.toString()), null);\r
+    c.setContents(new StringSelection(FastaFile.print(seqs)), null);\r
   }\r
 \r
   /**\r
@@ -656,33 +672,14 @@ public class AlignFrame
       }\r
 \r
       String str = (String) contents.getTransferData(DataFlavor.stringFlavor);\r
-      StringTokenizer st = new StringTokenizer(str);\r
-      ArrayList seqs = new ArrayList();\r
 \r
-      while (st.hasMoreElements())\r
-      {\r
-        String name = st.nextToken();\r
-        int start = Integer.parseInt(st.nextToken());\r
-        int end = Integer.parseInt(st.nextToken());\r
-        Sequence sequence = new Sequence(name, st.nextToken(), start,\r
-                                         end);\r
+      String format = IdentifyFile.Identify(str, "Paste");\r
+      SequenceI[] sequences = FormatAdapter.readFile(str, "Paste", format);\r
 \r
-        if (!newAlignment)\r
-        {\r
-          viewport.alignment.addSequence(sequence);\r
-        }\r
-        else\r
-        {\r
-          seqs.add(sequence);\r
-        }\r
-      }\r
 \r
       if (newAlignment)\r
       {\r
-        SequenceI[] newSeqs = new SequenceI[seqs.size()];\r
-        seqs.toArray(newSeqs);\r
-\r
-        AlignFrame af = new AlignFrame(new Alignment(newSeqs));\r
+        AlignFrame af = new AlignFrame(new Alignment(sequences));\r
         String newtitle = new String("Copied sequences");\r
 \r
         if (title.startsWith("Copied sequences"))\r
@@ -699,20 +696,21 @@ public class AlignFrame
       }\r
       else\r
       {\r
-        viewport.firePropertyChange("alignment", null,\r
-                                    viewport.getAlignment().getSequences());\r
+        //!newAlignment\r
+        for (int i = 0; i < sequences.length; i++)\r
+          viewport.alignment.addSequence(sequences[i]);\r
+\r
         viewport.setEndSeq(viewport.alignment.getHeight());\r
         viewport.alignment.getWidth();\r
-        viewport.updateConservation();\r
-        viewport.updateConsensus();\r
-        alignPanel.repaint();\r
+        viewport.firePropertyChange("alignment", null, viewport.getAlignment().getSequences());\r
       }\r
     }\r
     catch (Exception ex)\r
     {\r
+        // could be anything being pasted in here\r
     }\r
 \r
-    // could be anything being pasted in here\r
+\r
   }\r
 \r
   /**\r
@@ -733,7 +731,6 @@ public class AlignFrame
    */\r
   protected void delete_actionPerformed(ActionEvent e)\r
   {\r
-    boolean seqsdeleted = false;\r
 \r
     if (viewport.getSelectionGroup() == null)\r
     {\r
@@ -765,7 +762,6 @@ public class AlignFrame
 \r
       if (seq.getSequence().length() < 1)\r
       {\r
-        seqsdeleted = true;\r
         viewport.getAlignment().deleteSequence(seq);\r
       }\r
       else\r
@@ -777,13 +773,10 @@ public class AlignFrame
     viewport.setSelectionGroup(null);\r
     viewport.alignment.deleteGroup(sg);\r
 \r
-    if (seqsdeleted)\r
-    {\r
-      viewport.firePropertyChange("alignment", null,\r
+    viewport.firePropertyChange("alignment", null,\r
                                   viewport.getAlignment().getSequences());\r
-    }\r
 \r
-    viewport.resetSeqLimits(alignPanel.seqPanel.seqCanvas.getHeight());\r
+\r
 \r
     if (viewport.getAlignment().getHeight() < 1)\r
     {\r
@@ -795,10 +788,6 @@ public class AlignFrame
       {\r
       }\r
     }\r
-\r
-    viewport.updateConservation();\r
-    viewport.updateConsensus();\r
-    alignPanel.repaint();\r
   }\r
 \r
   /**\r
@@ -907,7 +896,7 @@ public class AlignFrame
         }\r
       }\r
 \r
-      alignPanel.repaint();\r
+      viewport.firePropertyChange("alignment", null, viewport.getAlignment().getSequences());\r
     }\r
   }\r
 \r
@@ -945,7 +934,7 @@ public class AlignFrame
         }\r
       }\r
 \r
-      alignPanel.repaint();\r
+      viewport.firePropertyChange("alignment", null, viewport.getAlignment().getSequences());\r
     }\r
   }\r
 \r
@@ -959,10 +948,16 @@ public class AlignFrame
     addHistoryItem(new HistoryItem("Remove Gapped Columns",\r
                                    viewport.alignment, HistoryItem.HIDE));\r
 \r
+    //This is to maintain viewport position on first residue\r
+    //of first sequence\r
+    SequenceI seq = viewport.alignment.getSequenceAt(0);\r
+    int startRes = seq.findPosition(viewport.startRes);\r
+\r
     viewport.getAlignment().removeGaps();\r
-    viewport.updateConservation();\r
-    viewport.updateConsensus();\r
-    alignPanel.repaint();\r
+\r
+    viewport.setStartRes(seq.findIndex(startRes)-1);\r
+\r
+   viewport.firePropertyChange("alignment", null, viewport.getAlignment().getSequences());\r
   }\r
 \r
   /**\r
@@ -975,6 +970,12 @@ public class AlignFrame
     addHistoryItem(new HistoryItem("Remove Gaps", viewport.alignment,\r
                                    HistoryItem.HIDE));\r
 \r
+    //This is to maintain viewport position on first residue\r
+    //of first sequence\r
+    SequenceI seq = viewport.alignment.getSequenceAt(0);\r
+    int startRes = seq.findPosition(viewport.startRes);\r
+\r
+\r
     SequenceI current;\r
     int jSize;\r
 \r
@@ -989,7 +990,7 @@ public class AlignFrame
     {\r
       seqs = viewport.getSelectionGroup().sequences;\r
       start = viewport.getSelectionGroup().getStartRes();\r
-      end = viewport.getSelectionGroup().getEndRes();\r
+      end = viewport.getSelectionGroup().getEndRes()+1;\r
     }\r
     else\r
     {\r
@@ -1001,24 +1002,103 @@ public class AlignFrame
       current = (SequenceI) seqs.elementAt(i);\r
       jSize = current.getLength();\r
 \r
+      // Removing a range is much quicker than removing gaps\r
+      // one by one for long sequences\r
       int j = start;\r
+      int rangeStart=-1, rangeEnd=-1;\r
 \r
       do\r
       {\r
         if (jalview.util.Comparison.isGap(current.getCharAt(j)))\r
         {\r
-          current.deleteCharAt(j);\r
-          j--;\r
-          jSize--;\r
+          if(rangeStart==-1)\r
+           {\r
+             rangeStart = j;\r
+             rangeEnd = j+1;\r
+           }\r
+           else\r
+           {\r
+             rangeEnd++;\r
+           }\r
+           j++;\r
+        }\r
+        else\r
+        {\r
+          if(rangeStart>-1)\r
+          {\r
+            current.deleteChars(rangeStart, rangeEnd);\r
+            j-=rangeEnd-rangeStart;\r
+            jSize-=rangeEnd-rangeStart;\r
+            rangeStart = -1;\r
+            rangeEnd = -1;\r
+          }\r
+          else\r
+            j++;\r
         }\r
-        j++;\r
       }\r
       while (j < end && j < jSize);\r
+      if(rangeStart>-1)\r
+      {\r
+       current.deleteChars(rangeStart, rangeEnd);\r
+      }\r
     }\r
 \r
-    viewport.updateConservation();\r
-    viewport.updateConsensus();\r
-    alignPanel.repaint();\r
+    viewport.setStartRes(seq.findIndex(startRes)-1);\r
+\r
+    viewport.firePropertyChange("alignment", null, viewport.getAlignment().getSequences());\r
+  }\r
+\r
+ public void alignmentChanged()\r
+ {\r
+   if(viewport.vconsensus!=null)\r
+   {\r
+     viewport.updateConsensus();\r
+     viewport.updateConservation();\r
+   }\r
+   resetAllColourSchemes();\r
+   if(alignPanel.overviewPanel!=null)\r
+     alignPanel.overviewPanel.updateOverviewImage();\r
+\r
+   alignPanel.repaint();\r
+ }\r
+\r
+  void resetAllColourSchemes()\r
+  {\r
+    ColourSchemeI cs = viewport.globalColourScheme;\r
+    if(cs!=null)\r
+    {\r
+      if (cs instanceof ClustalxColourScheme)\r
+      {\r
+        ( (ClustalxColourScheme) viewport.getGlobalColourScheme()).\r
+            resetClustalX(viewport.alignment.getSequences(),\r
+                          viewport.alignment.getWidth());\r
+      }\r
+\r
+      cs.setConsensus(viewport.vconsensus);\r
+      if (cs.conservationApplied())\r
+      {\r
+        Alignment al = (Alignment) viewport.alignment;\r
+        Conservation c = new Conservation("All",\r
+                                          ResidueProperties.propHash, 3,\r
+                                          al.getSequences(), 0,\r
+                                          al.getWidth() - 1);\r
+        c.calculate();\r
+        c.verdict(false, viewport.ConsPercGaps);\r
+\r
+        cs.setConservation(c);\r
+      }\r
+    }\r
+\r
+    int s, sSize = viewport.alignment.getGroups().size();\r
+    for(s=0; s<sSize; s++)\r
+    {\r
+      SequenceGroup sg = (SequenceGroup)viewport.alignment.getGroups().elementAt(s);\r
+      if(sg.cs!=null && sg.cs instanceof ClustalxColourScheme)\r
+      {\r
+        ((ClustalxColourScheme)sg.cs).resetClustalX(sg.sequences, sg.getWidth());\r
+      }\r
+      sg.recalcConservation();\r
+    }\r
   }\r
 \r
   /**\r
@@ -1045,9 +1125,7 @@ public class AlignFrame
       }\r
     }\r
 \r
-    viewport.updateConservation();\r
-    viewport.updateConsensus();\r
-    alignPanel.repaint();\r
+    alignmentChanged();\r
   }\r
 \r
   /**\r
@@ -1371,65 +1449,50 @@ public class AlignFrame
   {\r
     int threshold = 0;\r
 \r
-    if (viewport.getAbovePIDThreshold())\r
+    if(cs!=null)\r
     {\r
-      threshold = SliderPanel.setPIDSliderSource(alignPanel, cs,\r
-                                                 "Background");\r
-\r
-      if (cs instanceof ResidueColourScheme)\r
+      if (viewport.getAbovePIDThreshold())\r
       {\r
-        ( (ResidueColourScheme) cs).setThreshold(threshold,\r
-                                                 viewport.\r
-                                                 getIgnoreGapsConsensus());\r
+        threshold = SliderPanel.setPIDSliderSource(alignPanel, cs,\r
+                                                   "Background");\r
+\r
+        cs.setThreshold(threshold,\r
+                        viewport.getIgnoreGapsConsensus());\r
+\r
+        viewport.setGlobalColourScheme(cs);\r
       }\r
-      else if (cs instanceof ScoreColourScheme)\r
+      else\r
       {\r
-        ( (ScoreColourScheme) cs).setThreshold(threshold,\r
-                                               viewport.getIgnoreGapsConsensus());\r
+        cs.setThreshold(0, viewport.getIgnoreGapsConsensus());\r
       }\r
 \r
-      viewport.setGlobalColourScheme(cs);\r
-    }\r
-    else if (cs instanceof ResidueColourScheme)\r
-    {\r
-      ( (ResidueColourScheme) cs).setThreshold(0,\r
-                                               viewport.getIgnoreGapsConsensus());\r
-    }\r
-\r
-\r
-    if (viewport.getConservationSelected())\r
-    {\r
-      ConservationColourScheme ccs = null;\r
-\r
-      Alignment al = (Alignment) viewport.alignment;\r
-      Conservation c = new Conservation("All",\r
-                                        ResidueProperties.propHash, 3,\r
-                                        al.getSequences(), 0,\r
-                                        al.getWidth() - 1);\r
-\r
-      c.calculate();\r
-      c.verdict(false, viewport.ConsPercGaps);\r
+      if (viewport.getConservationSelected())\r
+      {\r
 \r
-      ccs = new ConservationColourScheme(c, cs);\r
+        Alignment al = (Alignment) viewport.alignment;\r
+        Conservation c = new Conservation("All",\r
+                                          ResidueProperties.propHash, 3,\r
+                                          al.getSequences(), 0,\r
+                                          al.getWidth() - 1);\r
 \r
-      ccs.setConsensus(viewport.vconsensus);\r
+        c.calculate();\r
+        c.verdict(false, viewport.ConsPercGaps);\r
 \r
-      viewport.setGlobalColourScheme(ccs);\r
+        cs.setConservation(c);\r
 \r
-      ccs.inc = SliderPanel.setConservationSlider(alignPanel, ccs,\r
-                                                  "Background");\r
-    }\r
-    else\r
-    {\r
-      // MUST NOTIFY THE COLOURSCHEME OF CONSENSUS!\r
-      if (cs != null)\r
+        cs.setConservationInc(SliderPanel.setConservationSlider(alignPanel, cs,\r
+            "Background"));\r
+      }\r
+      else\r
       {\r
-        cs.setConsensus(viewport.vconsensus);\r
+        cs.setConservation(null);\r
       }\r
 \r
-      viewport.setGlobalColourScheme(cs);\r
+      cs.setConsensus(viewport.vconsensus);\r
     }\r
 \r
+    viewport.setGlobalColourScheme(cs);\r
+\r
     if (viewport.getColourAppliesToAllGroups())\r
     {\r
       Vector groups = viewport.alignment.getGroups();\r
@@ -1441,8 +1504,10 @@ public class AlignFrame
         if (cs == null)\r
         {\r
           sg.cs = null;\r
+          continue;\r
         }\r
-        else if (cs instanceof ClustalxColourScheme)\r
+\r
+        if (cs instanceof ClustalxColourScheme)\r
         {\r
           sg.cs = new ClustalxColourScheme(sg.sequences, sg.getWidth());\r
         }\r
@@ -1461,17 +1526,19 @@ public class AlignFrame
           }\r
         }\r
 \r
-        if (viewport.getAbovePIDThreshold())\r
+        if (viewport.getAbovePIDThreshold()\r
+            || cs instanceof PIDColourScheme\r
+            || cs instanceof Blosum62ColourScheme)\r
         {\r
-          if (sg.cs instanceof ResidueColourScheme)\r
-          {\r
-            ( (ResidueColourScheme) sg.cs).setThreshold(threshold,\r
+         sg.cs.setThreshold(threshold,\r
                 viewport.getIgnoreGapsConsensus());\r
-          }\r
 \r
           sg.cs.setConsensus(AAFrequency.calculate(sg.sequences, 0,\r
               sg.getWidth()));\r
         }\r
+        else\r
+          sg.cs.setThreshold(0, viewport.getIgnoreGapsConsensus());\r
+\r
 \r
         if (viewport.getConservationSelected())\r
         {\r
@@ -1481,21 +1548,10 @@ public class AlignFrame
                                             viewport.alignment.getWidth() - 1);\r
           c.calculate();\r
           c.verdict(false, viewport.ConsPercGaps);\r
-\r
-          ConservationColourScheme ccs = new ConservationColourScheme(c,\r
-              sg.cs);\r
-\r
-          // MUST NOTIFY THE COLOURSCHEME OF CONSENSUS!\r
-          ccs.setConsensus(AAFrequency.calculate(sg.sequences, 0,\r
-                                                 sg.getWidth()));\r
-          sg.cs = ccs;\r
-        }\r
-        else if (cs != null)\r
-        {\r
-          // MUST NOTIFY THE COLOURSCHEME OF CONSENSUS!\r
-          sg.cs.setConsensus(AAFrequency.calculate(sg.sequences, 0,\r
-              sg.getWidth()));\r
+          sg.cs.setConservation(c);\r
         }\r
+        else\r
+          sg.cs.setConservation(null);\r
       }\r
     }\r
 \r
@@ -1514,7 +1570,7 @@ public class AlignFrame
    */\r
   protected void modifyPID_actionPerformed(ActionEvent e)\r
   {\r
-    if (viewport.getAbovePIDThreshold())\r
+    if (viewport.getAbovePIDThreshold() && viewport.globalColourScheme!=null)\r
     {\r
       SliderPanel.setPIDSliderSource(alignPanel,\r
                                      viewport.getGlobalColourScheme(),\r
@@ -1530,7 +1586,7 @@ public class AlignFrame
    */\r
   protected void modifyConservation_actionPerformed(ActionEvent e)\r
   {\r
-    if (viewport.getConservationSelected())\r
+    if (viewport.getConservationSelected() && viewport.globalColourScheme!=null)\r
     {\r
       SliderPanel.setConservationSlider(alignPanel,\r
                                         viewport.globalColourScheme,\r
@@ -1551,16 +1607,7 @@ public class AlignFrame
     viewport.setAbovePIDThreshold(false);\r
     abovePIDThreshold.setSelected(false);\r
 \r
-    ColourSchemeI cs = viewport.getGlobalColourScheme();\r
-\r
-    if (cs instanceof ConservationColourScheme)\r
-    {\r
-      changeColour( ( (ConservationColourScheme) cs).cs);\r
-    }\r
-    else\r
-    {\r
-      changeColour(cs);\r
-    }\r
+    changeColour(viewport.getGlobalColourScheme());\r
 \r
     modifyConservation_actionPerformed(null);\r
   }\r
@@ -1579,14 +1626,7 @@ public class AlignFrame
 \r
     ColourSchemeI cs = viewport.getGlobalColourScheme();\r
 \r
-    if (cs instanceof ConservationColourScheme)\r
-    {\r
-      changeColour( ( (ConservationColourScheme) cs).cs);\r
-    }\r
-    else\r
-    {\r
-      changeColour(cs);\r
-    }\r
+    changeColour(viewport.getGlobalColourScheme());\r
 \r
     modifyPID_actionPerformed(null);\r
   }\r
@@ -1632,8 +1672,37 @@ public class AlignFrame
 \r
       while (userColours.hasMoreElements())\r
       {\r
-        JRadioButtonMenuItem radioItem = new JRadioButtonMenuItem(userColours.\r
+        final JRadioButtonMenuItem radioItem = new JRadioButtonMenuItem(userColours.\r
             nextElement().toString());\r
+        radioItem.setName("USER_DEFINED");\r
+        radioItem.addMouseListener(new MouseAdapter()\r
+            {\r
+              public void mousePressed(MouseEvent evt)\r
+              {\r
+                if(evt.isControlDown() || SwingUtilities.isRightMouseButton(evt))\r
+                {\r
+                  radioItem.removeActionListener(radioItem.getActionListeners()[0]);\r
+\r
+                  int option = JOptionPane.showInternalConfirmDialog(jalview.gui.Desktop.desktop,\r
+                      "Remove from default list?",\r
+                      "Remove user defined colour",\r
+                      JOptionPane.YES_NO_OPTION);\r
+                  if(option == JOptionPane.YES_OPTION)\r
+                  {\r
+                    jalview.gui.UserDefinedColours.removeColourFromDefaults(radioItem.getText());\r
+                    colourMenu.remove(radioItem);\r
+                  }\r
+                  else\r
+                    radioItem.addActionListener(new ActionListener()\r
+                    {\r
+                      public void actionPerformed(ActionEvent evt)\r
+                      {\r
+                        userDefinedColour_actionPerformed(evt);\r
+                      }\r
+                    });\r
+                }\r
+              }\r
+            });\r
         radioItem.addActionListener(new ActionListener()\r
         {\r
           public void actionPerformed(ActionEvent evt)\r
@@ -1641,6 +1710,7 @@ public class AlignFrame
             userDefinedColour_actionPerformed(evt);\r
           }\r
         });\r
+\r
         colourMenu.insert(radioItem, 15);\r
         colours.add(radioItem);\r
       }\r
@@ -1766,21 +1836,11 @@ public class AlignFrame
       return;\r
     }\r
 \r
-    try\r
-    {\r
       PCAPanel pcaPanel = new PCAPanel(viewport, null);\r
       JInternalFrame frame = new JInternalFrame();\r
       frame.setContentPane(pcaPanel);\r
       Desktop.addInternalFrame(frame, "Principal component analysis",\r
                                400, 400);\r
-    }\r
-    catch (java.lang.OutOfMemoryError ex)\r
-    {\r
-      JOptionPane.showInternalMessageDialog(this,\r
-                                            "Too many sequences selected\nfor Principal Component Analysis!!",\r
-                                            "Out of memory",\r
-                                            JOptionPane.WARNING_MESSAGE);\r
-    }\r
   }\r
 \r
   /**\r
@@ -1962,17 +2022,6 @@ public class AlignFrame
       }\r
       ;\r
     });\r
-    viewport.addPropertyChangeListener(new java.beans.PropertyChangeListener()\r
-    {\r
-      public void propertyChange(PropertyChangeEvent evt)\r
-      {\r
-        if (evt.getPropertyName().equals("alignment"))\r
-        {\r
-          treePanel.getTree().UpdatePlaceHolders( (Vector) evt.getNewValue());\r
-          treePanel.repaint();\r
-        }\r
-      }\r
-    });\r
   }\r
 \r
   /**\r
@@ -2119,6 +2168,11 @@ public class AlignFrame
     }\r
   }\r
 \r
+\r
+  public TreePanel ShowNewickTree(NewickFile nf, String title)\r
+  {\r
+    return ShowNewickTree(nf,title,600,500,4,5);\r
+  }\r
   /**\r
    * DOCUMENT ME!\r
    *\r
@@ -2127,7 +2181,7 @@ public class AlignFrame
    *\r
    * @return DOCUMENT ME!\r
    */\r
-  public TreePanel ShowNewickTree(NewickFile nf, String title)\r
+  public TreePanel ShowNewickTree(NewickFile nf, String title, int w,int h,int x, int y)\r
   {\r
     TreePanel tp = null;\r
 \r
@@ -2141,7 +2195,14 @@ public class AlignFrame
                            viewport.getAlignment().getSequences(), nf,\r
                            "FromFile",\r
                            title);\r
-        Desktop.addInternalFrame(tp, title, 600, 500);\r
+\r
+        tp.setSize(w,h);\r
+\r
+        if(x>0 && y>0)\r
+          tp.setLocation(x,y);\r
+\r
+\r
+        Desktop.addInternalFrame(tp, title, w, h);\r
         addTreeMenuItem(tp, title);\r
       }\r
     }\r