If alignment is closed, then undo performed in visible window

[jalview.git] / src / jalview / gui / AlignFrame.java

diff --git a/src/jalview/gui/AlignFrame.java b/src/jalview/gui/AlignFrame.java
index 3adc725..cc9ad28 100755 (executable)
--- a/src/jalview/gui/AlignFrame.java
+++ b/src/jalview/gui/AlignFrame.java
@@ -64,7 +64,6 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
 
   String fileName = null;
 
-  private int treeCount = 0;
 
   /**
    * Creates a new AlignFrame object.
@@ -975,10 +974,13 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
     command.undoCommand();
 
     AlignViewport originalSource = getOriginatingSource(command);
-
-    originalSource.hasHiddenColumns = viewport.colSel.getHiddenColumns() != null;
     updateEditMenuBar();
-    originalSource.firePropertyChange("alignment", null,viewport.getAlignment().getSequences());
+
+    if(originalSource!=null)
+    {
+      originalSource.hasHiddenColumns = viewport.colSel.getHiddenColumns() != null;
+      originalSource.firePropertyChange("alignment", null,null);
+    }
   }
 
   /**
@@ -993,15 +995,18 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
     command.doCommand();
 
     AlignViewport originalSource = getOriginatingSource(command);
-    originalSource.hasHiddenColumns = viewport.colSel.getHiddenColumns()!=null;
-
     updateEditMenuBar();
-    originalSource.firePropertyChange("alignment", null, viewport.getAlignment().getSequences());
+
+    if(originalSource!=null)
+    {
+      originalSource.hasHiddenColumns = viewport.colSel.getHiddenColumns() != null;
+      originalSource.firePropertyChange("alignment", null,null);
+    }
   }
 
   AlignViewport getOriginatingSource(CommandI command)
   {
-    AlignViewport originalSource = viewport;
+    AlignViewport originalSource = null;
     //For sequence removal and addition, we need to fire
    //the property change event FROM the viewport where the
    //original alignment was altered
@@ -1011,6 +1016,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
       AlignmentI al = editCommand.getAlignment();
       Vector comps = (Vector) PaintRefresher.components
           .get(viewport.getSequenceSetId());
+      System.out.println(comps.size());
       for (int i = 0; i < comps.size(); i++)
       {
         if (comps.elementAt(i) instanceof AlignmentPanel)
@@ -1022,7 +1028,17 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
           }
         }
       }
+      if (originalSource == null && al!=null)
+      {
+        //The original view is closed, we must validate
+        //the current view against the closed view first
+        PaintRefresher.validateSequences(al, viewport.alignment);
+        originalSource = viewport;
+      }
+
     }
+
+
     return originalSource;
   }
 
@@ -2516,7 +2532,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
       return;
     }
 
-     new PCAPanel(viewport);
+     new PCAPanel(alignPanel);
   }
 
 
@@ -2636,9 +2652,11 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
       tp = new TreePanel(alignPanel, type, pwType);
     }
 
-    addTreeMenuItem(tp, title);
+    title = title + " from " + this.title;
+    if(viewport.viewName!=null)
+      title+= " ("+viewport.viewName+")";
 
-    Desktop.addInternalFrame(tp, title + " from " + this.title, 600, 500);
+    Desktop.addInternalFrame(tp, title, 600, 500);
   }
 
   /**
@@ -2676,51 +2694,53 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
    * @param treePanel Displayed tree window.
    * @param title SortBy menu item title.
    */
-  void addTreeMenuItem(final TreePanel treePanel, String title)
+  public void buildTreeMenu()
   {
-    final JMenuItem item = new JMenuItem(title);
-
-    treeCount++;
-
-    if (treeCount == 1)
-    {
-      sort.add(sortByTreeMenu);
-    }
+    sortByTreeMenu.removeAll();
 
-    sortByTreeMenu.add(item);
-    item.addActionListener(new java.awt.event.ActionListener()
+    Vector comps = (Vector)PaintRefresher.components.get(viewport.getSequenceSetId());
+    Vector treePanels = new Vector();
+    int i, iSize = comps.size();
+    for(i=0; i<iSize; i++)
     {
-      public void actionPerformed(ActionEvent e)
+      if(comps.elementAt(i) instanceof TreePanel)
       {
-        SequenceI[] oldOrder = viewport.getAlignment().getSequencesArray();
-        AlignmentSorter.sortByTree(viewport.getAlignment(),
-                                   treePanel.getTree());
+        treePanels.add(comps.elementAt(i));
+      }
+    }
 
-        addHistoryItem(new OrderCommand("Tree Sort",
-                                        oldOrder,
-                                        viewport.alignment));
+    iSize = treePanels.size();
 
+    if(iSize<1)
+    {
+      sortByTreeMenu.setVisible(false);
+      return;
+    }
 
-        alignPanel.repaint();
-      }
-    });
+    sortByTreeMenu.setVisible(true);
 
-    treePanel.addInternalFrameListener(new javax.swing.event.
-                                       InternalFrameAdapter()
+    for(i=0; i<treePanels.size(); i++)
     {
-      public void internalFrameClosed(
-          javax.swing.event.InternalFrameEvent evt)
+      TreePanel tp = (TreePanel)treePanels.elementAt(i);
+      final JMenuItem item = new JMenuItem(tp.getTitle());
+      final NJTree tree = ((TreePanel)treePanels.elementAt(i)).getTree();
+      item.addActionListener(new java.awt.event.ActionListener()
       {
-        treeCount--;
-        sortByTreeMenu.remove(item);
-
-        if (treeCount == 0)
+        public void actionPerformed(ActionEvent e)
         {
-          sort.remove(sortByTreeMenu);
+          SequenceI[] oldOrder = viewport.getAlignment().getSequencesArray();
+          AlignmentSorter.sortByTree(viewport.getAlignment(), tree);
+
+          addHistoryItem(new OrderCommand("Tree Sort",
+                                          oldOrder,
+                                          viewport.alignment));
+
+          alignPanel.repaint();
         }
-      }
-      ;
-    });
+      });
+
+      sortByTreeMenu.add(item);
+    }
   }
 
   /**
@@ -2876,7 +2896,6 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
 
 
         Desktop.addInternalFrame(tp, title, w, h);
-        addTreeMenuItem(tp, title);
       }
     }
     catch (Exception ex)