accelerators, save menu item
[jalview.git] / src / jalview / gui / AlignFrame.java
index 73872d0..f82efb5 100755 (executable)
@@ -33,10 +33,9 @@ import jalview.datamodel.*;
 import jalview.io.*;
 import jalview.jbgui.*;
 import jalview.schemes.*;
-import jalview.util.ShiftList;
+import jalview.commands.*;
 import jalview.ws.*;
 import java.awt.dnd.*;
-import org.biojava.dasobert.eventmodel.*;
 
 /**
  * DOCUMENT ME!
@@ -52,16 +51,17 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
   /** DOCUMENT ME!! */
   public static final int DEFAULT_HEIGHT = 500;
   public AlignmentPanel alignPanel;
-  AlignViewport viewport;
 
+  AlignViewport viewport;
 
   Vector alignPanels = new Vector();
 
 
   /** DOCUMENT ME!! */
   public String currentFileFormat = null;
-  Stack historyList = new Stack();
-  Stack redoList = new Stack();
+
+  public String fileName = null;
+
   private int treeCount = 0;
 
   /**
@@ -93,7 +93,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
       al.setDataset(null);
     }
 
-    addAlignmentPanel(alignPanel);
+    addAlignmentPanel(alignPanel, true);
     init();
   }
 
@@ -106,7 +106,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
   {
     viewport = ap.av;
     alignPanel = ap;
-    addAlignmentPanel(ap);
+    addAlignmentPanel(ap, false);
     init();
   }
 
@@ -137,13 +137,16 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
      setGUINucleotide(viewport.alignment.isNucleotide());
    }
 
-   if (jalview.bin.Cache.getDefault("WRAP_ALIGNMENT", false))
+   setMenusFromViewport(viewport);
+
+   if (viewport.wrapAlignment)
    {
-     wrapMenuItem.setSelected(true);
      wrapMenuItem_actionPerformed(null);
    }
 
    addKeyListener();
+
+
   }
 
   void addKeyListener()
@@ -165,30 +168,20 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
             case KeyEvent.VK_V:
               if (!evt.isControlDown())
               {
-                AlignmentI al;
-                if(viewport.hasHiddenRows)
-                {
-                  al = viewport.alignment.getHiddenSequences().getFullAlignment();
-                }
-                else
-                  al = new Alignment(viewport.alignment.getSequencesArray());
-
-                AlignViewport newview = new AlignViewport(al);
-
-                AlignmentPanel copy = new AlignmentPanel(af, newview);
+                AlignmentPanel newap =
+                    new Jalview2XML().copyAlignPanel(alignPanel, true);
 
                 if(viewport.viewName==null)
                   viewport.viewName="View 1";
 
-                copy.av.sequenceSetID = viewport.getSequenceSetId();
-                copy.av.viewName = "View " +
+                newap.av.historyList = viewport.historyList;
+                newap.av.redoList = viewport.redoList;
+                newap.av.viewName = "View " +
                     (Desktop.getViewCount(viewport.getSequenceSetId())+1);
 
+                addAlignmentPanel(newap, false);
 
-                addAlignmentPanel(copy);
-                PaintRefresher.Register(copy, viewport.getSequenceSetId());
-                PaintRefresher.Register(alignPanel,
-                                        viewport.getSequenceSetId());
+                tabbedPane.setSelectedIndex(tabbedPane.getTabCount()-1);
 
               }
               break;
@@ -380,21 +373,22 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
                                            viewport.startSeq
                                            + viewport.endSeq - viewport.startSeq);
               break;
-
-
           }
         }
       });
   }
 
 
-  public void addAlignmentPanel(final AlignmentPanel ap)
+  public void addAlignmentPanel(final AlignmentPanel ap,
+                                boolean newPanel)
   {
+    ap.alignFrame = this;
+
     alignPanels.addElement(ap);
 
     int aSize = alignPanels.size();
 
-   tabbedPane.setVisible(aSize>1 || ap.av.viewName!=null);
+    tabbedPane.setVisible(aSize>1 || ap.av.viewName!=null);
 
     if (aSize == 1 && ap.av.viewName==null)
     {
@@ -411,29 +405,18 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
       }
 
       tabbedPane.addTab(ap.av.viewName==null?"Original":ap.av.viewName, ap);
-    }
-
-    ap.av.updateConsensus(ap);
-    ap.av.updateConservation(ap);
 
+      ap.setVisible(false);
+    }
 
-    ap.av.addPropertyChangeListener(new PropertyChangeListener()
+    if(newPanel)
     {
-     public void propertyChange(PropertyChangeEvent evt)
-     {
-       if (evt.getPropertyName().equals("alignment"))
-       {
-         PaintRefresher.Refresh(ap, ap.av.getSequenceSetId());
-         alignmentChanged();
-       }
-     }
-   });
-
+      ap.av.updateConsensus(ap);
+      ap.av.updateConservation(ap);
+    }
   }
 
 
-
-
   public AlignViewport getViewport()
   {
     return viewport;
@@ -476,10 +459,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
   public void setGUINucleotide(boolean nucleotide)
   {
     showTranslation.setVisible( nucleotide );
-    //sequenceFeatures.setVisible(!nucleotide );
-    //featureSettings.setVisible( !nucleotide );
-    conservationMenuItem.setVisible( !nucleotide );
-    modifyConservation.setVisible(   !nucleotide );
+    conservationMenuItem.setEnabled( !nucleotide );
+    modifyConservation.setEnabled(   !nucleotide );
 
     //Remember AlignFrame always starts as protein
     if(!nucleotide)
@@ -488,6 +469,34 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
     }
   }
 
+  /**
+   * Need to call this method when tabs are selected for multiple views,
+   * or when loading from Jalview2XML.java
+   * @param av AlignViewport
+   */
+  void setMenusFromViewport(AlignViewport av)
+  {
+    colourTextMenuItem.setSelected(av.showColourText);
+    abovePIDThreshold.setSelected(av.getAbovePIDThreshold());
+    conservationMenuItem.setSelected(av.getConservationSelected());
+    seqLimits.setSelected(av.getShowJVSuffix());
+    renderGapsMenuItem.setSelected(av.renderGaps);
+    wrapMenuItem.setSelected(av.wrapAlignment);
+    annotationPanelMenuItem.setState(av.showAnnotation);
+    viewBoxesMenuItem.setSelected(av.showBoxes);
+    viewTextMenuItem.setSelected(av.showText);
+
+    setColourSelected(ColourSchemeProperty.
+                      getColourName(av.getGlobalColourScheme()));
+
+    showSeqFeatures.setSelected(av.showSequenceFeatures);
+    hiddenMarkers.setState(av.showHiddenMarkers);
+    applyToAllGroups.setState(av.colourAppliesToAllGroups);
+    smoothFont.setState(av.antiAlias);
+
+    updateEditMenuBar();
+  }
+
 
   Hashtable progressBars;
   public void setProgressBar(String message, long id)
@@ -564,12 +573,21 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
     Desktop.instance.inputURLMenuItem_actionPerformed(viewport);
   }
 
+
+  public void save_actionPerformed(ActionEvent e)
+  {
+    if(fileName==null || currentFileFormat==null)
+      saveAs_actionPerformed(null);
+    else
+      saveAlignment(fileName, currentFileFormat);
+  }
+
   /**
    * DOCUMENT ME!
    *
    * @param e DOCUMENT ME!
    */
-  public void saveAlignmentMenu_actionPerformed(ActionEvent e)
+  public void saveAs_actionPerformed(ActionEvent e)
   {
     JalviewFileChooser chooser = new JalviewFileChooser(jalview.bin.Cache.
         getProperty( "LAST_DIRECTORY"),
@@ -590,7 +608,6 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
     if (value == JalviewFileChooser.APPROVE_OPTION)
     {
         currentFileFormat = chooser.getSelectedFormat();
-
         if (currentFileFormat == null)
         {
           JOptionPane.showInternalMessageDialog(Desktop.desktop,
@@ -601,13 +618,14 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
           return;
         }
 
+        fileName = chooser.getSelectedFile().getPath();
+
       jalview.bin.Cache.setProperty("DEFAULT_FILE_FORMAT",
                                     currentFileFormat);
 
-      String choice = chooser.getSelectedFile().getPath();
-      jalview.bin.Cache.setProperty("LAST_DIRECTORY", choice);
+      jalview.bin.Cache.setProperty("LAST_DIRECTORY", fileName);
 
-      saveAlignment(choice, currentFileFormat);
+      saveAlignment(fileName, currentFileFormat);
     }
   }
 
@@ -625,6 +643,11 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
 
       new Jalview2XML().SaveAlignment(this, file, shortName);
 
+      statusBar.setText("Successfully saved to file: "
+                          +fileName+" in "
+                          +format +" format.");
+
+
       // USE Jalview2XML to save this file
       return true;
     }
@@ -663,6 +686,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
         out.print(output);
         out.close();
         this.setTitle(file);
+        statusBar.setText("Successfully saved to file: "
+                          +fileName+" in "
+                          +format +" format.");
         return true;
       }
       catch (Exception ex)
@@ -803,18 +829,28 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
   {
     try
     {
-      for(int i=0; i<alignPanels.size(); i++)
+      if(alignPanels!=null)
       {
-        AlignmentPanel ap = (AlignmentPanel)alignPanels.elementAt(i);
-        PaintRefresher.RemoveComponent(ap.seqPanel.seqCanvas);
-        PaintRefresher.RemoveComponent(ap.idPanel.idCanvas);
-        PaintRefresher.RemoveComponent(ap);
+        for (int i = 0; i < alignPanels.size(); i++)
+        {
+          AlignmentPanel ap = (AlignmentPanel) alignPanels.elementAt(i);
+          PaintRefresher.RemoveComponent(ap.seqPanel.seqCanvas);
+          PaintRefresher.RemoveComponent(ap.idPanel.idCanvas);
+          PaintRefresher.RemoveComponent(ap);
+        }
+      //  alignPanels = null;
       }
+    //  else
+     //   System.out.println("null one here");
+
+    //  alignPanel = null;
+    //  viewport = null;
 
       this.setClosed(true);
     }
     catch (Exception ex)
     {
+      ex.printStackTrace();
     }
   }
 
@@ -824,12 +860,12 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
    */
   void updateEditMenuBar()
   {
-  /*  if (historyList.size() > 0)
+
+    if (viewport.historyList.size() > 0)
     {
       undoMenuItem.setEnabled(true);
-
-      HistoryItem hi = (HistoryItem) historyList.peek();
-      undoMenuItem.setText("Undo " + hi.getDescription());
+      CommandI command = (CommandI) viewport.historyList.peek();
+      undoMenuItem.setText("Undo " + command.getDescription());
     }
     else
     {
@@ -837,32 +873,34 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
       undoMenuItem.setText("Undo");
     }
 
-    if (redoList.size() > 0)
+    if (viewport.redoList.size() > 0)
     {
       redoMenuItem.setEnabled(true);
 
-      HistoryItem hi = (HistoryItem) redoList.peek();
-      redoMenuItem.setText("Redo " + hi.getDescription());
+      CommandI command = (CommandI) viewport.redoList.peek();
+      redoMenuItem.setText("Redo " + command.getDescription());
     }
     else
     {
       redoMenuItem.setEnabled(false);
       redoMenuItem.setText("Redo");
-    }*/
+    }
   }
 
-  /**
-   * DOCUMENT ME!
-   *
-   * @param hi DOCUMENT ME!
-   */
-  public void addHistoryItem(HistoryItem hi)
+
+  public void addHistoryItem(CommandI command)
   {
-    historyList.push(hi);
-    redoList.clear();
-    updateEditMenuBar();
+    if(command.getSize()>0)
+    {
+      viewport.historyList.push(command);
+      viewport.redoList.clear();
+      updateEditMenuBar();
+      viewport.hasHiddenColumns = viewport.colSel.getHiddenColumns() != null;
+    }
   }
 
+
+
   /**
    * DOCUMENT ME!
    *
@@ -870,13 +908,14 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
    */
   protected void undoMenuItem_actionPerformed(ActionEvent e)
   {
-    HistoryItem nh,hi = (HistoryItem) historyList.pop();
-    redoList.push(nh=new HistoryItem(hi.getDescription(), viewport.alignment,
-                                  HistoryItem.HIDE));
-    if (hi.alColumnChanges!=null)
-      nh.alColumnChanges = hi.alColumnChanges.getInverse();
-    restoreHistoryItem(hi);
-    viewport.firePropertyChange("alignment", null, viewport.getAlignment().getSequences());
+    CommandI command = (CommandI)viewport.historyList.pop();
+    viewport.redoList.push(command);
+    command.undoCommand();
+
+    viewport.hasHiddenColumns = viewport.colSel.getHiddenColumns() != null;
+    updateEditMenuBar();
+    viewport.firePropertyChange("alignment", null,
+                                viewport.getAlignment().getSequences());
   }
 
   /**
@@ -886,27 +925,15 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
    */
   protected void redoMenuItem_actionPerformed(ActionEvent e)
   {
-    HistoryItem nh,hi = (HistoryItem) redoList.pop();
-    historyList.push(nh=new HistoryItem(hi.getDescription(), viewport.alignment,
-        HistoryItem.HIDE));
-    if (hi.alColumnChanges!=null)
-      nh.alColumnChanges=hi.alColumnChanges.getInverse();
-    restoreHistoryItem(hi);
+    CommandI command = (CommandI) viewport.redoList.pop();
+    viewport.historyList.push(command);
+    command.doCommand();
+    viewport.hasHiddenColumns = viewport.colSel.getHiddenColumns()!=null;
+
     updateEditMenuBar();
     viewport.firePropertyChange("alignment", null, viewport.getAlignment().getSequences());
   }
 
-  // used by undo and redo
-  void restoreHistoryItem(HistoryItem hi)
-  {
-
-    hi.restore(viewport.getColumnSelection());
-
-    updateEditMenuBar();
-
-    viewport.firePropertyChange("alignment", null,
-                                viewport.getAlignment().getSequences());
-  }
 
   /**
    * DOCUMENT ME!
@@ -1069,8 +1096,6 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
    */
   protected void pasteThis_actionPerformed(ActionEvent e)
   {
-    addHistoryItem(new HistoryItem("Paste Sequences", viewport.alignment,
-                                   HistoryItem.PASTE));
     paste(false);
   }
 
@@ -1150,18 +1175,28 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
         alignment = viewport.getAlignment();
 
         //!newAlignment
+        SequenceI [] newseqs = new SequenceI[sequences.length];
         for (int i = 0; i < sequences.length; i++)
         {
-          Sequence newseq = new Sequence(sequences[i].getName(),
+          newseqs[i] = new Sequence(sequences[i].getName(),
               sequences[i].getSequence(), sequences[i].getStart(),
               sequences[i].getEnd());
 
-          alignment.addSequence(newseq);
-          PaintRefresher.Refresh(alignPanel,
-                                 alignPanel.av.getSequenceSetId(),
-                                 null,newseq);
+          alignment.addSequence(newseqs[i]);
         }
 
+        /*
+         //ADD HISTORY ITEM
+         */
+        addHistoryItem(new EditCommand(
+            "Add sequences",
+            EditCommand.PASTE,
+            newseqs,
+            0,
+            alignment.getWidth(),
+            alignment)
+            );
+
 
         viewport.setEndSeq(alignment.getHeight());
         alignment.getWidth();
@@ -1265,37 +1300,48 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
   protected void delete_actionPerformed(ActionEvent e)
   {
 
-    if (viewport.getSelectionGroup() == null)
+    SequenceGroup sg = viewport.getSelectionGroup();
+    if (sg == null)
     {
       return;
     }
 
+    Vector seqs = new Vector();
+    int cutLength = sg.getEndRes()-sg.getStartRes()+1;
+    boolean seqsCut = false;
+    SequenceI seq;
+    for (int i = 0; i < sg.getSize(false); i++)
+    {
+      seq = sg.getSequenceAt(i);
+      seqs.addElement(seq);
+      if(seq.getLength()<=cutLength)
+        seqsCut = true;
+    }
 
-    SequenceGroup sg = viewport.getSelectionGroup();
 
+   // If the cut affects all sequences, remove highlighted columns
+   if (sg.getSize(false) == viewport.alignment.getHeight())
+   {
+     viewport.getColumnSelection().removeElements(sg.getStartRes(),
+         sg.getEndRes() + 1);
+   }
 
-    addHistoryItem(new HistoryItem("Delete Sequences", viewport.alignment,
-                                   HistoryItem.HIDE));
 
+    SequenceI [] cut = new SequenceI[seqs.size()];
+    for(int i=0; i<seqs.size(); i++)
+      cut[i] = (SequenceI)seqs.elementAt(i);
 
-    for (int i = 0; i < sg.getSize(false); i++)
-    {
-      SequenceI seq = sg.getSequenceAt(i);
-      seq.deleteChars(sg.getStartRes(), sg.getEndRes() + 1);
 
-      // If the cut affects all sequences, remove highlighted columns
-      if (sg.getSize(false) == viewport.alignment.getHeight())
-      {
-        viewport.getColumnSelection().removeElements(sg.getStartRes(),
-            sg.getEndRes() + 1);
-      }
+    /*
+    //ADD HISTORY ITEM
+    */
+    addHistoryItem(new EditCommand("Cut Sequences",
+                                      EditCommand.CUT,
+                                      cut,
+                                      sg.getStartRes(),
+                                      sg.getEndRes()-sg.getStartRes()+1,
+                                      viewport.alignment));
 
-      if (seq.getSequence().length() < 1)
-      {
-        viewport.getAlignment().deleteSequence(seq);
-        PaintRefresher.Refresh(alignPanel,alignPanel.av.getSequenceSetId(),seq,null);
-      }
-    }
 
     viewport.setSelectionGroup(null);
     viewport.alignment.deleteGroup(sg);
@@ -1303,8 +1349,6 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
     viewport.firePropertyChange("alignment", null,
                                   viewport.getAlignment().getSequences());
 
-
-
     if (viewport.getAlignment().getHeight() < 1)
     {
       try
@@ -1411,37 +1455,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
    */
   public void remove2LeftMenuItem_actionPerformed(ActionEvent e)
   {
-    ColumnSelection colSel = viewport.getColumnSelection();
-
-    if (colSel.size() > 0)
-    {
-      HistoryItem edit;
-      addHistoryItem(edit=new HistoryItem("Remove Left", viewport.alignment,
-                                     HistoryItem.HIDE));
-
-      int min = colSel.getMin();
-      viewport.getAlignment().trimLeft(min);
-      colSel.compensateForEdit(0, min);
-      edit.addShift(0,min);
-      if (viewport.getSelectionGroup() != null)
-      {
-        viewport.getSelectionGroup().adjustForRemoveLeft(min);
-      }
-
-      Vector groups = viewport.alignment.getGroups();
-
-      for (int i = 0; i < groups.size(); i++)
-      {
-        SequenceGroup sg = (SequenceGroup) groups.get(i);
-
-        if (!sg.adjustForRemoveLeft(min))
-        {
-          viewport.alignment.deleteGroup(sg);
-        }
-      }
-
-      viewport.firePropertyChange("alignment", null, viewport.getAlignment().getSequences());
-    }
+    trimAlignment(true);
   }
 
   /**
@@ -1451,21 +1465,54 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
    */
   public void remove2RightMenuItem_actionPerformed(ActionEvent e)
   {
+      trimAlignment(false);
+  }
+
+  void trimAlignment(boolean trimLeft)
+  {
     ColumnSelection colSel = viewport.getColumnSelection();
+    int column;
 
     if (colSel.size() > 0)
     {
-      addHistoryItem(new HistoryItem("Remove Right", viewport.alignment,
-                                     HistoryItem.HIDE));
+      if(trimLeft)
+        column = colSel.getMin();
+      else
+        column = colSel.getMax();
 
-      int max = colSel.getMax();
-      viewport.getAlignment().trimRight(max);
-      // TODO: delete hidden column entries in colSel to right of max
-      // TODO: record hidden columns in history for undo.
-      if (viewport.getSelectionGroup() != null)
+      SequenceI [] seqs;
+      if(viewport.getSelectionGroup()!=null)
+        seqs = viewport.getSelectionGroup().getSequencesAsArray(true);
+      else
+        seqs = viewport.alignment.getSequencesArray();
+
+
+      TrimRegionCommand trimRegion;
+      if(trimLeft)
       {
-        viewport.getSelectionGroup().adjustForRemoveRight(max);
+        trimRegion = new TrimRegionCommand("Remove Left",
+                                    TrimRegionCommand.TRIM_LEFT,
+                                    seqs,
+                                    column,
+                                    viewport.alignment,
+                                    viewport.colSel,
+                                    viewport.selectionGroup);
       }
+     else
+     {
+       trimRegion = new TrimRegionCommand("Remove Right",
+                                   TrimRegionCommand.TRIM_RIGHT,
+                                   seqs,
+                                   column,
+                                   viewport.alignment,
+                                   viewport.colSel,
+                                   viewport.selectionGroup);
+     }
+
+     statusBar.setText("Removed "+trimRegion.getSize()+" columns.");
+
+
+      addHistoryItem(trimRegion);
 
       Vector groups = viewport.alignment.getGroups();
 
@@ -1473,13 +1520,15 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
       {
         SequenceGroup sg = (SequenceGroup) groups.get(i);
 
-        if (!sg.adjustForRemoveRight(max))
+        if ( (trimLeft && !sg.adjustForRemoveLeft(column))
+            || (!trimLeft && !sg.adjustForRemoveRight(column)))
         {
           viewport.alignment.deleteGroup(sg);
         }
       }
 
-      viewport.firePropertyChange("alignment", null, viewport.getAlignment().getSequences());
+      viewport.firePropertyChange("alignment", null,
+                                  viewport.getAlignment().getSequences());
     }
   }
 
@@ -1490,20 +1539,39 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
    */
   public void removeGappedColumnMenuItem_actionPerformed(ActionEvent e)
   {
-    HistoryItem edit;
-    addHistoryItem(edit=new HistoryItem("Remove Gapped Columns",
-                                   viewport.alignment, HistoryItem.HIDE));
+    int start = 0, end = viewport.alignment.getWidth()-1;
+
+    SequenceI[] seqs;
+    if (viewport.getSelectionGroup() != null)
+    {
+      seqs = viewport.getSelectionGroup().getSequencesAsArray(true);
+      start = viewport.getSelectionGroup().getStartRes();
+      end = viewport.getSelectionGroup().getEndRes();
+    }
+    else
+      seqs = viewport.alignment.getSequencesArray();
+
+
+    RemoveGapColCommand removeGapCols =
+        new RemoveGapColCommand("Remove Gapped Columns",
+                                seqs,
+                                start, end,
+                                viewport.getGapCharacter());
+
+    addHistoryItem(removeGapCols);
+
+    statusBar.setText("Removed "+removeGapCols.getSize()+" empty columns.");
 
     //This is to maintain viewport position on first residue
     //of first sequence
     SequenceI seq = viewport.alignment.getSequenceAt(0);
     int startRes = seq.findPosition(viewport.startRes);
-    ShiftList shifts;
-    viewport.getAlignment().removeGaps(shifts=new ShiftList());
-    edit.alColumnChanges=shifts.getInverse();
-    if (viewport.hasHiddenColumns)
-      viewport.getColumnSelection().compensateForEdits(shifts);
-    viewport.setStartRes(seq.findIndex(startRes)-1);
+   // ShiftList shifts;
+   // viewport.getAlignment().removeGaps(shifts=new ShiftList());
+   // edit.alColumnChanges=shifts.getInverse();
+   // if (viewport.hasHiddenColumns)
+   //   viewport.getColumnSelection().compensateForEdits(shifts);
+   viewport.setStartRes(seq.findIndex(startRes)-1);
    viewport.firePropertyChange("alignment", null, viewport.getAlignment().getSequences());
 
   }
@@ -1515,71 +1583,27 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
    */
   public void removeAllGapsMenuItem_actionPerformed(ActionEvent e)
   {
-    // TODO: hidden regions should not be touched by removeAllGaps - a minimal number of gaps will remain in alignment segments containing uneven length subsequences
-    // TODO: columnSelection.compensateforedits should be called (and passed to history item)
-    addHistoryItem(new HistoryItem("Remove Gaps", viewport.alignment,
-                                   HistoryItem.HIDE));
+    int start = 0, end = viewport.alignment.getWidth()-1;
+
+    SequenceI[] seqs;
+    if (viewport.getSelectionGroup() != null)
+    {
+      seqs = viewport.getSelectionGroup().getSequencesAsArray(true);
+      start = viewport.getSelectionGroup().getStartRes();
+      end = viewport.getSelectionGroup().getEndRes();
+    }
+    else
+      seqs = viewport.alignment.getSequencesArray();
 
     //This is to maintain viewport position on first residue
     //of first sequence
     SequenceI seq = viewport.alignment.getSequenceAt(0);
     int startRes = seq.findPosition(viewport.startRes);
 
-
-    SequenceI current;
-
-    Vector seqs = null;
-
-    int start = 0;
-    int end = viewport.alignment.getWidth();
-
-    if (viewport.getSelectionGroup() != null
-        && viewport.getSelectionGroup().getSequences(true) != null
-        && viewport.getSelectionGroup().getSize(true) > 0)
-    {
-      seqs = viewport.getSelectionGroup().getSequences(true);
-      start = viewport.getSelectionGroup().getStartRes();
-      end = viewport.getSelectionGroup().getEndRes()+1;
-    }
-    else
-    {
-      seqs = viewport.alignment.getSequences();
-    }
-    /* Commented out regions below are partial implementation of todo above.
-       * divide start,end into visible chunks, and for each:
-      int diff=end-start+1;
-      int diffmax=0;
-      int dr[] = new int[seqs.size()];
-      */
-     for (int i = 0; i < seqs.size(); i++)
-     {
-       current = (SequenceI) seqs.elementAt(i);
-       //dr[i]=
-       current.removeGaps(start, end);
-       /*if (d<diff) // can only shift
-         diff=d;
-       if (diffmax<d)
-         diffmax=d;
-         */
-     }
-     /* // after the end of each chunk -
-      * if (diff>0) {
-      // record shift for history.
-       editgaps.addShift(start, diff);
-       if (viewport.hasHiddenColumns && diffmax>diff) {
-       // pad sequence
-        StringBuffer gaps=new StringBuffer(diffmax);
-        for (int i=0,j=diffmax-diff; i<j; i++)
-        gaps.append(viewport.getGapCharacter());
-        for (int i=0, j=seqs.size(); i<j; i++) {
-        current = (SequenceI) seqs.elementAt(i);
-        if (dr[i]-diff>0) {
-        String sq = current.getSequence();
-        current.setSequence(sq.substring(0, hcend-dr[i])+gaps.substring(0, dr[i]-diff)+sq.substring());
-        }
-        }
-       }
-       }*/
+    addHistoryItem(new RemoveGapsCommand("Remove Gaps",
+                                           seqs,
+                                           start, end,
+                     viewport.getGapCharacter()));
 
     viewport.setStartRes(seq.findIndex(startRes)-1);
 
@@ -1587,77 +1611,6 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
 
   }
 
- public void alignmentChanged()
- {
-   AlignViewport av;
-   AlignmentPanel ap;
-
-   for(int i=0; i<alignPanels.size(); i++)
-   {
-     ap = (AlignmentPanel) alignPanels.elementAt(i);
-     av = ap.av;
-
-   if (av.padGaps)
-       av.getAlignment().padGaps();
-
-     if (av.hconsensus != null && av.autoCalculateConsensus)
-     {
-       av.updateConsensus(ap);
-       av.updateConservation(ap);
-       ap.annotationPanel.repaint();
-     }
-
-     resetAllColourSchemes();
-
-     av.alignment.adjustSequenceAnnotations();
-
-     if (ap.overviewPanel != null)
-       ap.overviewPanel.updateOverviewImage();
-
-     ap.repaint();
-   }
- }
-
-  void resetAllColourSchemes()
-  {
-    ColourSchemeI cs = viewport.globalColourScheme;
-    if(cs!=null)
-    {
-      if (cs instanceof ClustalxColourScheme)
-      {
-        ( (ClustalxColourScheme) viewport.getGlobalColourScheme()).
-            resetClustalX(viewport.alignment.getSequences(),
-                          viewport.alignment.getWidth());
-      }
-
-      cs.setConsensus(viewport.hconsensus);
-      if (cs.conservationApplied())
-      {
-        Alignment al = (Alignment) viewport.alignment;
-        Conservation c = new Conservation("All",
-                                          ResidueProperties.propHash, 3,
-                                          al.getSequences(), 0,
-                                          al.getWidth() - 1);
-        c.calculate();
-        c.verdict(false, viewport.ConsPercGaps);
-
-        cs.setConservation(c);
-      }
-    }
-
-    int s, sSize = viewport.alignment.getGroups().size();
-    for(s=0; s<sSize; s++)
-    {
-      SequenceGroup sg = (SequenceGroup)viewport.alignment.getGroups().elementAt(s);
-      if(sg.cs!=null && sg.cs instanceof ClustalxColourScheme)
-      {
-        ((ClustalxColourScheme)sg.cs).resetClustalX(
-            sg.getSequences(true), sg.getWidth());
-      }
-      sg.recalcConservation();
-    }
-  }
-
   /**
    * DOCUMENT ME!
    *
@@ -1665,9 +1618,6 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
    */
   public void padGapsMenuitem_actionPerformed(ActionEvent e)
   {
-    addHistoryItem(new HistoryItem("Pad Gaps", viewport.alignment,
-                                   HistoryItem.HIDE));
-
     viewport.padGaps = padGapsMenuitem.isSelected();
 
     viewport.firePropertyChange("alignment",
@@ -2332,10 +2282,10 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
    */
   public void sortPairwiseMenuItem_actionPerformed(ActionEvent e)
   {
-    addHistoryItem(new HistoryItem("Pairwise Sort", viewport.alignment,
-                                   HistoryItem.SORT));
+    SequenceI [] oldOrder = viewport.getAlignment().getSequencesArray();
     AlignmentSorter.sortByPID(viewport.getAlignment(),
                               viewport.getAlignment().getSequenceAt(0));
+    addHistoryItem(new OrderCommand("Pairwise Sort", oldOrder, viewport.alignment));
     alignPanel.repaint();
   }
 
@@ -2346,9 +2296,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
    */
   public void sortIDMenuItem_actionPerformed(ActionEvent e)
   {
-    addHistoryItem(new HistoryItem("ID Sort", viewport.alignment,
-                                   HistoryItem.SORT));
+    SequenceI [] oldOrder = viewport.getAlignment().getSequencesArray();
     AlignmentSorter.sortByID(viewport.getAlignment());
+    addHistoryItem(new OrderCommand("ID Sort", oldOrder, viewport.alignment));
     alignPanel.repaint();
   }
 
@@ -2359,10 +2309,10 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
    */
   public void sortGroupMenuItem_actionPerformed(ActionEvent e)
   {
-    addHistoryItem(new HistoryItem("Group Sort", viewport.alignment,
-                                   HistoryItem.SORT));
-
+    SequenceI [] oldOrder = viewport.getAlignment().getSequencesArray();
     AlignmentSorter.sortByGroup(viewport.getAlignment());
+    addHistoryItem(new OrderCommand("Group Sort", oldOrder, viewport.alignment));
+
     alignPanel.repaint();
   }
 
@@ -2560,11 +2510,13 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
     {
       public void actionPerformed(ActionEvent e)
       {
-        addHistoryItem(new HistoryItem("Sort", viewport.alignment,
-                                       HistoryItem.SORT));
+        SequenceI [] oldOrder = viewport.getAlignment().getSequencesArray();
 
         // TODO: JBPNote - have to map order entries to curent SequenceI pointers
         AlignmentSorter.sortBy(viewport.getAlignment(), order);
+
+        addHistoryItem(new OrderCommand(order.getName(), oldOrder, viewport.alignment));
+
         alignPanel.repaint();
       }
     });
@@ -2595,10 +2547,15 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener
     {
       public void actionPerformed(ActionEvent e)
       {
-        addHistoryItem(new HistoryItem("Tree Sort",
-                                       viewport.alignment, HistoryItem.SORT));
+        SequenceI[] oldOrder = viewport.getAlignment().getSequencesArray();
         AlignmentSorter.sortByTree(viewport.getAlignment(),
                                    treePanel.getTree());
+
+        addHistoryItem(new OrderCommand("Tree Sort",
+                                        oldOrder,
+                                        viewport.alignment));
+
+
         alignPanel.repaint();
       }
     });
@@ -3182,6 +3139,7 @@ public void drop(DropTargetDropEvent evt)
     {
       alignPanel = (AlignmentPanel) alignPanels.elementAt(index);
       viewport = alignPanel.av;
+      setMenusFromViewport(viewport);
     }
   }