JAL-1780 JAL-653 jim forgot to put the conditional action in!

[jalview.git] / src / jalview / gui / PopupMenu.java

diff --git a/src/jalview/gui/PopupMenu.java b/src/jalview/gui/PopupMenu.java
index 1263b71..2aa8675 100644 (file)
--- a/src/jalview/gui/PopupMenu.java
+++ b/src/jalview/gui/PopupMenu.java
@@ -20,27 +20,6 @@
  */
 package jalview.gui;
 
-import java.awt.Color;
-import java.awt.event.ActionEvent;
-import java.awt.event.ActionListener;
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.Hashtable;
-import java.util.LinkedHashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.TreeMap;
-import java.util.Vector;
-
-import javax.swing.ButtonGroup;
-import javax.swing.JCheckBoxMenuItem;
-import javax.swing.JColorChooser;
-import javax.swing.JMenu;
-import javax.swing.JMenuItem;
-import javax.swing.JOptionPane;
-import javax.swing.JPopupMenu;
-import javax.swing.JRadioButtonMenuItem;
-
 import jalview.analysis.AAFrequency;
 import jalview.analysis.AlignmentAnnotationUtils;
 import jalview.analysis.AlignmentUtils;
@@ -80,6 +59,27 @@ import jalview.util.GroupUrlLink.UrlStringTooLongException;
 import jalview.util.MessageManager;
 import jalview.util.UrlLink;
 
+import java.awt.Color;
+import java.awt.event.ActionEvent;
+import java.awt.event.ActionListener;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Hashtable;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.TreeMap;
+import java.util.Vector;
+
+import javax.swing.ButtonGroup;
+import javax.swing.JCheckBoxMenuItem;
+import javax.swing.JColorChooser;
+import javax.swing.JMenu;
+import javax.swing.JMenuItem;
+import javax.swing.JOptionPane;
+import javax.swing.JPopupMenu;
+import javax.swing.JRadioButtonMenuItem;
+
 /**
  * DOCUMENT ME!
  * 
@@ -204,9 +204,9 @@ public class PopupMenu extends JPopupMenu
 
   JMenu jMenu1 = new JMenu();
 
-  JMenuItem structureMenu = new JMenuItem();
+  JMenuItem proteinStructureMenu = new JMenuItem();
 
-  JMenu viewStructureMenu = new JMenu();
+  JMenu rnaStructureMenu = new JMenu();
 
   JMenuItem editSequence = new JMenuItem();
 
@@ -322,51 +322,11 @@ public class PopupMenu extends JPopupMenu
         makeReferenceSeq.setText("Mark as representative");
       }
 
-      if (seq.getDatasetSequence().getPDBId() != null
-              && seq.getDatasetSequence().getPDBId().size() > 0)
-      {
-        java.util.Enumeration e = seq.getDatasetSequence().getPDBId()
-                .elements();
-
-        while (e.hasMoreElements())
-        {
-          final PDBEntry pdb = (PDBEntry) e.nextElement();
-
-          menuItem = new JMenuItem();
-          menuItem.setText(pdb.getId());
-          menuItem.addActionListener(new ActionListener()
-          {
-            @Override
-            public void actionPerformed(ActionEvent e)
-            {
-              // TODO re JAL-860: optionally open dialog or provide a menu entry
-              // allowing user to open just one structure per sequence
-              // new AppJmol(pdb, ap.av.collateForPDB(new PDBEntry[]
-              // { pdb })[0], null, ap);
-              new StructureViewer(ap.getStructureSelectionManager())
-                      .viewStructures(pdb,
-                              ap.av.collateForPDB(new PDBEntry[]
-                              { pdb })[0], null, ap);
-            }
-          });
-          viewStructureMenu.add(menuItem);
-
-          /*
-           * menuItem = new JMenuItem(); menuItem.setText(pdb.getId());
-           * menuItem.addActionListener(new java.awt.event.ActionListener() {
-           * public void actionPerformed(ActionEvent e) {
-           * colourByStructure(pdb.getId()); } });
-           * colStructureMenu.add(menuItem);
-           */
-        }
-      }
-      else
+      if (ap.av.getAlignment().isNucleotide() == false)
       {
-        if (ap.av.getAlignment().isNucleotide() == false)
-        {
-          structureMenu.remove(viewStructureMenu);
-        }
+        remove(rnaStructureMenu);
       }
+
       if (ap.av.getAlignment().isNucleotide() == true)
       {
         AlignmentAnnotation[] aa = ap.av.getAlignment()
@@ -391,7 +351,7 @@ public class PopupMenu extends JPopupMenu
                 System.out.println("end");
               }
             });
-            viewStructureMenu.add(menuItem);
+            rnaStructureMenu.add(menuItem);
           }
         }
 
@@ -422,7 +382,7 @@ public class PopupMenu extends JPopupMenu
                           ap);
                 }
               });
-              viewStructureMenu.add(menuItem);
+              rnaStructureMenu.add(menuItem);
             }
           }
         }
@@ -638,7 +598,8 @@ public class PopupMenu extends JPopupMenu
     if (seq == null)
     {
       sequenceMenu.setVisible(false);
-      structureMenu.setVisible(false);
+      proteinStructureMenu.setVisible(false);
+      rnaStructureMenu.setVisible(false);
     }
 
     if (links != null && links.size() > 0)
@@ -1379,8 +1340,9 @@ public class PopupMenu extends JPopupMenu
       }
     });
     jMenu1.setText(MessageManager.getString("label.group"));
-    structureMenu.setText(MessageManager.getString("label.view_structure"));
-    structureMenu.addActionListener(new ActionListener()
+    proteinStructureMenu.setText(MessageManager
+            .getString("label.view_protein_structure"));
+    proteinStructureMenu.addActionListener(new ActionListener()
     {
       @Override
       public void actionPerformed(ActionEvent actionEvent)
@@ -1395,8 +1357,9 @@ public class PopupMenu extends JPopupMenu
       }
     });
 
-    viewStructureMenu.setText(MessageManager
-            .getString("label.view_structure"));
+    rnaStructureMenu.setText(MessageManager
+            .getString("label.view_rna_structure"));
+
     // colStructureMenu.setText("Colour By Structure");
     editSequence.setText(MessageManager.getString("label.edit_sequence")
             + "...");
@@ -1439,7 +1402,8 @@ public class PopupMenu extends JPopupMenu
     groupMenu.add(sequenceSelDetails);
     add(groupMenu);
     add(sequenceMenu);
-    add(structureMenu);
+    add(rnaStructureMenu);
+    add(proteinStructureMenu);
     if (sequence!=null)
     {
       add(hideInsertions);
@@ -2432,7 +2396,7 @@ public class PopupMenu extends JPopupMenu
     // wysiwig behaviour
 
     cap.setText(new FormatAdapter().formatSequences(e.getActionCommand(),
-            ap.av, true));
+            ap, true));
   }
 
   public void pdbFromFile_actionPerformed()