JAL-3454 file loading string-only (testNG) fails for PDB file

[jalview.git] / src / jalview / io / AppletFormatAdapter.java

diff --git a/src/jalview/io/AppletFormatAdapter.java b/src/jalview/io/AppletFormatAdapter.java
index 4c25634..8c29078 100755 (executable)
--- a/src/jalview/io/AppletFormatAdapter.java
+++ b/src/jalview/io/AppletFormatAdapter.java
@@ -20,7 +20,7 @@
  */
 package jalview.io;
 
-import jalview.api.AlignExportSettingI;
+import jalview.api.AlignExportSettingsI;
 import jalview.api.AlignmentViewPanel;
 import jalview.datamodel.Alignment;
 import jalview.datamodel.AlignmentAnnotation;
@@ -30,6 +30,7 @@ import jalview.datamodel.PDBEntry.Type;
 import jalview.datamodel.SequenceI;
 import jalview.ext.jmol.JmolParser;
 import jalview.structure.StructureImportSettings;
+import jalview.util.Platform;
 
 import java.io.File;
 import java.io.IOException;
@@ -73,7 +74,7 @@ public class AppletFormatAdapter
    */
   protected String newline = System.getProperty("line.separator");
 
-  private AlignExportSettingI exportSettings;
+  private AlignExportSettingsI exportSettings;
 
   private File selectedFile;
 
@@ -100,7 +101,7 @@ public class AppletFormatAdapter
   }
 
   public AppletFormatAdapter(AlignmentViewPanel alignPanel,
-          AlignExportSettingI settings)
+          AlignExportSettingsI settings)
   {
     viewpanel = alignPanel;
     exportSettings = settings;
@@ -157,9 +158,9 @@ public class AppletFormatAdapter
   {
 
     this.selectedFile = selectedFile;
-    if (selectedFile != null)
-      this.inFile = selectedFile.getPath();
-    this.inFile = file;
+    // BH 2019.10.06 PDB.getSequenceRecords calling this and then needs string,
+    // below
+    inFile = (selectedFile == null ? file : selectedFile.getPath());
     try
     {
       if (fileFormat.isStructureFile())
@@ -178,9 +179,11 @@ public class AppletFormatAdapter
         }
         else
         {
-          // todo is MCview parsing obsolete yet? JAL-2120
+          // BH: This block is executed by PDBSequenceFetcherTest
+
+          // todo is mc_view parsing obsolete yet? JAL-2120
           StructureImportSettings.setShowSeqFeatures(true);
-          alignFile = new MCview.PDBfile(annotFromStructure,
+          alignFile = new mc_view.PDBfile(annotFromStructure,
                   localSecondaryStruct, serviceSecondaryStruct, inFile,
                   sourceType);
         }
@@ -265,7 +268,7 @@ public class AppletFormatAdapter
         else
         {
           StructureImportSettings.setShowSeqFeatures(true);
-          alignFile = new MCview.PDBfile(annotFromStructure,
+          alignFile = new mc_view.PDBfile(annotFromStructure,
                   localSecondaryStruct, serviceSecondaryStruct, source);
         }
         ((StructureFile) alignFile).setDbRefType(Type.PDB);
@@ -434,7 +437,9 @@ public class AppletFormatAdapter
   public static DataSourceType checkProtocol(Object dataObject)
   {
     if(dataObject instanceof File)
+    {
       return DataSourceType.FILE;
+    }
     
     String data = dataObject.toString();
     DataSourceType protocol = DataSourceType.PASTE;
@@ -444,7 +449,7 @@ public class AppletFormatAdapter
     {
       protocol = DataSourceType.URL;
     }
-    else if (jalview.bin.Jalview.isJS)
+    else if (Platform.isJS())
     {
       protocol = DataSourceType.RELATIVE_URL;
     }
@@ -455,6 +460,10 @@ public class AppletFormatAdapter
     return protocol;
   }
 
+  /**
+   * @param args
+   * @j2sIgnore
+   */
   public static void main(String[] args)
   {
     int i = 0;