JAL-1648 resolved CR-JAL-41 review issues

[jalview.git] / src / jalview / io / cache / AppCache.java

diff --git a/src/jalview/io/cache/AppCache.java b/src/jalview/io/cache/AppCache.java
index 9663c98..091d30e 100644 (file)
--- a/src/jalview/io/cache/AppCache.java
+++ b/src/jalview/io/cache/AppCache.java
@@ -3,10 +3,8 @@ package jalview.io.cache;
 
 import jalview.bin.Cache;
 
-import java.util.Arrays;
 import java.util.Hashtable;
 import java.util.LinkedHashSet;
-import java.util.List;
 
 /**
  * A singleton class used for querying and persisting cache items.
@@ -16,15 +14,17 @@ import java.util.List;
  */
 public class AppCache
 {
-  private static AppCache instance = null;
+  public static final String DEFAULT_LIMIT = "99";
 
-  private Hashtable<String, LinkedHashSet<String>> cacheItems;
+  public static final String CACHE_DELIMITER = ";";
+
+  private static AppCache instance = null;
 
   private static final String DEFAULT_LIMIT_KEY = ".DEFAULT_LIMIT";
 
-  private static final String DEFAULT_LIMIT = "99";
 
-  private static final String CACHE_DELIMITER = ";";
+
+  private Hashtable<String, LinkedHashSet<String>> cacheItems;
 
   private AppCache()
   {
@@ -50,7 +50,7 @@ public class AppCache
 
 
   /**
-   * Returns an singleton instance of AppCache
+   * Returns a singleton instance of AppCache
    * 
    * @return
    */
@@ -63,33 +63,7 @@ public class AppCache
     return instance;
   }
 
-  /**
-   * Method for initialising cache items for a given cache key
-   * 
-   * @param cacheKey
-   */
-  public void initCache(String cacheKey)
-  {
-    String separatedStr = Cache.getProperty(cacheKey);
-    if (separatedStr == null || separatedStr.isEmpty())
-    {
-      return;
-    }
 
-    List<String> persistedCacheItems = Arrays.asList(separatedStr.split(CACHE_DELIMITER));
-
-    LinkedHashSet<String> foundCacheItems = cacheItems.get(cacheKey);
-    if (foundCacheItems == null)
-    {
-      foundCacheItems = new LinkedHashSet<String>();
-    }
-
-    for (String cacheItem : persistedCacheItems)
-    {
-      foundCacheItems.add(cacheItem);
-    }
-    cacheItems.put(cacheKey, foundCacheItems);
-  }
 
   /**
    * Method for persisting cache items for a given cache key
@@ -114,9 +88,10 @@ public class AppCache
   }
 
   /**
-   * Method for deleted cached items for a given cache key
+   * Method for deleting cached items for a given cache key
    * 
    * @param cacheKey
+   *          the cache key
    */
   public void deleteCacheItems(String cacheKey)
   {
@@ -128,9 +103,10 @@ public class AppCache
    * Method for obtaining the preset maximum cache limit for a given cache key
    * 
    * @param cacheKey
-   * @return
+   *          the cache key
+   * @return the max number of items that could be cached
    */
-  public String getCacheLmit(String cacheKey)
+  public String getCacheLimit(String cacheKey)
   {
     String uniqueKey = cacheKey + DEFAULT_LIMIT_KEY;
     return Cache.getDefault(uniqueKey, DEFAULT_LIMIT);
@@ -140,13 +116,17 @@ public class AppCache
    * Method for updating the preset maximum cache limit for a given cache key
    * 
    * @param cacheKey
+   *          the cache key
    * @param newLimit
+   *          the max number of items that could be cached for the given cache
+   *          key
    * @return
    */
-  public int updateCacheLimit(String cacheKey, String newLimit)
+  public int updateCacheLimit(String cacheKey, int newUserLimit)
   {
+    String newLimit = String.valueOf(newUserLimit);
     String uniqueKey = cacheKey + DEFAULT_LIMIT_KEY;
-    String formerLimit = getCacheLmit(cacheKey);
+    String formerLimit = getCacheLimit(cacheKey);
     if (newLimit != null && !newLimit.isEmpty()
             && !formerLimit.equals(newLimit))
     {
@@ -161,20 +141,13 @@ public class AppCache
    * structure
    * 
    * @param cacheKey
+   *          the cache key
    * @param cacheItems
+   *          the items to add to the cache
    */
-  public void putCache(String cacheKey, LinkedHashSet<String> cacheItems)
+  public void putCache(String cacheKey, LinkedHashSet<String> newCacheItems)
   {
-    getCacheItems().put(cacheKey, cacheItems);
+    cacheItems.put(cacheKey, newCacheItems);
   }
 
-  /**
-   * Getter method for obtaining cache data structure
-   * 
-   * @return
-   */
-  Hashtable<String, LinkedHashSet<String>> getCacheItems()
-  {
-    return cacheItems;
-  }
 }