JAL-1665 refactored Sequence.getSequenceFeatures

[jalview.git] / src / jalview / viewmodel / seqfeatures / FeatureRendererModel.java

diff --git a/src/jalview/viewmodel/seqfeatures/FeatureRendererModel.java b/src/jalview/viewmodel/seqfeatures/FeatureRendererModel.java
index a53004d..674f3d1 100644 (file)
--- a/src/jalview/viewmodel/seqfeatures/FeatureRendererModel.java
+++ b/src/jalview/viewmodel/seqfeatures/FeatureRendererModel.java
@@ -14,13 +14,11 @@ import java.beans.PropertyChangeListener;
 import java.beans.PropertyChangeSupport;
 import java.util.ArrayList;
 import java.util.Arrays;
-import java.util.Enumeration;
 import java.util.Hashtable;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
-import java.util.Vector;
 import java.util.concurrent.ConcurrentHashMap;
 
 public abstract class FeatureRendererModel implements
@@ -248,11 +246,12 @@ public abstract class FeatureRendererModel implements
   {
     ArrayList<SequenceFeature> tmp = new ArrayList<SequenceFeature>();
     SequenceFeature[] features = sequence.getSequenceFeatures();
+
     if (features != null)
     {
       for (int i = 0; i < features.length; i++)
       {
-        if (av.areFeaturesDisplayed()
+        if (!av.areFeaturesDisplayed()
                 || !av.getFeaturesDisplayed().isVisible(
                         features[i].getType()))
         {
@@ -262,9 +261,11 @@ public abstract class FeatureRendererModel implements
         if (features[i].featureGroup != null
                 && featureGroups != null
                 && featureGroups.containsKey(features[i].featureGroup)
-                && !((Boolean) featureGroups.get(features[i].featureGroup))
+                && !featureGroups.get(features[i].featureGroup)
                         .booleanValue())
+        {
           continue;
+        }
 
         if ((features[i].getBegin() <= res)
                 && (features[i].getEnd() >= res))
@@ -322,9 +323,7 @@ public abstract class FeatureRendererModel implements
     for (int i = 0; i < alignment.getHeight(); i++)
     {
       SequenceI asq = alignment.getSequenceAt(i);
-      SequenceI dasq = asq.getDatasetSequence();
-      SequenceFeature[] features = dasq != null ? dasq
-              .getSequenceFeatures() : asq.getSequenceFeatures();
+      SequenceFeature[] features = asq.getSequenceFeatures();
 
       if (features == null)
       {
@@ -345,7 +344,7 @@ public abstract class FeatureRendererModel implements
               groupDisplayed = Boolean.valueOf(newMadeVisible);
               featureGroups.put(fgrp, groupDisplayed);
             }
-            if (!((Boolean) groupDisplayed).booleanValue())
+            if (!groupDisplayed.booleanValue())
             {
               index++;
               continue;
@@ -435,7 +434,7 @@ public abstract class FeatureRendererModel implements
           if (initOrders)
           {
             setOrder(oldRender[j], (1 - (1 + (float) j)
-                    / (float) oldRender.length));
+                    / oldRender.length));
           }
           if (allfeatures.contains(oldRender[j]))
           {
@@ -666,9 +665,9 @@ public abstract class FeatureRendererModel implements
   }
 
   @Override
-  public Map getFeatureColours()
+  public Map<String, Object> getFeatureColours()
   {
-    return new ConcurrentHashMap<>(featureColours);
+    return new ConcurrentHashMap<String, Object>(featureColours);
   }
 
   /**
@@ -799,7 +798,7 @@ public abstract class FeatureRendererModel implements
     }
     if (featureGroups.containsKey(group))
     {
-      return ((Boolean) featureGroups.get(group)).booleanValue();
+      return featureGroups.get(group).booleanValue();
     }
     if (newGroupsVisible)
     {
@@ -825,7 +824,7 @@ public abstract class FeatureRendererModel implements
 
       for (Object grp : featureGroups.keySet())
       {
-        Boolean state = (Boolean) featureGroups.get(grp);
+        Boolean state = featureGroups.get(grp);
         if (state.booleanValue() == visible)
         {
           gp.add(grp);
@@ -854,7 +853,7 @@ public abstract class FeatureRendererModel implements
         featureGroups.put(gst, new Boolean(visible));
         if (st != null)
         {
-          rdrw = rdrw || (visible != ((Boolean) st).booleanValue());
+          rdrw = rdrw || (visible != st.booleanValue());
         }
       }
       if (rdrw)
@@ -900,7 +899,7 @@ public abstract class FeatureRendererModel implements
       {
         for (int i = 0; i < typ.length; i++)
         {
-          if (feature_disp.isVisible(typ[i]))
+          if (!feature_disp.isVisible(typ[i]))
           {
             typ[i] = null;
           }