unnecessary code

[jalview.git] / src / jalview / ws / EnfinEnvision2OneWay.java

diff --git a/src/jalview/ws/EnfinEnvision2OneWay.java b/src/jalview/ws/EnfinEnvision2OneWay.java
index 8e596b7..b1a0bdb 100644 (file)
--- a/src/jalview/ws/EnfinEnvision2OneWay.java
+++ b/src/jalview/ws/EnfinEnvision2OneWay.java
@@ -11,6 +11,7 @@ import jalview.gui.AlignFrame;
 import jalview.gui.Desktop;
 import jalview.util.GroupUrlLink;
 
+import java.awt.Component;
 import java.awt.Cursor;
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
@@ -142,6 +143,7 @@ public class EnfinEnvision2OneWay extends DefaultHandler implements Runnable,WSM
   private boolean running=false;
   private Vector groupURLLinks = null;
   private Vector groupURLdescr = null;
+  private static String[] allowedDb=new String[] {"UNIPROT","EMBL","PDB"} ;
   
   public EnfinEnvision2OneWay() {
     groupURLLinks = new Vector();
@@ -207,6 +209,15 @@ public class EnfinEnvision2OneWay extends DefaultHandler implements Runnable,WSM
    */
   private void addshowLink(JMenu linkMenu, String label, String descr, final GroupUrlLink urlgenerator, final Object[] urlstub)
   {
+    Component[] jmi=linkMenu.getMenuComponents();
+    for (int i=0; i<jmi.length; i++)
+    {
+      if (jmi[i] instanceof JMenuItem && ((JMenuItem)jmi[i]).getText().equalsIgnoreCase(label))
+      {
+        // don't add this - its a repeat of an existing URL.
+        return;
+      }
+    }
     JMenuItem item = new JMenuItem(label);
     item.setToolTipText("Submit ("+urlgenerator.getNumberInvolved(urlstub)+" seqs) to workflow: "+descr);
     item.addActionListener(new java.awt.event.ActionListener()
@@ -366,40 +377,31 @@ public class EnfinEnvision2OneWay extends DefaultHandler implements Runnable,WSM
         final String label = urlLink.getLabel();
         boolean usingNames = false;
         // Now see which parts of the group apply for this URL
-        String ltarget = urlLink.getTarget(); // jalview.util.DBRefUtils.getCanonicalName(urlLink.getTarget());
-        Object[] idset = (Object[]) commonDbrefs.get(ltarget.toUpperCase());
+        String ltarget;
         String[] seqstr,ids; // input to makeUrl
-        if (idset!=null)
-        {
-          int numinput = ((int[])idset[0])[0];
-          String[] allids = ((String[])idset[1]);
-          seqstr = new String[numinput];
-          ids = new String[numinput];
-          for (int sq=0,idcount=0;sq<seqs.length;sq++)
+        for (int t=0;t<allowedDb.length; t++) {
+          ltarget = allowedDb[t]; // jalview.util.DBRefUtils.getCanonicalName(urlLink.getTarget());
+          Object[] idset = (Object[]) commonDbrefs.get(ltarget.toUpperCase());
+          if (idset!=null)
           {
-            if (allids[sq]!=null) {
-              ids[idcount] = allids[sq];
-              seqstr[idcount++] = idandseqs[1][sq];
+            int numinput = ((int[])idset[0])[0];
+            String[] allids = ((String[])idset[1]);
+            seqstr = new String[numinput];
+            ids = new String[numinput];
+            for (int sq=0,idcount=0;sq<seqs.length;sq++)
+            {
+              if (allids[sq]!=null) {
+                ids[idcount] = allids[sq];
+                seqstr[idcount++] = idandseqs[1][sq];
+              }
             }
+            addMenu = addMenu | createAndAddLinks(linkMenus,false,urlLink,label,ltarget,descr, ids,seqstr);
           }
-        } else {
-          // just use the id/seq set
-          seqstr = idandseqs[1];
-          ids = idandseqs[0];
-          usingNames=true;
-        }
-        // and try and make the groupURL!
-        
-        Object[] urlset = urlLink.makeUrlStubs(ids,seqstr, "FromJalview"+System.currentTimeMillis(),false);
-        if (urlset!=null)
-        {
-          int type = urlLink.getGroupURLType() & 3;
-          //System.out.println(urlLink.getGroupURLType() +" "+((String[])urlset[3])[0]);
-          // first two bits ofurlLink type bitfield are sequenceids and sequences
-          // TODO: FUTURE: ensure the groupURL menu structure can be generalised
-          addshowLink(linkMenus[type], label + (((type & 1)==1) ? ("("+(usingNames ? "Names" : ltarget)+")") : ""), descr, urlLink, urlset);
-          addMenu = true;
         }
+        // also do names only.
+        seqstr = idandseqs[1];
+        ids = idandseqs[0];
+        addMenu = addMenu | createAndAddLinks(linkMenus,true,urlLink,label,"Names",descr, ids,seqstr);
       }
     if (addMenu)
     {
@@ -417,6 +419,22 @@ public class EnfinEnvision2OneWay extends DefaultHandler implements Runnable,WSM
     return null;
   }
 
+  private boolean createAndAddLinks(JMenu[] linkMenus, boolean usingNames,
+          GroupUrlLink urlLink, String label, String ltarget, String descr, String[] ids,
+          String[] seqstr)
+  {
+    Object[] urlset = urlLink.makeUrlStubs(ids,seqstr, "FromJalview"+System.currentTimeMillis(),false);
+    if (urlset!=null)
+    {
+      int type = urlLink.getGroupURLType() & 3;
+      //System.out.println(urlLink.getGroupURLType() +" "+((String[])urlset[3])[0]);
+      // first two bits ofurlLink type bitfield are sequenceids and sequences
+      // TODO: FUTURE: ensure the groupURL menu structure can be generalised
+      addshowLink(linkMenus[type], label + " "+(usingNames ? (((type & 1)==1) ? "(Names)" : "") : ("("+ltarget+")")), descr, urlLink, urlset);
+      return true;
+    }
+    return false;
+  }
   /// end of stuff copied from popupmenu
   public void attachWSMenuEntry(final JMenu wsmenu, final AlignFrame alignFrame)
   {