JAL-1712 fixes/tests for Castor binding and 'show flanking regions'

[jalview.git] / src / jalview / ws / dbsources / EmblXmlSource.java

diff --git a/src/jalview/ws/dbsources/EmblXmlSource.java b/src/jalview/ws/dbsources/EmblXmlSource.java
index 58ee42d..92e863a 100644 (file)
--- a/src/jalview/ws/dbsources/EmblXmlSource.java
+++ b/src/jalview/ws/dbsources/EmblXmlSource.java
@@ -20,23 +20,23 @@
  */
 package jalview.ws.dbsources;
 
+import java.io.File;
+
 import jalview.datamodel.Alignment;
 import jalview.datamodel.AlignmentI;
 import jalview.datamodel.SequenceI;
 import jalview.datamodel.xdb.embl.EmblEntry;
+import jalview.datamodel.xdb.embl.EmblFile;
 import jalview.util.MessageManager;
 import jalview.ws.ebi.EBIFetchClient;
 
-import java.io.File;
-import java.util.Iterator;
-
 public abstract class EmblXmlSource extends EbiFileRetrievedProxy
 {
 
   /**
    * Last properly parsed embl file.
    */
-  public jalview.datamodel.xdb.embl.EmblFile efile = null;
+  public EmblFile efile = null;
 
   public EmblXmlSource()
   {
@@ -94,7 +94,7 @@ public abstract class EmblXmlSource extends EbiFileRetrievedProxy
       file = reply.getAbsolutePath();
       if (reply.length() > 25)
       {
-        efile = jalview.datamodel.xdb.embl.EmblFile.getEmblFile(reply);
+        efile = EmblFile.getEmblFile(reply);
       }
       else
       {
@@ -103,19 +103,10 @@ public abstract class EmblXmlSource extends EbiFileRetrievedProxy
     }
     if (efile != null)
     {
-      for (Iterator i = efile.getEntries().iterator(); i.hasNext();)
+      for (EmblEntry entry : efile.getEntries())
       {
-        EmblEntry entry = (EmblEntry) i.next();
-        SequenceI[] seqparts = entry.getSequences(false, true, emprefx); // TODO:
-        // use
-        // !fetchNa,!fetchPeptide
-        // here
-        // instead
-        // -
-        // see
-        // todo
-        // in
-        // emblEntry
+        SequenceI[] seqparts = entry.getSequences(false, true, emprefx);
+        // TODO: use !fetchNa,!fetchPeptide here instead - see todo in EmblEntry
         if (seqparts != null)
         {
           SequenceI[] newseqs = null;
@@ -136,8 +127,8 @@ public abstract class EmblXmlSource extends EbiFileRetrievedProxy
           }
           for (int j = 0; j < seqparts.length; si++, j++)
           {
-            newseqs[si] = seqparts[j].deriveSequence(); // place DBReferences on
-            // dataset and refer
+            newseqs[si] = seqparts[j].deriveSequence();
+            // place DBReferences on dataset and refer
           }
           seqs = newseqs;