Merge branch 'develop' into JAL-1483_29dev
authorJim Procter <jprocter@dundee.ac.uk>
Wed, 7 Jan 2015 23:08:47 +0000 (23:08 +0000)
committerJim Procter <jprocter@dundee.ac.uk>
Wed, 7 Jan 2015 23:08:47 +0000 (23:08 +0000)
updated JAL-1483 with commits from 15th Dec-7th Jan 2015

Conflicts:
.classpath
src/jalview/api/AlignmentViewPanel.java
src/jalview/appletgui/SeqPanel.java
src/jalview/ext/rbvi/chimera/JalviewChimeraBinding.java
src/jalview/gui/AlignFrame.java
src/jalview/gui/AlignViewport.java
src/jalview/gui/AnnotationExporter.java
src/jalview/gui/FeatureRenderer.java
src/jalview/gui/FeatureSettings.java
src/jalview/gui/Jalview2XML.java
src/jalview/gui/Jalview2XML_V1.java
src/jalview/gui/PopupMenu.java
src/jalview/gui/SeqPanel.java
src/jalview/io/BioJsHTMLOutput.java
src/jalview/io/HtmlSvgOutput.java

1  2 
.classpath
src/jalview/gui/FeatureRenderer.java
src/jalview/gui/FeatureSettings.java
src/jalview/gui/Jalview2XML_V1.java
src/jalview/io/BioJsHTMLOutput.java

diff --combined .classpath
        <classpathentry kind="lib" path="lib/log4j-to-slf4j-2.0-rc2.jar"/>
        <classpathentry kind="lib" path="lib/slf4j-log4j12-1.7.7.jar"/>
        <classpathentry kind="lib" path="lib/VARNAv3-91.jar"/>
        <classpathentry kind="lib" path="lib/xml-apis.jar"/>
        <classpathentry kind="con" path="org.eclipse.jdt.junit.JUNIT_CONTAINER/4"/>
        <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
 -      <classpathentry kind="con" path="org.eclipse.jdt.USER_LIBRARY/Plugin.jar"/>
 +      <classpathentry kind="con" path="org.eclipse.jdt.USER_LIBRARY/plugin"/>
        <classpathentry kind="lib" path="lib/jfreesvg-2.1.jar"/>
        <classpathentry kind="output" path="classes"/>
  </classpath>
   */
  package jalview.gui;
  
--import java.util.*;
- import java.awt.*;
- import java.awt.event.*;
- import java.awt.image.*;
- import java.beans.PropertyChangeListener;
- import javax.swing.*;
- import jalview.datamodel.*;
 -import java.util.concurrent.ConcurrentHashMap;
 -
 -import java.awt.*;
 -import java.awt.event.*;
 -import java.awt.image.*;
 -import java.beans.PropertyChangeListener;
 -import java.beans.PropertyChangeSupport;
 -
 -import javax.swing.*;
 -
 -import jalview.datamodel.*;
++import jalview.datamodel.SearchResults;
++import jalview.datamodel.SequenceFeature;
++import jalview.datamodel.SequenceI;
  import jalview.schemes.GraduatedColor;
  import jalview.util.MessageManager;
  
++import java.awt.BorderLayout;
++import java.awt.Color;
++import java.awt.Dimension;
++import java.awt.Font;
++import java.awt.GridLayout;
++import java.awt.event.ActionEvent;
++import java.awt.event.ActionListener;
++import java.awt.event.ItemEvent;
++import java.awt.event.ItemListener;
++import java.awt.event.MouseAdapter;
++import java.awt.event.MouseEvent;
++
++import javax.swing.JColorChooser;
++import javax.swing.JComboBox;
++import javax.swing.JLabel;
++import javax.swing.JOptionPane;
++import javax.swing.JPanel;
++import javax.swing.JScrollPane;
++import javax.swing.JSpinner;
++import javax.swing.JTextArea;
++import javax.swing.JTextField;
++import javax.swing.SwingConstants;
++
  /**
   * DOCUMENT ME!
   * 
   * @author $author$
   * @version $Revision$
   */
 -public class FeatureRenderer implements jalview.api.FeatureRenderer
 +public class FeatureRenderer extends jalview.renderer.seqfeatures.FeatureRenderer implements jalview.api.FeatureRenderer
  {
 -  AlignmentPanel ap;
 -
 -  AlignViewport av;
 -
    Color resBoxColour;
  
 -  /**
 -   * global transparency for feature
 -   */
 -  float transparency = 1.0f;
 -
 -  FontMetrics fm;
 -
 -  int charOffset;
 -
 -  Map featureColours = new ConcurrentHashMap();
 -
 -  // A higher level for grouping features of a
 -  // particular type
 -  Map featureGroups = new ConcurrentHashMap();
 -
 -  // This is actually an Integer held in the hashtable,
 -  // Retrieved using the key feature type
 -  Object currentColour;
 -
 -  String[] renderOrder;
 -
 -  PropertyChangeSupport changeSupport = new PropertyChangeSupport(this);
 -
 -  Vector allfeatures;
 +  AlignmentPanel ap;
  
    /**
     * Creates a new FeatureRenderer object.
@@@ -52,7 -82,6 +69,7 @@@
     */
    public FeatureRenderer(AlignmentPanel ap)
    {
 +    super();
      this.ap = ap;
      this.av = ap.av;
      if (ap != null && ap.getSeqPanel() != null && ap.getSeqPanel().seqCanvas != null
      }
    }
  
 -  public class FeatureRendererSettings implements Cloneable
 -  {
 -    String[] renderOrder;
 -
 -    Map featureGroups;
 -
 -    Map featureColours;
 -
 -    float transparency;
 -
 -    Map featureOrder;
 -
 -    public FeatureRendererSettings(String[] renderOrder,
 -            Hashtable featureGroups, Hashtable featureColours,
 -            float transparency, Hashtable featureOrder)
 -    {
 -      super();
 -      this.renderOrder = renderOrder;
 -      this.featureGroups = featureGroups;
 -      this.featureColours = featureColours;
 -      this.transparency = transparency;
 -      this.featureOrder = featureOrder;
 -    }
 -
 -    /**
 -     * create an independent instance of the feature renderer settings
 -     * 
 -     * @param fr
 -     */
 -    public FeatureRendererSettings(FeatureRenderer fr)
 -    {
 -      renderOrder = null;
 -      featureGroups = new ConcurrentHashMap();
 -      featureColours = new ConcurrentHashMap();
 -      featureOrder = new ConcurrentHashMap();
 -      if (fr.renderOrder != null)
 -      {
 -        this.renderOrder = new String[fr.renderOrder.length];
 -        System.arraycopy(fr.renderOrder, 0, renderOrder, 0,
 -                fr.renderOrder.length);
 -      }
 -      if (fr.featureGroups != null)
 -      {
 -        this.featureGroups = new ConcurrentHashMap(fr.featureGroups);
 -      }
 -      if (fr.featureColours != null)
 -      {
 -        this.featureColours = new ConcurrentHashMap(fr.featureColours);
 -      }
 -      Iterator en = fr.featureColours.keySet().iterator();
 -      while (en.hasNext())
 -      {
 -        Object next = en.next();
 -        Object val = featureColours.get(next);
 -        if (val instanceof GraduatedColor)
 -        {
 -          featureColours
 -                  .put(next, new GraduatedColor((GraduatedColor) val));
 -        }
 -      }
 -      this.transparency = fr.transparency;
 -      if (fr.featureOrder != null)
 -      {
 -        this.featureOrder = new ConcurrentHashMap(fr.featureOrder);
 -      }
 -    }
 -  }
 -
 -  public FeatureRendererSettings getSettings()
 -  {
 -    return new FeatureRendererSettings(this);
 -  }
 -
 -  public void transferSettings(FeatureRendererSettings fr)
 -  {
 -    this.renderOrder = fr.renderOrder;
 -    this.featureGroups = fr.featureGroups;
 -    this.featureColours = fr.featureColours;
 -    this.transparency = fr.transparency;
 -    this.featureOrder = fr.featureOrder;
 -  }
 -
 -  /**
 -   * update from another feature renderer
 -   * 
 -   * @param fr
 -   *          settings to copy
 -   */
 -  public void transferSettings(FeatureRenderer fr)
 -  {
 -    FeatureRendererSettings frs = new FeatureRendererSettings(fr);
 -    this.renderOrder = frs.renderOrder;
 -    this.featureGroups = frs.featureGroups;
 -    this.featureColours = frs.featureColours;
 -    this.transparency = frs.transparency;
 -    this.featureOrder = frs.featureOrder;
 -    if (av != null && av != fr.av)
 -    {
 -      // copy over the displayed feature settings
 -      if (fr.av != null)
 -      {
 -        if (fr.av.getFeaturesDisplayed() != null)
 -        {
 -          // update display settings
 -          if (av.getFeaturesDisplayed() == null)
 -          {
 -            av.setFeaturesDisplayed(new Hashtable(fr.av.getFeaturesDisplayed()));
 -          }
 -          else
 -          {
 -            av.getFeaturesDisplayed().clear();
 -            Enumeration en = fr.av.getFeaturesDisplayed().keys();
 -            while (en.hasMoreElements())
 -            {
 -              av.getFeaturesDisplayed().put(en.nextElement(), Boolean.TRUE);
 -            }
 -
 -          }
 -        }
 -      }
 -    }
 -  }
 -
 -  BufferedImage offscreenImage;
 -
 -  boolean offscreenRender = false;
 -
 -  public Color findFeatureColour(Color initialCol, SequenceI seq, int res)
 -  {
 -    return new Color(findFeatureColour(initialCol.getRGB(), seq, res));
 -  }
 -
 -  /**
 -   * This is used by the Molecule Viewer and Overview to get the accurate
 -   * colourof the rendered sequence
 -   */
 -  public synchronized int findFeatureColour(int initialCol, SequenceI seq,
 -          int column)
 -  {
 -    if (!av.showSequenceFeatures)
 -    {
 -      return initialCol;
 -    }
 -
 -    if (seq != lastSeq)
 -    {
 -      lastSeq = seq;
 -      sequenceFeatures = lastSeq.getDatasetSequence().getSequenceFeatures();
 -      if (sequenceFeatures != null)
 -      {
 -        sfSize = sequenceFeatures.length;
 -      }
 -    }
 -
 -    if (sequenceFeatures != lastSeq.getDatasetSequence()
 -            .getSequenceFeatures())
 -    {
 -      sequenceFeatures = lastSeq.getDatasetSequence().getSequenceFeatures();
 -      if (sequenceFeatures != null)
 -      {
 -        sfSize = sequenceFeatures.length;
 -      }
 -    }
 -
 -    if (sequenceFeatures == null || sfSize == 0)
 -    {
 -      return initialCol;
 -    }
 -
 -    if (jalview.util.Comparison.isGap(lastSeq.getCharAt(column)))
 -    {
 -      return Color.white.getRGB();
 -    }
 -
 -    // Only bother making an offscreen image if transparency is applied
 -    if (transparency != 1.0f && offscreenImage == null)
 -    {
 -      offscreenImage = new BufferedImage(1, 1, BufferedImage.TYPE_INT_ARGB);
 -    }
 -
 -    currentColour = null;
 -    // TODO: non-threadsafe - each rendering thread needs its own instance of
 -    // the feature renderer - or this should be synchronized.
 -    offscreenRender = true;
 -
 -    if (offscreenImage != null)
 -    {
 -      offscreenImage.setRGB(0, 0, initialCol);
 -      drawSequence(offscreenImage.getGraphics(), lastSeq, column, column, 0);
 -
 -      return offscreenImage.getRGB(0, 0);
 -    }
 -    else
 -    {
 -      drawSequence(null, lastSeq, lastSeq.findPosition(column), -1, -1);
 -
 -      if (currentColour == null)
 -      {
 -        return initialCol;
 -      }
 -      else
 -      {
 -        return ((Integer) currentColour).intValue();
 -      }
 -    }
 -
 -  }
 -
 -  /**
 -   * DOCUMENT ME!
 -   * 
 -   * @param g
 -   *          DOCUMENT ME!
 -   * @param seq
 -   *          DOCUMENT ME!
 -   * @param sg
 -   *          DOCUMENT ME!
 -   * @param start
 -   *          DOCUMENT ME!
 -   * @param end
 -   *          DOCUMENT ME!
 -   * @param x1
 -   *          DOCUMENT ME!
 -   * @param y1
 -   *          DOCUMENT ME!
 -   * @param width
 -   *          DOCUMENT ME!
 -   * @param height
 -   *          DOCUMENT ME!
 -   */
 -  // String type;
 -  // SequenceFeature sf;
 -  SequenceI lastSeq;
 -
 -  SequenceFeature[] sequenceFeatures;
 -
 -  int sfSize, sfindex, spos, epos;
 -
 -  /**
 -   * show scores as heights
 -   */
 -  protected boolean varyHeight = false;
 -
 -  synchronized public void drawSequence(Graphics g, SequenceI seq,
 -          int start, int end, int y1)
 -  {
 -
 -    if (seq.getDatasetSequence().getSequenceFeatures() == null
 -            || seq.getDatasetSequence().getSequenceFeatures().length == 0)
 -    {
 -      return;
 -    }
 -
 -    if (g != null)
 -    {
 -      fm = g.getFontMetrics();
 -    }
 -
 -    if (av.getFeaturesDisplayed() == null || renderOrder == null
 -            || newFeatureAdded)
 -    {
 -      findAllFeatures();
 -      if (av.getFeaturesDisplayed().size() < 1)
 -      {
 -        return;
 -      }
 -
 -      sequenceFeatures = seq.getDatasetSequence().getSequenceFeatures();
 -    }
 -
 -    if (lastSeq == null
 -            || seq != lastSeq
 -            || seq.getDatasetSequence().getSequenceFeatures() != sequenceFeatures)
 -    {
 -      lastSeq = seq;
 -      sequenceFeatures = seq.getDatasetSequence().getSequenceFeatures();
 -    }
 -
 -    if (transparency != 1 && g != null)
 -    {
 -      Graphics2D g2 = (Graphics2D) g;
 -      g2.setComposite(AlphaComposite.getInstance(AlphaComposite.SRC_OVER,
 -              transparency));
 -    }
 -
 -    if (!offscreenRender)
 -    {
 -      spos = lastSeq.findPosition(start);
 -      epos = lastSeq.findPosition(end);
 -    }
 -
 -    sfSize = sequenceFeatures.length;
 -    String type;
 -    for (int renderIndex = 0; renderIndex < renderOrder.length; renderIndex++)
 -    {
 -      type = renderOrder[renderIndex];
 -
 -      if (type == null || !av.getFeaturesDisplayed().containsKey(type))
 -      {
 -        continue;
 -      }
 -
 -      // loop through all features in sequence to find
 -      // current feature to render
 -      for (sfindex = 0; sfindex < sfSize; sfindex++)
 -      {
 -        if (!sequenceFeatures[sfindex].type.equals(type))
 -        {
 -          continue;
 -        }
 -
 -        if (featureGroups != null
 -                && sequenceFeatures[sfindex].featureGroup != null
 -                && sequenceFeatures[sfindex].featureGroup.length() != 0
 -                && featureGroups
 -                        .containsKey(sequenceFeatures[sfindex].featureGroup)
 -                && !((Boolean) featureGroups
 -                        .get(sequenceFeatures[sfindex].featureGroup))
 -                        .booleanValue())
 -        {
 -          continue;
 -        }
 -
 -        if (!offscreenRender
 -                && (sequenceFeatures[sfindex].getBegin() > epos || sequenceFeatures[sfindex]
 -                        .getEnd() < spos))
 -        {
 -          continue;
 -        }
 -
 -        if (offscreenRender && offscreenImage == null)
 -        {
 -          if (sequenceFeatures[sfindex].begin <= start
 -                  && sequenceFeatures[sfindex].end >= start)
 -          {
 -            // this is passed out to the overview and other sequence renderers
 -            // (e.g. molecule viewer) to get displayed colour for rendered
 -            // sequence
 -            currentColour = new Integer(
 -                    getColour(sequenceFeatures[sfindex]).getRGB());
 -            // used to be retreived from av.featuresDisplayed
 -            // currentColour = av.featuresDisplayed
 -            // .get(sequenceFeatures[sfindex].type);
 -
 -          }
 -        }
 -        else if (sequenceFeatures[sfindex].type.equals("disulfide bond"))
 -        {
 -
 -          renderFeature(g, seq,
 -                  seq.findIndex(sequenceFeatures[sfindex].begin) - 1,
 -                  seq.findIndex(sequenceFeatures[sfindex].begin) - 1,
 -                  getColour(sequenceFeatures[sfindex])
 -                  // new Color(((Integer) av.featuresDisplayed
 -                  // .get(sequenceFeatures[sfindex].type)).intValue())
 -                  , start, end, y1);
 -          renderFeature(g, seq,
 -                  seq.findIndex(sequenceFeatures[sfindex].end) - 1,
 -                  seq.findIndex(sequenceFeatures[sfindex].end) - 1,
 -                  getColour(sequenceFeatures[sfindex])
 -                  // new Color(((Integer) av.featuresDisplayed
 -                  // .get(sequenceFeatures[sfindex].type)).intValue())
 -                  , start, end, y1);
 -
 -        }
 -        else if (showFeature(sequenceFeatures[sfindex]))
 -        {
 -          if (av.showSeqFeaturesHeight
 -                  && sequenceFeatures[sfindex].score != Float.NaN)
 -          {
 -            renderScoreFeature(g, seq,
 -                    seq.findIndex(sequenceFeatures[sfindex].begin) - 1,
 -                    seq.findIndex(sequenceFeatures[sfindex].end) - 1,
 -                    getColour(sequenceFeatures[sfindex]), start, end, y1,
 -                    normaliseScore(sequenceFeatures[sfindex]));
 -          }
 -          else
 -          {
 -            renderFeature(g, seq,
 -                    seq.findIndex(sequenceFeatures[sfindex].begin) - 1,
 -                    seq.findIndex(sequenceFeatures[sfindex].end) - 1,
 -                    getColour(sequenceFeatures[sfindex]), start, end, y1);
 -          }
 -        }
 -
 -      }
 -
 -    }
 -
 -    if (transparency != 1.0f && g != null)
 -    {
 -      Graphics2D g2 = (Graphics2D) g;
 -      g2.setComposite(AlphaComposite.getInstance(AlphaComposite.SRC_OVER,
 -              1.0f));
 -    }
 -  }
 -
 -  Hashtable minmax = new Hashtable();
 -
 -  /**
 -   * normalise a score against the max/min bounds for the feature type.
 -   * 
 -   * @param sequenceFeature
 -   * @return byte[] { signed, normalised signed (-127 to 127) or unsigned
 -   *         (0-255) value.
 -   */
 -  private final byte[] normaliseScore(SequenceFeature sequenceFeature)
 -  {
 -    float[] mm = ((float[][]) minmax.get(sequenceFeature.type))[0];
 -    final byte[] r = new byte[]
 -    { 0, (byte) 255 };
 -    if (mm != null)
 -    {
 -      if (r[0] != 0 || mm[0] < 0.0)
 -      {
 -        r[0] = 1;
 -        r[1] = (byte) ((int) 128.0 + 127.0 * (sequenceFeature.score / mm[1]));
 -      }
 -      else
 -      {
 -        r[1] = (byte) ((int) 255.0 * (sequenceFeature.score / mm[1]));
 -      }
 -    }
 -    return r;
 -  }
 -
 -  char s;
 -
 -  int i;
 -
 -  void renderFeature(Graphics g, SequenceI seq, int fstart, int fend,
 -          Color featureColour, int start, int end, int y1)
 -  {
 -
 -    if (((fstart <= end) && (fend >= start)))
 -    {
 -      if (fstart < start)
 -      { // fix for if the feature we have starts before the sequence start,
 -        fstart = start; // but the feature end is still valid!!
 -      }
 -
 -      if (fend >= end)
 -      {
 -        fend = end;
 -      }
 -      int pady = (y1 + av.charHeight) - av.charHeight / 5;
 -      for (i = fstart; i <= fend; i++)
 -      {
 -        s = seq.getCharAt(i);
 -
 -        if (jalview.util.Comparison.isGap(s))
 -        {
 -          continue;
 -        }
 -
 -        g.setColor(featureColour);
 -
 -        g.fillRect((i - start) * av.charWidth, y1, av.charWidth,
 -                av.charHeight);
 -
 -        if (offscreenRender || !av.validCharWidth)
 -        {
 -          continue;
 -        }
 -
 -        g.setColor(Color.white);
 -        charOffset = (av.charWidth - fm.charWidth(s)) / 2;
 -        g.drawString(String.valueOf(s), charOffset
 -                + (av.charWidth * (i - start)), pady);
 -
 -      }
 -    }
 -  }
 -
 -  void renderScoreFeature(Graphics g, SequenceI seq, int fstart, int fend,
 -          Color featureColour, int start, int end, int y1, byte[] bs)
 -  {
 -
 -    if (((fstart <= end) && (fend >= start)))
 -    {
 -      if (fstart < start)
 -      { // fix for if the feature we have starts before the sequence start,
 -        fstart = start; // but the feature end is still valid!!
 -      }
 -
 -      if (fend >= end)
 -      {
 -        fend = end;
 -      }
 -      int pady = (y1 + av.charHeight) - av.charHeight / 5;
 -      int ystrt = 0, yend = av.charHeight;
 -      if (bs[0] != 0)
 -      {
 -        // signed - zero is always middle of residue line.
 -        if (bs[1] < 128)
 -        {
 -          yend = av.charHeight * (128 - bs[1]) / 512;
 -          ystrt = av.charHeight - yend / 2;
 -        }
 -        else
 -        {
 -          ystrt = av.charHeight / 2;
 -          yend = av.charHeight * (bs[1] - 128) / 512;
 -        }
 -      }
 -      else
 -      {
 -        yend = av.charHeight * bs[1] / 255;
 -        ystrt = av.charHeight - yend;
 -
 -      }
 -      for (i = fstart; i <= fend; i++)
 -      {
 -        s = seq.getCharAt(i);
 -
 -        if (jalview.util.Comparison.isGap(s))
 -        {
 -          continue;
 -        }
 -
 -        g.setColor(featureColour);
 -        int x = (i - start) * av.charWidth;
 -        g.drawRect(x, y1, av.charWidth, av.charHeight);
 -        g.fillRect(x, y1 + ystrt, av.charWidth, yend);
 -
 -        if (offscreenRender || !av.validCharWidth)
 -        {
 -          continue;
 -        }
 -
 -        g.setColor(Color.black);
 -        charOffset = (av.charWidth - fm.charWidth(s)) / 2;
 -        g.drawString(String.valueOf(s), charOffset
 -                + (av.charWidth * (i - start)), pady);
 -
 -      }
 -    }
 -  }
 -
 -  boolean newFeatureAdded = false;
 -
 -  /**
 -   * Called when alignment in associated view has new/modified features to
 -   * discover and display.
 -   * 
 -   */
 -  public void featuresAdded()
 -  {
 -    lastSeq = null;
 -    findAllFeatures();
 -  }
 -
 -  boolean findingFeatures = false;
 -
 -  /**
 -   * search the alignment for all new features, give them a colour and display
 -   * them. Then fires a PropertyChangeEvent on the changeSupport object.
 -   * 
 -   */
 -  void findAllFeatures()
 -  {
 -    synchronized (firing)
 -    {
 -      if (firing.equals(Boolean.FALSE))
 -      {
 -        firing = Boolean.TRUE;
 -        findAllFeatures(true); // add all new features as visible
 -        changeSupport.firePropertyChange("changeSupport", null, null);
 -        firing = Boolean.FALSE;
 -      }
 -    }
 -  }
 -
 -  /**
 -   * Searches alignment for all features and updates colours
 -   * 
 -   * @param newMadeVisible
 -   *          if true newly added feature types will be rendered immediatly
 -   */
 -  synchronized void findAllFeatures(boolean newMadeVisible)
 -  {
 -    newFeatureAdded = false;
 -
 -    if (findingFeatures)
 -    {
 -      newFeatureAdded = true;
 -      return;
 -    }
 -
 -    findingFeatures = true;
 -
 -    if (av.getFeaturesDisplayed() == null)
 -    {
 -      av.setFeaturesDisplayed(new Hashtable());
 -    }
 -
 -    allfeatures = new Vector();
 -    Vector oldfeatures = new Vector();
 -    if (renderOrder != null)
 -    {
 -      for (int i = 0; i < renderOrder.length; i++)
 -      {
 -        if (renderOrder[i] != null)
 -        {
 -          oldfeatures.addElement(renderOrder[i]);
 -        }
 -      }
 -    }
 -    if (minmax == null)
 -    {
 -      minmax = new Hashtable();
 -    }
 -    AlignmentI alignment = av.getAlignment();
 -    for (int i = 0; i < alignment.getHeight(); i++)
 -    {
 -      SequenceFeature[] features = alignment.getSequenceAt(i)
 -              .getDatasetSequence().getSequenceFeatures();
 -
 -      if (features == null)
 -      {
 -        continue;
 -      }
 -
 -      int index = 0;
 -      while (index < features.length)
 -      {
 -        if (!av.getFeaturesDisplayed().containsKey(features[index].getType()))
 -        {
 -
 -          if (featureGroups.containsKey(features[index].getType()))
 -          {
 -            boolean visible = ((Boolean) featureGroups
 -                    .get(features[index].featureGroup)).booleanValue();
 -
 -            if (!visible)
 -            {
 -              index++;
 -              continue;
 -            }
 -          }
 -
 -          if (!(features[index].begin == 0 && features[index].end == 0))
 -          {
 -            // If beginning and end are 0, the feature is for the whole sequence
 -            // and we don't want to render the feature in the normal way
 -
 -            if (newMadeVisible
 -                    && !oldfeatures.contains(features[index].getType()))
 -            {
 -              // this is a new feature type on the alignment. Mark it for
 -              // display.
 -              av.getFeaturesDisplayed().put(features[index].getType(),
 -                      new Integer(getColour(features[index].getType())
 -                              .getRGB()));
 -              setOrder(features[index].getType(), 0);
 -            }
 -          }
 -        }
 -        if (!allfeatures.contains(features[index].getType()))
 -        {
 -          allfeatures.addElement(features[index].getType());
 -        }
 -        if (features[index].score != Float.NaN)
 -        {
 -          int nonpos = features[index].getBegin() >= 1 ? 0 : 1;
 -          float[][] mm = (float[][]) minmax.get(features[index].getType());
 -          if (mm == null)
 -          {
 -            mm = new float[][]
 -            { null, null };
 -            minmax.put(features[index].getType(), mm);
 -          }
 -          if (mm[nonpos] == null)
 -          {
 -            mm[nonpos] = new float[]
 -            { features[index].score, features[index].score };
 -
 -          }
 -          else
 -          {
 -            if (mm[nonpos][0] > features[index].score)
 -            {
 -              mm[nonpos][0] = features[index].score;
 -            }
 -            if (mm[nonpos][1] < features[index].score)
 -            {
 -              mm[nonpos][1] = features[index].score;
 -            }
 -          }
 -        }
 -        index++;
 -      }
 -    }
 -    updateRenderOrder(allfeatures);
 -    findingFeatures = false;
 -  }
 -
 -  protected Boolean firing = Boolean.FALSE;
 -
 -  /**
 -   * replaces the current renderOrder with the unordered features in
 -   * allfeatures. The ordering of any types in both renderOrder and allfeatures
 -   * is preserved, and all new feature types are rendered on top of the existing
 -   * types, in the order given by getOrder or the order given in allFeatures.
 -   * Note. this operates directly on the featureOrder hash for efficiency. TODO:
 -   * eliminate the float storage for computing/recalling the persistent ordering
 -   * New Cability: updates min/max for colourscheme range if its dynamic
 -   * 
 -   * @param allFeatures
 -   */
 -  private void updateRenderOrder(Vector allFeatures)
 -  {
 -    Vector allfeatures = new Vector(allFeatures);
 -    String[] oldRender = renderOrder;
 -    renderOrder = new String[allfeatures.size()];
 -    Object mmrange, fc = null;
 -    boolean initOrders = (featureOrder == null);
 -    int opos = 0;
 -    if (oldRender != null && oldRender.length > 0)
 -    {
 -      for (int j = 0; j < oldRender.length; j++)
 -      {
 -        if (oldRender[j] != null)
 -        {
 -          if (initOrders)
 -          {
 -            setOrder(oldRender[j], (1 - (1 + (float) j)
 -                    / (float) oldRender.length));
 -          }
 -          if (allfeatures.contains(oldRender[j]))
 -          {
 -            renderOrder[opos++] = oldRender[j]; // existing features always
 -            // appear below new features
 -            allfeatures.removeElement(oldRender[j]);
 -            if (minmax != null)
 -            {
 -              mmrange = minmax.get(oldRender[j]);
 -              if (mmrange != null)
 -              {
 -                fc = featureColours.get(oldRender[j]);
 -                if (fc != null && fc instanceof GraduatedColor
 -                        && ((GraduatedColor) fc).isAutoScale())
 -                {
 -                  ((GraduatedColor) fc).updateBounds(
 -                          ((float[][]) mmrange)[0][0],
 -                          ((float[][]) mmrange)[0][1]);
 -                }
 -              }
 -            }
 -          }
 -        }
 -      }
 -    }
 -    if (allfeatures.size() == 0)
 -    {
 -      // no new features - leave order unchanged.
 -      return;
 -    }
 -    int i = allfeatures.size() - 1;
 -    int iSize = i;
 -    boolean sort = false;
 -    String[] newf = new String[allfeatures.size()];
 -    float[] sortOrder = new float[allfeatures.size()];
 -    Enumeration en = allfeatures.elements();
 -    // sort remaining elements
 -    while (en.hasMoreElements())
 -    {
 -      newf[i] = en.nextElement().toString();
 -      if (minmax != null)
 -      {
 -        // update from new features minmax if necessary
 -        mmrange = minmax.get(newf[i]);
 -        if (mmrange != null)
 -        {
 -          fc = featureColours.get(newf[i]);
 -          if (fc != null && fc instanceof GraduatedColor
 -                  && ((GraduatedColor) fc).isAutoScale())
 -          {
 -            ((GraduatedColor) fc).updateBounds(((float[][]) mmrange)[0][0],
 -                    ((float[][]) mmrange)[0][1]);
 -          }
 -        }
 -      }
 -      if (initOrders || !featureOrder.containsKey(newf[i]))
 -      {
 -        int denom = initOrders ? allfeatures.size() : featureOrder.size();
 -        // new unordered feature - compute persistent ordering at head of
 -        // existing features.
 -        setOrder(newf[i], i / (float) denom);
 -      }
 -      // set order from newly found feature from persisted ordering.
 -      sortOrder[i] = 2 - ((Float) featureOrder.get(newf[i])).floatValue();
 -      if (i < iSize)
 -      {
 -        // only sort if we need to
 -        sort = sort || sortOrder[i] > sortOrder[i + 1];
 -      }
 -      i--;
 -    }
 -    if (iSize > 1 && sort)
 -    {
 -      jalview.util.QuickSort.sort(sortOrder, newf);
 -    }
 -    sortOrder = null;
 -    System.arraycopy(newf, 0, renderOrder, opos, newf.length);
 -  }
 -
 -  /**
 -   * get a feature style object for the given type string. Creates a
 -   * java.awt.Color for a featureType with no existing colourscheme. TODO:
 -   * replace return type with object implementing standard abstract colour/style
 -   * interface
 -   * 
 -   * @param featureType
 -   * @return java.awt.Color or GraduatedColor
 -   */
 -  public Object getFeatureStyle(String featureType)
 -  {
 -    Object fc = featureColours.get(featureType);
 -    if (fc == null)
 -    {
 -      jalview.schemes.UserColourScheme ucs = new jalview.schemes.UserColourScheme();
 -      Color col = ucs.createColourFromName(featureType);
 -      featureColours.put(featureType, fc = col);
 -    }
 -    return fc;
 -  }
 -
 -  /**
 -   * return a nominal colour for this feature
 -   * 
 -   * @param featureType
 -   * @return standard color, or maximum colour for graduated colourscheme
 -   */
 -  public Color getColour(String featureType)
 -  {
 -    Object fc = getFeatureStyle(featureType);
 -
 -    if (fc instanceof Color)
 -    {
 -      return (Color) fc;
 -    }
 -    else
 -    {
 -      if (fc instanceof GraduatedColor)
 -      {
 -        return ((GraduatedColor) fc).getMaxColor();
 -      }
 -    }
 -    throw new Error(MessageManager.formatMessage("error.implementation_error_unrecognised_render_object_for_features_type", new String[]{fc.getClass().toString(),featureType}));
 -  }
 -
 -  /**
 -   * calculate the render colour for a specific feature using current feature
 -   * settings.
 -   * 
 -   * @param feature
 -   * @return render colour for the given feature
 -   */
 -  public Color getColour(SequenceFeature feature)
 -  {
 -    Object fc = getFeatureStyle(feature.getType());
 -    if (fc instanceof Color)
 -    {
 -      return (Color) fc;
 -    }
 -    else
 -    {
 -      if (fc instanceof GraduatedColor)
 -      {
 -        return ((GraduatedColor) fc).findColor(feature);
 -      }
 -    }
 -    throw new Error(MessageManager.formatMessage("error.implementation_error_unrecognised_render_object_for_features_type", new String[]{fc.getClass().toString(),feature.getType()}));
 -  }
 -
 -  private boolean showFeature(SequenceFeature sequenceFeature)
 -  {
 -    Object fc = getFeatureStyle(sequenceFeature.type);
 -    if (fc instanceof GraduatedColor)
 -    {
 -      return ((GraduatedColor) fc).isColored(sequenceFeature);
 -    }
 -    else
 -    {
 -      return true;
 -    }
 -  }
 -
    // // /////////////
    // // Feature Editing Dialog
    // // Will be refactored in next release.
        lastDescriptionAdded = description.getText().replaceAll("\n", " ");
        // TODO: determine if the null feature group is valid
        if (lastFeatureGroupAdded.length() < 1)
++      {
          lastFeatureGroupAdded = null;
++      }
      }
  
      if (!newFeatures)
          sf.description = lastDescriptionAdded;
  
          setColour(sf.type, fcol);
 -        av.getFeaturesDisplayed().put(sf.type, getColour(sf.type));
 +        getFeaturesDisplayed().setVisible(sf.type);
  
          try
          {
          for (int i = 0; i < sequences.length; i++)
          {
            features[i].type = lastFeatureAdded;
 -          if (lastFeatureGroupAdded != null)
 -            features[i].featureGroup = lastFeatureGroupAdded;
 +          // fix for JAL-1538 - always set feature group here
 +          features[i].featureGroup = lastFeatureGroupAdded;
            features[i].description = lastDescriptionAdded;
            sequences[i].addSequenceFeature(features[i]);
            ffile.parseDescriptionHTML(features[i], false);
          }
  
-         
 -        if (av.getFeaturesDisplayed() == null)
 -        {
 -          av.setFeaturesDisplayed(new Hashtable());
 -        }
 -
          if (lastFeatureGroupAdded != null)
          {
 -          if (featureGroups == null)
 -            featureGroups = new Hashtable();
 -          featureGroups.put(lastFeatureGroupAdded, new Boolean(true));
 +          setGroupVisibility(lastFeatureGroupAdded, true);
          }
          setColour(lastFeatureAdded, fcol);
 -        av.getFeaturesDisplayed().put(lastFeatureAdded,
 -                getColour(lastFeatureAdded));
 +        setVisible(lastFeatureAdded);
  
          findAllFeatures(false);
  
      return true;
    }
  
 +
    /**
     * update the amend feature button dependent on the given style
     * 
        // colour.setForeground(colour.getBackground());
      }
    }
 -
 -  public void setColour(String featureType, Object col)
 -  {
 -    // overwrite
 -    // Color _col = (col instanceof Color) ? ((Color) col) : (col instanceof
 -    // GraduatedColor) ? ((GraduatedColor) col).getMaxColor() : null;
 -    // Object c = featureColours.get(featureType);
 -    // if (c == null || c instanceof Color || (c instanceof GraduatedColor &&
 -    // !((GraduatedColor)c).getMaxColor().equals(_col)))
 -    {
 -      featureColours.put(featureType, col);
 -    }
 -  }
 -
 -  public void setTransparency(float value)
 -  {
 -    transparency = value;
 -  }
 -
 -  public float getTransparency()
 -  {
 -    return transparency;
 -  }
 -
 -  /**
 -   * Replace current ordering with new ordering
 -   * 
 -   * @param data
 -   *          { String(Type), Colour(Type), Boolean(Displayed) }
 -   */
 -  public void setFeaturePriority(Object[][] data)
 -  {
 -    setFeaturePriority(data, true);
 -  }
 -
 -  /**
 -   * 
 -   * @param data
 -   *          { String(Type), Colour(Type), Boolean(Displayed) }
 -   * @param visibleNew
 -   *          when true current featureDisplay list will be cleared
 -   */
 -  public void setFeaturePriority(Object[][] data, boolean visibleNew)
 -  {
 -    if (visibleNew)
 -    {
 -      if (av.getFeaturesDisplayed() != null)
 -      {
 -        av.getFeaturesDisplayed().clear();
 -      }
 -      else
 -      {
 -        av.setFeaturesDisplayed(new Hashtable());
 -      }
 -    }
 -    if (data == null)
 -    {
 -      return;
 -    }
 -
 -    // The feature table will display high priority
 -    // features at the top, but theses are the ones
 -    // we need to render last, so invert the data
 -    renderOrder = new String[data.length];
 -
 -    if (data.length > 0)
 -    {
 -      for (int i = 0; i < data.length; i++)
 -      {
 -        String type = data[i][0].toString();
 -        setColour(type, data[i][1]); // todo : typesafety - feature color
 -        // interface object
 -        if (((Boolean) data[i][2]).booleanValue())
 -        {
 -          av.getFeaturesDisplayed().put(type, new Integer(getColour(type)
 -                  .getRGB()));
 -        }
 -
 -        renderOrder[data.length - i - 1] = type;
 -      }
 -    }
 -
 -  }
 -
 -  Map featureOrder = null;
 -
 -  /**
 -   * analogous to colour - store a normalized ordering for all feature types in
 -   * this rendering context.
 -   * 
 -   * @param type
 -   *          Feature type string
 -   * @param position
 -   *          normalized priority - 0 means always appears on top, 1 means
 -   *          always last.
 -   */
 -  public float setOrder(String type, float position)
 -  {
 -    if (featureOrder == null)
 -    {
 -      featureOrder = new Hashtable();
 -    }
 -    featureOrder.put(type, new Float(position));
 -    return position;
 -  }
 -
 -  /**
 -   * get the global priority (0 (top) to 1 (bottom))
 -   * 
 -   * @param type
 -   * @return [0,1] or -1 for a type without a priority
 -   */
 -  public float getOrder(String type)
 -  {
 -    if (featureOrder != null)
 -    {
 -      if (featureOrder.containsKey(type))
 -      {
 -        return ((Float) featureOrder.get(type)).floatValue();
 -      }
 -    }
 -    return -1;
 -  }
 -
 -  /**
 -   * @param listener
 -   * @see java.beans.PropertyChangeSupport#addPropertyChangeListener(java.beans.PropertyChangeListener)
 -   */
 -  public void addPropertyChangeListener(PropertyChangeListener listener)
 -  {
 -    changeSupport.addPropertyChangeListener(listener);
 -  }
 -
 -  /**
 -   * @param listener
 -   * @see java.beans.PropertyChangeSupport#removePropertyChangeListener(java.beans.PropertyChangeListener)
 -   */
 -  public void removePropertyChangeListener(PropertyChangeListener listener)
 -  {
 -    changeSupport.removePropertyChangeListener(listener);
 -  }
  }
   */
  package jalview.gui;
  
 -import jalview.analysis.AlignmentSorter;
  import jalview.bin.Cache;
 -import jalview.commands.OrderCommand;
 -import jalview.datamodel.AlignmentI;
  import jalview.datamodel.SequenceFeature;
 -import jalview.datamodel.SequenceGroup;
  import jalview.datamodel.SequenceI;
  import jalview.gui.Help.HelpId;
  import jalview.io.JalviewFileChooser;
@@@ -52,10 -56,10 +52,10 @@@ import java.io.FileOutputStream
  import java.io.InputStreamReader;
  import java.io.OutputStreamWriter;
  import java.io.PrintWriter;
  import java.util.Hashtable;
  import java.util.Iterator;
  import java.util.List;
 +import java.util.Set;
  import java.util.Vector;
  
  import javax.help.HelpSetException;
@@@ -103,8 -107,6 +103,8 @@@ public class FeatureSettings extends JP
  
    Object[][] originalData;
  
 +  private float originalTransparency;
 +
    final JInternalFrame frame;
  
    JScrollPane scrollPane = new JScrollPane();
    {
      this.af = af;
      fr = af.getFeatureRenderer();
 -
 -    transparency.setMaximum(100 - (int) (fr.transparency * 100));
 +    // allow transparency to be recovered
 +    transparency.setMaximum(100 - (int) ((originalTransparency=fr.getTransparency()) * 100));
  
      try
      {
          if (SwingUtilities.isRightMouseButton(evt))
          {
            popupSort(selectedRow, (String) table.getValueAt(selectedRow, 0),
 -                  table.getValueAt(selectedRow, 1), fr.minmax, evt.getX(),
 -                  evt.getY());
 +                  table.getValueAt(selectedRow, 1), fr.getMinMax(),
 +                  evt.getX(), evt.getY());
          }
          else if (evt.getClickCount() == 2)
          {
          if (evt.isPopupTrigger())
          {
            popupSort(selectedRow, (String) table.getValueAt(selectedRow, 0),
 -                  table.getValueAt(selectedRow, 1), fr.minmax, evt.getX(),
 +                  table.getValueAt(selectedRow, 1), fr.getMinMax(),
 +                  evt.getX(),
                    evt.getY());
          }
        }
      dassourceBrowser = new DasSourceBrowser(this);
      dasSettingsPane.add(dassourceBrowser, BorderLayout.CENTER);
  
 -    if (af.getViewport().getFeaturesDisplayed() == null
 -            || fr.renderOrder == null)
 +    if (af.getViewport().isShowSequenceFeatures() || !fr.hasRenderOrder())
      {
        fr.findAllFeatures(true); // display everything!
      }
  
        public void actionPerformed(ActionEvent e)
        {
 -        me.sortByScore(new String[]
 +        me.af.avc.sortAlignmentByFeatureScore(new String[]
          { type });
        }
  
  
        public void actionPerformed(ActionEvent e)
        {
 -        me.sortByDens(new String[]
 +        me.af.avc.sortAlignmentByFeatureDensity(new String[]
          { type });
        }
  
  
    synchronized public void setTableData()
    {
 -    if (fr.featureGroups == null)
 -    {
 -      fr.featureGroups = new Hashtable();
 -    }
      Vector allFeatures = new Vector();
      Vector allGroups = new Vector();
      SequenceFeature[] tmpfeatures;
            if (!allGroups.contains(group))
            {
              allGroups.addElement(group);
 -            if (group != null)
 -            {
 -              checkGroupState(group);
 -            }
 +            checkGroupState(group);
            }
          }
  
    }
  
    /**
 +   * Synchronise gui group list and check visibility of group
     * 
     * @param group
 -   * @return true if group has been seen before and is already added to set.
 +   * @return true if group is visible
     */
    private boolean checkGroupState(String group)
    {
 -    boolean visible;
 -    if (fr.featureGroups.containsKey(group))
 -    {
 -      visible = ((Boolean) fr.featureGroups.get(group)).booleanValue();
 -    }
 -    else
 -    {
 -      visible = true; // new group is always made visible
 -    }
 +    boolean visible = fr.checkGroupVisibility(group, true);
  
      if (groupPanel == null)
      {
      if (alreadyAdded)
      {
  
 -      return true;
 +      return visible;
      }
 -
 -    fr.featureGroups.put(group, new Boolean(visible));
      final String grp = group;
      final JCheckBox check = new JCheckBox(group, visible);
      check.setFont(new Font("Serif", Font.BOLD, 12));
      {
        public void itemStateChanged(ItemEvent evt)
        {
 -        fr.featureGroups.put(check.getText(),
 -                new Boolean(check.isSelected()));
 +        fr.setGroupVisibility(check.getText(), check.isSelected());
          af.alignPanel.getSeqPanel().seqCanvas.repaint();
          if (af.alignPanel.overviewPanel != null)
          {
        }
      });
      groupPanel.add(check);
 -    return false;
 +    return visible;
    }
  
    boolean resettingTable = false;
            continue;
          }
  
 -        if (group == null || fr.featureGroups.get(group) == null
 -                || ((Boolean) fr.featureGroups.get(group)).booleanValue())
 +        if (group == null || checkGroupState(group))
          {
 -          if (group != null)
 -          {
 -            checkGroupState(group);
 -          }
            type = tmpfeatures[index].getType();
            if (!visibleChecks.contains(type))
            {
      Object[][] data = new Object[fSize][3];
      int dataIndex = 0;
  
 -    if (fr.renderOrder != null)
 +    if (fr.hasRenderOrder())
      {
        if (!handlingUpdate)
 -       {
 +      {
          fr.findAllFeatures(groupChanged != null); // prod to update
 +        // colourschemes. but don't
 +        // affect display
 +        // First add the checks in the previous render order,
 +        // in case the window has been closed and reopened
        }
 -      // colourschemes. but don't
 -      // affect display
 -      // First add the checks in the previous render order,
 -      // in case the window has been closed and reopened
 -      for (int ro = fr.renderOrder.length - 1; ro > -1; ro--)
 +      List<String> frl = fr.getRenderOrder();
 +      for (int ro = frl.size() - 1; ro > -1; ro--)
        {
 -        type = fr.renderOrder[ro];
 +        type = frl.get(ro);
  
          if (!visibleChecks.contains(type))
          {
  
          data[dataIndex][0] = type;
          data[dataIndex][1] = fr.getFeatureStyle(type);
 -        data[dataIndex][2] = new Boolean(
 -                af.getViewport().getFeaturesDisplayed().containsKey(type));
 +        data[dataIndex][2] = new Boolean(af.getViewport()
 +                .getFeaturesDisplayed().isVisible(type));
          dataIndex++;
          visibleChecks.removeElement(type);
        }
        if (data[dataIndex][1] == null)
        {
          // "Colour has been updated in another view!!"
 -        fr.renderOrder = null;
 +        fr.clearRenderOrder();
          return;
        }
  
  
      if (groupPanel != null)
      {
 -      groupPanel.setLayout(new GridLayout(fr.featureGroups.size() / 4 + 1,
 -              4));
 +      groupPanel.setLayout(new GridLayout(
 +              fr.getFeatureGroupsSize() / 4 + 1, 4));
  
        groupPanel.validate();
        bigPanel.add(groupPanel, BorderLayout.NORTH);
          PrintWriter out = new PrintWriter(new OutputStreamWriter(
                  new FileOutputStream(choice), "UTF-8"));
  
 -        Iterator e = fr.featureColours.keySet().iterator();
 -        float[] sortOrder = new float[fr.featureColours.size()];
 -        String[] sortTypes = new String[fr.featureColours.size()];
 +        Set fr_colours = fr.getAllFeatureColours();
 +        Iterator e = fr_colours.iterator();
 +        float[] sortOrder = new float[fr_colours.size()];
 +        String[] sortTypes = new String[fr_colours.size()];
          int i = 0;
          while (e.hasNext())
          {
      {
        public void actionPerformed(ActionEvent e)
        {
 -        sortByScore(null);
 +        af.avc.sortAlignmentByFeatureScore(null);
        }
      });
      sortByDens.setFont(JvSwingUtils.getLabelFont());
      {
        public void actionPerformed(ActionEvent e)
        {
 -        sortByDens(null);
 +        af.avc.sortAlignmentByFeatureDensity(null);
 +      }
 +    });
 +    help.setFont(JvSwingUtils.getLabelFont());
 +    help.setText(MessageManager.getString("action.help"));
 +    help.addActionListener(new ActionListener()
 +    {
 +      public void actionPerformed(ActionEvent e)
 +      {
++        try
++        {
++          Help.showHelpWindow(HelpId.SequenceFeatureSettings);
++        } catch (HelpSetException e1)
++        {
++          e1.printStackTrace();
++        }
+       }
+     });
+     help.setFont(JvSwingUtils.getLabelFont());
+     help.setText(MessageManager.getString("action.help"));
+     help.addActionListener(new ActionListener()
+     {
+       public void actionPerformed(ActionEvent e)
+       {
          try
          {
            Help.showHelpWindow(HelpId.SequenceFeatureSettings);
      {
        public void actionPerformed(ActionEvent e)
        {
 +        fr.setTransparency(originalTransparency);
          updateFeatureRenderer(originalData);
          close();
        }
      settingsPane.add(buttonPanel, java.awt.BorderLayout.SOUTH);
    }
  
 -  protected void sortByDens(String[] typ)
 -  {
 -    sortBy(typ, "Sort by Density", AlignmentSorter.FEATURE_DENSITY);
 -  }
 -
 -  protected void sortBy(String[] typ, String methodText, final String method)
 -  {
 -    if (typ == null)
 -    {
 -      typ = getDisplayedFeatureTypes();
 -    }
 -    String gps[] = null;
 -    gps = getDisplayedFeatureGroups();
 -    if (typ != null)
 -    {
 -      ArrayList types = new ArrayList();
 -      for (int i = 0; i < typ.length; i++)
 -      {
 -        if (typ[i] != null)
 -        {
 -          types.add(typ[i]);
 -        }
 -        typ = new String[types.size()];
 -        types.toArray(typ);
 -      }
 -    }
 -    if (gps != null)
 -    {
 -      ArrayList grps = new ArrayList();
 -
 -      for (int i = 0; i < gps.length; i++)
 -      {
 -        if (gps[i] != null)
 -        {
 -          grps.add(gps[i]);
 -        }
 -      }
 -      gps = new String[grps.size()];
 -      grps.toArray(gps);
 -    }
 -    AlignmentPanel alignPanel = af.alignPanel;
 -    AlignmentI al = alignPanel.av.getAlignment();
 -
 -    int start, stop;
 -    SequenceGroup sg = alignPanel.av.getSelectionGroup();
 -    if (sg != null)
 -    {
 -      start = sg.getStartRes();
 -      stop = sg.getEndRes();
 -    }
 -    else
 -    {
 -      start = 0;
 -      stop = al.getWidth();
 -    }
 -    SequenceI[] oldOrder = al.getSequencesArray();
 -    AlignmentSorter.sortByFeature(typ, gps, start, stop, al, method);
 -    af.addHistoryItem(new OrderCommand(methodText, oldOrder, alignPanel.av
 -            .getAlignment()));
 -    alignPanel.paintAlignment(true);
 -
 -  }
 -
 -  protected void sortByScore(String[] typ)
 -  {
 -    sortBy(typ, "Sort by Feature Score", AlignmentSorter.FEATURE_SCORE);
 -  }
 -
 -  private String[] getDisplayedFeatureTypes()
 -  {
 -    String[] typ = null;
 -    if (fr != null)
 -    {
 -      synchronized (fr.renderOrder)
 -      {
 -        typ = new String[fr.renderOrder.length];
 -        System.arraycopy(fr.renderOrder, 0, typ, 0, typ.length);
 -        for (int i = 0; i < typ.length; i++)
 -        {
 -          if (af.viewport.getFeaturesDisplayed().get(typ[i]) == null)
 -          {
 -            typ[i] = null;
 -          }
 -        }
 -      }
 -    }
 -    return typ;
 -  }
 -
 -  private String[] getDisplayedFeatureGroups()
 -  {
 -    String[] gps = null;
 -    ArrayList<String> _gps = new ArrayList<String>();
 -    if (fr != null)
 -    {
 -
 -      if (fr.featureGroups != null)
 -      {
 -        Iterator en = fr.featureGroups.keySet().iterator();
 -        int g = 0;
 -        boolean valid = false;
 -        while (en.hasNext())
 -        {
 -          String gp = (String) en.next();
 -          Boolean on = (Boolean) fr.featureGroups.get(gp);
 -          if (on != null && on.booleanValue())
 -          {
 -            valid = true;
 -            _gps.add(gp);
 -          }
 -        }
 -        if (!valid)
 -        {
 -          return null;
 -        }
 -        else
 -        {
 -          gps = new String[_gps.size()];
 -          _gps.toArray(gps);
 -        }
 -      }
 -    }
 -    return gps;
 -  }
 -
    public void fetchDAS_actionPerformed(ActionEvent e)
    {
      fetchDAS.setEnabled(false);
@@@ -40,6 -40,6 +40,7 @@@ import jalview.schemes.ResiduePropertie
  import jalview.structure.StructureSelectionManager;
  import jalview.util.MessageManager;
  import jalview.util.jarInputStreamProvider;
++import jalview.viewmodel.seqfeatures.FeatureRendererSettings;
  
  import java.io.InputStreamReader;
  import java.util.Hashtable;
@@@ -49,10 -49,7 +50,7 @@@ import java.util.jar.JarInputStream
  
  import javax.swing.JOptionPane;
  
- import jalview.util.MessageManager;
- import jalview.util.jarInputStreamProvider;
  import org.exolab.castor.xml.IDResolver;
- import jalview.viewmodel.seqfeatures.FeatureRendererSettings;
  
  /**
   * DOCUMENT ME!
@@@ -414,31 -411,29 +412,31 @@@ public class Jalview2XML_V
      }
  
      af.viewport.setColourAppliesToAllGroups(true);
 -    af.viewport.showSequenceFeatures = view.getShowSequenceFeatures();
 +    af.viewport.setShowSequenceFeatures(view.getShowSequenceFeatures());
  
      if (jms.getFeatureSettings() != null)
      {
 -      af.viewport.setFeaturesDisplayed(new Hashtable());
 +      Hashtable featuresDisplayed = new Hashtable();
 +      Hashtable featureColours = new Hashtable();
        String[] renderOrder = new String[jms.getFeatureSettings()
                .getSettingCount()];
        for (int fs = 0; fs < jms.getFeatureSettings().getSettingCount(); fs++)
        {
          Setting setting = jms.getFeatureSettings().getSetting(fs);
  
 -        af.alignPanel.getSeqPanel().seqCanvas.getFeatureRenderer().setColour(
 +        featureColours.put(
                  setting.getType(), new java.awt.Color(setting.getColour()));
  
          renderOrder[fs] = setting.getType();
  
          if (setting.getDisplay())
          {
 -          af.viewport.getFeaturesDisplayed().put(setting.getType(), new Integer(
 +          featuresDisplayed.put(setting.getType(), new Integer(
                    setting.getColour()));
          }
        }
 -      af.alignPanel.getSeqPanel().seqCanvas.getFeatureRenderer().renderOrder = renderOrder;
 +      FeatureRendererSettings frs = new FeatureRendererSettings(renderOrder, new Hashtable(), featureColours, 1.0f, null);
 +      af.alignPanel.getSeqPanel().seqCanvas.getFeatureRenderer().transferSettings(frs);
      }
  
      af.setMenusFromViewport(af.viewport);
@@@ -1,6 -1,5 +1,6 @@@
  package jalview.io;
  
 +import jalview.api.FeaturesDisplayedI;
  import jalview.datamodel.AlignmentI;
  import jalview.datamodel.SequenceFeature;
  import jalview.datamodel.SequenceI;
@@@ -14,13 -13,13 +14,13 @@@ import jalview.json.binding.v1.BioJsSeq
  import jalview.schemes.ColourSchemeProperty;
  import jalview.util.MessageManager;
  
 +import java.awt.Color;
  import java.io.BufferedReader;
  import java.io.IOException;
  import java.io.InputStreamReader;
  import java.io.PrintWriter;
  import java.net.URL;
  import java.util.ArrayList;
 -import java.util.Hashtable;
  
  import com.json.JSONException;
  
@@@ -28,11 -27,11 +28,11 @@@ public class BioJsHTMLOutpu
  {
    private AlignViewport av;
  
 -  private FeatureRenderer fr;
 +  private jalview.api.FeatureRenderer fr;
  
    private String globalColorScheme;
  
 -  private Hashtable displayedFeatures;
 +  private FeaturesDisplayedI displayedFeatures;
  
    private String jalviewVersion;
  
        this.av = ap.av;
        this.globalColorScheme = ColourSchemeProperty.getColourName(av
                .getGlobalColourScheme());
 -      this.fr = new FeatureRenderer(ap);
 -    fr.transferSettings(fr1);
 +      this.fr = ap.cloneFeatureRenderer();
        displayedFeatures = av.getFeaturesDisplayed();
--
--    exportJalviewAlignmentAsBioJsHtmlFile();
--  }
++    }
    }
  
    private void exportJalviewAlignmentAsBioJsHtmlFile()
          for (SequenceFeature sf : seqFeatures)
          {
            if (displayedFeatures != null
 -                  && displayedFeatures.get(sf.getType()) != null)
 +                  && displayedFeatures.isVisible(sf.getType()))
            {
 +
 +            // TODO: translate graduated/complex colourschemes to biojs model
              String featureColour = jalview.util.Format.getHexString(fr
 -                    .getColour(sf));
 +                    .findFeatureColour(Color.white, seq,
 +                            seq.findIndex(sf.getBegin())));
              BioJsFeaturePojo bjsFeature = new BioJsFeaturePojo();
              bjsFeature.setFillColor(featureColour);
              bjsFeature.setXstart(seq.findIndex(sf.getBegin()) - 1);