*/
public class FeatureStore
{
+ /**
+ * a class providing criteria for performing a binary search of a list
+ */
+ abstract static class SearchCriterion
+ {
+ /**
+ * Answers true if the entry passes the search criterion test
+ *
+ * @param entry
+ * @return
+ */
+ abstract boolean compare(SequenceFeature entry);
+
+ static SearchCriterion byStart(final long target)
+ {
+ return new SearchCriterion() {
+
+ @Override
+ boolean compare(SequenceFeature entry)
+ {
+ return entry.getBegin() >= target;
+ }
+ };
+ }
+
+ static SearchCriterion byEnd(final long target)
+ {
+ return new SearchCriterion()
+ {
+
+ @Override
+ boolean compare(SequenceFeature entry)
+ {
+ return entry.getEnd() >= target;
+ }
+ };
+ }
+
+ static SearchCriterion byFeature(final ContiguousI to,
+ final Comparator<ContiguousI> rc)
+ {
+ return new SearchCriterion()
+ {
+
+ @Override
+ boolean compare(SequenceFeature entry)
+ {
+ return rc.compare(entry, to) >= 0;
+ }
+ };
+ }
+ }
+
Comparator<ContiguousI> startOrdering = new RangeComparator(true);
Comparator<ContiguousI> endOrdering = new RangeComparator(false);
*/
public boolean addFeature(SequenceFeature feature)
{
+ /*
+ * keep a record of feature groups
+ */
if (!feature.isNonPositional())
{
positionalFeatureGroups.add(feature.getFeatureGroup());
* contained by) an existing feature. If there is no nesting, the feature is
* added to the list and the method returns true. If nesting is found, the
* feature is not added and the method returns false.
- * <p>
- * Contact features are added at the position of their first contact point
*
* @param feature
* @return
{
synchronized (nonNestedFeatures)
{
- int insertPosition = binarySearchForAdd(nonNestedFeatures, feature);
+ /*
+ * find the first stored feature which doesn't precede the new one
+ */
+ int insertPosition = binarySearch(nonNestedFeatures,
+ SearchCriterion.byFeature(feature, startOrdering));
/*
* fail if we detect feature enclosure - of the new feature by
}
if (insertPosition < nonNestedFeatures.size())
{
+ // FIXME may have to test more than one feature here
+ // e.g. add [40-60] to [20-42, 30-50, 45-55]
if (encloses(feature, nonNestedFeatures.get(insertPosition)))
{
return false;
}
/*
- * checks passed - add or append the feature
+ * checks passed - add the feature
*/
- if (insertPosition == nonNestedFeatures.size())
- {
- nonNestedFeatures.add(feature);
- }
- else
- {
- nonNestedFeatures.add(insertPosition, feature);
- }
+ nonNestedFeatures.add(insertPosition, feature);
+
return true;
}
}
}
/**
- * Answers the index of the first element in the given list which follows or
- * matches the given feature in the sort order. If no such element, answers
- * the length of the list.
- *
- * @param list
- * @param feature
- *
- * @return
- */
- protected int binarySearchForAdd(List<SequenceFeature> list, SequenceFeature feature)
- {
- // TODO binary search!
- int i = 0;
- while (i < list.size())
- {
- if (startOrdering.compare(nonNestedFeatures.get(i), feature) >= 0)
- {
- break;
- }
- i++;
- }
- return i;
- }
-
- /**
* Add a contact feature to the lists that hold them ordered by start (first
* contact) and by end (second contact) position, ensuring the lists remain
* ordered, and returns true. If the contact feature lists already contain the
}
/**
- * Returns a (possibly empty) list of entries whose range overlaps the given
+ * Returns a (possibly empty) list of features whose extent overlaps the given
* range. The returned list is not ordered. Contact features are included if
* either of the contact points lies within the range.
*
/**
* Adds contact features to the result list where either the second or the
- * first contact position lies within the target range.
+ * first contact position lies within the target range
*
* @param from
* @param to
}
/**
+ * Adds to the result list any contact features whose end (second contact
+ * point), but not start (first contact point), lies in the query from-to
+ * range
+ *
* @param from
* @param to
* @param result
protected void findContactEndFeatures(long from, long to,
List<SequenceFeature> result)
{
- // TODO binary search for startPosition
- for (int startPosition = 0; startPosition < contactFeatureEnds.size(); startPosition++)
+ /*
+ * find the first contact feature (if any) that does not lie
+ * entirely before the target range
+ */
+ int startPosition = binarySearch(contactFeatureEnds,
+ SearchCriterion.byEnd(from));
+ for (; startPosition < contactFeatureEnds.size(); startPosition++)
{
SequenceFeature sf = contactFeatureEnds.get(startPosition);
if (!sf.isContactFeature())
+ sf.getType() + " in contact features list");
continue;
}
+
int begin = sf.getBegin();
if (begin >= from && begin <= to)
{
*/
continue;
}
+
int end = sf.getEnd();
if (end >= from && end <= to)
{
result.add(sf);
}
- }
- }
-
- /**
- * Returns the index of the first contact feature found whose end (second
- * contact position) is not before the given start position. If no such
- * feature is found, returns the length of the contact features list.
- *
- * @param start
- * @return
- */
- protected int contactsBinarySearch(long start)
- {
- // TODO binary search!!
- int i = 0;
- while (i < contactFeatureEnds.size())
- {
- if (contactFeatureEnds.get(i).getEnd() >= start)
+ if (end > to)
{
break;
}
- i++;
}
-
- return i;
}
/**
- * Adds features to the result list that are at a single position which lies
- * within the target range. Non-positional features (start=end=0) and contact
+ * Adds non-nested features to the result list that lie within the target
+ * range. Non-positional features (start=end=0), contact features and nested
* features are excluded.
*
* @param from
protected void findNonNestedFeatures(long from, long to,
List<SequenceFeature> result)
{
- int startIndex = binarySearch(nonNestedFeatures, from);
+ int startIndex = binarySearch(nonNestedFeatures,
+ SearchCriterion.byEnd(from));
+
findNonNestedFeatures(startIndex, from, to, result);
}
* @return
*/
protected int findNonNestedFeatures(final int startIndex, long from,
- long to,
- List<SequenceFeature> result)
+ long to, List<SequenceFeature> result)
{
int i = startIndex;
while (i < nonNestedFeatures.size())
}
/**
- * Performs a binary search of the (sorted) list to find the index of the
- * first entry whose end position is not less than the target position (i.e.
- * skip all features that properly precede the given position)
- *
- * @param features
- * @param target
- * @return
- */
- protected int binarySearch(List<SequenceFeature> features, long target)
- {
- int width = features.size() / 2;
- int lastpos = width;
- while (width > 0)
- {
- int end = features.get(lastpos).getEnd();
- width = width / 2;
- if (end > target)
- {
- lastpos -= width;
- }
- else
- {
- lastpos += width;
- }
- }
- // todo correct binary search
- return lastpos > 1 ? lastpos - 2 : 0;
- // return lastpos;
- }
-
- /**
* Adds contact features whose start position lies in the from-to range to the
* result list
*
protected void findContactStartFeatures(long from, long to,
List<SequenceFeature> result)
{
- // TODO binary search for startPosition
- for (int startPosition = 0; startPosition < contactFeatureStarts.size(); startPosition++)
+ int startPosition = binarySearch(contactFeatureStarts,
+ SearchCriterion.byStart(from));
+
+ for (; startPosition < contactFeatureStarts.size(); startPosition++)
{
SequenceFeature sf = contactFeatureStarts.get(startPosition);
if (!sf.isContactFeature())
.unmodifiableSet(nonPositionalFeatureGroups);
}
}
+
+ /**
+ * Performs a binary search of the (sorted) list to find the index of the
+ * first entry which returns true for the given comparator function. Returns
+ * the length of the list if there is no such entry.
+ *
+ * @param features
+ * @param sc
+ * @return
+ */
+ protected int binarySearch(List<SequenceFeature> features,
+ SearchCriterion sc)
+ {
+ int start = 0;
+ int end = features.size() - 1;
+ int matched = features.size();
+
+ while (start <= end)
+ {
+ int mid = (start + end) / 2;
+ SequenceFeature entry = features.get(mid);
+ boolean compare = sc.compare(entry);
+ if (compare)
+ {
+ matched = mid;
+ end = mid - 1;
+ }
+ else
+ {
+ start = mid + 1;
+ }
+ }
+
+ return matched;
+ }
}
git://source.jalview.org / jalview.git / commitdiff