JAL-2759 Updates following review

diff --git a/src/jalview/datamodel/BoundedHiddenColsIterator.java b/src/jalview/datamodel/BoundedHiddenColsIterator.java
index aa3f4ad..8ec2a4d 100644 (file)
--- a/src/jalview/datamodel/BoundedHiddenColsIterator.java
+++ b/src/jalview/datamodel/BoundedHiddenColsIterator.java
@@ -11,12 +11,6 @@ import java.util.List;
  */
 public class BoundedHiddenColsIterator implements Iterator<int[]>
 {
-  // start position to iterate from
-  private int start;
-
-  // end position to iterate to
-  private int end;
-
   // current index in hiddenColumns
   private int currentPosition = 0;
 
@@ -67,8 +61,8 @@ public class BoundedHiddenColsIterator implements Iterator<int[]>
   private void init(int lowerBound, int upperBound,
           List<int[]> hiddenColumns)
   {
-    start = lowerBound;
-    end = upperBound;
+    int start = lowerBound;
+    int end = upperBound;
 
     if (hiddenColumns != null)
     {

diff --git a/src/jalview/datamodel/HiddenCursorPosition.java b/src/jalview/datamodel/HiddenCursorPosition.java
index 3c0b17a..160ed71 100644 (file)
--- a/src/jalview/datamodel/HiddenCursorPosition.java
+++ b/src/jalview/datamodel/HiddenCursorPosition.java
@@ -1,12 +1,12 @@
 package jalview.datamodel;
 
-public class HiddenCursorPosition
+public final class HiddenCursorPosition
 {
   // index of last visited region
-  private int regionIndex;
+  private final int regionIndex;
 
   // number of hidden columns before last visited region
-  private int hiddenSoFar;
+  private final int hiddenSoFar;
 
   public HiddenCursorPosition(int index, int hiddencount)
   {