Merge branch 'develop' into task/JAL-4001_migrate_googleanalytics_to_GA4

diff --combined src/jalview/gui/Desktop.java
index cfc56b2,2dfe820..99c394b
--- 1/src/jalview/gui/Desktop.java
--- 2/src/jalview/gui/Desktop.java
+++ b/src/jalview/gui/Desktop.java
@@@ -536,9 -536,6 +536,9 @@@ public class Desktop extends jalview.jb
        setBounds(xPos, yPos, 900, 650);
      }
  
 +    // start dialogue queue for single dialogues
 +    startDialogQueue();
 +
      if (!Platform.isJS())
      /**
       * Java only
@@@ -626,6 -623,12 +626,12 @@@
        }
      });
      desktop.addMouseListener(ma);
+ 
+     if (Platform.isJS())
+     {
+       // used for jalviewjsTest
+       jalview.bin.Console.info("JALVIEWJS: CREATED DESKTOP");
+     }
    }
  
    /**
@@@ -3054,7 -3057,7 +3060,7 @@@
    /**
     * pause the queue
     */
 -  private java.util.concurrent.Semaphore block = new Semaphore(0);
 +  private Semaphore block = new Semaphore(0);
  
    private static groovy.ui.Console groovyConsole;
  
@@@ -3072,7 -3075,12 +3078,7 @@@
        {
          if (dialogPause)
          {
 -          try
 -          {
 -            block.acquire();
 -          } catch (InterruptedException x)
 -          {
 -          }
 +          acquireDialogQueue();
          }
          if (instance == null)
          {
@@@ -3090,41 -3098,12 +3096,41 @@@
      });
    }
  
 +  private boolean dialogQueueStarted = false;
 +
    public void startDialogQueue()
    {
 +    if (dialogQueueStarted)
 +    {
 +      return;
 +    }
      // set the flag so we don't pause waiting for another permit and semaphore
      // the current task to begin
 -    dialogPause = false;
 +    releaseDialogQueue();
 +    dialogQueueStarted = true;
 +  }
 +
 +  public void acquireDialogQueue()
 +  {
 +    try
 +    {
 +      block.acquire();
 +      dialogPause = true;
 +    } catch (InterruptedException e)
 +    {
 +      jalview.bin.Console.debug("Interruption when acquiring DialogueQueue",
 +              e);
 +    }
 +  }
 +
 +  public void releaseDialogQueue()
 +  {
 +    if (!dialogPause)
 +    {
 +      return;
 +    }
      block.release();
 +    dialogPause = false;
    }
  
    /**
@@@ -3159,10 -3138,14 +3165,14 @@@
      String title = "View of desktop";
      ImageExporter exporter = new ImageExporter(writer, null, TYPE.EPS,
              title);
-     try {
+     try
+     {
        exporter.doExport(of, this, width, height, title);
-     } catch (ImageOutputException ioex) {
-       jalview.bin.Console.error("Unexpected error whilst writing Jalview desktop snapshot as EPS",ioex);
+     } catch (ImageOutputException ioex)
+     {
+       jalview.bin.Console.error(
+               "Unexpected error whilst writing Jalview desktop snapshot as EPS",
+               ioex);
      }
    }
  
@@@ -3609,7 -3592,8 +3619,8 @@@
     */
    public static void closeDesktop()
    {
-     if (Desktop.instance != null) {
+     if (Desktop.instance != null)
+     {
        Desktop.instance.closeAll_actionPerformed(null);
        Desktop.instance.setVisible(false);
        Desktop.instance.dispose();