JAL-4311 fix test checking pdbentry gets quality score metadata from 3dbeacons

diff --git a/src/jalview/gui/structurechooser/ThreeDBStructureChooserQuerySource.java b/src/jalview/gui/structurechooser/ThreeDBStructureChooserQuerySource.java
index 349d467..f5a1065 100644 (file)
--- a/src/jalview/gui/structurechooser/ThreeDBStructureChooserQuerySource.java
+++ b/src/jalview/gui/structurechooser/ThreeDBStructureChooserQuerySource.java
@@ -463,11 +463,11 @@ public class ThreeDBStructureChooserQuerySource
         }
         try
         {
-          if (strucTfType!=null && "".equals(strucTfType)) {
+          if (strucTfType!=null && !"".equals(strucTfType)) {
             pdbEntry.setTempFacType(strucTfType);
           }
-          if (strucTfType_v!=null && "".equals(strucTfType_v)) {
-          pdbEntry.setTempFacTypeVersion(strucTfType_v);
+          if (strucTfType_v!=null && !"".equals(strucTfType_v)) {
+            pdbEntry.setTempFacTypeVersion(strucTfType_v);
           }
         } catch (Exception q)
         {

diff --git a/test/jalview/gui/StructureChooserTest.java b/test/jalview/gui/StructureChooserTest.java
index 66760a2..846fa1a 100644 (file)
--- a/test/jalview/gui/StructureChooserTest.java
+++ b/test/jalview/gui/StructureChooserTest.java
@@ -237,6 +237,9 @@ public class StructureChooserTest
     assertTrue(ss.size() > 0);
     
     sc.promptForTDBFetch(true);
+    try {
+      Thread.sleep(500);
+    } catch (Exception q) {}
     
     // check collation
     Object[] sqandpdb = sc.collectSelectedSeqsAndPDBEntries();
@@ -247,6 +250,8 @@ public class StructureChooserTest
     assertNotNull(selpdb);
     assertEquals(1, selsq.length);
     assertEquals(1, selpdb.length);
+    assertTrue(selpdb[0].hasProvider());
+    assertTrue(selpdb[0].hasTempFacType());
     
     
   }