jalview.git
11 years agoJAL-1373 JAL-520 wrap tooltips for columns in annotation rows
Jim Procter [Mon, 2 Sep 2013 17:11:29 +0000 (18:11 +0100)]
JAL-1373 JAL-520 wrap tooltips for columns in annotation rows

11 years agoJAL-1373 generate percentages with appropriate precision
Jim Procter [Mon, 2 Sep 2013 17:09:08 +0000 (18:09 +0100)]
JAL-1373 generate percentages with appropriate precision

11 years agoJAL-1373 pass size of sequence set to consensus rendering routines so appropriate...
Jim Procter [Mon, 2 Sep 2013 17:07:42 +0000 (18:07 +0100)]
JAL-1373 pass size of sequence set to consensus rendering routines so appropriate precision can be chosen

11 years agoMerge branch 'JAL-1359_patch' into Release_2_8_1_Branch
Jim Procter [Tue, 27 Aug 2013 15:08:37 +0000 (16:08 +0100)]
Merge branch 'JAL-1359_patch' into Release_2_8_1_Branch

11 years agoJAL-1359 simpler logic for deciding if all threads have finished.
Jim Procter [Tue, 27 Aug 2013 15:08:17 +0000 (16:08 +0100)]
JAL-1359 simpler logic for deciding if all threads have finished.
Note: I couldn't reproduce the JAL-1359 bug after rebuilding my JABAWS development server - so trust me on this fix :)

11 years agoMerge branch 'JAL-1332_regression' into Release_2_8_1_Branch
Jim Procter [Tue, 27 Aug 2013 14:46:19 +0000 (15:46 +0100)]
Merge branch 'JAL-1332_regression' into Release_2_8_1_Branch

11 years agoJAL-1332 regression from 7ce72ca7fadf35a249427ecb836b22abb04ab653 - allow 'null'...
Jim Procter [Tue, 27 Aug 2013 14:42:06 +0000 (15:42 +0100)]
JAL-1332 regression from 7ce72ca7fadf35a249427ecb836b22abb04ab653 - allow 'null' context to be used (for test/src/jalview/ws/jabaws/TestDisorderAnnotExportImport where Desktop is not created before an AlignFrame is constructed)

11 years agoJAL-1332 - defer SSM provision to root provider for the alignment view
Jim Procter [Tue, 27 Aug 2013 14:40:50 +0000 (15:40 +0100)]
JAL-1332 - defer SSM provision to root provider for the alignment view

11 years agoMerge branch 'JAL-1353-bugdemo' into Release_2_8_1_Branch
Jim Procter [Tue, 20 Aug 2013 16:28:34 +0000 (17:28 +0100)]
Merge branch 'JAL-1353-bugdemo' into Release_2_8_1_Branch

11 years agoJAL-1353 test demonstrating the freeze with minimal jalview code dependency
Jim Procter [Tue, 20 Aug 2013 16:27:16 +0000 (17:27 +0100)]
JAL-1353 test demonstrating the freeze with minimal jalview code dependency

11 years agoMerge branch 'JAL-1347' into Release_2_8_1_Branch
Jim Procter [Fri, 12 Jul 2013 15:58:53 +0000 (16:58 +0100)]
Merge branch 'JAL-1347' into Release_2_8_1_Branch

11 years agoJAL-1347 RNA Structure consensus follows the alignment viewport consensus rendering...
Jim Procter [Fri, 12 Jul 2013 15:58:22 +0000 (16:58 +0100)]
JAL-1347 RNA Structure consensus follows the alignment viewport consensus rendering settings in version 2.8.x

11 years agoJAL-1347 flow control for display of profile data is upstream from this method
Jim Procter [Fri, 12 Jul 2013 15:57:45 +0000 (16:57 +0100)]
JAL-1347 flow control for display of profile data is upstream from this method

11 years agoMerge branch 'JAL-1347' into Release_2_8_1_Branch
Jim Procter [Thu, 11 Jul 2013 12:57:54 +0000 (13:57 +0100)]
Merge branch 'JAL-1347' into Release_2_8_1_Branch

11 years agoJAL-1347 identify and set rendering settings for consensus annotation rows
Jim Procter [Thu, 11 Jul 2013 12:57:03 +0000 (13:57 +0100)]
JAL-1347 identify and set rendering settings for consensus annotation rows
JAL-966 Note  - should abstract this logic even further away in Jalview v3

11 years agoJAL-1347 refactor logic for setting display flags for histogram and profile to main...
Jim Procter [Thu, 11 Jul 2013 12:54:25 +0000 (13:54 +0100)]
JAL-1347 refactor logic for setting display flags for histogram and profile to main control loop

11 years agoJAL-1347 make it efficient to call getConsensus to test identity of alignment annotat...
Jim Procter [Thu, 11 Jul 2013 12:53:27 +0000 (13:53 +0100)]
JAL-1347 make it efficient to call getConsensus to test identity of alignment annotation rows

11 years agoMerge branch 'JAL-895/reopen' into Release_2_8_1_Branch
Jim Procter [Tue, 9 Jul 2013 09:50:55 +0000 (10:50 +0100)]
Merge branch 'JAL-895/reopen' into Release_2_8_1_Branch

11 years agoJAL-895 - patch example files with correct Fe positions
Jim Procter [Tue, 9 Jul 2013 09:49:10 +0000 (10:49 +0100)]
JAL-895 - patch example files with correct Fe positions

11 years agoMerge branch 'Release_2_8_1_Branch' into Release_2_8_Branch
Jim Procter [Mon, 8 Jul 2013 12:48:56 +0000 (13:48 +0100)]
Merge branch 'Release_2_8_1_Branch' into Release_2_8_Branch

11 years agomake sure 'example alignment' can be found in documentation
Jim Procter [Mon, 8 Jul 2013 12:48:09 +0000 (13:48 +0100)]
make sure 'example alignment' can be found in documentation

11 years agoMerge branch 'structures/JAL-1016' into Release_2_8_Branch
Jim Procter [Sun, 7 Jul 2013 12:19:41 +0000 (13:19 +0100)]
Merge branch 'structures/JAL-1016' into Release_2_8_Branch

11 years agoJAL-1345 - set nSeconds arg for http://chemapps.stolaf.edu/jmol/docs/#compare accordi...
Jim Procter [Sun, 7 Jul 2013 12:08:52 +0000 (13:08 +0100)]
JAL-1345 - set nSeconds arg for chemapps.stolaf.edu/jmol/docs/#compare according to total number of superpositions

11 years agoJAL-1016 Instruct user to report situations where the race condition still happens
Jim Procter [Sun, 7 Jul 2013 11:44:25 +0000 (12:44 +0100)]
JAL-1016 Instruct user to report situations where the race condition still happens

11 years agoJAL-1332 make SSM context discovery safer (particularly in plugin context)
Jim Procter [Sun, 7 Jul 2013 11:42:59 +0000 (12:42 +0100)]
JAL-1332 make SSM context discovery safer (particularly in plugin context)

11 years agoJAL-583 refactor todo about separating code to construct Jmol superposition from...
Jim Procter [Sun, 7 Jul 2013 11:39:43 +0000 (12:39 +0100)]
JAL-583 refactor todo about separating code to construct Jmol superposition from the code that obtains the atom matching used to construct the expression

11 years agofix for JAL-1016 - wait around until we have a complete set of PDB filename mappings...
Jim Procter [Sun, 7 Jul 2013 11:39:23 +0000 (12:39 +0100)]
fix for JAL-1016 - wait around until we have a complete set of PDB filename mappings available in Jmol

11 years agoJAL-1016 - do our assertions immediatly
Jim Procter [Sun, 7 Jul 2013 11:38:02 +0000 (12:38 +0100)]
JAL-1016 - do our assertions immediatly

11 years agoMerge branch 'bug/JAL-1230' into Release_2_8_Branch
Jim Procter [Sun, 23 Jun 2013 18:06:23 +0000 (19:06 +0100)]
Merge branch 'bug/JAL-1230' into Release_2_8_Branch

11 years agoJAL-1230 update alignment state for annotation edits, and validate annotation panel...
Jim Procter [Sun, 23 Jun 2013 18:05:42 +0000 (19:05 +0100)]
JAL-1230 update alignment state for annotation edits, and validate annotation panel height to ensure any autocalculated annotation is made visible

11 years agoJAL-1230 proxy method for synchronising internal AlignmentI state in response to...
Jim Procter [Sun, 23 Jun 2013 18:03:53 +0000 (19:03 +0100)]
JAL-1230 proxy method for synchronising internal AlignmentI state in response to changes in alignment annotation

11 years agoJAL-1230 simplify initialisation of consensus, conservation and structure consensus...
Jim Procter [Sun, 23 Jun 2013 18:02:20 +0000 (19:02 +0100)]
JAL-1230 simplify initialisation of consensus, conservation and structure consensus rows

11 years agoMerge branch 'bug/JAL-1230' into Release_2_8_Branch
Jim Procter [Sun, 23 Jun 2013 13:00:05 +0000 (14:00 +0100)]
Merge branch 'bug/JAL-1230' into Release_2_8_Branch

11 years agoMerge commit '72c628b' into Release_2_8_Branch
Jim Procter [Sun, 23 Jun 2013 12:58:40 +0000 (13:58 +0100)]
Merge commit '72c628b' into Release_2_8_Branch

11 years agoMerge branch 'feature/JAL-1330' into Release_2_8_Branch
Jim Procter [Sat, 22 Jun 2013 13:17:34 +0000 (14:17 +0100)]
Merge branch 'feature/JAL-1330' into Release_2_8_Branch

11 years agoJAL-1330 pick primary seqeunce data source for authority rather than first node of...
Jim Procter [Sat, 22 Jun 2013 13:17:14 +0000 (14:17 +0100)]
JAL-1330 pick primary seqeunce data source for authority rather than first node of sub tree

11 years agoJAL-1230 comment unused code to avoid NPE
Jim Procter [Fri, 21 Jun 2013 16:20:03 +0000 (17:20 +0100)]
JAL-1230 comment unused code to avoid NPE

11 years agoJAL-1327 TODO
Jim Procter [Fri, 21 Jun 2013 14:09:01 +0000 (15:09 +0100)]
JAL-1327 TODO

11 years agoJAL-1326 JAL-1327 update all graphline thresholds with flag for interactive or final...
Jim Procter [Fri, 21 Jun 2013 14:08:37 +0000 (15:08 +0100)]
JAL-1326 JAL-1327 update all graphline thresholds with flag for interactive or final adjustment event

11 years agoJAL-1241 - generate colour for all annotation values within range
Jim Procter [Fri, 21 Jun 2013 13:29:41 +0000 (14:29 +0100)]
JAL-1241 - generate colour for all annotation values within range

11 years agoMerge branch 'JAL-1294_iupredexportimport' into Release_2_8_Branch
Jim Procter [Fri, 21 Jun 2013 13:12:49 +0000 (14:12 +0100)]
Merge branch 'JAL-1294_iupredexportimport' into Release_2_8_Branch

11 years agoJAL-1325 formatting
Jim Procter [Fri, 21 Jun 2013 12:59:53 +0000 (13:59 +0100)]
JAL-1325 formatting

11 years agoJAL-1325 JAL-1294 resolve SEQUENCE_REF and GROUP_REF for GRAPHLINE statements
Jim Procter [Fri, 21 Jun 2013 12:59:35 +0000 (13:59 +0100)]
JAL-1325 JAL-1294 resolve SEQUENCE_REF and GROUP_REF for GRAPHLINE statements

11 years agoJAL-1294 JAL-1325 store graphline for individual annotation rows.
Jim Procter [Fri, 21 Jun 2013 12:58:42 +0000 (13:58 +0100)]
JAL-1294 JAL-1325 store graphline for individual annotation rows.

11 years agoJAL-1294 JAL-1325 bugfix equals
Jim Procter [Fri, 21 Jun 2013 11:20:11 +0000 (12:20 +0100)]
JAL-1294 JAL-1325 bugfix equals

11 years agoJAL-1294 JAL-1325 test annotation threshold line equivalence
Jim Procter [Fri, 21 Jun 2013 10:58:47 +0000 (11:58 +0100)]
JAL-1294 JAL-1325 test annotation threshold line equivalence

11 years agoMerge branch 'JAL-1321_jws2_tooltips' into Release_2_8_Branch
Jim Procter [Fri, 21 Jun 2013 10:36:17 +0000 (11:36 +0100)]
Merge branch 'JAL-1321_jws2_tooltips' into Release_2_8_Branch

11 years agoJAL-1127 set option widgets to service defaults only when showing default settings
Jim Procter [Fri, 21 Jun 2013 10:35:07 +0000 (11:35 +0100)]
JAL-1127 set option widgets to service defaults only when showing default settings

11 years agoJAL-1240 avoid NPE when source has no proxy available
Jim Procter [Wed, 19 Jun 2013 16:41:27 +0000 (17:41 +0100)]
JAL-1240 avoid NPE when source has no proxy available

11 years agoMerge branch 'JAL-1321_jws2_tooltips' into Release_2_8_Branch
Jim Procter [Wed, 19 Jun 2013 16:00:37 +0000 (17:00 +0100)]
Merge branch 'JAL-1321_jws2_tooltips' into Release_2_8_Branch

11 years agoJAL-1320 ascending alphabetical order
Jim Procter [Tue, 18 Jun 2013 20:57:45 +0000 (21:57 +0100)]
JAL-1320 ascending alphabetical order

11 years agoJAL-1320 preserve option/parameter order with LinkedHashMap
Jim Procter [Tue, 18 Jun 2013 20:57:02 +0000 (21:57 +0100)]
JAL-1320 preserve option/parameter order with LinkedHashMap

11 years agoJAL-1320 sort options and parameters according to their name
Jim Procter [Tue, 18 Jun 2013 20:38:16 +0000 (21:38 +0100)]
JAL-1320 sort options and parameters according to their name

11 years agotypo
Jim Procter [Tue, 18 Jun 2013 20:29:29 +0000 (21:29 +0100)]
typo

11 years agoJAL-1321 don't show a tooltip for empty strings
Jim Procter [Tue, 18 Jun 2013 20:28:57 +0000 (21:28 +0100)]
JAL-1321 don't show a tooltip for empty strings

11 years agoMerge branch 'JAL-1319_jronn_npe' into Release_2_8_Branch
Jim Procter [Mon, 17 Jun 2013 17:26:47 +0000 (18:26 +0100)]
Merge branch 'JAL-1319_jronn_npe' into Release_2_8_Branch

11 years agoJAL-1319 (blacklist fix) check for presence of a score object before we start making...
Jim Procter [Mon, 17 Jun 2013 17:25:54 +0000 (18:25 +0100)]
JAL-1319 (blacklist fix) check for presence of a score object before we start making annotation

11 years agoMerge branch 'JAL-1312_ambiguity_na' into Release_2_8_Branch
Jim Procter [Mon, 17 Jun 2013 16:51:33 +0000 (17:51 +0100)]
Merge branch 'JAL-1312_ambiguity_na' into Release_2_8_Branch

11 years agoJAL-1027 fix errors in alternative codon table
Jim Procter [Mon, 17 Jun 2013 16:45:23 +0000 (17:45 +0100)]
JAL-1027 fix errors in alternative codon table

11 years agoJAL-1027 check that ResidueProperties.codonHash2 is actually identical to the codon...
Jim Procter [Mon, 17 Jun 2013 16:45:03 +0000 (17:45 +0100)]
JAL-1027 check that ResidueProperties.codonHash2 is actually identical to the codon table used in previous versions

11 years agoJAL-1027 use alternative codon table in ResidueProperties.codonHash2 for translation
Jim Procter [Mon, 17 Jun 2013 16:41:40 +0000 (17:41 +0100)]
JAL-1027 use alternative codon table in ResidueProperties.codonHash2 for translation

11 years agoJAL-1035 option to allow 'STOP' codon to translate as '*'
Jim Procter [Mon, 17 Jun 2013 14:23:00 +0000 (15:23 +0100)]
JAL-1035 option to allow 'STOP' codon to translate as '*'

11 years agoJAL-1312 patch for regression noticed after patch to jalview.analysis.Dna cdna transl...
Jim Procter [Mon, 17 Jun 2013 14:14:40 +0000 (15:14 +0100)]
JAL-1312 patch for regression noticed after patch to jalview.analysis.Dna cdna translation

11 years agoJAL-1312 rewrite of code for first reported exception - note - maintaining scontigs...
Jim Procter [Mon, 17 Jun 2013 14:13:13 +0000 (15:13 +0100)]
JAL-1312 rewrite of code for first reported exception - note - maintaining scontigs may not even be necessary !

11 years agoJAL-1312 formatting and more comprehensive test
Jim Procter [Mon, 17 Jun 2013 14:10:22 +0000 (15:10 +0100)]
JAL-1312 formatting and more comprehensive test

11 years agoJAL-1312 remove unnecessary methods
Jim Procter [Mon, 17 Jun 2013 14:09:04 +0000 (15:09 +0100)]
JAL-1312 remove unnecessary methods

11 years agoJAL-1312 more helpful error message when translation breaks
Jim Procter [Mon, 17 Jun 2013 12:52:21 +0000 (13:52 +0100)]
JAL-1312 more helpful error message when translation breaks

11 years agoJAL-529 - IUBMB nucleotide ambiguity codes and programmatic generation of codons...
Jim Procter [Mon, 17 Jun 2013 09:40:26 +0000 (10:40 +0100)]
JAL-529 - IUBMB nucleotide ambiguity codes and programmatic generation of codons and inverse tables

11 years agoJAL-1318 - route warnings to stderr (need to find a better solution for JAL-1069)
Jim Procter [Mon, 17 Jun 2013 09:35:28 +0000 (10:35 +0100)]
JAL-1318 - route warnings to stderr (need to find a better solution for JAL-1069)

11 years agoJAL-1318 avoid failure if SequenceI objects don't have valid dataset references
Jim Procter [Mon, 17 Jun 2013 09:33:11 +0000 (10:33 +0100)]
JAL-1318 avoid failure if SequenceI objects don't have valid dataset references

11 years agoJAL-966 avoid using java.util.Vector
Jim Procter [Mon, 17 Jun 2013 09:31:58 +0000 (10:31 +0100)]
JAL-966 avoid using java.util.Vector

11 years agotest for JAL-1312
Jim Procter [Mon, 17 Jun 2013 09:21:32 +0000 (10:21 +0100)]
test for JAL-1312

11 years agoMerge branch 'JAL-1316' into Release_2_8_Branch
Jim Procter [Fri, 14 Jun 2013 15:23:22 +0000 (16:23 +0100)]
Merge branch 'JAL-1316' into Release_2_8_Branch

11 years agoJAL-1316 compact '' to '
Jim Procter [Fri, 14 Jun 2013 15:18:23 +0000 (16:18 +0100)]
JAL-1316 compact '' to '

11 years agoJAL-1316 recognise and extract quoted region as nodename
Jim Procter [Fri, 14 Jun 2013 15:17:58 +0000 (16:17 +0100)]
JAL-1316 recognise and extract quoted region as nodename

11 years agoJAL-1316 JAL-1313 newick IO test harness
Jim Procter [Fri, 14 Jun 2013 14:06:42 +0000 (15:06 +0100)]
JAL-1316 JAL-1313 newick IO test harness

11 years agoMerge branch 'JAL-1314_headlessFlag' into Release_2_8_Branch
Jim Procter [Thu, 13 Jun 2013 16:38:08 +0000 (17:38 +0100)]
Merge branch 'JAL-1314_headlessFlag' into Release_2_8_Branch

11 years agoJAL-1314 allow 'nogui' and 'headless' as synonyms for 'nodisplay' argument and ensure...
Jim Procter [Thu, 13 Jun 2013 16:37:43 +0000 (17:37 +0100)]
JAL-1314 allow 'nogui' and 'headless' as synonyms for 'nodisplay' argument and ensure awt.gui.headless=true is set as early as possible.

11 years agoJAL-1314 test for common variants of -nodisplay performing the same for EPS generation
Jim Procter [Thu, 13 Jun 2013 16:36:46 +0000 (17:36 +0100)]
JAL-1314 test for common variants of -nodisplay performing the same for EPS generation
JAL-1314 test for identical termination behaviour with/without java.awt.headless=true

11 years agoMerge branch 'JAL-1315_headlessEPS' into Release_2_8_Branch
Jim Procter [Thu, 13 Jun 2013 15:55:11 +0000 (16:55 +0100)]
Merge branch 'JAL-1315_headlessEPS' into Release_2_8_Branch

11 years agofix for JAL-1315
Jim Procter [Thu, 13 Jun 2013 15:53:33 +0000 (16:53 +0100)]
fix for JAL-1315

11 years agoJAL-1315 test for exit and successful generation of EPS using commandline
Jim Procter [Thu, 13 Jun 2013 15:53:10 +0000 (16:53 +0100)]
JAL-1315 test for exit and successful generation of EPS using commandline

11 years agoMerge branch '2_8_1_patch_multiharmony' into Release_2_8_Branch
Jim Procter [Sun, 9 Jun 2013 14:30:33 +0000 (15:30 +0100)]
Merge branch '2_8_1_patch_multiharmony' into Release_2_8_Branch

11 years agofix for JAL-1298
Jim Procter [Sun, 9 Jun 2013 14:29:43 +0000 (15:29 +0100)]
fix for JAL-1298

11 years agoJAL-715 - TODO
Jim Procter [Sun, 9 Jun 2013 14:29:14 +0000 (15:29 +0100)]
JAL-715 - TODO

11 years agoMerge branch '2_8_1_patch_multiharmony' into Release_2_8_Branch
Jim Procter [Fri, 7 Jun 2013 15:32:54 +0000 (16:32 +0100)]
Merge branch '2_8_1_patch_multiharmony' into Release_2_8_Branch

11 years agoJAL-1309 fix broken partition computation for adding in ungrouped sequences as final...
Jim Procter [Fri, 7 Jun 2013 12:31:37 +0000 (13:31 +0100)]
JAL-1309 fix broken partition computation for adding in ungrouped sequences as final group

11 years agoJAL-945 uniquify prior to submission
Jim Procter [Fri, 7 Jun 2013 12:24:47 +0000 (13:24 +0100)]
JAL-945 uniquify prior to submission

11 years agoformatting
Jim Procter [Fri, 7 Jun 2013 12:24:16 +0000 (13:24 +0100)]
formatting

11 years agoJAL-715 allow headless construction for testing
Jim Procter [Fri, 7 Jun 2013 12:24:08 +0000 (13:24 +0100)]
JAL-715 allow headless construction for testing

11 years agoJAL-724 JAL-715 refactor and create new test for RSBS framework and Multi-harmony...
Jim Procter [Fri, 7 Jun 2013 12:23:28 +0000 (13:23 +0100)]
JAL-724 JAL-715 refactor and create new test for RSBS framework and Multi-harmony service

11 years agofix for JAL-1246
Jim Procter [Tue, 4 Jun 2013 13:23:08 +0000 (14:23 +0100)]
fix for JAL-1246

11 years agoJAL-1307 patch to squash number format exceptions when pressing return
Jim Procter [Tue, 4 Jun 2013 10:50:19 +0000 (11:50 +0100)]
JAL-1307 patch to squash number format exceptions when pressing return

11 years agoJAL-1300 documentation
Jim Procter [Tue, 4 Jun 2013 09:45:19 +0000 (10:45 +0100)]
JAL-1300 documentation

11 years agoMerge branch 'JAL-1259_hotfix' into Release_2_8_Branch
Jim Procter [Fri, 31 May 2013 16:10:11 +0000 (17:10 +0100)]
Merge branch 'JAL-1259_hotfix' into Release_2_8_Branch

11 years agoJAL-1259 patch to avoid NPE
Jim Procter [Fri, 31 May 2013 16:09:33 +0000 (17:09 +0100)]
JAL-1259 patch to avoid NPE

11 years agoMerge branch 'JAL-1161_optimisingAnnotationPanel' (early part) into Release_2_8_Branch
Jim Procter [Fri, 24 May 2013 14:14:01 +0000 (15:14 +0100)]
Merge branch 'JAL-1161_optimisingAnnotationPanel' (early part) into Release_2_8_Branch

11 years agoJAL-1291 reinstate fastPaint flag manipulation to make trackPad scrolling smooth
Jim Procter [Fri, 24 May 2013 13:14:45 +0000 (14:14 +0100)]
JAL-1291 reinstate fastPaint flag manipulation to make trackPad scrolling smooth

11 years agoJAL-1291 TODO: revised graphGroup model so grouped graphs are more efficiently rendered
Jim Procter [Fri, 24 May 2013 12:34:55 +0000 (13:34 +0100)]
JAL-1291 TODO: revised graphGroup model so grouped graphs are more efficiently rendered

11 years agoJAL-1291 - don't touch the graphics object until after deciding to skip annotation row
Jim Procter [Fri, 24 May 2013 12:27:49 +0000 (13:27 +0100)]
JAL-1291 - don't touch the graphics object until after deciding to skip annotation row