jalview.git
5 years ago// BH 2018.04.18 comment: addNotify() is not appropriate here. We
hansonr [Thu, 18 Apr 2019 17:59:40 +0000 (12:59 -0500)]
// BH 2018.04.18 comment: addNotify() is not appropriate here. We
    // are not changing ancestors, and keyboard action listeners do
    // not need to be reset. addNotify() is a very expensive operation,
    // requiring a full re-layout of all parents and children.
    // Note in JComponent:
    // This method is called by the toolkit internally and should
    // not be called directly by programs.
    // I note that addNotify() is called in several areas of Jalview.

5 years agoAdds check for gap padding to disallow fast paint upon pasting if
hansonr [Thu, 18 Apr 2019 17:55:55 +0000 (12:55 -0500)]
Adds check for gap padding to disallow fast paint upon pasting if
alignment has been modified.

5 years agoremoves unnecessary clearFastPaint
hansonr [Thu, 18 Apr 2019 17:54:46 +0000 (12:54 -0500)]
removes unnecessary clearFastPaint

5 years agoCorrects incorrect calls to ViewportRanges.setEndSeq()
hansonr [Thu, 18 Apr 2019 17:54:08 +0000 (12:54 -0500)]
Corrects incorrect calls to ViewportRanges.setEndSeq()

This function has the limit of height - 1, not height. Also adds safety
for start < 0 in ViewportRanges.setEndSeq();

5 years agopushing again, just comments
hansonr [Thu, 18 Apr 2019 15:03:30 +0000 (10:03 -0500)]
pushing again, just comments

5 years agohack for fastpaint Java bug upshifting one line after a sequence
hansonr [Thu, 18 Apr 2019 14:32:42 +0000 (09:32 -0500)]
hack for fastpaint Java bug upshifting one line after a sequence
selection paste. Covered in Java by a full paint by ConsensusThread.

5 years agoJAL-1793 basic help text for VCF option
gmungoc [Thu, 18 Apr 2019 14:32:37 +0000 (15:32 +0100)]
JAL-1793 basic help text for VCF option

5 years agoJAL-3111 additional release notes
gmungoc [Thu, 18 Apr 2019 14:17:45 +0000 (15:17 +0100)]
JAL-3111 additional release notes

5 years agoJAL-3111 small simplification of table tags, valign top
gmungoc [Thu, 18 Apr 2019 12:24:42 +0000 (13:24 +0100)]
JAL-3111 small simplification of table tags, valign top

5 years agoJAL-3111 release notes first pass complete
gmungoc [Thu, 18 Apr 2019 12:08:26 +0000 (13:08 +0100)]
JAL-3111 release notes first pass complete

5 years agoJAL-3130 moved jar needed for getdown to libs (not a module)
Ben Soares [Thu, 18 Apr 2019 12:02:11 +0000 (13:02 +0100)]
JAL-3130 moved jar needed for getdown to libs (not a module)

5 years agoreverting seqPanel.seqCanvas.clearFastPaint();
hansonr [Thu, 18 Apr 2019 11:53:00 +0000 (06:53 -0500)]
reverting     seqPanel.seqCanvas.clearFastPaint();

5 years agoJAL-3224 Removed JREs (these now need to be in ~/buildtools/jre/openjdk-java_vm/...
Ben Soares [Thu, 18 Apr 2019 11:37:00 +0000 (12:37 +0100)]
JAL-3224 Removed JREs (these now need to be in ~/buildtools/jre/openjdk-java_vm/...). Moved install4j config to utils. Made install4j template file (gradle will edit this correctly). Fixed symbolic link in bundled MacOS JRE problem. Added getdown launcher with .tgz unbundling support [currently broken].

5 years agoJAL-2620 updated help page to mention alternative genetic code tables
gmungoc [Thu, 18 Apr 2019 11:36:53 +0000 (12:36 +0100)]
JAL-2620 updated help page to mention alternative genetic code tables

5 years agoMerge branch 'develop' into Jalview-JS/develop
gmungoc [Thu, 18 Apr 2019 08:36:57 +0000 (09:36 +0100)]
Merge branch 'develop' into Jalview-JS/develop

5 years agoJAL-3193 dbSource always "ENSEMBL"
gmungoc [Thu, 18 Apr 2019 08:36:28 +0000 (09:36 +0100)]
JAL-3193 dbSource always "ENSEMBL"

5 years agoMerge branch 'develop' into Jalview-JS/develop
gmungoc [Thu, 18 Apr 2019 08:31:17 +0000 (09:31 +0100)]
Merge branch 'develop' into Jalview-JS/develop

5 years agoexplicit Hashtable objects
hansonr [Thu, 18 Apr 2019 03:54:33 +0000 (22:54 -0500)]
explicit Hashtable objects

5 years agoadds an explicit clearing of the SeqCanvas fastPaint flag upon viewport
hansonr [Thu, 18 Apr 2019 03:53:59 +0000 (22:53 -0500)]
adds an explicit clearing of the SeqCanvas fastPaint flag upon viewport
adjustment

5 years agoJAL-3026 fix bug loading Jalview Project (in Java)
gmungoc [Wed, 17 Apr 2019 15:34:58 +0000 (16:34 +0100)]
JAL-3026 fix bug loading Jalview Project (in Java)

5 years agoJAL-3111 fix 2.11 html anchor in docs
Jim Procter [Wed, 17 Apr 2019 14:34:59 +0000 (15:34 +0100)]
JAL-3111 fix 2.11 html anchor in docs

5 years agoMerge branch 'documentation/JAL-3111_release_211' into develop
Jim Procter [Wed, 17 Apr 2019 14:32:58 +0000 (15:32 +0100)]
Merge branch 'documentation/JAL-3111_release_211' into develop

5 years agoJAL-3111 Jalview 2.11 what’s New and estimated release date
Jim Procter [Wed, 17 Apr 2019 14:32:36 +0000 (15:32 +0100)]
JAL-3111 Jalview 2.11 what’s New and estimated release date

5 years agoJAL-3111 tweak PCA documentation
Jim Procter [Wed, 17 Apr 2019 14:32:07 +0000 (15:32 +0100)]
JAL-3111 tweak PCA documentation

5 years agoMerge branch 'develop' into documentation/JAL-3111_release_211
Jim Procter [Wed, 17 Apr 2019 12:53:16 +0000 (13:53 +0100)]
Merge branch 'develop' into documentation/JAL-3111_release_211

5 years agoMerge branch 'develop' into Jalview-JS/develop
gmungoc [Wed, 17 Apr 2019 10:48:28 +0000 (11:48 +0100)]
Merge branch 'develop' into Jalview-JS/develop

5 years agoJAL-3224 Add commons-compress-1.18.jar
Ben Soares [Wed, 17 Apr 2019 00:59:32 +0000 (01:59 +0100)]
JAL-3224 Add commons-compress-1.18.jar

5 years agoJAL-3224 Bundling appropriate Mac OS/Windows JRE as java_vm in install4j
Ben Soares [Wed, 17 Apr 2019 00:33:02 +0000 (01:33 +0100)]
JAL-3224 Bundling appropriate Mac OS/Windows JRE as java_vm in install4j

5 years agoJAL-3224 New version of getdown which will cope with unpacking .tgz resources, specif...
Ben Soares [Wed, 17 Apr 2019 00:04:19 +0000 (01:04 +0100)]
JAL-3224 New version of getdown which will cope with unpacking .tgz resources, specifically for the java_vm and symbolic links within

5 years agoJAL-3130 moved resources/install4j to utils/install4j
Ben Soares [Tue, 16 Apr 2019 23:45:47 +0000 (00:45 +0100)]
JAL-3130 moved resources/install4j to utils/install4j

5 years agobetter resource loading/file caching
hansonr [Tue, 16 Apr 2019 22:29:07 +0000 (17:29 -0500)]
better resource loading/file caching

5 years agocaching of DnD files dropped
hansonr [Tue, 16 Apr 2019 22:28:14 +0000 (17:28 -0500)]
caching of DnD files dropped

5 years agojmol-app updated for SwingJS ZipTools upgrade
hansonr [Tue, 16 Apr 2019 21:07:20 +0000 (16:07 -0500)]
jmol-app updated for SwingJS ZipTools upgrade

5 years agolocalizes Thread colourby so that it does not cause ThreadStateException
hansonr [Tue, 16 Apr 2019 21:06:36 +0000 (16:06 -0500)]
localizes Thread colourby so that it does not cause ThreadStateException
in Java

5 years agocomments only
hansonr [Tue, 16 Apr 2019 21:05:41 +0000 (16:05 -0500)]
comments only

5 years agoJAL-3130 tidy up system.output jims/JAL-3130_Java11_Gradle_publishing
Jim Procter [Tue, 16 Apr 2019 16:38:59 +0000 (17:38 +0100)]
JAL-3130 tidy up system.output

5 years agoJAL-3130 call Jalview via the Test JVM’s JAVA_HOME/bin/java
Jim Procter [Tue, 16 Apr 2019 16:38:18 +0000 (17:38 +0100)]
JAL-3130 call Jalview via the Test JVM’s JAVA_HOME/bin/java

5 years agoJAL-3130 refactored ‘clover’ to ‘use_clover’ since clover is an ambiguous property...
Jim Procter [Tue, 16 Apr 2019 16:36:45 +0000 (17:36 +0100)]
JAL-3130 refactored ‘clover’ to ‘use_clover’ since clover is an ambiguous property - still offer -Pclover=true as command line switch to enable clover coverage

5 years agoJAL-3130 JAL-1889 reportCurrentWorkingDirectory test to report absolute path when...
Jim Procter [Tue, 16 Apr 2019 15:06:52 +0000 (16:06 +0100)]
JAL-3130 JAL-1889 reportCurrentWorkingDirectory test to report absolute path when running command line tests

5 years agomissing check for JavaScript in client response for String (Java) vs.
hansonr [Tue, 16 Apr 2019 13:39:31 +0000 (08:39 -0500)]
missing check for JavaScript in client response for String (Java) vs.
Map (JavaScript) -- since JavaScript has already done the conversion to
a Map and needs no further JSON parsing.

5 years agoJAL-3130 JAL-1889 report absolute paths for CommandLineTests
Jim Procter [Tue, 16 Apr 2019 13:28:44 +0000 (14:28 +0100)]
JAL-3130 JAL-1889 report absolute paths for CommandLineTests

5 years agounused old SwingJS dependencies
hansonr [Tue, 16 Apr 2019 13:20:31 +0000 (08:20 -0500)]
unused old SwingJS dependencies

5 years agounused old SwingJS dependencies
hansonr [Tue, 16 Apr 2019 13:16:30 +0000 (08:16 -0500)]
unused old SwingJS dependencies

5 years agoJAL-3130 JAL-1889 report absolute paths for CommandLineTests
Jim Procter [Tue, 16 Apr 2019 13:14:10 +0000 (14:14 +0100)]
JAL-3130 JAL-1889 report absolute paths for CommandLineTests

5 years agoJAL-3130 JAL-1889 report absolute paths for CommandLineTests
Jim Procter [Tue, 16 Apr 2019 13:09:12 +0000 (14:09 +0100)]
JAL-3130 JAL-1889 report absolute paths for CommandLineTests

5 years agoAdds _j2sclasslist.txt to SwingJS distribution; fixes missing
hansonr [Tue, 16 Apr 2019 12:34:10 +0000 (07:34 -0500)]
Adds _j2sclasslist.txt to SwingJS distribution; fixes missing
menuListener

5 years agoJAL-3196 change default are resource properties to http://www.jalview.org/getdown/jre
Jim Procter [Tue, 16 Apr 2019 12:29:10 +0000 (13:29 +0100)]
JAL-3196 change default are resource properties to jalview.org/getdown/jre

5 years agoMerge branch 'bug/JAL-3218scalePanelPopups' into develop
gmungoc [Tue, 16 Apr 2019 11:48:31 +0000 (12:48 +0100)]
Merge branch 'bug/JAL-3218scalePanelPopups' into develop

5 years agoReinstate imports from "JAL-1889 JAL-3130 patch broken tests" commit 05efc2ac3c6427a4...
Jim Procter [Tue, 16 Apr 2019 10:01:10 +0000 (11:01 +0100)]
Reinstate imports from "JAL-1889 JAL-3130 patch broken tests" commit 05efc2ac3c6427a4dabce842ebbd6f2ae17f49b9.

5 years agoJAL-1189 JAL-3130 patch broken tests
Jim Procter [Tue, 16 Apr 2019 09:33:42 +0000 (10:33 +0100)]
JAL-1189 JAL-3130 patch broken tests

5 years agoJAL-3130 Somewhere in the old libs the Jws2 client is working. Compile with Java...
Ben Soares [Mon, 15 Apr 2019 16:26:30 +0000 (17:26 +0100)]
JAL-3130 Somewhere in the old libs the Jws2 client is working.  Compile with Java 11 in Java 1.8 target mode, and then run in Java1.8 JRE with 'java -cp "j8lib/*:classes" jalview.bin.Jalview'.  Will need to find out which of these is actually needed

5 years agoJAL-3130 Helper classes to take Class Exceptions when run in java 1.8 JRE out of...
Ben Soares [Mon, 15 Apr 2019 16:24:38 +0000 (17:24 +0100)]
JAL-3130 Helper classes to take Class Exceptions when run in java 1.8 JRE out of main classes

5 years agoJAL-3130 some clover fixes for helplinks. Use 'gradle test -Pclover=true'
Ben Soares [Mon, 15 Apr 2019 16:17:09 +0000 (17:17 +0100)]
JAL-3130 some clover fixes for helplinks. Use 'gradle test -Pclover=true'

5 years agoJAL-3193 no separatge EnsemblGenomes source in SequenceFetcher
gmungoc [Mon, 15 Apr 2019 15:52:19 +0000 (16:52 +0100)]
JAL-3193 no separatge EnsemblGenomes source in SequenceFetcher

5 years agoJAL-3130 adapted getdown src. attempt 2. first attempt failed due to cp'ed .git files
Ben Soares [Mon, 15 Apr 2019 09:25:36 +0000 (10:25 +0100)]
JAL-3130 adapted getdown src. attempt 2. first attempt failed due to cp'ed .git files

5 years agoMerge branch 'develop' into Jalview-JS/develop
gmungoc [Mon, 15 Apr 2019 08:47:50 +0000 (09:47 +0100)]
Merge branch 'develop' into Jalview-JS/develop

5 years agoJAL-3130 write clover.xml during cloverReport phase
Jim Procter [Sun, 14 Apr 2019 20:22:45 +0000 (21:22 +0100)]
JAL-3130 write clover.xml during cloverReport phase

5 years agoJAL-3130 make sure testng-results.xml is generated
Jim Procter [Sun, 14 Apr 2019 10:48:05 +0000 (11:48 +0100)]
JAL-3130 make sure testng-results.xml is generated

5 years agoJAL-3130 specify module list when launching new Jalview for CLI tests
Jim Procter [Fri, 12 Apr 2019 16:36:22 +0000 (17:36 +0100)]
JAL-3130 specify module list when launching new Jalview for CLI tests

5 years agoJAL-3130 instrument main and compile separately to test classes so Clover doesn’t...
Jim Procter [Fri, 12 Apr 2019 16:35:32 +0000 (17:35 +0100)]
JAL-3130 instrument main and compile separately to test classes so Clover doesn’t misclassify them

5 years agoJAL-3130 gradle test now runs open clover 4.3.1 and new cloverReport task
Jim Procter [Fri, 12 Apr 2019 15:06:54 +0000 (16:06 +0100)]
JAL-3130 gradle test now runs open clover 4.3.1 and new cloverReport task

5 years agoMerge branch 'develop' into task/JAL-3130_Java_11_investigations-getdown_src
Jim Procter [Thu, 11 Apr 2019 13:52:20 +0000 (14:52 +0100)]
Merge branch 'develop' into task/JAL-3130_Java_11_investigations-getdown_src

5 years agoJAL-3130 ensure J11 libs/modules are added when building and running test suite
Jim Procter [Thu, 11 Apr 2019 13:37:58 +0000 (14:37 +0100)]
JAL-3130 ensure J11 libs/modules are added when building and running test suite

5 years agoJAL-3130 clean up eclipse class path for dependencies moved to j11lib
Jim Procter [Thu, 11 Apr 2019 13:37:08 +0000 (14:37 +0100)]
JAL-3130 clean up eclipse class path for dependencies moved to j11lib

5 years agoJAL-3193 rest.ensemblgenomes.org merged to rest.ensembl.org
gmungoc [Wed, 10 Apr 2019 20:35:10 +0000 (21:35 +0100)]
JAL-3193 rest.ensemblgenomes.org merged to rest.ensembl.org

5 years agoJAL-3018 REST version updated to 10.0
gmungoc [Wed, 10 Apr 2019 20:20:22 +0000 (21:20 +0100)]
JAL-3018 REST version updated to 10.0

5 years agoJAL-3033 and more classes for examples core
Jim Procter [Wed, 10 Apr 2019 13:56:32 +0000 (14:56 +0100)]
JAL-3033 and more classes for examples core

5 years agoJAL-3033 http://www.jalview.org/jalview-js/JalviewJS.shtml?open%20http://www.jalview...
Jim Procter [Tue, 9 Apr 2019 13:23:56 +0000 (14:23 +0100)]
JAL-3033 jalview.org/jalview-js/JalviewJS.shtml?open%20http://www.jalview.org/examples/uniref50.fa

5 years agoJTable improvements
hansonr [Tue, 9 Apr 2019 04:41:36 +0000 (23:41 -0500)]
JTable improvements

- prevents loss of tool tip when clicking or editing

- corrects offset of center label in variable color option

- speed somewhat improved

5 years agobetter comment regarding setting recognized ajax-enabled sites
hansonr [Tue, 9 Apr 2019 04:39:28 +0000 (23:39 -0500)]
better comment regarding setting recognized ajax-enabled sites

5 years agoMerge branch 'Jalview-JS/develop' of https://source.jalview.org/git/jalview.git into...
hansonr [Tue, 9 Apr 2019 04:38:42 +0000 (23:38 -0500)]
Merge branch 'Jalview-JS/develop' of https://source.jalview.org/git/jalview.git into Jalview-JS/develop

5 years agocode formatting only
hansonr [Tue, 9 Apr 2019 04:38:21 +0000 (23:38 -0500)]
code formatting only

5 years agoJAL-3033 more classes for the kitchen sink
Jim Procter [Mon, 8 Apr 2019 13:43:32 +0000 (14:43 +0100)]
JAL-3033 more classes for the kitchen sink

5 years agoJAL-3033 updated classlist for loading the example file (jim's kitchensink corefile)
Jim Procter [Mon, 8 Apr 2019 13:23:29 +0000 (14:23 +0100)]
JAL-3033 updated classlist for loading the example file (jim's kitchensink corefile)

5 years agoFile caching activated explicitly in Platform
hansonr [Fri, 5 Apr 2019 18:43:12 +0000 (13:43 -0500)]
File caching activated explicitly in Platform

5 years agoJAL-3130 adapted getdown src
Ben Soares [Fri, 5 Apr 2019 17:01:18 +0000 (18:01 +0100)]
JAL-3130 adapted getdown src

5 years agoFix for #196 EBI does not allow AJAX on Tools/dbfetch - now they do.
hansonr [Fri, 5 Apr 2019 16:37:25 +0000 (11:37 -0500)]
Fix for #196  EBI does not allow AJAX on Tools/dbfetch  - now they do.

5 years agocommand line fix
hansonr [Fri, 5 Apr 2019 16:36:52 +0000 (11:36 -0500)]
command line fix

5 years agoJAL-3130 This commit concentrates on the Mac OS X DMG app bundle, ensuring only one...
Ben Soares [Fri, 5 Apr 2019 16:19:07 +0000 (17:19 +0100)]
JAL-3130 This commit concentrates on the Mac OS X DMG app bundle, ensuring only one JRE needed in the .app bundle for 1) install4j, 2) getdown, 3) jalview

5 years agoMerge branch 'Jalview-JS/develop' of https://source.jalview.org/git/jalview.git into...
hansonr [Fri, 5 Apr 2019 16:13:42 +0000 (11:13 -0500)]
Merge branch 'Jalview-JS/develop' of https://source.jalview.org/git/jalview.git into Jalview-JS/develop

5 years agofixes for Jalview command-line URI code
hansonr [Fri, 5 Apr 2019 16:13:21 +0000 (11:13 -0500)]
fixes for Jalview command-line URI code

5 years agoJAL-3204 update to uniprot schema
gmungoc [Fri, 5 Apr 2019 07:08:35 +0000 (08:08 +0100)]
JAL-3204 update to uniprot schema

5 years agoMerge branch 'Jalview-JS/develop' of https://source.jalview.org/git/jalview.git into...
hansonr [Thu, 4 Apr 2019 21:35:40 +0000 (16:35 -0500)]
Merge branch 'Jalview-JS/develop' of https://source.jalview.org/git/jalview.git into Jalview-JS/develop

5 years agoj2sNative cleanup; fix for JTextArea preferred height miscalculation
hansonr [Thu, 4 Apr 2019 21:31:44 +0000 (16:31 -0500)]
j2sNative cleanup; fix for JTextArea preferred height miscalculation

5 years agoJAL-3220 j2sIgnore on 3 more main methods
gmungoc [Thu, 4 Apr 2019 19:45:19 +0000 (20:45 +0100)]
JAL-3220 j2sIgnore on 3 more main methods

5 years agoJAL-3220 j2sIgnore on main methods on test / utility classes
gmungoc [Thu, 4 Apr 2019 19:37:32 +0000 (20:37 +0100)]
JAL-3220 j2sIgnore on main methods on test / utility classes

5 years agoJAL-3220 unneeded main methods removed
gmungoc [Thu, 4 Apr 2019 15:00:54 +0000 (16:00 +0100)]
JAL-3220 unneeded main methods removed

5 years agoJAL-3130 trying to be Java 1.8 source compatible -- not sure if this is ultimately...
Ben Soares [Thu, 4 Apr 2019 10:10:01 +0000 (11:10 +0100)]
JAL-3130 trying to be Java 1.8 source compatible -- not sure if this is ultimately feasible in the same .java files

5 years agoJAL-3130 JAL-3007 more files needed for getdown launcher
Ben Soares [Thu, 4 Apr 2019 10:09:04 +0000 (11:09 +0100)]
JAL-3130 JAL-3007 more files needed for getdown launcher

5 years agoJAL-3130 JAL-3007 improvements to gradle build
Ben Soares [Thu, 4 Apr 2019 10:08:07 +0000 (11:08 +0100)]
JAL-3130 JAL-3007 improvements to gradle build

5 years agoMerge branch 'develop' into Jalview-JS/develop
gmungoc [Thu, 4 Apr 2019 07:21:43 +0000 (08:21 +0100)]
Merge branch 'develop' into Jalview-JS/develop

5 years agoreplacing @j2sNative with @j2sIgnore where appropriate - requires NEW
hansonr [Wed, 3 Apr 2019 23:52:20 +0000 (18:52 -0500)]
replacing @j2sNative with @j2sIgnore where appropriate - requires NEW
TRANSPILER

5 years agoremoving early SplitPane SwingJS hack
hansonr [Wed, 3 Apr 2019 23:51:20 +0000 (18:51 -0500)]
removing early SplitPane SwingJS hack

5 years agoJAL-3021 show Sequence Details with cursor at top
gmungoc [Wed, 3 Apr 2019 15:43:19 +0000 (16:43 +0100)]
JAL-3021 show Sequence Details with cursor at top

5 years agoj2sNative clean-up. Fixes problem with second try of sequence fetching
hansonr [Wed, 3 Apr 2019 13:41:19 +0000 (08:41 -0500)]
j2sNative clean-up. Fixes problem with second try of sequence fetching
not retrieving (cached) data

5 years ago#210 Fixes Ensembl fetch problem (really)
hansonr [Tue, 2 Apr 2019 17:09:01 +0000 (12:09 -0500)]
#210 Fixes Ensembl fetch problem (really)

5 years agoJAL-3218 allow both Hide and Reveal in scale panel popup menu bug/JAL-3218scalePanelPopups
gmungoc [Tue, 2 Apr 2019 13:10:45 +0000 (14:10 +0100)]
JAL-3218 allow both Hide and Reveal in scale panel popup menu

5 years agoJAL-3130 JAL-3007 Added gradle build for Java 11. Now in root jalview dir
Ben Soares [Mon, 1 Apr 2019 16:04:56 +0000 (17:04 +0100)]
JAL-3130 JAL-3007 Added gradle build for Java 11. Now in root jalview dir

5 years agoMerge branch 'Jalview-JS/develop' of https://source.jalview.org/git/jalview.git into...
hansonr [Mon, 1 Apr 2019 14:31:10 +0000 (09:31 -0500)]
Merge branch 'Jalview-JS/develop' of https://source.jalview.org/git/jalview.git into Jalview-JS/develop

5 years agonote to self: Time to write a good interface and stop doing this secret
hansonr [Mon, 1 Apr 2019 14:30:53 +0000 (09:30 -0500)]
note to self: Time to write a good interface and stop doing this secret
calling of swingjs methods.