JAL-2360 structure viewers now using ColourMenuHelper, obsolete methods

[jalview.git] / src / jalview / gui / ColourMenuHelper.java

diff --git a/src/jalview/gui/ColourMenuHelper.java b/src/jalview/gui/ColourMenuHelper.java
index a5f4355..8e0765b 100644 (file)
--- a/src/jalview/gui/ColourMenuHelper.java
+++ b/src/jalview/gui/ColourMenuHelper.java
@@ -27,8 +27,9 @@ public class ColourMenuHelper
   /**
    * Adds items to the colour menu, as mutually exclusive members of a button
    * group. The callback handler is responsible for the action on selecting any
-   * of these options. It is returned the name of the selected colour, or "None"
-   * or "User Defined".
+   * of these options. The callback method receives the name of the selected
+   * colour, or "None" or "User Defined". This method returns the ButtonGroup to
+   * which items were added.
    * <ul>
    * <li>None</li>
    * <li>Clustal</li>
@@ -43,28 +44,35 @@ public class ColourMenuHelper
    *          a callback to handle menu selection
    * @param coll
    *          the data the menu is being built for
+   * @param simpleOnly
+   *          if true, only simple per-residue colour schemes are included
    */
-  public static void addMenuItems(final JMenu colourMenu,
-          final ColourChangeListener client, AnnotatedCollectionI coll)
+  public static ButtonGroup addMenuItems(final JMenu colourMenu,
+          final ColourChangeListener client, AnnotatedCollectionI coll,
+          boolean simpleOnly)
   {
     /*
      * ButtonGroup groups those items whose 
      * selection is mutually exclusive
      */
     ButtonGroup colours = new ButtonGroup();
-    JRadioButtonMenuItem noColourmenuItem = new JRadioButtonMenuItem(
-            MessageManager.getString("label.none"));
-    noColourmenuItem.setName(ResidueColourScheme.NONE);
-    noColourmenuItem.addActionListener(new ActionListener()
+
+    if (!simpleOnly)
     {
-      @Override
-      public void actionPerformed(ActionEvent e)
+      JRadioButtonMenuItem noColourmenuItem = new JRadioButtonMenuItem(
+              MessageManager.getString("label.none"));
+      noColourmenuItem.setName(ResidueColourScheme.NONE);
+      noColourmenuItem.addActionListener(new ActionListener()
       {
-        client.changeColour_actionPerformed(ResidueColourScheme.NONE);
-      }
-    });
-    colourMenu.add(noColourmenuItem);
-    colours.add(noColourmenuItem);
+        @Override
+        public void actionPerformed(ActionEvent e)
+        {
+          client.changeColour_actionPerformed(ResidueColourScheme.NONE);
+        }
+      });
+      colourMenu.add(noColourmenuItem);
+      colours.add(noColourmenuItem);
+    }
 
     /*
      * scan registered colour schemes (built-in or user-defined
@@ -74,9 +82,14 @@ public class ColourMenuHelper
             .getColourSchemes();
     for (ColourSchemeI scheme : colourSchemes)
     {
+      if (simpleOnly && !scheme.isSimple())
+      {
+        continue;
+      }
+
       /*
        * button text is i18n'd but the name is the canonical name of
-       * the colour scheme (inspected in changeColour_actionPerformed)
+       * the colour scheme (inspected in setColourSelected())
        */
       final String name = scheme.getSchemeName();
       String label = MessageManager.getStringOrReturn("label.colourScheme_"
@@ -148,18 +161,28 @@ public class ColourMenuHelper
       colours.add(radioItem);
     }
 
-    final String label = MessageManager.getString("action.user_defined");
-    JRadioButtonMenuItem userDefinedColour = new JRadioButtonMenuItem(label);
-    userDefinedColour.addActionListener(new ActionListener()
+    /*
+     * only add the option to load/configure a user-defined colour
+     * to the AlignFrame colour menu
+     */
+    if (client instanceof AlignFrame)
     {
-      @Override
-      public void actionPerformed(ActionEvent e)
+      final String label = MessageManager.getString("action.user_defined");
+      JRadioButtonMenuItem userDefinedColour = new JRadioButtonMenuItem(
+              label);
+      userDefinedColour.addActionListener(new ActionListener()
       {
-        client.changeColour_actionPerformed(ResidueColourScheme.USER_DEFINED);
-      }
-    });
-    colourMenu.add(userDefinedColour);
-    colours.add(userDefinedColour);
+        @Override
+        public void actionPerformed(ActionEvent e)
+        {
+          client.changeColour_actionPerformed(ResidueColourScheme.USER_DEFINED);
+        }
+      });
+      colourMenu.add(userDefinedColour);
+      colours.add(userDefinedColour);
+    }
+
+    return colours;
   }
 
   /**