JAL-3275 JAL-3633: JAL-3275 Turned Preferences into a Singleton that checks renews...

[jalview.git] / src / jalview / gui / Preferences.java

diff --git a/src/jalview/gui/Preferences.java b/src/jalview/gui/Preferences.java
index da33f39..65b333e 100755 (executable)
--- a/src/jalview/gui/Preferences.java
+++ b/src/jalview/gui/Preferences.java
@@ -129,6 +129,8 @@ public class Preferences extends GPreferences
 
   private String previousProxyType;
 
+  private static Preferences INSTANCE = null; // add "final"
+
   /**
    * Holds name and link separated with | character. Sequence ID must be
    * $SEQUENCE_ID$ or $SEQUENCE_ID=/.possible | chars ./=$
@@ -188,22 +190,43 @@ public class Preferences extends GPreferences
   private OptionsParam textOpt = new OptionsParam(
           MessageManager.getString("action.text"), "Text");
 
-  /**
-   * Creates a new Preferences object.
-   */
-  public Preferences()
+  // get singleton Preferences instance
+  public static Preferences getPreferences()
+  {
+    return getPreferences(0, null);
+  }
+
+  public static Preferences getPreferences(int selectTab, String message)
   {
-    new Preferences(0);
+    if (INSTANCE == null || INSTANCE.frame == null
+            || INSTANCE.frame.isClosed())
+    {
+      INSTANCE = new Preferences();
+    }
+    INSTANCE.selectTab(selectTab);
+    INSTANCE.setMessage(message);
+    return INSTANCE;
   }
 
-  public Preferences(int selectTab)
+  public static void openPreferences()
   {
-    new Preferences(selectTab, null);
+    openPreferences(0, null);
   }
 
-  public Preferences(int selectTab, String message)
+  public static void openPreferences(int selectTab, String message)
   {
-    super(selectTab, message);
+    Preferences p = getPreferences(selectTab, message);
+    p.frame.show();
+    p.frame.moveToFront();
+    p.frame.grabFocus();
+  }
+
+  /**
+   * Creates a new Preferences object.
+   */
+  private Preferences()
+  {
+    super();
     frame = new JInternalFrame();
     frame.setContentPane(this);
     if (!Platform.isJS())
@@ -574,7 +597,7 @@ public class Preferences extends GPreferences
     proxyAuthUsernameTB
             .setText(Cache.getDefault("PROXY_AUTH_USERNAME", ""));
     // we are not storing or retrieving proxy password from .jalview_properties
-    proxyAuthPasswordTB.setText(Cache.proxyAuthPassword == null ? ""
+    proxyAuthPasswordPB.setText(Cache.proxyAuthPassword == null ? ""
             : new String(Cache.proxyAuthPassword));
     setCustomProxyEnabled();
 
@@ -675,6 +698,11 @@ public class Preferences extends GPreferences
       return;
     }
 
+    /* 
+     * Set proxy settings first (to be before web services refresh)
+     */
+    saveProxySettings();
+
     /*
      * Save Visual settings
      */
@@ -818,6 +846,8 @@ public class Preferences extends GPreferences
     /*
      * Save Connections settings
      */
+    // Proxy settings set first (to catch web services)
+
     Cache.setOrRemove("DEFAULT_BROWSER", defaultBrowser.getText());
 
     jalview.util.BrowserLauncher.resetBrowser();
@@ -848,9 +878,6 @@ public class Preferences extends GPreferences
     Cache.applicationProperties.setProperty("DEFAULT_URL",
             sequenceUrlLinks.getPrimaryUrlId());
 
-    // Proxy settings
-    saveProxySettings();
-
     Cache.setProperty("VERSION_CHECK",
             Boolean.toString(versioncheck.isSelected()));
     if (Cache.getProperty("USAGESTATS") != null || usagestats.isSelected())
@@ -949,10 +976,10 @@ public class Preferences extends GPreferences
 
   public void saveProxySettings()
   {
-    Cache.applicationProperties.setProperty("USE_PROXY",
-            customProxy.isSelected() ? Cache.PROXYTYPE_CUSTOM
-                    : noProxy.isSelected() ? Cache.PROXYTYPE_NONE
-                            : Cache.PROXYTYPE_SYSTEM);
+    String newProxyType = customProxy.isSelected() ? Cache.PROXYTYPE_CUSTOM
+            : noProxy.isSelected() ? Cache.PROXYTYPE_NONE
+                    : Cache.PROXYTYPE_SYSTEM;
+    Cache.applicationProperties.setProperty("USE_PROXY", newProxyType);
     Cache.setOrRemove("PROXY_SERVER", proxyServerHttpTB.getText());
     Cache.setOrRemove("PROXY_PORT", proxyPortHttpTB.getText());
     Cache.setOrRemove("PROXY_SERVER_HTTPS", proxyServerHttpsTB.getText());
@@ -960,8 +987,15 @@ public class Preferences extends GPreferences
     Cache.setOrRemove("PROXY_AUTH",
             Boolean.toString(proxyAuth.isSelected()));
     Cache.setOrRemove("PROXY_AUTH_USERNAME", proxyAuthUsernameTB.getText());
-    Cache.proxyAuthPassword = proxyAuthPasswordTB.getPassword();
+    Cache.proxyAuthPassword = proxyAuthPasswordPB.getPassword();
     Cache.setProxyPropertiesFromPreferences(previousProxyType);
+    if (newProxyType.equals(Cache.PROXYTYPE_CUSTOM)
+            || !newProxyType.equals(previousProxyType))
+    {
+      // force a re-lookup of ws if proxytype is custom or has changed
+      wsPrefs.update++;
+    }
+    previousProxyType = newProxyType;
   }
 
   /**