JAL-3365 expand range of allowed DSSP secondary structure symbols in Stockholm files
[jalview.git] / src / jalview / io / StockholmFile.java
index accd100..5d645ca 100644 (file)
@@ -1,19 +1,21 @@
 /*
- * Jalview - A Sequence Alignment Editor and Viewer (Version 2.8.2)
- * Copyright (C) 2014 The Jalview Authors
+ * Jalview - A Sequence Alignment Editor and Viewer ($$Version-Rel$$)
+ * Copyright (C) $$Year-Rel$$ The Jalview Authors
  * 
  * This file is part of Jalview.
  * 
  * Jalview is free software: you can redistribute it and/or
  * modify it under the terms of the GNU General Public License 
- * as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
+ * as published by the Free Software Foundation, either version 3
+ * of the License, or (at your option) any later version.
  *  
  * Jalview is distributed in the hope that it will be useful, but 
  * WITHOUT ANY WARRANTY; without even the implied warranty 
  * of MERCHANTABILITY or FITNESS FOR A PARTICULAR 
  * PURPOSE.  See the GNU General Public License for more details.
  * 
- * You should have received a copy of the GNU General Public License along with Jalview.  If not, see <http://www.gnu.org/licenses/>.
+ * You should have received a copy of the GNU General Public License
+ * along with Jalview.  If not, see <http://www.gnu.org/licenses/>.
  * The Jalview Authors are detailed in the 'AUTHORS' file.
  */
 /*
  */
 package jalview.io;
 
-import jalview.datamodel.AlignmentI;
-import jalview.datamodel.AlignmentAnnotation;
-import jalview.datamodel.AlignmentI;
-import jalview.datamodel.Annotation;
-import jalview.datamodel.DBRefEntry;
-import jalview.datamodel.Mapping;
-import jalview.datamodel.Sequence;
-import jalview.datamodel.SequenceFeature;
-import jalview.datamodel.SequenceI;
-import jalview.util.Format;
-
 import java.io.BufferedReader;
 import java.io.FileReader;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Enumeration;
 import java.util.Hashtable;
+import java.util.LinkedHashMap;
 import java.util.List;
-import java.util.StringTokenizer;
+import java.util.Locale;
+import java.util.Map;
 import java.util.Vector;
 
 import com.stevesoft.pat.Regex;
@@ -47,8 +40,21 @@ import com.stevesoft.pat.Regex;
 import fr.orsay.lri.varna.exceptions.ExceptionUnmatchedClosingParentheses;
 import fr.orsay.lri.varna.factories.RNAFactory;
 import fr.orsay.lri.varna.models.rna.RNA;
-
-// import org.apache.log4j.*;
+import jalview.analysis.Rna;
+import jalview.datamodel.AlignmentAnnotation;
+import jalview.datamodel.AlignmentI;
+import jalview.datamodel.Annotation;
+import jalview.datamodel.DBRefEntry;
+import jalview.datamodel.DBRefSource;
+import jalview.datamodel.Mapping;
+import jalview.datamodel.Sequence;
+import jalview.datamodel.SequenceFeature;
+import jalview.datamodel.SequenceI;
+import jalview.schemes.ResidueProperties;
+import jalview.util.Comparison;
+import jalview.util.DBRefUtils;
+import jalview.util.Format;
+import jalview.util.MessageManager;
 
 /**
  * This class is supposed to parse a Stockholm format file into Jalview There
@@ -60,15 +66,32 @@ import fr.orsay.lri.varna.models.rna.RNA;
  * 
  * @author bsb at sanger.ac.uk
  * @author Natasha Shersnev (Dundee, UK) (Stockholm file writer)
- * @author Lauren Lui (UCSC, USA) (RNA secondary structure annotation import as stockholm)
+ * @author Lauren Lui (UCSC, USA) (RNA secondary structure annotation import as
+ *         stockholm)
  * @author Anne Menard (Paris, FR) (VARNA parsing of Stockholm file data)
  * @version 0.3 + jalview mods
  * 
  */
 public class StockholmFile extends AlignFile
 {
-  // static Logger logger = Logger.getLogger("jalview.io.StockholmFile");
-  protected ArrayList<RNA> result;
+  private static final String ANNOTATION = "annotation";
+
+  // private static final Regex OPEN_PAREN = new Regex("(<|\\[)", "(");
+  //
+  // private static final Regex CLOSE_PAREN = new Regex("(>|\\])", ")");
+
+  public static final Regex DETECT_BRACKETS = new Regex(
+          "(<|>|\\[|\\]|\\(|\\)|\\{|\\})");
+
+  // WUSS extended symbols. Avoid ambiguity with protein SS annotations by using
+  // NOT_RNASS first.
+  public static final String RNASS_BRACKETS = "<>[](){}AaBbCcDdEeFfGgHhIiJjKkLlMmNnOoPpQqRrSsTtUuVvWwXxYyZz";
+
+  // use the following regex to decide an annotations (whole) line is NOT an RNA
+  // SS (it contains only E,H,e,h and other non-brace/non-alpha chars)
+  private static final Regex NOT_RNASS = new Regex(
+          "^[^<>[\\](){}ADFJ-RUVWYZadfj-ruvwyz]*$");
+
   StringBuffer out; // output buffer
 
   AlignmentI al;
@@ -85,7 +108,8 @@ public class StockholmFile extends AlignFile
     this.al = al;
   }
 
-  public StockholmFile(String inFile, String type) throws IOException
+  public StockholmFile(String inFile, DataSourceType type)
+          throws IOException
   {
     super(inFile, type);
   }
@@ -95,10 +119,12 @@ public class StockholmFile extends AlignFile
     super(source);
   }
 
+  @Override
   public void initData()
   {
     super.initData();
   }
+
   /**
    * Parse a file in Stockholm format into Jalview's data model using VARNA
    * 
@@ -111,7 +137,7 @@ public class StockholmFile extends AlignFile
     fr = new FileReader(inFile);
 
     BufferedReader r = new BufferedReader(fr);
-    result = null;
+    List<RNA> result = null;
     try
     {
       result = RNAFactory.loadSecStrStockholm(r);
@@ -124,7 +150,7 @@ public class StockholmFile extends AlignFile
     // DEBUG System.out.println("this is the secondary scructure:"
     // +result.size());
     SequenceI[] seqs = new SequenceI[result.size()];
-    String id=null;
+    String id = null;
     for (int i = 0; i < result.size(); i++)
     {
       // DEBUG System.err.println("Processing i'th sequence in Stockholm file")
@@ -149,8 +175,7 @@ public class StockholmFile extends AlignFile
       for (int k = 0; k < rna.length(); k++)
       {
         ann[k] = new Annotation(annot[k], "",
-                jalview.schemes.ResidueProperties.getRNASecStrucState(
-                        annot[k]).charAt(0), 0f);
+                Rna.getRNASecStrucState(annot[k]).charAt(0), 0f);
 
       }
       AlignmentAnnotation align = new AlignmentAnnotation("Sec. str.",
@@ -164,7 +189,6 @@ public class StockholmFile extends AlignFile
 
   }
 
-  
   /**
    * Parse a file in Stockholm format into Jalview's data model. The file has to
    * be passed at construction time
@@ -172,73 +196,73 @@ public class StockholmFile extends AlignFile
    * @throws IOException
    *           If there is an error with the input file
    */
+  @Override
   public void parse() throws IOException
   {
-      StringBuffer treeString = new StringBuffer();
-      String treeName = null;
-      // --------------- Variable Definitions -------------------
-      String line;
-      String version;
+    StringBuffer treeString = new StringBuffer();
+    String treeName = null;
+    // --------------- Variable Definitions -------------------
+    String line;
+    String version;
     // String id;
-      Hashtable seqAnn = new Hashtable(); // Sequence related annotations
-      Hashtable seqs = new Hashtable();
-      Regex p, r, rend, s, x;
-      // Temporary line for processing RNA annotation
-      // String RNAannot = "";
-
-      // ------------------ Parsing File ----------------------
-      // First, we have to check that this file has STOCKHOLM format, i.e. the
-      // first line must match
-      
-  
-               r = new Regex("# STOCKHOLM ([\\d\\.]+)");
-               if (!r.search(nextLine()))
-               {
-                       throw new IOException(
-                                       "This file is not in valid STOCKHOLM format: First line does not contain '# STOCKHOLM'");
-               }
-               else
-               {
-                       version = r.stringMatched(1);
-               
-                       // logger.debug("Stockholm version: " + version);
-               }
-
-               // We define some Regexes here that will be used regularily later
-               rend = new Regex("^\\s*\\/\\/"); // Find the end of an alignment
-               p = new Regex("(\\S+)\\/(\\d+)\\-(\\d+)"); // split sequence id in
-               // id/from/to
-               s = new Regex("(\\S+)\\s+(\\S*)\\s+(.*)"); // Parses annotation subtype
-               r = new Regex("#=(G[FSRC]?)\\s+(.*)"); // Finds any annotation line
-               x = new Regex("(\\S+)\\s+(\\S+)"); // split id from sequence
-
-               // Convert all bracket types to parentheses (necessary for passing to VARNA)
-               Regex openparen = new Regex("(<|\\[)", "(");
-               Regex closeparen = new Regex("(>|\\])", ")");
-
-               // Detect if file is RNA by looking for bracket types
-               Regex detectbrackets = new Regex("(<|>|\\[|\\]|\\(|\\))");
-
-               rend.optimize();
-           p.optimize();
-           s.optimize();
-           r.optimize();
-           x.optimize();
-           openparen.optimize();
-           closeparen.optimize();
-       
-           while ((line = nextLine()) != null)
-           {
-             if (line.length() == 0)
-             {
-               continue;
-             }
-             if (rend.search(line))
-             {
-               // End of the alignment, pass stuff back
+    Hashtable seqAnn = new Hashtable(); // Sequence related annotations
+    LinkedHashMap<String, String> seqs = new LinkedHashMap<>();
+    Regex p, r, rend, s, x;
+    // Temporary line for processing RNA annotation
+    // String RNAannot = "";
+
+    // ------------------ Parsing File ----------------------
+    // First, we have to check that this file has STOCKHOLM format, i.e. the
+    // first line must match
+
+    r = new Regex("# STOCKHOLM ([\\d\\.]+)");
+    if (!r.search(nextLine()))
+    {
+      throw new IOException(MessageManager
+              .getString("exception.stockholm_invalid_format"));
+    }
+    else
+    {
+      version = r.stringMatched(1);
+
+      // logger.debug("Stockholm version: " + version);
+    }
+
+    // We define some Regexes here that will be used regularily later
+    rend = new Regex("^\\s*\\/\\/"); // Find the end of an alignment
+    p = new Regex("(\\S+)\\/(\\d+)\\-(\\d+)"); // split sequence id in
+    // id/from/to
+    s = new Regex("(\\S+)\\s+(\\S*)\\s+(.*)"); // Parses annotation subtype
+    r = new Regex("#=(G[FSRC]?)\\s+(.*)"); // Finds any annotation line
+    x = new Regex("(\\S+)\\s+(\\S+)"); // split id from sequence
+
+    // Convert all bracket types to parentheses (necessary for passing to VARNA)
+    Regex openparen = new Regex("(<|\\[)", "(");
+    Regex closeparen = new Regex("(>|\\])", ")");
+
+    // // Detect if file is RNA by looking for bracket types
+    // Regex detectbrackets = new Regex("(<|>|\\[|\\]|\\(|\\))");
+
+    rend.optimize();
+    p.optimize();
+    s.optimize();
+    r.optimize();
+    x.optimize();
+    openparen.optimize();
+    closeparen.optimize();
+
+    while ((line = nextLine()) != null)
+    {
+      if (line.length() == 0)
+      {
+        continue;
+      }
+      if (rend.search(line))
+      {
+        // End of the alignment, pass stuff back
         this.noSeqs = seqs.size();
-       
-        String seqdb,dbsource = null;
+
+        String dbsource = null;
         Regex pf = new Regex("PF[0-9]{5}(.*)"); // Finds AC for Pfam
         Regex rf = new Regex("RF[0-9]{5}(.*)"); // Finds AC for Rfam
         if (getAlignmentProperty("AC") != null)
@@ -254,102 +278,107 @@ public class StockholmFile extends AlignFile
             dbsource = "RFAM";
           }
         }
-               // logger.debug("Number of sequences: " + this.noSeqs);
-               Enumeration accs = seqs.keys();
-               while (accs.hasMoreElements())
-               {
-                 String acc = (String) accs.nextElement();
-                 // logger.debug("Processing sequence " + acc);
-                 String seq = (String) seqs.remove(acc);
-                 if (maxLength < seq.length())
-                 {
-                   maxLength = seq.length();
-                 }
-                 int start = 1;
-                 int end = -1;
-                 String sid = acc;
-                 /*
+        // logger.debug("Number of sequences: " + this.noSeqs);
+        for (Map.Entry<String, String> skey : seqs.entrySet())
+        {
+          // logger.debug("Processing sequence " + acc);
+          String acc = skey.getKey();
+          String seq = skey.getValue();
+          if (maxLength < seq.length())
+          {
+            maxLength = seq.length();
+          }
+          int start = 1;
+          int end = -1;
+          String sid = acc;
+          /*
            * Retrieve hash of annotations for this accession Associate
            * Annotation with accession
-                  */
-                 Hashtable accAnnotations = null;
-       
-                 if (seqAnn != null && seqAnn.containsKey(acc))
-                 {
-                   accAnnotations = (Hashtable) seqAnn.remove(acc);
-                   //TODO: add structures to sequence
-                 }
-       
-                 // Split accession in id and from/to
-                 if (p.search(acc))
-                 {
-                   sid = p.stringMatched(1);
-                   start = Integer.parseInt(p.stringMatched(2));
-                   end = Integer.parseInt(p.stringMatched(3));
-                 }
-                 // logger.debug(sid + ", " + start + ", " + end);
-       
-                 Sequence seqO = new Sequence(sid, seq, start, end);
-                 // Add Description (if any)
-                 if (accAnnotations != null && accAnnotations.containsKey("DE"))
-                 {
-                   String desc = (String) accAnnotations.get("DE");
-                   seqO.setDescription((desc == null) ? "" : desc);
-                 }
-                 // Add DB References (if any)
-                 if (accAnnotations != null && accAnnotations.containsKey("DR"))
-                 {
-                   String dbr = (String) accAnnotations.get("DR");
-                   if (dbr != null && dbr.indexOf(";") > -1)
-                   {
-                     String src = dbr.substring(0, dbr.indexOf(";"));
-                     String acn = dbr.substring(dbr.indexOf(";") + 1);
-                     jalview.util.DBRefUtils.parseToDbRef(seqO, src, "0", acn);
-                   }
-                 }        
+           */
+          Hashtable accAnnotations = null;
+
+          if (seqAnn != null && seqAnn.containsKey(acc))
+          {
+            accAnnotations = (Hashtable) seqAnn.remove(acc);
+            // TODO: add structures to sequence
+          }
+
+          // Split accession in id and from/to
+          if (p.search(acc))
+          {
+            sid = p.stringMatched(1);
+            start = Integer.parseInt(p.stringMatched(2));
+            end = Integer.parseInt(p.stringMatched(3));
+          }
+          // logger.debug(sid + ", " + start + ", " + end);
+
+          Sequence seqO = new Sequence(sid, seq, start, end);
+          // Add Description (if any)
+          if (accAnnotations != null && accAnnotations.containsKey("DE"))
+          {
+            String desc = (String) accAnnotations.get("DE");
+            seqO.setDescription((desc == null) ? "" : desc);
+          }
+          // Add DB References (if any)
+          if (accAnnotations != null && accAnnotations.containsKey("DR"))
+          {
+            String dbr = (String) accAnnotations.get("DR");
+            if (dbr != null && dbr.indexOf(";") > -1)
+            {
+              String src = dbr.substring(0, dbr.indexOf(";"));
+              String acn = dbr.substring(dbr.indexOf(";") + 1);
+              jalview.util.DBRefUtils.parseToDbRef(seqO, src, "0", acn);
+            }
+          }
 
           if (accAnnotations != null && accAnnotations.containsKey("AC"))
           {
-            if (dbsource != null)
+            String dbr = (String) accAnnotations.get("AC");
+            if (dbr != null)
             {
-              String dbr = (String) accAnnotations.get("AC");
-              if (dbr != null)
-                 {
-                // we could get very clever here - but for now - just try to guess accession type from source of alignment plus structure of accession
-                guessDatabaseFor(seqO, dbr, dbsource);
-                         
-                           }
-                 }
-            // else - do what ?  add the data anyway and prompt the user to specify what references these are ?
+              // we could get very clever here - but for now - just try to
+              // guess accession type from type of sequence, source of alignment
+              // plus
+              // structure
+              // of accession
+              guessDatabaseFor(seqO, dbr, dbsource);
+            }
+            // else - do what ? add the data anyway and prompt the user to
+            // specify what references these are ?
           }
-               
-                 Hashtable features = null;
-                 // We need to adjust the positions of all features to account for gaps
-                 try
-                 {
-                   features = (Hashtable) accAnnotations.remove("features");
-                 } catch (java.lang.NullPointerException e)
-                 {
-                   // loggerwarn("Getting Features for " + acc + ": " +
-                   // e.getMessage());
-                   // continue;
-                 }
-                 // if we have features
-                 if (features != null)
-                 {
-                   int posmap[] = seqO.findPositionMap();
-                   Enumeration i = features.keys();
-                   while (i.hasMoreElements())
-                   {
-                     // TODO: parse out secondary structure annotation as annotation
-                     // row
-                     // TODO: parse out scores as annotation row
-                     // TODO: map coding region to core jalview feature types
-                     String type = i.nextElement().toString();
-                     Hashtable content = (Hashtable) features.remove(type);
+
+          Hashtable features = null;
+          // We need to adjust the positions of all features to account for gaps
+          try
+          {
+            features = (Hashtable) accAnnotations.remove("features");
+          } catch (java.lang.NullPointerException e)
+          {
+            // loggerwarn("Getting Features for " + acc + ": " +
+            // e.getMessage());
+            // continue;
+          }
+          // if we have features
+          if (features != null)
+          {
+            int posmap[] = seqO.findPositionMap();
+            Enumeration i = features.keys();
+            while (i.hasMoreElements())
+            {
+              // TODO: parse out secondary structure annotation as annotation
+              // row
+              // TODO: parse out scores as annotation row
+              // TODO: map coding region to core jalview feature types
+              String type = i.nextElement().toString();
+              Hashtable content = (Hashtable) features.remove(type);
 
               // add alignment annotation for this feature
               String key = type2id(type);
+
+              /*
+               * have we added annotation rows for this type ?
+               */
+              boolean annotsAdded = false;
               if (key != null)
               {
                 if (accAnnotations != null
@@ -358,345 +387,371 @@ public class StockholmFile extends AlignFile
                   Vector vv = (Vector) accAnnotations.get(key);
                   for (int ii = 0; ii < vv.size(); ii++)
                   {
+                    annotsAdded = true;
                     AlignmentAnnotation an = (AlignmentAnnotation) vv
                             .elementAt(ii);
                     seqO.addAlignmentAnnotation(an);
+                    annotations.add(an);
+                  }
+                }
+              }
+
+              Enumeration j = content.keys();
+              while (j.hasMoreElements())
+              {
+                String desc = j.nextElement().toString();
+                if (ANNOTATION.equals(desc) && annotsAdded)
+                {
+                  // don't add features if we already added an annotation row
+                  continue;
+                }
+                String ns = content.get(desc).toString();
+                char[] byChar = ns.toCharArray();
+                for (int k = 0; k < byChar.length; k++)
+                {
+                  char c = byChar[k];
+                  if (!(c == ' ' || c == '_' || c == '-' || c == '.')) // PFAM
+                  // uses
+                  // '.'
+                  // for
+                  // feature
+                  // background
+                  {
+                    int new_pos = posmap[k]; // look up nearest seqeunce
+                    // position to this column
+                    SequenceFeature feat = new SequenceFeature(type, desc,
+                            new_pos, new_pos, null);
+
+                    seqO.addSequenceFeature(feat);
                   }
                 }
               }
 
-                     Enumeration j = content.keys();
-                     while (j.hasMoreElements())
-                     {
-                       String desc = j.nextElement().toString();
-                       String ns = content.get(desc).toString();
-                       char[] byChar = ns.toCharArray();
-                       for (int k = 0; k < byChar.length; k++)
-                       {
-                         char c = byChar[k];
-                         if (!(c == ' ' || c == '_' || c == '-' || c == '.')) // PFAM
-                         // uses
-                         // '.'
-                         // for
-                         // feature
-                         // background
-                         {
-                           int new_pos = posmap[k]; // look up nearest seqeunce
-                           // position to this column
-                           SequenceFeature feat = new SequenceFeature(type, desc,
-                                   new_pos, new_pos, 0f, null);
-       
-                           seqO.addSequenceFeature(feat);
-                         }
-                       }
-                     }
-       
-                   }
-       
-                 }
-                 // garbage collect
-       
-                 // logger.debug("Adding seq " + acc + " from " + start + " to " + end
-                 // + ": " + seq);
-                 this.seqs.addElement(seqO);
-               }
-               return; // finished parsing this segment of source
-             }
-             else if (!r.search(line))
-             {
-               // System.err.println("Found sequence line: " + line);
-       
-               // Split sequence in sequence and accession parts
-               if (!x.search(line))
-               {
-                 // logger.error("Could not parse sequence line: " + line);
-                 throw new IOException("Could not parse sequence line: " + line);
-               }
-               String ns = (String) seqs.get(x.stringMatched(1));
-               if (ns == null)
-               {
-                 ns = "";
-               }
-               ns += x.stringMatched(2);
-       
-               seqs.put(x.stringMatched(1), ns);
-             }
-             else
-             {
-               String annType = r.stringMatched(1);
-               String annContent = r.stringMatched(2);
-       
-               // System.err.println("type:" + annType + " content: " + annContent);
-       
-               if (annType.equals("GF"))
-               {
-                 /*
-                  * Generic per-File annotation, free text Magic features: #=GF NH
-                  * <tree in New Hampshire eXtended format> #=GF TN <Unique identifier
-                  * for the next tree> Pfam descriptions: 7. DESCRIPTION OF FIELDS
-                  * 
-                  * Compulsory fields: ------------------
-                  * 
-                  * AC Accession number: Accession number in form PFxxxxx.version or
-                  * PBxxxxxx. ID Identification: One word name for family. DE
-                  * Definition: Short description of family. AU Author: Authors of the
-                  * entry. SE Source of seed: The source suggesting the seed members
-                  * belong to one family. GA Gathering method: Search threshold to
-                  * build the full alignment. TC Trusted Cutoff: Lowest sequence score
-                  * and domain score of match in the full alignment. NC Noise Cutoff:
-                  * Highest sequence score and domain score of match not in full
-                  * alignment. TP Type: Type of family -- presently Family, Domain,
-                  * Motif or Repeat. SQ Sequence: Number of sequences in alignment. AM
-                  * Alignment Method The order ls and fs hits are aligned to the model
-                  * to build the full align. // End of alignment.
-                  * 
-                  * Optional fields: ----------------
-                  * 
-                  * DC Database Comment: Comment about database reference. DR Database
-                  * Reference: Reference to external database. RC Reference Comment:
-                  * Comment about literature reference. RN Reference Number: Reference
-                  * Number. RM Reference Medline: Eight digit medline UI number. RT
-                  * Reference Title: Reference Title. RA Reference Author: Reference
-                  * Author RL Reference Location: Journal location. PI Previous
-                  * identifier: Record of all previous ID lines. KW Keywords: Keywords.
-                  * CC Comment: Comments. NE Pfam accession: Indicates a nested domain.
-                  * NL Location: Location of nested domains - sequence ID, start and
-                  * end of insert.
-                  * 
-                  * Obsolete fields: ----------- AL Alignment method of seed: The
-                  * method used to align the seed members.
-                  */
-                 // Let's save the annotations, maybe we'll be able to do something
-                 // with them later...
-                 Regex an = new Regex("(\\w+)\\s*(.*)");
-                 if (an.search(annContent))
-                 {
-                   if (an.stringMatched(1).equals("NH"))
-                   {
-                     treeString.append(an.stringMatched(2));
-                   }
-                   else if (an.stringMatched(1).equals("TN"))
-                   {
-                     if (treeString.length() > 0)
-                     {
-                       if (treeName == null)
-                       {
-                         treeName = "Tree " + (getTreeCount() + 1);
-                       }
-                       addNewickTree(treeName, treeString.toString());
-                     }
-                     treeName = an.stringMatched(2);
-                     treeString = new StringBuffer();
-                   }
-                   setAlignmentProperty(an.stringMatched(1), an.stringMatched(2));
-                 }
-               }
-               else if (annType.equals("GS"))
-               {
-                 // Generic per-Sequence annotation, free text
-                 /*
-                  * Pfam uses these features: Feature Description ---------------------
-                  * ----------- AC <accession> ACcession number DE <freetext>
-                  * DEscription DR <db>; <accession>; Database Reference OS <organism>
-                  * OrganiSm (species) OC <clade> Organism Classification (clade, etc.)
-                  * LO <look> Look (Color, etc.)
-                  */
-                 if (s.search(annContent))
-                 {
-                   String acc = s.stringMatched(1);
-                   String type = s.stringMatched(2);
-                   String content = s.stringMatched(3);
-                   // TODO: store DR in a vector.
-                   // TODO: store AC according to generic file db annotation.
-                   Hashtable ann;
-                   if (seqAnn.containsKey(acc))
-                   {
-                     ann = (Hashtable) seqAnn.get(acc);
-                   }
-                   else
-                   {
-                     ann = new Hashtable();
-                   }
-                   ann.put(type, content);
-                   seqAnn.put(acc, ann);
-                 }
-                 else
-                 {
-                   throw new IOException("Error parsing " + line);
-                 }
-               }
-               else if (annType.equals("GC"))
-               {
-                 // Generic per-Column annotation, exactly 1 char per column
-                 // always need a label.
-                 if (x.search(annContent))
-                 {
-                   // parse out and create alignment annotation directly.
-                   parseAnnotationRow(annotations, x.stringMatched(1),
-                           x.stringMatched(2));
-                 }
-               }
-               else if (annType.equals("GR"))
-               {
-                 // Generic per-Sequence AND per-Column markup, exactly 1 char per
-                 // column
-                 /*
-                  * Feature Description Markup letters ------- -----------
-                  * -------------- SS Secondary Structure [HGIEBTSCX] SA Surface
-                  * Accessibility [0-9X] (0=0%-10%; ...; 9=90%-100%) TM TransMembrane
-                  * [Mio] PP Posterior Probability [0-9*] (0=0.00-0.05; 1=0.05-0.15;
-                  * *=0.95-1.00) LI LIgand binding [*] AS Active Site [*] IN INtron (in
-                  * or after) [0-2]
-                  */
-                 if (s.search(annContent))
-                 {
-                   String acc = s.stringMatched(1);
-                   String type = s.stringMatched(2);
-                   String seq = new String(s.stringMatched(3));
-                   String description = null;
-                   // Check for additional information about the current annotation
-                   // We use a simple string tokenizer here for speed
-                   StringTokenizer sep = new StringTokenizer(seq, " \t");
-                   description = sep.nextToken();
-                   if (sep.hasMoreTokens())
-                   {
-                     seq = sep.nextToken();
-                   }
-                   else
-                   {
-                     seq = description;
-                     description = new String();
-                   }
-                   // sequence id with from-to fields
-       
-                   Hashtable ann;
-                   // Get an object with all the annotations for this sequence
-                   if (seqAnn.containsKey(acc))
-                   {
-                     // logger.debug("Found annotations for " + acc);
-                     ann = (Hashtable) seqAnn.get(acc);
-                   }
-                   else
-                   {
-                     // logger.debug("Creating new annotations holder for " + acc);
-                     ann = new Hashtable();
-                     seqAnn.put(acc, ann);
-                   }
+            }
+
+          }
+          // garbage collect
+
+          // logger.debug("Adding seq " + acc + " from " + start + " to " + end
+          // + ": " + seq);
+          this.seqs.addElement(seqO);
+        }
+        return; // finished parsing this segment of source
+      }
+      else if (!r.search(line))
+      {
+        // System.err.println("Found sequence line: " + line);
+
+        // Split sequence in sequence and accession parts
+        if (!x.search(line))
+        {
+          // logger.error("Could not parse sequence line: " + line);
+          throw new IOException(MessageManager.formatMessage(
+                  "exception.couldnt_parse_sequence_line", new String[]
+                  { line }));
+        }
+        String ns = seqs.get(x.stringMatched(1));
+        if (ns == null)
+        {
+          ns = "";
+        }
+        ns += x.stringMatched(2);
+
+        seqs.put(x.stringMatched(1), ns);
+      }
+      else
+      {
+        String annType = r.stringMatched(1);
+        String annContent = r.stringMatched(2);
+
+        // System.err.println("type:" + annType + " content: " + annContent);
+
+        if (annType.equals("GF"))
+        {
+          /*
+           * Generic per-File annotation, free text Magic features: #=GF NH
+           * <tree in New Hampshire eXtended format> #=GF TN <Unique identifier
+           * for the next tree> Pfam descriptions: 7. DESCRIPTION OF FIELDS
+           * 
+           * Compulsory fields: ------------------
+           * 
+           * AC Accession number: Accession number in form PFxxxxx.version or
+           * PBxxxxxx. ID Identification: One word name for family. DE
+           * Definition: Short description of family. AU Author: Authors of the
+           * entry. SE Source of seed: The source suggesting the seed members
+           * belong to one family. GA Gathering method: Search threshold to
+           * build the full alignment. TC Trusted Cutoff: Lowest sequence score
+           * and domain score of match in the full alignment. NC Noise Cutoff:
+           * Highest sequence score and domain score of match not in full
+           * alignment. TP Type: Type of family -- presently Family, Domain,
+           * Motif or Repeat. SQ Sequence: Number of sequences in alignment. AM
+           * Alignment Method The order ls and fs hits are aligned to the model
+           * to build the full align. // End of alignment.
+           * 
+           * Optional fields: ----------------
+           * 
+           * DC Database Comment: Comment about database reference. DR Database
+           * Reference: Reference to external database. RC Reference Comment:
+           * Comment about literature reference. RN Reference Number: Reference
+           * Number. RM Reference Medline: Eight digit medline UI number. RT
+           * Reference Title: Reference Title. RA Reference Author: Reference
+           * Author RL Reference Location: Journal location. PI Previous
+           * identifier: Record of all previous ID lines. KW Keywords: Keywords.
+           * CC Comment: Comments. NE Pfam accession: Indicates a nested domain.
+           * NL Location: Location of nested domains - sequence ID, start and
+           * end of insert.
+           * 
+           * Obsolete fields: ----------- AL Alignment method of seed: The
+           * method used to align the seed members.
+           */
+          // Let's save the annotations, maybe we'll be able to do something
+          // with them later...
+          Regex an = new Regex("(\\w+)\\s*(.*)");
+          if (an.search(annContent))
+          {
+            if (an.stringMatched(1).equals("NH"))
+            {
+              treeString.append(an.stringMatched(2));
+            }
+            else if (an.stringMatched(1).equals("TN"))
+            {
+              if (treeString.length() > 0)
+              {
+                if (treeName == null)
+                {
+                  treeName = "Tree " + (getTreeCount() + 1);
+                }
+                addNewickTree(treeName, treeString.toString());
+              }
+              treeName = an.stringMatched(2);
+              treeString = new StringBuffer();
+            }
+            // TODO: JAL-3532 - this is where GF comments and database
+            // references are lost
+            // suggest overriding this method for Stockholm files to catch and
+            // properly
+            // process CC, DR etc into multivalued properties
+            setAlignmentProperty(an.stringMatched(1), an.stringMatched(2));
+          }
+        }
+        else if (annType.equals("GS"))
+        {
+          // Generic per-Sequence annotation, free text
+          /*
+           * Pfam uses these features: Feature Description ---------------------
+           * ----------- AC <accession> ACcession number DE <freetext>
+           * DEscription DR <db>; <accession>; Database Reference OS <organism>
+           * OrganiSm (species) OC <clade> Organism Classification (clade, etc.)
+           * LO <look> Look (Color, etc.)
+           */
+          if (s.search(annContent))
+          {
+            String acc = s.stringMatched(1);
+            String type = s.stringMatched(2);
+            String content = s.stringMatched(3);
+            // TODO: store DR in a vector.
+            // TODO: store AC according to generic file db annotation.
+            Hashtable ann;
+            if (seqAnn.containsKey(acc))
+            {
+              ann = (Hashtable) seqAnn.get(acc);
+            }
+            else
+            {
+              ann = new Hashtable();
+            }
+            ann.put(type, content);
+            seqAnn.put(acc, ann);
+          }
+          else
+          {
+            // throw new IOException("Error parsing " + line);
+            System.err.println(">> missing annotation: " + line);
+          }
+        }
+        else if (annType.equals("GC"))
+        {
+          // Generic per-Column annotation, exactly 1 char per column
+          // always need a label.
+          if (x.search(annContent))
+          {
+            // parse out and create alignment annotation directly.
+            parseAnnotationRow(annotations, x.stringMatched(1),
+                    x.stringMatched(2));
+          }
+        }
+        else if (annType.equals("GR"))
+        {
+          // Generic per-Sequence AND per-Column markup, exactly 1 char per
+          // column
+          /*
+           * Feature Description Markup letters ------- -----------
+           * -------------- SS Secondary Structure [HGIEBTSCX] SA Surface
+           * Accessibility [0-9X] (0=0%-10%; ...; 9=90%-100%) TM TransMembrane
+           * [Mio] PP Posterior Probability [0-9*] (0=0.00-0.05; 1=0.05-0.15;
+           * *=0.95-1.00) LI LIgand binding [*] AS Active Site [*] IN INtron (in
+           * or after) [0-2]
+           */
+          if (s.search(annContent))
+          {
+            String acc = s.stringMatched(1);
+            String type = s.stringMatched(2);
+            String oseq = s.stringMatched(3);
+            /*
+             * copy of annotation field that may be processed into whitespace chunks
+             */
+            String seq = new String(oseq);
+
+            Hashtable ann;
+            // Get an object with all the annotations for this sequence
+            if (seqAnn.containsKey(acc))
+            {
+              // logger.debug("Found annotations for " + acc);
+              ann = (Hashtable) seqAnn.get(acc);
+            }
+            else
+            {
+              // logger.debug("Creating new annotations holder for " + acc);
+              ann = new Hashtable();
+              seqAnn.put(acc, ann);
+            }
+
+            // // start of block for appending annotation lines for wrapped
+            // stokchholm file
             // TODO test structure, call parseAnnotationRow with vector from
             // hashtable for specific sequence
-                   Hashtable features;
-                   // Get an object with all the content for an annotation
-                   if (ann.containsKey("features"))
-                   {
-                     // logger.debug("Found features for " + acc);
-                     features = (Hashtable) ann.get("features");
-                   }
-                   else
-                   {
-                     // logger.debug("Creating new features holder for " + acc);
-                     features = new Hashtable();
-                     ann.put("features", features);
-                   }
-       
-                   Hashtable content;
-                   if (features.containsKey(this.id2type(type)))
-                   {
-                     // logger.debug("Found content for " + this.id2type(type));
-                     content = (Hashtable) features.get(this.id2type(type));
-                   }
-                   else
-                   {
-                     // logger.debug("Creating new content holder for " +
-                     // this.id2type(type));
-                     content = new Hashtable();
-                     features.put(this.id2type(type), content);
-                   }
-                   String ns = (String) content.get(description);
-                   if (ns == null)
-                   {
-                     ns = "";
-                   }
-                   ns += seq;
-                   content.put(description, ns);
-       
-//                 if(type.equals("SS")){
-                       Hashtable strucAnn;
-                       if (seqAnn.containsKey(acc))
-                       {
-                         strucAnn = (Hashtable) seqAnn.get(acc);
-                       }
-                       else
-                       {
-                         strucAnn = new Hashtable();
-                       }
-                       
-                       Vector newStruc=new Vector();
-                       parseAnnotationRow(newStruc, type,ns);
-                       
-                       strucAnn.put(type, newStruc);
-                       seqAnn.put(acc, strucAnn);
-                    }
-//               }
-                       else
-                       {
-                                               System.err
-                                               .println("Warning - couldn't parse sequence annotation row line:\n"
-                                               + line);
-                       // throw new IOException("Error parsing " + line);
-                       }
-                       }
-                       else
-                       {
-                       throw new IOException("Unknown annotation detected: " + annType
-                               + " " + annContent);
-                       }
-                       }
-               }
-               if (treeString.length() > 0)
-               {
-               if (treeName == null)
-               {
-                       treeName = "Tree " + (1 + getTreeCount());
-               }
-               addNewickTree(treeName, treeString.toString());
-               }
-       }
 
-/**
-   * Demangle an accession string and guess the originating sequence database for a given sequence
-   * @param seqO sequence to be annotated
-   * @param dbr Accession string for sequence
-   * @param dbsource source database for alignment (PFAM or RFAM)
+            Hashtable features;
+            // Get an object with all the content for an annotation
+            if (ann.containsKey("features"))
+            {
+              // logger.debug("Found features for " + acc);
+              features = (Hashtable) ann.get("features");
+            }
+            else
+            {
+              // logger.debug("Creating new features holder for " + acc);
+              features = new Hashtable();
+              ann.put("features", features);
+            }
+
+            Hashtable content;
+            if (features.containsKey(this.id2type(type)))
+            {
+              // logger.debug("Found content for " + this.id2type(type));
+              content = (Hashtable) features.get(this.id2type(type));
+            }
+            else
+            {
+              // logger.debug("Creating new content holder for " +
+              // this.id2type(type));
+              content = new Hashtable();
+              features.put(this.id2type(type), content);
+            }
+            String ns = (String) content.get(ANNOTATION);
+
+            if (ns == null)
+            {
+              ns = "";
+            }
+            // finally, append the annotation line
+            ns += seq;
+            content.put(ANNOTATION, ns);
+            // // end of wrapped annotation block.
+            // // Now a new row is created with the current set of data
+
+            Hashtable strucAnn;
+            if (seqAnn.containsKey(acc))
+            {
+              strucAnn = (Hashtable) seqAnn.get(acc);
+            }
+            else
+            {
+              strucAnn = new Hashtable();
+            }
+
+            Vector<AlignmentAnnotation> newStruc = new Vector<>();
+            parseAnnotationRow(newStruc, type, ns);
+            for (AlignmentAnnotation alan : newStruc)
+            {
+              alan.visible = false;
+            }
+            // new annotation overwrites any existing annotation...
+
+            strucAnn.put(type, newStruc);
+            seqAnn.put(acc, strucAnn);
+          }
+          // }
+          else
+          {
+            System.err.println(
+                    "Warning - couldn't parse sequence annotation row line:\n"
+                            + line);
+            // throw new IOException("Error parsing " + line);
+          }
+        }
+        else
+        {
+          throw new IOException(MessageManager.formatMessage(
+                  "exception.unknown_annotation_detected", new String[]
+                  { annType, annContent }));
+        }
+      }
+    }
+    if (treeString.length() > 0)
+    {
+      if (treeName == null)
+      {
+        treeName = "Tree " + (1 + getTreeCount());
+      }
+      addNewickTree(treeName, treeString.toString());
+    }
+  }
+
+  /**
+   * Demangle an accession string and guess the originating sequence database
+   * for a given sequence
+   * 
+   * @param seqO
+   *          sequence to be annotated
+   * @param dbr
+   *          Accession string for sequence
+   * @param dbsource
+   *          source database for alignment (PFAM or RFAM)
    */
   private void guessDatabaseFor(Sequence seqO, String dbr, String dbsource)
   {
-    DBRefEntry dbrf=null;
-    List<DBRefEntry> dbrs=new ArrayList<DBRefEntry>();
-    String seqdb="Unknown",sdbac=""+dbr;
-    int st=-1,en=-1,p;
-    if ((st=sdbac.indexOf("/"))>-1)
+    DBRefEntry dbrf = null;
+    List<DBRefEntry> dbrs = new ArrayList<>();
+    String seqdb = "Unknown", sdbac = "" + dbr;
+    int st = -1, en = -1, p;
+    if ((st = sdbac.indexOf("/")) > -1)
     {
-      String num,range=sdbac.substring(st+1);
-      sdbac = sdbac.substring(0,st);
-      if ((p=range.indexOf("-"))>-1)
+      String num, range = sdbac.substring(st + 1);
+      sdbac = sdbac.substring(0, st);
+      if ((p = range.indexOf("-")) > -1)
       {
         p++;
-        if (p<range.length())
-        {
-        num = range.substring(p).trim();
-        try {
-          en = Integer.parseInt(num);
-        } catch (NumberFormatException x)
+        if (p < range.length())
         {
-          // could warn here that index is invalid
-          en = -1;
-        }
+          num = range.substring(p).trim();
+          try
+          {
+            en = Integer.parseInt(num);
+          } catch (NumberFormatException x)
+          {
+            // could warn here that index is invalid
+            en = -1;
+          }
         }
-      } else {
-        p=range.length();
       }
-      num=range.substring(0,p).trim();
-      try {
+      else
+      {
+        p = range.length();
+      }
+      num = range.substring(0, p).trim();
+      try
+      {
         st = Integer.parseInt(num);
       } catch (NumberFormatException x)
       {
@@ -704,47 +759,65 @@ public class StockholmFile extends AlignFile
         st = -1;
       }
     }
-    if (dbsource.equals("PFAM")) {
+    if (dbsource == null)
+    {
+      // make up an origin based on whether the sequence looks like it is
+      // nucleotide
+      // or protein
+      dbsource = (seqO.isProtein()) ? "PFAM" : "RFAM";
+    }
+    if (dbsource.equals("PFAM"))
+    {
       seqdb = "UNIPROT";
-      if (sdbac.indexOf(".")>-1)
+      if (sdbac.indexOf(".") > -1)
       {
         // strip of last subdomain
-        sdbac = sdbac.substring(0,sdbac.indexOf("."));
-        dbrf = jalview.util.DBRefUtils.parseToDbRef(seqO, seqdb, dbsource, sdbac);
-        if (dbrf!=null)
+        sdbac = sdbac.substring(0, sdbac.indexOf("."));
+        dbrf = jalview.util.DBRefUtils.parseToDbRef(seqO, seqdb, dbsource,
+                sdbac);
+        if (dbrf != null)
         {
           dbrs.add(dbrf);
         }
       }
-      dbrf = jalview.util.DBRefUtils.parseToDbRef(seqO, dbsource, dbsource, dbr);
-      if (dbr!=null)
+      dbrf = jalview.util.DBRefUtils.parseToDbRef(seqO, dbsource, dbsource,
+              dbr);
+      if (dbr != null)
       {
         dbrs.add(dbrf);
       }
-    } else {
-      seqdb = "EMBL"; // total guess - could be ENA, or something else these days
-      if (sdbac.indexOf(".")>-1)
+    }
+    else
+    {
+      seqdb = "EMBL"; // total guess - could be ENA, or something else these
+                      // days
+      if (sdbac.indexOf(".") > -1)
       {
         // strip off last subdomain
-        sdbac = sdbac.substring(0,sdbac.indexOf("."));
-        dbrf = jalview.util.DBRefUtils.parseToDbRef(seqO, seqdb, dbsource, sdbac);
-        if (dbrf!=null)
+        sdbac = sdbac.substring(0, sdbac.indexOf("."));
+        dbrf = jalview.util.DBRefUtils.parseToDbRef(seqO, seqdb, dbsource,
+                sdbac);
+        if (dbrf != null)
         {
           dbrs.add(dbrf);
         }
       }
-      
-      dbrf = jalview.util.DBRefUtils.parseToDbRef(seqO, dbsource, dbsource, dbr);
-      if (dbrf!=null)
+
+      dbrf = jalview.util.DBRefUtils.parseToDbRef(seqO, dbsource, dbsource,
+              dbr);
+      if (dbrf != null)
       {
         dbrs.add(dbrf);
       }
     }
-    if (st!=-1 && en!=-1)
+    if (st != -1 && en != -1)
     {
-      for (DBRefEntry d:dbrs)
+      for (DBRefEntry d : dbrs)
       {
-        jalview.util.MapList mp = new jalview.util.MapList(new int[] { seqO.getStart(),seqO.getEnd()},new int[] { st,en},1,1);
+        jalview.util.MapList mp = new jalview.util.MapList(
+                new int[]
+                { seqO.getStart(), seqO.getEnd() }, new int[] { st, en }, 1,
+                1);
         jalview.datamodel.Mapping mping = new Mapping(mp);
         d.setMap(mping);
       }
@@ -752,32 +825,36 @@ public class StockholmFile extends AlignFile
   }
 
   protected static AlignmentAnnotation parseAnnotationRow(
-          Vector annotation, String label, String annots)
+          Vector<AlignmentAnnotation> annotation, String label,
+          String annots)
   {
     String convert1, convert2 = null;
 
-    // Convert all bracket types to parentheses
-    Regex openparen = new Regex("(<|\\[)", "(");
-    Regex closeparen = new Regex("(>|\\])", ")");
-
-    // Detect if file is RNA by looking for bracket types
-    Regex detectbrackets = new Regex("(<|>|\\[|\\]|\\(|\\))");
-
-    convert1 = openparen.replaceAll(annots);
-    convert2 = closeparen.replaceAll(convert1);
-    annots = convert2;
+    // convert1 = OPEN_PAREN.replaceAll(annots);
+    // convert2 = CLOSE_PAREN.replaceAll(convert1);
+    // annots = convert2;
 
     String type = label;
     if (label.contains("_cons"))
     {
-      type = (label.indexOf("_cons") == label.length() - 5) ? label
-              .substring(0, label.length() - 5) : label;
+      type = (label.indexOf("_cons") == label.length() - 5)
+              ? label.substring(0, label.length() - 5)
+              : label;
     }
-    boolean ss = false;
+    boolean ss = false, posterior = false;
     type = id2type(type);
-    if (type.equals("secondary structure"))
+
+    boolean isrnass = false;
+    if (type.equalsIgnoreCase("secondary structure"))
     {
       ss = true;
+      isrnass = !NOT_RNASS.search(annots); // sorry about the double negative
+                                           // here (it's easier for dealing with
+                                           // other non-alpha-non-brace chars)
+    }
+    if (type.equalsIgnoreCase("posterior probability"))
+    {
+      posterior = true;
     }
     // decide on secondary structure or not.
     Annotation[] els = new Annotation[annots.length()];
@@ -789,36 +866,61 @@ public class StockholmFile extends AlignFile
       // be written out
       if (ss)
       {
-        if (detectbrackets.search(pos))
+        // if (" .-_".indexOf(pos) == -1)
         {
-          ann.secondaryStructure = jalview.schemes.ResidueProperties
-                  .getRNASecStrucState(pos).charAt(0);
-        }
-        else
-        {
-          ann.secondaryStructure = jalview.schemes.ResidueProperties
-                  .getDssp3state(pos).charAt(0);
+          if (isrnass && RNASS_BRACKETS.indexOf(pos) >= 0)
+          {
+            ann.secondaryStructure = Rna.getRNASecStrucState(pos).charAt(0);
+            ann.displayCharacter = "" + pos.charAt(0);
+          }
+          else
+          {
+            ann.secondaryStructure = ResidueProperties.getDssp3state(pos)
+                    .charAt(0);
+
+            if (ann.secondaryStructure == pos.charAt(0))
+            {
+              ann.displayCharacter = ""; // null; // " ";
+            }
+            else
+            {
+              ann.displayCharacter = " " + ann.displayCharacter;
+            }
+          }
         }
 
-        if (ann.secondaryStructure == pos.charAt(0) || pos.charAt(0) == 'C')
+      }
+      if (posterior && !ann.isWhitespace()
+              && !Comparison.isGap(pos.charAt(0)))
+      {
+        float val = 0;
+        // symbol encodes values - 0..*==0..10
+        if (pos.charAt(0) == '*')
         {
-          ann.displayCharacter = ""; // null; // " ";
+          val = 10;
         }
         else
         {
-          ann.displayCharacter = " " + ann.displayCharacter;
+          val = pos.charAt(0) - '0';
+          if (val > 9)
+          {
+            val = 10;
+          }
         }
+        ann.value = val;
       }
 
       els[i] = ann;
     }
     AlignmentAnnotation annot = null;
-    Enumeration e = annotation.elements();
+    Enumeration<AlignmentAnnotation> e = annotation.elements();
     while (e.hasMoreElements())
     {
-      annot = (AlignmentAnnotation) e.nextElement();
+      annot = e.nextElement();
       if (annot.label.equals(type))
+      {
         break;
+      }
       annot = null;
     }
     if (annot == null)
@@ -839,36 +941,67 @@ public class StockholmFile extends AlignFile
     return annot;
   }
 
-  public String print(SequenceI[] s)
+  private String dbref_to_ac_record(DBRefEntry ref)
   {
+    return ref.getSource().toString() + " ; "
+            + ref.getAccessionId().toString();
+  }
+
+  @Override
+  public String print(SequenceI[] s, boolean jvSuffix)
+  {
+    out = new StringBuffer();
+    out.append("# STOCKHOLM 1.0");
+    out.append(newline);
+
     // find max length of id
     int max = 0;
     int maxid = 0;
     int in = 0;
-    Hashtable dataRef = null;
-    while ((in < s.length) && (s[in] != null))
+    int slen = s.length;
+    SequenceI seq;
+    Hashtable<String, String> dataRef = null;
+    boolean isAA = s[in].isProtein();
+    while ((in < slen) && ((seq = s[in]) != null))
     {
-      String tmp = printId(s[in]);
-      if (s[in].getSequence().length > max)
-      {
-        max = s[in].getSequence().length;
-      }
+      String tmp = printId(seq, jvSuffix);
+      max = Math.max(max, seq.getLength());
 
       if (tmp.length() > maxid)
       {
         maxid = tmp.length();
       }
-      if (s[in].getDBRef() != null)
+      List<DBRefEntry> seqrefs = seq.getDBRefs();
+      int ndb;
+      if (seqrefs != null && (ndb = seqrefs.size()) > 0)
       {
-        for (int idb = 0; idb < s[in].getDBRef().length; idb++)
+        if (dataRef == null)
         {
-          if (dataRef == null)
-            dataRef = new Hashtable();
-
-          String datAs1 = s[in].getDBRef()[idb].getSource().toString()
-                  + " ; "
-                  + s[in].getDBRef()[idb].getAccessionId().toString();
-          dataRef.put(tmp, datAs1);
+          dataRef = new Hashtable<>();
+        }
+        List<DBRefEntry> primrefs = seq.getPrimaryDBRefs();
+        if (primrefs.size() >= 1)
+        {
+          dataRef.put(tmp, dbref_to_ac_record(primrefs.get(0)));
+        }
+        else
+        {
+          for (int idb = 0; idb < seq.getDBRefs().size(); idb++)
+          {
+            DBRefEntry dbref = seq.getDBRefs().get(idb);
+            dataRef.put(tmp, dbref_to_ac_record(dbref));
+            // if we put in a uniprot or EMBL record then we're done:
+            if (isAA && DBRefSource.UNIPROT
+                    .equals(DBRefUtils.getCanonicalName(dbref.getSource())))
+            {
+              break;
+            }
+            if (!isAA && DBRefSource.EMBL
+                    .equals(DBRefUtils.getCanonicalName(dbref.getSource())))
+            {
+              break;
+            }
+          }
         }
       }
       in++;
@@ -894,14 +1027,15 @@ public class StockholmFile extends AlignFile
     // output database accessions
     if (dataRef != null)
     {
-      Enumeration en = dataRef.keys();
+      Enumeration<String> en = dataRef.keys();
       while (en.hasMoreElements())
       {
         Object idd = en.nextElement();
-        String type = (String) dataRef.remove(idd);
-        out.append(new Format("%-" + (maxid - 2) + "s").form("#=GS "
-                + idd.toString() + " "));
-        if (type.contains("PFAM") || type.contains("RFAM"))
+        String type = dataRef.remove(idd);
+        out.append(new Format("%-" + (maxid - 2) + "s")
+                .form("#=GS " + idd.toString() + " "));
+        if (isAA && type.contains("UNIPROT")
+                || (!isAA && type.contains("EMBL")))
         {
 
           out.append(" AC " + type.substring(type.indexOf(";") + 1));
@@ -915,131 +1049,179 @@ public class StockholmFile extends AlignFile
     }
 
     // output annotations
-    while (i < s.length && s[i] != null)
+    while (i < slen && (seq = s[i]) != null)
     {
-      if (s[i].getDatasetSequence() != null)
+      AlignmentAnnotation[] alAnot = seq.getAnnotation();
+      if (alAnot != null)
       {
-        SequenceI ds = s[i].getDatasetSequence();
-        AlignmentAnnotation[] alAnot;
         Annotation[] ann;
-        Annotation annot;
-        alAnot = s[i].getAnnotation();
-        String feature = "";
-        if (alAnot != null)
+        for (int j = 0, nj = alAnot.length; j < nj; j++)
         {
-          for (int j = 0; j < alAnot.length; j++)
+
+          String key = type2id(alAnot[j].label);
+          boolean isrna = alAnot[j].isValidStruc();
+
+          if (isrna)
+          {
+            // hardwire to secondary structure if there is RNA secondary
+            // structure on the annotation
+            key = "SS";
+          }
+          if (key == null)
           {
-            if (ds.getSequenceFeatures() != null)
-            {
-              feature = ds.getSequenceFeatures()[0].type;
-            }
-            String key = type2id(feature);
 
-            if (key == null)
-              continue;
+            continue;
+          }
 
-            // out.append("#=GR ");
-            out.append(new Format("%-" + maxid + "s").form("#=GR "
-                    + printId(s[i]) + " " + key + " "));
-            ann = alAnot[j].annotations;
-            String seq = "";
-            for (int k = 0; k < ann.length; k++)
-            {
-              annot = ann[k];
-              String ch = (annot == null) ? Character.toString(s[i]
-                      .getCharAt(k)) : annot.displayCharacter;
-              if (ch.length() == 0)
-              {
-                if (key.equals("SS"))
-                {
-                  char ll = annot.secondaryStructure;
-                  seq = (Character.toString(ll).equals(" ")) ? seq + "C"
-                          : seq + ll;
-                }
-                else
-                {
-                  seq += ".";
-                }
-              }
-              else if (ch.length() == 1)
-              {
-                seq += ch;
-              }
-              else if (ch.length() > 1)
-              {
-                seq += ch.charAt(1);
-              }
-            }
-            out.append(seq);
-            out.append(newline);
+          // out.append("#=GR ");
+          out.append(new Format("%-" + maxid + "s").form(
+                  "#=GR " + printId(seq, jvSuffix) + " " + key + " "));
+          ann = alAnot[j].annotations;
+          String sseq = "";
+          for (int k = 0, nk = ann.length; k < nk; k++)
+          {
+            sseq += outputCharacter(key, k, isrna, ann, seq);
           }
+          out.append(sseq);
+          out.append(newline);
         }
       }
 
-      out.append(new Format("%-" + maxid + "s").form(printId(s[i]) + " "));
-      out.append(s[i].getSequenceAsString());
+      out.append(new Format("%-" + maxid + "s")
+              .form(printId(seq, jvSuffix) + " "));
+      out.append(seq.getSequenceAsString());
       out.append(newline);
       i++;
     }
 
     // alignment annotation
     AlignmentAnnotation aa;
-    if (al.getAlignmentAnnotation() != null)
+    AlignmentAnnotation[] an = al.getAlignmentAnnotation();
+    if (an != null)
     {
-      for (int ia = 0; ia < al.getAlignmentAnnotation().length; ia++)
+      for (int ia = 0, na = an.length; ia < na; ia++)
       {
-        aa = al.getAlignmentAnnotation()[ia];
-        if (aa.autoCalculated || !aa.visible)
+        aa = an[ia];
+        if (aa.autoCalculated || !aa.visible || aa.sequenceRef != null)
         {
           continue;
         }
-        String seq = "";
+        String sseq = "";
         String label;
-
+        String key = "";
         if (aa.label.equals("seq"))
+        {
           label = "seq_cons";
+        }
         else
-          label = type2id(aa.label.toLowerCase()) + "_cons";
-
-        if (label == null)
-          label = aa.label;
-
-        out.append(new Format("%-" + maxid + "s").form("#=GC " + label
-                + " "));
-        for (int j = 0; j < aa.annotations.length; j++)
         {
-          String ch = (aa.annotations[j] == null) ? "-"
-                  : aa.annotations[j].displayCharacter;
-          if (ch.length() == 0)
+          key = type2id(aa.label.toLowerCase(Locale.ROOT));
+          if (key == null)
           {
-            char ll = aa.annotations[j].secondaryStructure;
-            if (Character.toString(ll).equals(" "))
-              seq += "C";
-            else
-              seq += ll;
+            label = aa.label;
           }
-          else if (ch.length() == 1)
+          else
           {
-            seq += ch;
-          }
-          else if (ch.length() > 1)
-  {
-            seq += ch.charAt(1);
+            label = key + "_cons";
           }
         }
-        out.append(seq);
+        if (label == null)
+        {
+          label = aa.label;
+        }
+        label = label.replace(" ", "_");
+
+        out.append(
+                new Format("%-" + maxid + "s").form("#=GC " + label + " "));
+        boolean isrna = aa.isValidStruc();
+        for (int j = 0, nj = aa.annotations.length; j < nj; j++)
+        {
+          sseq += outputCharacter(key, j, isrna, aa.annotations, null);
+        }
+        out.append(sseq);
         out.append(newline);
       }
     }
+
+    out.append("//");
+    out.append(newline);
+
     return out.toString();
   }
 
+  /**
+   * add an annotation character to the output row
+   * 
+   * @param seq
+   * @param key
+   * @param k
+   * @param isrna
+   * @param ann
+   * @param sequenceI
+   */
+  private char outputCharacter(String key, int k, boolean isrna,
+          Annotation[] ann, SequenceI sequenceI)
+  {
+    char seq = ' ';
+    Annotation annot = ann[k];
+    String ch = (annot == null)
+            ? ((sequenceI == null) ? "-"
+                    : Character.toString(sequenceI.getCharAt(k)))
+            : (annot.displayCharacter == null
+                    ? String.valueOf(annot.secondaryStructure)
+                    : annot.displayCharacter);
+    if (ch == null)
+    {
+      ch = " ";
+    }
+    if (key != null && key.equals("SS"))
+    {
+      char ssannotchar = ' ';
+      boolean charset = false;
+      if (annot == null)
+      {
+        // sensible gap character
+        ssannotchar = ' ';
+        charset = true;
+      }
+      else
+      {
+        // valid secondary structure AND no alternative label (e.g. ' B')
+        if (annot.secondaryStructure > ' ' && ch.length() < 2)
+        {
+          ssannotchar = annot.secondaryStructure;
+          charset = true;
+        }
+      }
+      if (charset)
+      {
+        return (ssannotchar == ' ' && isrna) ? '.' : ssannotchar;
+      }
+    }
+
+    if (ch.length() == 0)
+    {
+      seq = '.';
+    }
+    else if (ch.length() == 1)
+    {
+      seq = ch.charAt(0);
+    }
+    else if (ch.length() > 1)
+    {
+      seq = ch.charAt(1);
+    }
+
+    return (seq == ' ' && key != null && key.equals("SS") && isrna) ? '.'
+            : seq;
+  }
+
   public String print()
   {
     out = new StringBuffer();
     out.append("# STOCKHOLM 1.0");
     out.append(newline);
-    print(getSeqsAsArray());
+    print(getSeqsAsArray(), false);
 
     out.append("//");
     out.append(newline);
@@ -1047,15 +1229,16 @@ public class StockholmFile extends AlignFile
   }
 
   private static Hashtable typeIds = null;
+
   static
   {
     if (typeIds == null)
     {
       typeIds = new Hashtable();
-      typeIds.put("SS", "secondary structure");
-      typeIds.put("SA", "surface accessibility");
+      typeIds.put("SS", "Secondary Structure");
+      typeIds.put("SA", "Surface Accessibility");
       typeIds.put("TM", "transmembrane");
-      typeIds.put("PP", "posterior probability");
+      typeIds.put("PP", "Posterior Probability");
       typeIds.put("LI", "ligand binding");
       typeIds.put("AS", "active site");
       typeIds.put("IN", "intron");
@@ -1066,7 +1249,7 @@ public class StockholmFile extends AlignFile
       typeIds.put("DE", "description");
       typeIds.put("DR", "reference");
       typeIds.put("LO", "look");
-      typeIds.put("RF", "reference positions");
+      typeIds.put("RF", "Reference Positions");
 
     }
   }
@@ -1077,8 +1260,8 @@ public class StockholmFile extends AlignFile
     {
       return (String) typeIds.get(id);
     }
-    System.err.println("Warning : Unknown Stockholm annotation type code "
-            + id);
+    System.err.println(
+            "Warning : Unknown Stockholm annotation type code " + id);
     return id;
   }
 
@@ -1089,7 +1272,7 @@ public class StockholmFile extends AlignFile
     while (e.hasMoreElements())
     {
       Object ll = e.nextElement();
-      if (typeIds.get(ll).toString().equals(type))
+      if (typeIds.get(ll).toString().equalsIgnoreCase(type))
       {
         key = (String) ll;
         break;
@@ -1097,12 +1280,13 @@ public class StockholmFile extends AlignFile
     }
     if (key != null)
     {
-      return (String) key;
+      return key;
     }
-    System.err.println("Warning : Unknown Stockholm annotation type: "
-            + type);
+    System.err.println(
+            "Warning : Unknown Stockholm annotation type: " + type);
     return key;
   }
+
   /**
    * make a friendly ID string.
    *