JAL-1492 JAL-1397 JAL-643 JAL-969 pull up global and group colourscheme logic and...

[jalview.git] / src / jalview / viewmodel / AlignmentViewport.java

diff --git a/src/jalview/viewmodel/AlignmentViewport.java b/src/jalview/viewmodel/AlignmentViewport.java
index 7e383a9..44ecf76 100644 (file)
--- a/src/jalview/viewmodel/AlignmentViewport.java
+++ b/src/jalview/viewmodel/AlignmentViewport.java
@@ -212,6 +212,24 @@ public abstract class AlignmentViewport implements AlignViewportI
     // calculation till later or to do all calculations in thread.
     // via changecolour
     globalColourScheme = cs;
+    boolean recalc=false;
+    if (cs!=null)
+    {
+      cs.setConservationApplied(recalc = getConservationSelected());
+      if (getAbovePIDThreshold() || cs instanceof PIDColourScheme || cs instanceof Blosum62ColourScheme)
+      {
+        recalc = true;
+        cs.setThreshold(threshold, ignoreGapsInConsensusCalculation);
+      } else {
+        cs.setThreshold(0, ignoreGapsInConsensusCalculation);
+      }
+      if (recalc)
+      {
+        cs.setConsensus(hconsensus);
+        cs.setConservation(hconservation);
+      }
+      cs.alignmentChanged(alignment, hiddenRepSequences);
+    }
     if (getColourAppliesToAllGroups())
     {
       for (SequenceGroup sg : getAlignment().getGroups())
@@ -221,29 +239,13 @@ public abstract class AlignmentViewport implements AlignViewportI
           sg.cs = null;
           continue;
         }
-        if (cs instanceof ClustalxColourScheme)
-        {
-          sg.cs = new ClustalxColourScheme(sg, getHiddenRepSequences());
-        }
-        else
-        {
-          try
-          {
-            sg.cs = cs.getClass().newInstance();
-          } catch (Exception ex)
-          {
-            ex.printStackTrace();
-            sg.cs = cs;
-          }
-        }
-
+        sg.cs = cs.applyTo(sg, getHiddenRepSequences());
+        sg.setConsPercGaps(ConsPercGaps);
         if (getAbovePIDThreshold() || cs instanceof PIDColourScheme
                 || cs instanceof Blosum62ColourScheme)
         {
           sg.cs.setThreshold(threshold, getIgnoreGapsConsensus());
-          sg.cs.setConsensus(AAFrequency.calculate(
-                  sg.getSequences(getHiddenRepSequences()), 0,
-                  sg.getWidth()));
+          recalc=true;
         }
         else
         {
@@ -252,20 +254,19 @@ public abstract class AlignmentViewport implements AlignViewportI
 
         if (getConservationSelected())
         {
-          Conservation c = new Conservation("Group",
-                  ResidueProperties.propHash, 3,
-                  sg.getSequences(getHiddenRepSequences()), 0,
-                  getAlignment().getWidth() - 1);
-          c.calculate();
-          c.verdict(false, getConsPercGaps());
-          sg.cs.setConservation(c);
+          sg.cs.setConservationApplied(true);
+          recalc=true;
         }
         else
         {
           sg.cs.setConservation(null);
-          sg.cs.setThreshold(0, getIgnoreGapsConsensus());
+          // sg.cs.setThreshold(0, getIgnoreGapsConsensus());
+        }
+        if (recalc) {
+          sg.recalcConservation();
+        } else {
+          sg.cs.alignmentChanged(sg, hiddenRepSequences);
         }
-
       }
     }
 
@@ -1306,7 +1307,7 @@ public abstract class AlignmentViewport implements AlignViewportI
     ColourSchemeI cs = globalColourScheme;
     if (cs != null)
     {
-      cs.alignmentChanged(alignment, null);
+      cs.alignmentChanged(alignment, hiddenRepSequences);
 
       cs.setConsensus(hconsensus);
       if (cs.conservationApplied())