JAL-3107 update any group associated annotation rows when a new group is created
[jalview.git] / src / jalview / gui / AlignFrame.java
index 060d7b1..c5a2bf0 100644 (file)
@@ -163,11 +163,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
 
   AlignViewport viewport;
 
-  ViewportRanges vpRanges;
-
   public AlignViewControllerI avc;
 
-  List<AlignmentPanel> alignPanels = new ArrayList<AlignmentPanel>();
+  List<AlignmentPanel> alignPanels = new ArrayList<>();
 
   /**
    * Last format used to load or save alignments in this window
@@ -234,8 +232,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
    * @param height
    *          height of frame.
    */
-  public AlignFrame(AlignmentI al, HiddenColumns hiddenColumns,
-          int width, int height)
+  public AlignFrame(AlignmentI al, HiddenColumns hiddenColumns, int width,
+          int height)
   {
     this(al, hiddenColumns, width, height, null);
   }
@@ -251,8 +249,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
    * @param sequenceSetId
    *          (may be null)
    */
-  public AlignFrame(AlignmentI al, HiddenColumns hiddenColumns,
-          int width, int height, String sequenceSetId)
+  public AlignFrame(AlignmentI al, HiddenColumns hiddenColumns, int width,
+          int height, String sequenceSetId)
   {
     this(al, hiddenColumns, width, height, sequenceSetId, null);
   }
@@ -270,8 +268,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
    * @param viewId
    *          (may be null)
    */
-  public AlignFrame(AlignmentI al, HiddenColumns hiddenColumns,
-          int width, int height, String sequenceSetId, String viewId)
+  public AlignFrame(AlignmentI al, HiddenColumns hiddenColumns, int width,
+          int height, String sequenceSetId, String viewId)
   {
     setSize(width, height);
 
@@ -336,7 +334,6 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       progressBar = new ProgressBar(this.statusPanel, this.statusBar);
     }
 
-    vpRanges = viewport.getRanges();
     avc = new jalview.controller.AlignViewController(this, viewport,
             alignPanel);
     if (viewport.getAlignmentConservationAnnotation() == null)
@@ -396,8 +393,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
 
     addKeyListener();
 
-    final List<AlignmentPanel> selviews = new ArrayList<AlignmentPanel>();
-    final List<AlignmentPanel> origview = new ArrayList<AlignmentPanel>();
+    final List<AlignmentPanel> selviews = new ArrayList<>();
+    final List<AlignmentPanel> origview = new ArrayList<>();
     final String menuLabel = MessageManager
             .getString("label.copy_format_from");
     ViewSelectionMenu vsel = new ViewSelectionMenu(menuLabel,
@@ -410,7 +407,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
                 origview.clear();
                 origview.add(alignPanel);
                 // make an array of all alignment panels except for this one
-                List<AlignmentPanel> aps = new ArrayList<AlignmentPanel>(
+                List<AlignmentPanel> aps = new ArrayList<>(
                         Arrays.asList(Desktop.getAlignmentPanels(null)));
                 aps.remove(AlignFrame.this.alignPanel);
                 return aps.toArray(new AlignmentPanel[aps.size()]);
@@ -510,9 +507,10 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       public void keyPressed(KeyEvent evt)
       {
         if (viewport.cursorMode
-                && ((evt.getKeyCode() >= KeyEvent.VK_0 && evt.getKeyCode() <= KeyEvent.VK_9) || (evt
-                        .getKeyCode() >= KeyEvent.VK_NUMPAD0 && evt
-                        .getKeyCode() <= KeyEvent.VK_NUMPAD9))
+                && ((evt.getKeyCode() >= KeyEvent.VK_0
+                        && evt.getKeyCode() <= KeyEvent.VK_9)
+                        || (evt.getKeyCode() >= KeyEvent.VK_NUMPAD0
+                                && evt.getKeyCode() <= KeyEvent.VK_NUMPAD9))
                 && Character.isDigit(evt.getKeyChar()))
         {
           alignPanel.getSeqPanel().numberPressed(evt.getKeyChar());
@@ -552,7 +550,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
         case KeyEvent.VK_LEFT:
           if (evt.isAltDown() || !viewport.cursorMode)
           {
-            slideSequences(false, alignPanel.getSeqPanel().getKeyboardNo1());
+            slideSequences(false,
+                    alignPanel.getSeqPanel().getKeyboardNo1());
           }
           else
           {
@@ -575,9 +574,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
         case KeyEvent.VK_SPACE:
           if (viewport.cursorMode)
           {
-            alignPanel.getSeqPanel().insertGapAtCursor(
-                    evt.isControlDown() || evt.isShiftDown()
-                            || evt.isAltDown());
+            alignPanel.getSeqPanel().insertGapAtCursor(evt.isControlDown()
+                    || evt.isShiftDown() || evt.isAltDown());
           }
           break;
 
@@ -600,9 +598,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
           }
           else
           {
-            alignPanel.getSeqPanel().deleteGapAtCursor(
-                    evt.isControlDown() || evt.isShiftDown()
-                            || evt.isAltDown());
+            alignPanel.getSeqPanel().deleteGapAtCursor(evt.isControlDown()
+                    || evt.isShiftDown() || evt.isAltDown());
           }
 
           break;
@@ -649,14 +646,15 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
 
         case KeyEvent.VK_F2:
           viewport.cursorMode = !viewport.cursorMode;
-          statusBar.setText(MessageManager.formatMessage(
-                  "label.keyboard_editing_mode",
-                  new String[] { (viewport.cursorMode ? "on" : "off") }));
+          statusBar.setText(MessageManager
+                  .formatMessage("label.keyboard_editing_mode", new String[]
+                  { (viewport.cursorMode ? "on" : "off") }));
           if (viewport.cursorMode)
           {
-            alignPanel.getSeqPanel().seqCanvas.cursorX = vpRanges
+            ViewportRanges ranges = viewport.getRanges();
+            alignPanel.getSeqPanel().seqCanvas.cursorX = ranges
                     .getStartRes();
-            alignPanel.getSeqPanel().seqCanvas.cursorY = vpRanges
+            alignPanel.getSeqPanel().seqCanvas.cursorY = ranges
                     .getStartSeq();
           }
           alignPanel.getSeqPanel().seqCanvas.repaint();
@@ -689,24 +687,10 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
           break;
         }
         case KeyEvent.VK_PAGE_UP:
-          if (viewport.getWrapAlignment())
-          {
-            vpRanges.scrollUp(true);
-          }
-          else
-          {
-            vpRanges.pageUp();
-          }
+          viewport.getRanges().pageUp();
           break;
         case KeyEvent.VK_PAGE_DOWN:
-          if (viewport.getWrapAlignment())
-          {
-            vpRanges.scrollUp(false);
-          }
-          else
-          {
-            vpRanges.pageDown();
-          }
+          viewport.getRanges().pageDown();
           break;
         }
       }
@@ -719,16 +703,16 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
         case KeyEvent.VK_LEFT:
           if (evt.isAltDown() || !viewport.cursorMode)
           {
-            viewport.firePropertyChange("alignment", null, viewport
-                    .getAlignment().getSequences());
+            viewport.firePropertyChange("alignment", null,
+                    viewport.getAlignment().getSequences());
           }
           break;
 
         case KeyEvent.VK_RIGHT:
           if (evt.isAltDown() || !viewport.cursorMode)
           {
-            viewport.firePropertyChange("alignment", null, viewport
-                    .getAlignment().getSequences());
+            viewport.firePropertyChange("alignment", null,
+                    viewport.getAlignment().getSequences());
           }
           break;
         }
@@ -814,8 +798,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
                     @Override
                     public void run()
                     {
-                      System.err
-                              .println("Rebuild WS Menu for service change");
+                      System.err.println(
+                              "Rebuild WS Menu for service change");
                       BuildWebServiceMenu();
                     }
 
@@ -859,13 +843,13 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     showReverse.setVisible(nucleotide);
     showReverseComplement.setVisible(nucleotide);
     conservationMenuItem.setEnabled(!nucleotide);
-    modifyConservation.setEnabled(!nucleotide
-            && conservationMenuItem.isSelected());
+    modifyConservation
+            .setEnabled(!nucleotide && conservationMenuItem.isSelected());
     showGroupConservation.setEnabled(!nucleotide);
 
-    showComplementMenuItem.setText(nucleotide ? MessageManager
-            .getString("label.protein") : MessageManager
-            .getString("label.nucleotide"));
+    showComplementMenuItem
+            .setText(nucleotide ? MessageManager.getString("label.protein")
+                    : MessageManager.getString("label.nucleotide"));
   }
 
   /**
@@ -1039,7 +1023,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
         Desktop.instance.closeAssociatedWindows();
 
         FileLoader loader = new FileLoader();
-        DataSourceType protocol = fileName.startsWith("http:") ? DataSourceType.URL
+        DataSourceType protocol = fileName.startsWith("http:")
+                ? DataSourceType.URL
                 : DataSourceType.FILE;
         loader.LoadFile(viewport, fileName, protocol, currentFileFormat);
       }
@@ -1048,7 +1033,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
         Rectangle bounds = this.getBounds();
 
         FileLoader loader = new FileLoader();
-        DataSourceType protocol = fileName.startsWith("http:") ? DataSourceType.URL
+        DataSourceType protocol = fileName.startsWith("http:")
+                ? DataSourceType.URL
                 : DataSourceType.FILE;
         AlignFrame newframe = loader.LoadFileWaitTillLoaded(fileName,
                 protocol, currentFileFormat);
@@ -1080,8 +1066,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   @Override
   public void addFromText_actionPerformed(ActionEvent e)
   {
-    Desktop.instance.inputTextboxMenuItem_actionPerformed(viewport
-            .getAlignPanel());
+    Desktop.instance
+            .inputTextboxMenuItem_actionPerformed(viewport.getAlignPanel());
   }
 
   @Override
@@ -1113,14 +1099,14 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   @Override
   public void saveAs_actionPerformed(ActionEvent e)
   {
-    String format = currentFileFormat == null ? null : currentFileFormat
-            .getName();
-    JalviewFileChooser chooser = JalviewFileChooser.forWrite(
-            Cache.getProperty("LAST_DIRECTORY"), format);
+    String format = currentFileFormat == null ? null
+            : currentFileFormat.getName();
+    JalviewFileChooser chooser = JalviewFileChooser
+            .forWrite(Cache.getProperty("LAST_DIRECTORY"), format);
 
     chooser.setFileView(new JalviewFileView());
-    chooser.setDialogTitle(MessageManager
-            .getString("label.save_alignment_to_file"));
+    chooser.setDialogTitle(
+            MessageManager.getString("label.save_alignment_to_file"));
     chooser.setToolTipText(MessageManager.getString("action.save"));
 
     int value = chooser.showSaveDialog(this);
@@ -1130,14 +1116,11 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       currentFileFormat = chooser.getSelectedFormat();
       while (currentFileFormat == null)
       {
-        JvOptionPane
-                .showInternalMessageDialog(
-                        Desktop.desktop,
-                        MessageManager
-                                .getString("label.select_file_format_before_saving"),
-                        MessageManager
-                                .getString("label.file_format_not_specified"),
-                        JvOptionPane.WARNING_MESSAGE);
+        JvOptionPane.showInternalMessageDialog(Desktop.desktop,
+                MessageManager.getString(
+                        "label.select_file_format_before_saving"),
+                MessageManager.getString("label.file_format_not_specified"),
+                JvOptionPane.WARNING_MESSAGE);
         currentFileFormat = chooser.getSelectedFormat();
         value = chooser.showSaveDialog(this);
         if (value != JalviewFileChooser.APPROVE_OPTION)
@@ -1165,15 +1148,15 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
 
       if (shortName.indexOf(java.io.File.separatorChar) > -1)
       {
-        shortName = shortName.substring(shortName
-                .lastIndexOf(java.io.File.separatorChar) + 1);
+        shortName = shortName.substring(
+                shortName.lastIndexOf(java.io.File.separatorChar) + 1);
       }
 
       success = new Jalview2XML().saveAlignment(this, file, shortName);
 
       statusBar.setText(MessageManager.formatMessage(
-              "label.successfully_saved_to_file_in_format", new Object[] {
-                  fileName, format }));
+              "label.successfully_saved_to_file_in_format", new Object[]
+              { fileName, format }));
 
     }
     else
@@ -1186,13 +1169,14 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       }
       FormatAdapter f = new FormatAdapter(alignPanel,
               exportData.getSettings());
-      String output = f.formatSequences(
-              format,
-              exportData.getAlignment(), // class cast exceptions will
+      String output = f.formatSequences(format, exportData.getAlignment(), // class
+                                                                           // cast
+                                                                           // exceptions
+                                                                           // will
               // occur in the distant future
               exportData.getOmitHidden(), exportData.getStartEndPostions(),
-              f.getCacheSuffixDefault(format), viewport.getAlignment()
-                      .getHiddenColumns());
+              f.getCacheSuffixDefault(format),
+              viewport.getAlignment().getHiddenColumns());
 
       if (output == null)
       {
@@ -1208,8 +1192,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
           out.close();
           this.setTitle(file);
           statusBar.setText(MessageManager.formatMessage(
-                  "label.successfully_saved_to_file_in_format",
-                  new Object[] { fileName, format.getName() }));
+                  "label.successfully_saved_to_file_in_format", new Object[]
+                  { fileName, format.getName() }));
         } catch (Exception ex)
         {
           success = false;
@@ -1221,9 +1205,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     if (!success)
     {
       JvOptionPane.showInternalMessageDialog(this, MessageManager
-              .formatMessage("label.couldnt_save_file",
-                      new Object[] { fileName }), MessageManager
-              .getString("label.error_saving_file"),
+              .formatMessage("label.couldnt_save_file", new Object[]
+              { fileName }),
+              MessageManager.getString("label.error_saving_file"),
               JvOptionPane.WARNING_MESSAGE);
     }
 
@@ -1254,8 +1238,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   @Override
   protected void outputText_actionPerformed(ActionEvent e)
   {
-    FileFormatI fileFormat = FileFormats.getInstance().forName(
-            e.getActionCommand());
+    FileFormatI fileFormat = FileFormats.getInstance()
+            .forName(e.getActionCommand());
     AlignmentExportData exportData = getAlignmentForExport(fileFormat,
             viewport, null);
     if (exportData.getSettings().isCancelled())
@@ -1270,15 +1254,15 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       cap.setText(new FormatAdapter(alignPanel, exportData.getSettings())
               .formatSequences(format, exportData.getAlignment(),
                       exportData.getOmitHidden(),
- exportData
-                              .getStartEndPostions(), viewport
-                              .getAlignment().getHiddenColumns()));
-      Desktop.addInternalFrame(cap, MessageManager.formatMessage(
-              "label.alignment_output_command",
-              new Object[] { e.getActionCommand() }), 600, 500);
+                      exportData.getStartEndPostions(),
+                      viewport.getAlignment().getHiddenColumns()));
+      Desktop.addInternalFrame(cap, MessageManager
+              .formatMessage("label.alignment_output_command", new Object[]
+              { e.getActionCommand() }), 600, 500);
     } catch (OutOfMemoryError oom)
     {
-      new OOMWarning("Outputting alignment as " + e.getActionCommand(), oom);
+      new OOMWarning("Outputting alignment as " + e.getActionCommand(),
+              oom);
       cap.dispose();
     }
 
@@ -1320,10 +1304,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     {
       alignmentToExport = viewport.getAlignment();
     }
-    alignmentStartEnd = alignmentToExport
-            .getVisibleStartAndEndIndex(viewport.getAlignment()
-                    .getHiddenColumns()
-                    .getHiddenRegions());
+    alignmentStartEnd = viewport.getAlignment().getHiddenColumns()
+            .getVisibleStartAndEndIndex(alignmentToExport.getWidth());
     AlignmentExportData ed = new AlignmentExportData(alignmentToExport,
             omitHidden, alignmentStartEnd, settings);
     return ed;
@@ -1424,10 +1406,10 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     JalviewFileChooser chooser = new JalviewFileChooser(
             jalview.bin.Cache.getProperty("LAST_DIRECTORY"));
     chooser.setFileView(new JalviewFileView());
-    chooser.setDialogTitle(MessageManager
-            .getString("label.load_jalview_annotations"));
-    chooser.setToolTipText(MessageManager
-            .getString("label.load_jalview_annotations"));
+    chooser.setDialogTitle(
+            MessageManager.getString("label.load_jalview_annotations"));
+    chooser.setToolTipText(
+            MessageManager.getString("label.load_jalview_annotations"));
 
     int value = chooser.showOpenDialog(null);
 
@@ -1526,9 +1508,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     {
       undoMenuItem.setEnabled(true);
       CommandI command = viewport.getHistoryList().peek();
-      undoMenuItem.setText(MessageManager.formatMessage(
-              "label.undo_command",
-              new Object[] { command.getDescription() }));
+      undoMenuItem.setText(MessageManager
+              .formatMessage("label.undo_command", new Object[]
+              { command.getDescription() }));
     }
     else
     {
@@ -1541,9 +1523,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       redoMenuItem.setEnabled(true);
 
       CommandI command = viewport.getRedoList().peek();
-      redoMenuItem.setText(MessageManager.formatMessage(
-              "label.redo_command",
-              new Object[] { command.getDescription() }));
+      redoMenuItem.setText(MessageManager
+              .formatMessage("label.redo_command", new Object[]
+              { command.getDescription() }));
     }
     else
     {
@@ -1615,8 +1597,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     {
       if (originalSource != viewport)
       {
-        Cache.log
-                .warn("Implementation worry: mismatch of viewport origin for undo");
+        Cache.log.warn(
+                "Implementation worry: mismatch of viewport origin for undo");
       }
       originalSource.updateHiddenColumns();
       // originalSource.hasHiddenColumns = (viewport.getColumnSelection() !=
@@ -1624,8 +1606,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       // && viewport.getColumnSelection().getHiddenColumns() != null &&
       // viewport.getColumnSelection()
       // .getHiddenColumns().size() > 0);
-      originalSource.firePropertyChange("alignment", null, originalSource
-              .getAlignment().getSequences());
+      originalSource.firePropertyChange("alignment", null,
+              originalSource.getAlignment().getSequences());
     }
   }
 
@@ -1655,8 +1637,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
 
       if (originalSource != viewport)
       {
-        Cache.log
-                .warn("Implementation worry: mismatch of viewport origin for redo");
+        Cache.log.warn(
+                "Implementation worry: mismatch of viewport origin for redo");
       }
       originalSource.updateHiddenColumns();
       // originalSource.hasHiddenColumns = (viewport.getColumnSelection() !=
@@ -1664,8 +1646,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       // && viewport.getColumnSelection().getHiddenColumns() != null &&
       // viewport.getColumnSelection()
       // .getHiddenColumns().size() > 0);
-      originalSource.firePropertyChange("alignment", null, originalSource
-              .getAlignment().getSequences());
+      originalSource.firePropertyChange("alignment", null,
+              originalSource.getAlignment().getSequences());
     }
   }
 
@@ -1680,8 +1662,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     {
       EditCommand editCommand = (EditCommand) command;
       al = editCommand.getAlignment();
-      List<Component> comps = PaintRefresher.components.get(viewport
-              .getSequenceSetId());
+      List<Component> comps = PaintRefresher.components
+              .get(viewport.getSequenceSetId());
 
       for (Component comp : comps)
       {
@@ -1727,23 +1709,23 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     }
     viewport.getAlignment().moveSelectedSequencesByOne(sg,
             viewport.getHiddenRepSequences(), up);
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(true, false);
   }
 
   synchronized void slideSequences(boolean right, int size)
   {
-    List<SequenceI> sg = new ArrayList<SequenceI>();
+    List<SequenceI> sg = new ArrayList<>();
     if (viewport.cursorMode)
     {
-      sg.add(viewport.getAlignment().getSequenceAt(
-              alignPanel.getSeqPanel().seqCanvas.cursorY));
+      sg.add(viewport.getAlignment()
+              .getSequenceAt(alignPanel.getSeqPanel().seqCanvas.cursorY));
     }
     else if (viewport.getSelectionGroup() != null
             && viewport.getSelectionGroup().getSize() != viewport
                     .getAlignment().getHeight())
     {
-      sg = viewport.getSelectionGroup().getSequences(
-              viewport.getHiddenRepSequences());
+      sg = viewport.getSelectionGroup()
+              .getSequences(viewport.getHiddenRepSequences());
     }
 
     if (sg.size() < 1)
@@ -1751,7 +1733,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       return;
     }
 
-    List<SequenceI> invertGroup = new ArrayList<SequenceI>();
+    List<SequenceI> invertGroup = new ArrayList<>();
 
     for (SequenceI seq : viewport.getAlignment().getSequences())
     {
@@ -1772,13 +1754,13 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     SlideSequencesCommand ssc;
     if (right)
     {
-      ssc = new SlideSequencesCommand("Slide Sequences", seqs2, seqs1,
-              size, viewport.getGapCharacter());
+      ssc = new SlideSequencesCommand("Slide Sequences", seqs2, seqs1, size,
+              viewport.getGapCharacter());
     }
     else
     {
-      ssc = new SlideSequencesCommand("Slide Sequences", seqs1, seqs2,
-              size, viewport.getGapCharacter());
+      ssc = new SlideSequencesCommand("Slide Sequences", seqs1, seqs2, size,
+              viewport.getGapCharacter());
     }
 
     int groupAdjustment = 0;
@@ -1823,9 +1805,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     if (!inSplitFrame && historyList != null && historyList.size() > 0
             && historyList.peek() instanceof SlideSequencesCommand)
     {
-      appendHistoryItem = ssc
-              .appendSlideCommand((SlideSequencesCommand) historyList
-                      .peek());
+      appendHistoryItem = ssc.appendSlideCommand(
+              (SlideSequencesCommand) historyList.peek());
     }
 
     if (!appendHistoryItem)
@@ -1873,36 +1854,32 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       Toolkit.getDefaultToolkit().getSystemClipboard()
               .setContents(new StringSelection(""), null);
 
-      Toolkit.getDefaultToolkit().getSystemClipboard()
-              .setContents(ss, Desktop.instance);
+      Toolkit.getDefaultToolkit().getSystemClipboard().setContents(ss,
+              Desktop.instance);
     } catch (OutOfMemoryError er)
     {
       new OOMWarning("copying region", er);
       return;
     }
 
-    ArrayList<int[]> hiddenColumns = null;
+    HiddenColumns hiddenColumns = null;
     if (viewport.hasHiddenColumns())
     {
-      hiddenColumns = new ArrayList<int[]>();
-      int hiddenOffset = viewport.getSelectionGroup().getStartRes(), hiddenCutoff = viewport
-              .getSelectionGroup().getEndRes();
-      for (int[] region : viewport.getAlignment().getHiddenColumns()
-              .getHiddenRegions())
-      {
-        if (region[0] >= hiddenOffset && region[1] <= hiddenCutoff)
-        {
-          hiddenColumns.add(new int[] { region[0] - hiddenOffset,
-              region[1] - hiddenOffset });
-        }
-      }
+      int hiddenOffset = viewport.getSelectionGroup().getStartRes();
+      int hiddenCutoff = viewport.getSelectionGroup().getEndRes();
+
+      // create new HiddenColumns object with copy of hidden regions
+      // between startRes and endRes, offset by startRes
+      hiddenColumns = new HiddenColumns(
+              viewport.getAlignment().getHiddenColumns(), hiddenOffset,
+              hiddenCutoff, hiddenOffset);
     }
 
     Desktop.jalviewClipboard = new Object[] { seqs,
         viewport.getAlignment().getDataset(), hiddenColumns };
     statusBar.setText(MessageManager.formatMessage(
-            "label.copied_sequences_to_clipboard", new Object[] { Integer
-                    .valueOf(seqs.length).toString() }));
+            "label.copied_sequences_to_clipboard", new Object[]
+            { Integer.valueOf(seqs.length).toString() }));
   }
 
   /**
@@ -1994,7 +1971,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       }
 
       int alwidth = 0;
-      ArrayList<Integer> newGraphGroups = new ArrayList<Integer>();
+      ArrayList<Integer> newGraphGroups = new ArrayList<>();
       int fgroup = -1;
 
       if (newAlignment)
@@ -2052,8 +2029,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
           {
             // copy and derive new dataset sequence
             sequences[i] = sequences[i].deriveSequence();
-            alignment.getDataset().addSequence(
-                    sequences[i].getDatasetSequence());
+            alignment.getDataset()
+                    .addSequence(sequences[i].getDatasetSequence());
             // TODO: avoid creation of duplicate dataset sequences with a
             // 'contains' method using SequenceI.equals()/SequenceI.contains()
           }
@@ -2083,18 +2060,20 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
             annotationAdded = true;
             if (alann[i].sequenceRef == null && !alann[i].autoCalculated)
             {
-              AlignmentAnnotation newann = new AlignmentAnnotation(alann[i]);
+              AlignmentAnnotation newann = new AlignmentAnnotation(
+                      alann[i]);
               if (newann.graphGroup > -1)
               {
                 if (newGraphGroups.size() <= newann.graphGroup
                         || newGraphGroups.get(newann.graphGroup) == null)
                 {
-                  for (int q = newGraphGroups.size(); q <= newann.graphGroup; q++)
+                  for (int q = newGraphGroups
+                          .size(); q <= newann.graphGroup; q++)
                   {
                     newGraphGroups.add(q, null);
                   }
-                  newGraphGroups.set(newann.graphGroup, new Integer(
-                          ++fgroup));
+                  newGraphGroups.set(newann.graphGroup,
+                          new Integer(++fgroup));
                 }
                 newann.graphGroup = newGraphGroups.get(newann.graphGroup)
                         .intValue();
@@ -2113,7 +2092,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
         //
         addHistoryItem(new EditCommand(
                 MessageManager.getString("label.add_sequences"),
-                Action.PASTE, sequences, 0, alignment.getWidth(), alignment));
+                Action.PASTE, sequences, 0, alignment.getWidth(),
+                alignment));
       }
       // Add any annotations attached to sequences
       for (int i = 0; i < sequences.length; i++)
@@ -2134,12 +2114,13 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
                 if (newGraphGroups.size() <= newann.graphGroup
                         || newGraphGroups.get(newann.graphGroup) == null)
                 {
-                  for (int q = newGraphGroups.size(); q <= newann.graphGroup; q++)
+                  for (int q = newGraphGroups
+                          .size(); q <= newann.graphGroup; q++)
                   {
                     newGraphGroups.add(q, null);
                   }
-                  newGraphGroups.set(newann.graphGroup, new Integer(
-                          ++fgroup));
+                  newGraphGroups.set(newann.graphGroup,
+                          new Integer(++fgroup));
                 }
                 newann.graphGroup = newGraphGroups.get(newann.graphGroup)
                         .intValue();
@@ -2149,8 +2130,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
             // was
             // duplicated
             // earlier
-            alignment
-                    .setAnnotationIndex(sequences[i].getAnnotation()[a], a);
+            alignment.setAnnotationIndex(sequences[i].getAnnotation()[a],
+                    a);
           }
         }
       }
@@ -2158,7 +2139,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       {
 
         // propagate alignment changed.
-        vpRanges.setEndSeq(alignment.getHeight());
+        viewport.getRanges().setEndSeq(alignment.getHeight());
         if (annotationAdded)
         {
           // Duplicate sequence annotation in all views.
@@ -2220,19 +2201,15 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
         if (Desktop.jalviewClipboard != null
                 && Desktop.jalviewClipboard[2] != null)
         {
-          List<int[]> hc = (List<int[]>) Desktop.jalviewClipboard[2];
-          for (int[] region : hc)
-          {
-            af.viewport.hideColumns(region[0], region[1]);
-          }
+          HiddenColumns hc = (HiddenColumns) Desktop.jalviewClipboard[2];
+          af.viewport.setHiddenColumns(hc);
         }
 
         // >>>This is a fix for the moment, until a better solution is
         // found!!<<<
         af.alignPanel.getSeqPanel().seqCanvas.getFeatureRenderer()
-                .transferSettings(
-                        alignPanel.getSeqPanel().seqCanvas
-                                .getFeatureRenderer());
+                .transferSettings(alignPanel.getSeqPanel().seqCanvas
+                        .getFeatureRenderer());
 
         // TODO: maintain provenance of an alignment, rather than just make the
         // title a concatenation of operations.
@@ -2271,8 +2248,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   {
     try
     {
-      AlignmentI alignment = AlignmentUtils.expandContext(getViewport()
-              .getAlignment(), -1);
+      AlignmentI alignment = AlignmentUtils
+              .expandContext(getViewport().getAlignment(), -1);
       AlignFrame af = new AlignFrame(alignment, DEFAULT_WIDTH,
               DEFAULT_HEIGHT);
       String newtitle = new String("Flanking alignment");
@@ -2280,19 +2257,15 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       if (Desktop.jalviewClipboard != null
               && Desktop.jalviewClipboard[2] != null)
       {
-        List<int[]> hc = (List<int[]>) Desktop.jalviewClipboard[2];
-        for (int region[] : hc)
-        {
-          af.viewport.hideColumns(region[0], region[1]);
-        }
+        HiddenColumns hc = (HiddenColumns) Desktop.jalviewClipboard[2];
+        af.viewport.setHiddenColumns(hc);
       }
 
       // >>>This is a fix for the moment, until a better solution is
       // found!!<<<
       af.alignPanel.getSeqPanel().seqCanvas.getFeatureRenderer()
-              .transferSettings(
-                      alignPanel.getSeqPanel().seqCanvas
-                              .getFeatureRenderer());
+              .transferSettings(alignPanel.getSeqPanel().seqCanvas
+                      .getFeatureRenderer());
 
       // TODO: maintain provenance of an alignment, rather than just make the
       // title a concatenation of operations.
@@ -2354,8 +2327,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
      */
     if (sg.getSize() == viewport.getAlignment().getHeight())
     {
-      boolean isEntireAlignWidth = (((sg.getEndRes() - sg.getStartRes()) + 1) == viewport
-              .getAlignment().getWidth()) ? true : false;
+      boolean isEntireAlignWidth = (((sg.getEndRes() - sg.getStartRes())
+              + 1) == viewport.getAlignment().getWidth()) ? true : false;
       if (isEntireAlignWidth)
       {
         int confirm = JvOptionPane.showConfirmDialog(this,
@@ -2384,8 +2357,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     viewport.sendSelection();
     viewport.getAlignment().deleteGroup(sg);
 
-    viewport.firePropertyChange("alignment", null, viewport.getAlignment()
-            .getSequences());
+    viewport.firePropertyChange("alignment", null,
+            viewport.getAlignment().getSequences());
     if (viewport.getAlignment().getHeight() < 1)
     {
       try
@@ -2410,7 +2383,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     {
       PaintRefresher.Refresh(this, viewport.getSequenceSetId());
       alignPanel.updateAnnotation();
-      alignPanel.paintAlignment(true);
+      alignPanel.paintAlignment(true, true);
     }
   }
 
@@ -2436,7 +2409,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     // JAL-2034 - should delegate to
     // alignPanel to decide if overview needs
     // updating.
-    alignPanel.paintAlignment(false);
+    alignPanel.paintAlignment(false, false);
     PaintRefresher.Refresh(alignPanel, viewport.getSequenceSetId());
   }
 
@@ -2457,12 +2430,11 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     viewport.setSelectionGroup(null);
     viewport.getColumnSelection().clear();
     viewport.setSelectionGroup(null);
-    alignPanel.getSeqPanel().seqCanvas.highlightSearchResults(null);
     alignPanel.getIdPanel().getIdCanvas().searchResults = null;
     // JAL-2034 - should delegate to
     // alignPanel to decide if overview needs
     // updating.
-    alignPanel.paintAlignment(false);
+    alignPanel.paintAlignment(false, false);
     PaintRefresher.Refresh(alignPanel, viewport.getSequenceSetId());
     viewport.sendSelection();
   }
@@ -2493,7 +2465,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     // alignPanel to decide if overview needs
     // updating.
 
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(true, false);
     PaintRefresher.Refresh(alignPanel, viewport.getSequenceSetId());
     viewport.sendSelection();
   }
@@ -2502,7 +2474,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   public void invertColSel_actionPerformed(ActionEvent e)
   {
     viewport.invertColumnSelection();
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(true, false);
     viewport.sendSelection();
   }
 
@@ -2549,8 +2521,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       SequenceI[] seqs;
       if (viewport.getSelectionGroup() != null)
       {
-        seqs = viewport.getSelectionGroup().getSequencesAsArray(
-                viewport.getHiddenRepSequences());
+        seqs = viewport.getSelectionGroup()
+                .getSequencesAsArray(viewport.getHiddenRepSequences());
       }
       else
       {
@@ -2562,7 +2534,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       {
         trimRegion = new TrimRegionCommand("Remove Left", true, seqs,
                 column, viewport.getAlignment());
-        vpRanges.setStartRes(0);
+        viewport.getRanges().setStartRes(0);
       }
       else
       {
@@ -2570,10 +2542,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
                 column, viewport.getAlignment());
       }
 
-      statusBar.setText(MessageManager.formatMessage(
-              "label.removed_columns",
-              new String[] { Integer.valueOf(trimRegion.getSize())
-                      .toString() }));
+      statusBar.setText(MessageManager
+              .formatMessage("label.removed_columns", new String[]
+              { Integer.valueOf(trimRegion.getSize()).toString() }));
 
       addHistoryItem(trimRegion);
 
@@ -2586,8 +2557,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
         }
       }
 
-      viewport.firePropertyChange("alignment", null, viewport
-              .getAlignment().getSequences());
+      viewport.firePropertyChange("alignment", null,
+              viewport.getAlignment().getSequences());
     }
   }
 
@@ -2605,8 +2576,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     SequenceI[] seqs;
     if (viewport.getSelectionGroup() != null)
     {
-      seqs = viewport.getSelectionGroup().getSequencesAsArray(
-              viewport.getHiddenRepSequences());
+      seqs = viewport.getSelectionGroup()
+              .getSequencesAsArray(viewport.getHiddenRepSequences());
       start = viewport.getSelectionGroup().getStartRes();
       end = viewport.getSelectionGroup().getEndRes();
     }
@@ -2621,23 +2592,23 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
 
     addHistoryItem(removeGapCols);
 
-    statusBar.setText(MessageManager.formatMessage(
-            "label.removed_empty_columns",
-            new Object[] { Integer.valueOf(removeGapCols.getSize())
-                    .toString() }));
+    statusBar.setText(MessageManager
+            .formatMessage("label.removed_empty_columns", new Object[]
+            { Integer.valueOf(removeGapCols.getSize()).toString() }));
 
     // This is to maintain viewport position on first residue
     // of first sequence
     SequenceI seq = viewport.getAlignment().getSequenceAt(0);
-    int startRes = seq.findPosition(vpRanges.getStartRes());
+    ViewportRanges ranges = viewport.getRanges();
+    int startRes = seq.findPosition(ranges.getStartRes());
     // ShiftList shifts;
     // viewport.getAlignment().removeGaps(shifts=new ShiftList());
     // edit.alColumnChanges=shifts.getInverse();
     // if (viewport.hasHiddenColumns)
     // viewport.getColumnSelection().compensateForEdits(shifts);
-    vpRanges.setStartRes(seq.findIndex(startRes) - 1);
-    viewport.firePropertyChange("alignment", null, viewport.getAlignment()
-            .getSequences());
+    ranges.setStartRes(seq.findIndex(startRes) - 1);
+    viewport.firePropertyChange("alignment", null,
+            viewport.getAlignment().getSequences());
 
   }
 
@@ -2655,8 +2626,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     SequenceI[] seqs;
     if (viewport.getSelectionGroup() != null)
     {
-      seqs = viewport.getSelectionGroup().getSequencesAsArray(
-              viewport.getHiddenRepSequences());
+      seqs = viewport.getSelectionGroup()
+              .getSequencesAsArray(viewport.getHiddenRepSequences());
       start = viewport.getSelectionGroup().getStartRes();
       end = viewport.getSelectionGroup().getEndRes();
     }
@@ -2668,15 +2639,15 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     // This is to maintain viewport position on first residue
     // of first sequence
     SequenceI seq = viewport.getAlignment().getSequenceAt(0);
-    int startRes = seq.findPosition(vpRanges.getStartRes());
+    int startRes = seq.findPosition(viewport.getRanges().getStartRes());
 
     addHistoryItem(new RemoveGapsCommand("Remove Gaps", seqs, start, end,
             viewport.getAlignment()));
 
-    vpRanges.setStartRes(seq.findIndex(startRes) - 1);
+    viewport.getRanges().setStartRes(seq.findIndex(startRes) - 1);
 
-    viewport.firePropertyChange("alignment", null, viewport.getAlignment()
-            .getSequences());
+    viewport.firePropertyChange("alignment", null,
+            viewport.getAlignment().getSequences());
 
   }
 
@@ -2690,8 +2661,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   public void padGapsMenuitem_actionPerformed(ActionEvent e)
   {
     viewport.setPadGaps(padGapsMenuitem.isSelected());
-    viewport.firePropertyChange("alignment", null, viewport.getAlignment()
-            .getSequences());
+    viewport.firePropertyChange("alignment", null,
+            viewport.getAlignment().getSequences());
   }
 
   /**
@@ -2729,8 +2700,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     /*
      * Create a new AlignmentPanel (with its own, new Viewport)
      */
-    AlignmentPanel newap = new Jalview2XML().copyAlignPanel(alignPanel,
-            true);
+    AlignmentPanel newap = new Jalview2XML().copyAlignPanel(alignPanel);
     if (!copyAnnotation)
     {
       /*
@@ -2805,8 +2775,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     }
     String newViewName = viewTitle + ((addFirstIndex) ? " " + index : "");
 
-    List<Component> comps = PaintRefresher.components.get(viewport
-            .getSequenceSetId());
+    List<Component> comps = PaintRefresher.components
+            .get(viewport.getSequenceSetId());
 
     List<String> existingNames = getExistingViewNames(comps);
 
@@ -2826,7 +2796,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
    */
   protected List<String> getExistingViewNames(List<Component> comps)
   {
-    List<String> existingNames = new ArrayList<String>();
+    List<String> existingNames = new ArrayList<>();
     for (Component comp : comps)
     {
       if (comp instanceof AlignmentPanel)
@@ -2884,21 +2854,21 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
 
     alignPanel.getIdPanel().getIdCanvas()
             .setPreferredSize(alignPanel.calculateIdWidth());
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(true, false);
   }
 
   @Override
   public void idRightAlign_actionPerformed(ActionEvent e)
   {
     viewport.setRightAlignIds(idRightAlign.isSelected());
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(false, false);
   }
 
   @Override
   public void centreColumnLabels_actionPerformed(ActionEvent e)
   {
     viewport.setCentreColumnLabels(centreColumnLabelsMenuItem.getState());
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(false, false);
   }
 
   /*
@@ -2931,7 +2901,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   protected void colourTextMenuItem_actionPerformed(ActionEvent e)
   {
     viewport.setColourText(colourTextMenuItem.isSelected());
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(false, false);
   }
 
   /**
@@ -2960,7 +2930,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   public void showAllColumns_actionPerformed(ActionEvent e)
   {
     viewport.showAllHiddenColumns();
-    repaint();
+    alignPanel.paintAlignment(true, true);
     viewport.sendSelection();
   }
 
@@ -2968,7 +2938,6 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   public void hideSelSequences_actionPerformed(ActionEvent e)
   {
     viewport.hideAllSelectedSeqs();
-    // alignPanel.paintAlignment(true);
   }
 
   /**
@@ -2987,9 +2956,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       // Hide everything by the current selection - this is a hack - we do the
       // invert and then hide
       // first check that there will be visible columns after the invert.
-      if (viewport.hasSelectedColumns()
-              || (sg != null && sg.getSize() > 0 && sg.getStartRes() <= sg
-                      .getEndRes()))
+      if (viewport.hasSelectedColumns() || (sg != null && sg.getSize() > 0
+              && sg.getStartRes() <= sg.getEndRes()))
       {
         // now invert the sequence set, if required - empty selection implies
         // that no hiding is required.
@@ -3066,7 +3034,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     viewport.expandColSelection(sg, false);
     viewport.hideAllSelectedSeqs();
     viewport.hideSelectedColumns();
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(true, true);
     viewport.sendSelection();
   }
 
@@ -3082,7 +3050,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   {
     viewport.showAllHiddenColumns();
     viewport.showAllHiddenSeqs();
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(true, true);
     viewport.sendSelection();
   }
 
@@ -3090,7 +3058,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   public void hideSelColumns_actionPerformed(ActionEvent e)
   {
     viewport.hideSelectedColumns();
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(true, true);
     viewport.sendSelection();
   }
 
@@ -3111,7 +3079,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   protected void scaleAbove_actionPerformed(ActionEvent e)
   {
     viewport.setScaleAboveWrapped(scaleAbove.isSelected());
-    alignPanel.paintAlignment(true);
+    // TODO: do we actually need to update overview for scale above change ?
+    alignPanel.paintAlignment(true, false);
   }
 
   /**
@@ -3124,7 +3093,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   protected void scaleLeft_actionPerformed(ActionEvent e)
   {
     viewport.setScaleLeftWrapped(scaleLeft.isSelected());
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(true, false);
   }
 
   /**
@@ -3137,7 +3106,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   protected void scaleRight_actionPerformed(ActionEvent e)
   {
     viewport.setScaleRightWrapped(scaleRight.isSelected());
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(true, false);
   }
 
   /**
@@ -3150,7 +3119,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   public void viewBoxesMenuItem_actionPerformed(ActionEvent e)
   {
     viewport.setShowBoxes(viewBoxesMenuItem.isSelected());
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(false, false);
   }
 
   /**
@@ -3163,7 +3132,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   public void viewTextMenuItem_actionPerformed(ActionEvent e)
   {
     viewport.setShowText(viewTextMenuItem.isSelected());
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(false, false);
   }
 
   /**
@@ -3176,7 +3145,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   protected void renderGapsMenuItem_actionPerformed(ActionEvent e)
   {
     viewport.setRenderGaps(renderGapsMenuItem.isSelected());
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(false, false);
   }
 
   public FeatureSettings featureSettings;
@@ -3214,11 +3183,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   public void showSeqFeatures_actionPerformed(ActionEvent evt)
   {
     viewport.setShowSequenceFeatures(showSeqFeatures.isSelected());
-    alignPanel.paintAlignment(true);
-    if (alignPanel.getOverviewPanel() != null)
-    {
-      alignPanel.getOverviewPanel().updateOverviewImage();
-    }
+    alignPanel.paintAlignment(true, true);
   }
 
   /**
@@ -3249,14 +3214,15 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     editPane.setEditable(false);
     StringBuffer contents = new AlignmentProperties(viewport.getAlignment())
             .formatAsHtml();
-    editPane.setText(MessageManager.formatMessage("label.html_content",
-            new Object[] { contents.toString() }));
+    editPane.setText(
+            MessageManager.formatMessage("label.html_content", new Object[]
+            { contents.toString() }));
     JInternalFrame frame = new JInternalFrame();
     frame.getContentPane().add(new JScrollPane(editPane));
 
-    Desktop.addInternalFrame(frame, MessageManager.formatMessage(
-            "label.alignment_properties", new Object[] { getTitle() }),
-            500, 400);
+    Desktop.addInternalFrame(frame, MessageManager
+            .formatMessage("label.alignment_properties", new Object[]
+            { getTitle() }), 500, 400);
   }
 
   /**
@@ -3274,22 +3240,29 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     }
 
     JInternalFrame frame = new JInternalFrame();
-    OverviewPanel overview = new OverviewPanel(alignPanel);
+    final OverviewPanel overview = new OverviewPanel(alignPanel);
     frame.setContentPane(overview);
-    Desktop.addInternalFrame(frame, MessageManager.formatMessage(
-            "label.overview_params", new Object[] { this.getTitle() }),
-            true, frame.getWidth(), frame.getHeight(), true, true);
+    Desktop.addInternalFrame(frame, MessageManager
+            .formatMessage("label.overview_params", new Object[]
+            { this.getTitle() }), true, frame.getWidth(), frame.getHeight(),
+            true, true);
     frame.pack();
     frame.setLayer(JLayeredPane.PALETTE_LAYER);
-    frame.addInternalFrameListener(new javax.swing.event.InternalFrameAdapter()
+    frame.addInternalFrameListener(
+            new javax.swing.event.InternalFrameAdapter()
+            {
+              @Override
+              public void internalFrameClosed(
+                      javax.swing.event.InternalFrameEvent evt)
+              {
+                overview.dispose();
+                alignPanel.setOverviewPanel(null);
+              };
+            });
+    if (getKeyListeners().length > 0)
     {
-      @Override
-      public void internalFrameClosed(
-              javax.swing.event.InternalFrameEvent evt)
-      {
-        alignPanel.setOverviewPanel(null);
-      };
-    });
+      frame.addKeyListener(getKeyListeners()[0]);
+    }
 
     alignPanel.setOverviewPanel(overview);
   }
@@ -3371,7 +3344,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
 
     viewport.setGlobalColourScheme(cs);
 
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(true, true);
   }
 
   /**
@@ -3380,8 +3353,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   @Override
   protected void modifyPID_actionPerformed()
   {
-    SliderPanel.setPIDSliderSource(alignPanel,
-            viewport.getResidueShading(), alignPanel.getViewName());
+    SliderPanel.setPIDSliderSource(alignPanel, viewport.getResidueShading(),
+            alignPanel.getViewName());
     SliderPanel.showPIDSlider();
   }
 
@@ -3452,11 +3425,11 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   public void sortPairwiseMenuItem_actionPerformed(ActionEvent e)
   {
     SequenceI[] oldOrder = viewport.getAlignment().getSequencesArray();
-    AlignmentSorter.sortByPID(viewport.getAlignment(), viewport
-            .getAlignment().getSequenceAt(0));
+    AlignmentSorter.sortByPID(viewport.getAlignment(),
+            viewport.getAlignment().getSequenceAt(0));
     addHistoryItem(new OrderCommand("Pairwise Sort", oldOrder,
             viewport.getAlignment()));
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(true, false);
   }
 
   /**
@@ -3470,9 +3443,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   {
     SequenceI[] oldOrder = viewport.getAlignment().getSequencesArray();
     AlignmentSorter.sortByID(viewport.getAlignment());
-    addHistoryItem(new OrderCommand("ID Sort", oldOrder,
-            viewport.getAlignment()));
-    alignPanel.paintAlignment(true);
+    addHistoryItem(
+            new OrderCommand("ID Sort", oldOrder, viewport.getAlignment()));
+    alignPanel.paintAlignment(true, false);
   }
 
   /**
@@ -3488,7 +3461,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     AlignmentSorter.sortByLength(viewport.getAlignment());
     addHistoryItem(new OrderCommand("Length Sort", oldOrder,
             viewport.getAlignment()));
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(true, false);
   }
 
   /**
@@ -3505,7 +3478,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     addHistoryItem(new OrderCommand("Group Sort", oldOrder,
             viewport.getAlignment()));
 
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(true, false);
   }
 
   /**
@@ -3532,8 +3505,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     if ((viewport.getSelectionGroup() == null)
             || (viewport.getSelectionGroup().getSize() < 2))
     {
-      JvOptionPane.showInternalMessageDialog(this, MessageManager
-              .getString("label.you_must_select_least_two_sequences"),
+      JvOptionPane.showInternalMessageDialog(this,
+              MessageManager.getString(
+                      "label.you_must_select_least_two_sequences"),
               MessageManager.getString("label.invalid_selection"),
               JvOptionPane.WARNING_MESSAGE);
     }
@@ -3553,8 +3527,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     viewport.autoCalculateConsensus = autoCalculate.isSelected();
     if (viewport.autoCalculateConsensus)
     {
-      viewport.firePropertyChange("alignment", null, viewport
-              .getAlignment().getSequences());
+      viewport.firePropertyChange("alignment", null,
+              viewport.getAlignment().getSequences());
     }
   }
 
@@ -3580,7 +3554,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
    * @param options
    *          parameters for the distance or similarity calculation
    */
-  void newTreePanel(String type, String modelName, SimilarityParamsI options)
+  void newTreePanel(String type, String modelName,
+          SimilarityParamsI options)
   {
     String frameTitle = "";
     TreePanel tp;
@@ -3596,14 +3571,12 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       {
         if (_s.getLength() < sg.getEndRes())
         {
-          JvOptionPane
-                  .showMessageDialog(
-                          Desktop.desktop,
-                          MessageManager
-                                  .getString("label.selected_region_to_tree_may_only_contain_residues_or_gaps"),
-                          MessageManager
-                                  .getString("label.sequences_selection_not_aligned"),
-                          JvOptionPane.WARNING_MESSAGE);
+          JvOptionPane.showMessageDialog(Desktop.desktop,
+                  MessageManager.getString(
+                          "label.selected_region_to_tree_may_only_contain_residues_or_gaps"),
+                  MessageManager.getString(
+                          "label.sequences_selection_not_aligned"),
+                  JvOptionPane.WARNING_MESSAGE);
 
           return;
         }
@@ -3644,8 +3617,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   public void addSortByOrderMenuItem(String title,
           final AlignmentOrder order)
   {
-    final JMenuItem item = new JMenuItem(MessageManager.formatMessage(
-            "action.by_title_param", new Object[] { title }));
+    final JMenuItem item = new JMenuItem(MessageManager
+            .formatMessage("action.by_title_param", new Object[]
+            { title }));
     sort.add(item);
     item.addActionListener(new java.awt.event.ActionListener()
     {
@@ -3658,10 +3632,10 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
         // pointers
         AlignmentSorter.sortBy(viewport.getAlignment(), order);
 
-        addHistoryItem(new OrderCommand(order.getName(), oldOrder, viewport
-                .getAlignment()));
+        addHistoryItem(new OrderCommand(order.getName(), oldOrder,
+                viewport.getAlignment()));
 
-        alignPanel.paintAlignment(true);
+        alignPanel.paintAlignment(true, false);
       }
     });
   }
@@ -3690,7 +3664,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
                 viewport.getAlignment());// ,viewport.getSelectionGroup());
         addHistoryItem(new OrderCommand("Sort by " + scoreLabel, oldOrder,
                 viewport.getAlignment()));
-        alignPanel.paintAlignment(true);
+        alignPanel.paintAlignment(true, false);
       }
     });
   }
@@ -3715,7 +3689,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       return;
     }
 
-    if (viewport.getAlignment().getAlignmentAnnotation().hashCode() != _annotationScoreVectorHash)
+    if (viewport.getAlignment().getAlignmentAnnotation()
+            .hashCode() != _annotationScoreVectorHash)
     {
       sortByAnnotScore.removeAll();
       // almost certainly a quicker way to do this - but we keep it simple
@@ -3758,9 +3733,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   {
     sortByTreeMenu.removeAll();
 
-    List<Component> comps = PaintRefresher.components.get(viewport
-            .getSequenceSetId());
-    List<TreePanel> treePanels = new ArrayList<TreePanel>();
+    List<Component> comps = PaintRefresher.components
+            .get(viewport.getSequenceSetId());
+    List<TreePanel> treePanels = new ArrayList<>();
     for (Component comp : comps)
     {
       if (comp instanceof TreePanel)
@@ -3804,7 +3779,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       addHistoryItem(new OrderCommand(undoname, oldOrder,
               viewport.getAlignment()));
     }
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(true, false);
     return true;
   }
 
@@ -3898,9 +3873,10 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     JalviewFileChooser chooser = new JalviewFileChooser(
             jalview.bin.Cache.getProperty("LAST_DIRECTORY"));
     chooser.setFileView(new JalviewFileView());
-    chooser.setDialogTitle(MessageManager
-            .getString("label.select_newick_like_tree_file"));
-    chooser.setToolTipText(MessageManager.getString("label.load_tree_file"));
+    chooser.setDialogTitle(
+            MessageManager.getString("label.select_newick_like_tree_file"));
+    chooser.setToolTipText(
+            MessageManager.getString("label.load_tree_file"));
 
     int value = chooser.showOpenDialog(null);
 
@@ -3915,20 +3891,17 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
         viewport.setCurrentTree(showNewickTree(fin, filePath).getTree());
       } catch (Exception ex)
       {
-        JvOptionPane
-                .showMessageDialog(
-                        Desktop.desktop,
-                        ex.getMessage(),
-                        MessageManager
-                                .getString("label.problem_reading_tree_file"),
-                        JvOptionPane.WARNING_MESSAGE);
+        JvOptionPane.showMessageDialog(Desktop.desktop, ex.getMessage(),
+                MessageManager.getString("label.problem_reading_tree_file"),
+                JvOptionPane.WARNING_MESSAGE);
         ex.printStackTrace();
       }
       if (fin != null && fin.hasWarningMessage())
       {
-        JvOptionPane.showMessageDialog(Desktop.desktop, fin
-                .getWarningMessage(), MessageManager
-                .getString("label.possible_problem_with_tree_file"),
+        JvOptionPane.showMessageDialog(Desktop.desktop,
+                fin.getWarningMessage(),
+                MessageManager
+                        .getString("label.possible_problem_with_tree_file"),
                 JvOptionPane.WARNING_MESSAGE);
       }
     }
@@ -4020,7 +3993,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       @Override
       public void run()
       {
-        final List<JMenuItem> legacyItems = new ArrayList<JMenuItem>();
+        final List<JMenuItem> legacyItems = new ArrayList<>();
         try
         {
           // System.err.println("Building ws menu again "
@@ -4035,7 +4008,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
           // TODO: group services by location as well as function and/or
           // introduce
           // object broker mechanism.
-          final Vector<JMenu> wsmenu = new Vector<JMenu>();
+          final Vector<JMenu> wsmenu = new Vector<>();
           final IProgressIndicator af = me;
 
           /*
@@ -4158,9 +4131,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
                 }
               } catch (Exception e)
               {
-                Cache.log
-                        .debug("Exception during web service menu building process.",
-                                e);
+                Cache.log.debug(
+                        "Exception during web service menu building process.",
+                        e);
               }
             }
           });
@@ -4245,7 +4218,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
           @Override
           public void actionPerformed(ActionEvent e)
           {
-            showProductsFor(af.viewport.getSequenceSelection(), dna, source);
+            showProductsFor(af.viewport.getSequenceSelection(), dna,
+                    source);
           }
         });
         showProducts.add(xtype);
@@ -4254,9 +4228,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       showProducts.setEnabled(showp);
     } catch (Exception e)
     {
-      Cache.log
-              .warn("canShowProducts threw an exception - please report to help@jalview.org",
-                      e);
+      Cache.log.warn(
+              "canShowProducts threw an exception - please report to help@jalview.org",
+              e);
       return false;
     }
     return showp;
@@ -4273,8 +4247,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
    * @param source
    *          the database to show cross-references for
    */
-  protected void showProductsFor(final SequenceI[] sel,
-          final boolean _odna, final String source)
+  protected void showProductsFor(final SequenceI[] sel, final boolean _odna,
+          final String source)
   {
     new Thread(CrossRefAction.showProductsFor(sel, _odna, source, this))
             .start();
@@ -4297,8 +4271,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     {
       jalview.bin.Cache.log.error(
               "Exception during translation. Please report this !", ex);
-      final String msg = MessageManager
-              .getString("label.error_when_translating_sequences_submit_bug_report");
+      final String msg = MessageManager.getString(
+              "label.error_when_translating_sequences_submit_bug_report");
       final String errorTitle = MessageManager
               .getString("label.implementation_error")
               + MessageManager.getString("label.translation_failed");
@@ -4308,8 +4282,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     }
     if (al == null || al.getHeight() == 0)
     {
-      final String msg = MessageManager
-              .getString("label.select_at_least_three_bases_in_at_least_one_sequence_to_cDNA_translation");
+      final String msg = MessageManager.getString(
+              "label.select_at_least_three_bases_in_at_least_one_sequence_to_cDNA_translation");
       final String errorTitle = MessageManager
               .getString("label.translation_failed");
       JvOptionPane.showMessageDialog(Desktop.desktop, msg, errorTitle,
@@ -4319,9 +4293,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     {
       AlignFrame af = new AlignFrame(al, DEFAULT_WIDTH, DEFAULT_HEIGHT);
       af.setFileFormat(this.currentFileFormat);
-      final String newTitle = MessageManager.formatMessage(
-              "label.translation_of_params",
-              new Object[] { this.getTitle() });
+      final String newTitle = MessageManager
+              .formatMessage("label.translation_of_params", new Object[]
+              { this.getTitle() });
       af.setTitle(newTitle);
       if (Cache.getDefault(Preferences.ENABLE_SPLIT_FRAME, true))
       {
@@ -4403,8 +4377,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     // Java's Transferable for native dnd
     evt.acceptDrop(DnDConstants.ACTION_COPY_OR_MOVE);
     Transferable t = evt.getTransferable();
-    List<String> files = new ArrayList<String>();
-    List<DataSourceType> protocols = new ArrayList<DataSourceType>();
+    final AlignFrame thisaf = this;
+    final List<String> files = new ArrayList<>();
+    List<DataSourceType> protocols = new ArrayList<>();
 
     try
     {
@@ -4415,145 +4390,160 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     }
     if (files != null)
     {
-      try
+      new Thread(new Runnable()
       {
-        // check to see if any of these files have names matching sequences in
-        // the alignment
-        SequenceIdMatcher idm = new SequenceIdMatcher(viewport
-                .getAlignment().getSequencesArray());
-        /**
-         * Object[] { String,SequenceI}
-         */
-        ArrayList<Object[]> filesmatched = new ArrayList<Object[]>();
-        ArrayList<String> filesnotmatched = new ArrayList<String>();
-        for (int i = 0; i < files.size(); i++)
+        @Override
+        public void run()
         {
-          String file = files.get(i).toString();
-          String pdbfn = "";
-          DataSourceType protocol = FormatAdapter.checkProtocol(file);
-          if (protocol == DataSourceType.FILE)
-          {
-            File fl = new File(file);
-            pdbfn = fl.getName();
-          }
-          else if (protocol == DataSourceType.URL)
-          {
-            URL url = new URL(file);
-            pdbfn = url.getFile();
-          }
-          if (pdbfn.length() > 0)
+          try
           {
-            // attempt to find a match in the alignment
-            SequenceI[] mtch = idm.findAllIdMatches(pdbfn);
-            int l = 0, c = pdbfn.indexOf(".");
-            while (mtch == null && c != -1)
+            // check to see if any of these files have names matching sequences
+            // in
+            // the alignment
+            SequenceIdMatcher idm = new SequenceIdMatcher(
+                    viewport.getAlignment().getSequencesArray());
+            /**
+             * Object[] { String,SequenceI}
+             */
+            ArrayList<Object[]> filesmatched = new ArrayList<>();
+            ArrayList<String> filesnotmatched = new ArrayList<>();
+            for (int i = 0; i < files.size(); i++)
             {
-              do
+              String file = files.get(i).toString();
+              String pdbfn = "";
+              DataSourceType protocol = FormatAdapter.checkProtocol(file);
+              if (protocol == DataSourceType.FILE)
               {
-                l = c;
-              } while ((c = pdbfn.indexOf(".", l)) > l);
-              if (l > -1)
+                File fl = new File(file);
+                pdbfn = fl.getName();
+              }
+              else if (protocol == DataSourceType.URL)
+              {
+                URL url = new URL(file);
+                pdbfn = url.getFile();
+              }
+              if (pdbfn.length() > 0)
               {
-                pdbfn = pdbfn.substring(0, l);
+                // attempt to find a match in the alignment
+                SequenceI[] mtch = idm.findAllIdMatches(pdbfn);
+                int l = 0, c = pdbfn.indexOf(".");
+                while (mtch == null && c != -1)
+                {
+                  do
+                  {
+                    l = c;
+                  } while ((c = pdbfn.indexOf(".", l)) > l);
+                  if (l > -1)
+                  {
+                    pdbfn = pdbfn.substring(0, l);
+                  }
+                  mtch = idm.findAllIdMatches(pdbfn);
+                }
+                if (mtch != null)
+                {
+                  FileFormatI type = null;
+                  try
+                  {
+                    type = new IdentifyFile().identify(file, protocol);
+                  } catch (Exception ex)
+                  {
+                    type = null;
+                  }
+                  if (type != null && type.isStructureFile())
+                  {
+                    filesmatched.add(new Object[] { file, protocol, mtch });
+                    continue;
+                  }
+                }
+                // File wasn't named like one of the sequences or wasn't a PDB
+                // file.
+                filesnotmatched.add(file);
               }
-              mtch = idm.findAllIdMatches(pdbfn);
             }
-            if (mtch != null)
+            int assocfiles = 0;
+            if (filesmatched.size() > 0)
             {
-              FileFormatI type = null;
-              try
+              boolean autoAssociate = Cache.getDefault("AUTOASSOCIATE_PDBANDSEQS", false);
+              if (!autoAssociate)
               {
-                type = new IdentifyFile().identify(file, protocol);
-              } catch (Exception ex)
+                String msg = MessageManager.formatMessage(
+                        "label.automatically_associate_structure_files_with_sequences_same_name",
+                        new Object[]
+                        { Integer.valueOf(filesmatched.size())
+                                .toString() });
+                String ttl = MessageManager.getString(
+                        "label.automatically_associate_structure_files_by_name");
+                int choice = JvOptionPane.showConfirmDialog(thisaf, msg,
+                        ttl, JvOptionPane.YES_NO_OPTION);
+                autoAssociate = choice == JvOptionPane.YES_OPTION;
+              }
+              if (autoAssociate)
               {
-                type = null;
+                for (Object[] fm : filesmatched)
+                {
+                  // try and associate
+                  // TODO: may want to set a standard ID naming formalism for
+                  // associating PDB files which have no IDs.
+                  for (SequenceI toassoc : (SequenceI[]) fm[2])
+                  {
+                    PDBEntry pe = new AssociatePdbFileWithSeq()
+                            .associatePdbWithSeq((String) fm[0],
+                                    (DataSourceType) fm[1], toassoc, false,
+                                    Desktop.instance);
+                    if (pe != null)
+                    {
+                      System.err.println("Associated file : "
+                              + ((String) fm[0]) + " with "
+                              + toassoc.getDisplayId(true));
+                      assocfiles++;
+                    }
+                  }
+                  // TODO: do we need to update overview ? only if features are
+                  // shown I guess
+                  alignPanel.paintAlignment(true, false);
+                }
               }
-              if (type != null && type.isStructureFile())
+              else
               {
-                filesmatched.add(new Object[] { file, protocol, mtch });
-                continue;
+                /*
+                 * add declined structures as sequences
+                 */
+                for (Object[] o : filesmatched)
+                {
+                  filesnotmatched.add((String) o[0]);
+                }
               }
             }
-            // File wasn't named like one of the sequences or wasn't a PDB file.
-            filesnotmatched.add(file);
-          }
-        }
-        int assocfiles = 0;
-        if (filesmatched.size() > 0)
-        {
-          if (Cache.getDefault("AUTOASSOCIATE_PDBANDSEQS", false)
-                  || JvOptionPane
-                          .showConfirmDialog(
-                                  this,
-                                  MessageManager
-                                          .formatMessage(
-                                                  "label.automatically_associate_structure_files_with_sequences_same_name",
-                                                  new Object[] { Integer
-                                                          .valueOf(
-                                                                  filesmatched
-                                                                          .size())
-                                                          .toString() }),
-                                  MessageManager
-                                          .getString("label.automatically_associate_structure_files_by_name"),
-                                  JvOptionPane.YES_NO_OPTION) == JvOptionPane.YES_OPTION)
-
-          {
-            for (Object[] fm : filesmatched)
+            if (filesnotmatched.size() > 0)
             {
-              // try and associate
-              // TODO: may want to set a standard ID naming formalism for
-              // associating PDB files which have no IDs.
-              for (SequenceI toassoc : (SequenceI[]) fm[2])
+              if (assocfiles > 0 && (Cache.getDefault(
+                      "AUTOASSOCIATE_PDBANDSEQS_IGNOREOTHERS", false)
+                      || JvOptionPane.showConfirmDialog(thisaf,
+                              "<html>" + MessageManager.formatMessage(
+                                      "label.ignore_unmatched_dropped_files_info",
+                                      new Object[]
+                                      { Integer.valueOf(
+                                              filesnotmatched.size())
+                                              .toString() })
+                                      + "</html>",
+                              MessageManager.getString(
+                                      "label.ignore_unmatched_dropped_files"),
+                              JvOptionPane.YES_NO_OPTION) == JvOptionPane.YES_OPTION))
               {
-                PDBEntry pe = new AssociatePdbFileWithSeq()
-                        .associatePdbWithSeq((String) fm[0],
-                                (DataSourceType) fm[1], toassoc, false,
-                                Desktop.instance);
-                if (pe != null)
-                {
-                  System.err.println("Associated file : "
-                          + ((String) fm[0]) + " with "
-                          + toassoc.getDisplayId(true));
-                  assocfiles++;
-                }
+                return;
+              }
+              for (String fn : filesnotmatched)
+              {
+                loadJalviewDataFile(fn, null, null, null);
               }
-              alignPanel.paintAlignment(true);
+
             }
-          }
-        }
-        if (filesnotmatched.size() > 0)
-        {
-          if (assocfiles > 0
-                  && (Cache.getDefault(
-                          "AUTOASSOCIATE_PDBANDSEQS_IGNOREOTHERS", false) || JvOptionPane
-                          .showConfirmDialog(
-                                  this,
-                                  "<html>"
-                                          + MessageManager
-                                                  .formatMessage(
-                                                          "label.ignore_unmatched_dropped_files_info",
-                                                          new Object[] { Integer
-                                                                  .valueOf(
-                                                                          filesnotmatched
-                                                                                  .size())
-                                                                  .toString() })
-                                          + "</html>",
-                                  MessageManager
-                                          .getString("label.ignore_unmatched_dropped_files"),
-                                  JvOptionPane.YES_NO_OPTION) == JvOptionPane.YES_OPTION))
-          {
-            return;
-          }
-          for (String fn : filesnotmatched)
+          } catch (Exception ex)
           {
-            loadJalviewDataFile(fn, null, null, null);
+            ex.printStackTrace();
           }
-
         }
-      } catch (Exception ex)
-      {
-        ex.printStackTrace();
-      }
+      }).start();
     }
   }
 
@@ -4581,9 +4571,11 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       // if the file isn't identified, or not positively identified as some
       // other filetype (PFAM is default unidentified alignment file type) then
       // try to parse as annotation.
-      boolean isAnnotation = (format == null || FileFormat.Pfam
-              .equals(format)) ? new AnnotationFile()
-              .annotateAlignmentView(viewport, file, sourceType) : false;
+      boolean isAnnotation = (format == null
+              || FileFormat.Pfam.equals(format))
+                      ? new AnnotationFile().annotateAlignmentView(viewport,
+                              file, sourceType)
+                      : false;
 
       if (!isAnnotation)
       {
@@ -4597,25 +4589,24 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
             if (tcf.annotateAlignment(viewport.getAlignment(), true))
             {
               buildColourMenu();
-              changeColour(new TCoffeeColourScheme(viewport.getAlignment()));
+              changeColour(
+                      new TCoffeeColourScheme(viewport.getAlignment()));
               isAnnotation = true;
-              statusBar
-                      .setText(MessageManager
-                              .getString("label.successfully_pasted_tcoffee_scores_to_alignment"));
+              statusBar.setText(MessageManager.getString(
+                      "label.successfully_pasted_tcoffee_scores_to_alignment"));
             }
             else
             {
               // some problem - if no warning its probable that the ID matching
               // process didn't work
-              JvOptionPane
-                      .showMessageDialog(
-                              Desktop.desktop,
-                              tcf.getWarningMessage() == null ? MessageManager
-                                      .getString("label.check_file_matches_sequence_ids_alignment")
-                                      : tcf.getWarningMessage(),
-                              MessageManager
-                                      .getString("label.problem_reading_tcoffee_score_file"),
-                              JvOptionPane.WARNING_MESSAGE);
+              JvOptionPane.showMessageDialog(Desktop.desktop,
+                      tcf.getWarningMessage() == null
+                              ? MessageManager.getString(
+                                      "label.check_file_matches_sequence_ids_alignment")
+                              : tcf.getWarningMessage(),
+                      MessageManager.getString(
+                              "label.problem_reading_tcoffee_score_file"),
+                      JvOptionPane.WARNING_MESSAGE);
             }
           }
           else
@@ -4624,9 +4615,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
           }
         } catch (Exception x)
         {
-          Cache.log
-                  .debug("Exception when processing data source as T-COFFEE score file",
-                          x);
+          Cache.log.debug(
+                  "Exception when processing data source as T-COFFEE score file",
+                  x);
           tcf = null;
         }
         if (tcf == null)
@@ -4640,14 +4631,13 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
           }
           if (FileFormat.ScoreMatrix == format)
           {
-            ScoreMatrixFile sm = new ScoreMatrixFile(new FileParse(file,
-                    sourceType));
+            ScoreMatrixFile sm = new ScoreMatrixFile(
+                    new FileParse(file, sourceType));
             sm.parse();
             // todo: i18n this message
-            statusBar
-                    .setText(MessageManager.formatMessage(
-                            "label.successfully_loaded_matrix",
-                            sm.getMatrixName()));
+            statusBar.setText(MessageManager.formatMessage(
+                    "label.successfully_loaded_matrix",
+                    sm.getMatrixName()));
           }
           else if (FileFormat.Jnet.equals(format))
           {
@@ -4655,11 +4645,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
             new JnetAnnotationMaker();
             JnetAnnotationMaker.add_annotation(predictions,
                     viewport.getAlignment(), 0, false);
-            SequenceI repseq = viewport.getAlignment().getSequenceAt(0);
-            viewport.getAlignment().setSeqrep(repseq);
-            HiddenColumns cs = new HiddenColumns();
-            cs.hideInsertionsFor(repseq);
-            viewport.getAlignment().setHiddenColumns(cs);
+            viewport.getAlignment().setupJPredAlignment();
             isAnnotation = true;
           }
           // else if (IdentifyFile.FeaturesFile.equals(format))
@@ -4667,7 +4653,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
           {
             if (parseFeaturesFile(file, sourceType))
             {
-              alignPanel.paintAlignment(true);
+              alignPanel.paintAlignment(true, true);
             }
           }
           else
@@ -4682,7 +4668,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
         alignPanel.adjustAnnotationHeight();
         viewport.updateSequenceIdColours();
         buildSortByAnnotationScoresMenu();
-        alignPanel.paintAlignment(true);
+        alignPanel.paintAlignment(true, true);
       }
     } catch (Exception ex)
     {
@@ -4697,11 +4683,16 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       }
       new OOMWarning(
               "loading data "
-                      + (sourceType != null ? (sourceType == DataSourceType.PASTE ? "from clipboard."
-                              : "using " + sourceType + " from " + file)
+                      + (sourceType != null
+                              ? (sourceType == DataSourceType.PASTE
+                                      ? "from clipboard."
+                                      : "using " + sourceType + " from "
+                                              + file)
                               : ".")
-                      + (format != null ? "(parsing as '" + format
-                              + "' file)" : ""), oom, Desktop.desktop);
+                      + (format != null
+                              ? "(parsing as '" + format + "' file)"
+                              : ""),
+              oom, Desktop.desktop);
     }
   }
 
@@ -4752,7 +4743,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     final AlignViewportI peer = viewport.getCodingComplement();
     if (peer != null)
     {
-      AlignFrame linkedAlignFrame = ((AlignViewport) peer).getAlignPanel().alignFrame;
+      AlignFrame linkedAlignFrame = ((AlignViewport) peer)
+              .getAlignPanel().alignFrame;
       if (linkedAlignFrame.tabbedPane.getTabCount() > index)
       {
         linkedAlignFrame.tabbedPane.setSelectedIndex(index);
@@ -4867,30 +4859,31 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     // here
     final JMenu rfetch = new JMenu(
             MessageManager.getString("action.fetch_db_references"));
-    rfetch.setToolTipText(MessageManager
-            .getString("label.retrieve_parse_sequence_database_records_alignment_or_selected_sequences"));
+    rfetch.setToolTipText(MessageManager.getString(
+            "label.retrieve_parse_sequence_database_records_alignment_or_selected_sequences"));
     webService.add(rfetch);
 
     final JCheckBoxMenuItem trimrs = new JCheckBoxMenuItem(
             MessageManager.getString("option.trim_retrieved_seqs"));
-    trimrs.setToolTipText(MessageManager
-            .getString("label.trim_retrieved_sequences"));
-    trimrs.setSelected(Cache.getDefault("TRIM_FETCHED_DATASET_SEQS", true));
+    trimrs.setToolTipText(
+            MessageManager.getString("label.trim_retrieved_sequences"));
+    trimrs.setSelected(
+            Cache.getDefault(DBRefFetcher.TRIM_RETRIEVED_SEQUENCES, true));
     trimrs.addActionListener(new ActionListener()
     {
       @Override
       public void actionPerformed(ActionEvent e)
       {
         trimrs.setSelected(trimrs.isSelected());
-        Cache.setProperty("TRIM_FETCHED_DATASET_SEQS",
+        Cache.setProperty(DBRefFetcher.TRIM_RETRIEVED_SEQUENCES,
                 Boolean.valueOf(trimrs.isSelected()).toString());
       };
     });
     rfetch.add(trimrs);
     JMenuItem fetchr = new JMenuItem(
             MessageManager.getString("label.standard_databases"));
-    fetchr.setToolTipText(MessageManager
-            .getString("label.fetch_embl_uniprot"));
+    fetchr.setToolTipText(
+            MessageManager.getString("label.fetch_embl_uniprot"));
     fetchr.addActionListener(new ActionListener()
     {
 
@@ -4904,8 +4897,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
           {
             boolean isNucleotide = alignPanel.alignFrame.getViewport()
                     .getAlignment().isNucleotide();
-            DBRefFetcher dbRefFetcher = new DBRefFetcher(alignPanel.av
-                    .getSequenceSelection(), alignPanel.alignFrame, null,
+            DBRefFetcher dbRefFetcher = new DBRefFetcher(
+                    alignPanel.av.getSequenceSelection(),
+                    alignPanel.alignFrame, null,
                     alignPanel.alignFrame.featureSettings, isNucleotide);
             dbRefFetcher.addListener(new FetchFinishedListenerI()
             {
@@ -5008,8 +5002,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
                 });
                 fetchr.setToolTipText(JvSwingUtils.wrapTooltip(true,
                         MessageManager.formatMessage(
-                                "label.fetch_retrieve_from",
-                                new Object[] { src.getDbName() })));
+                                "label.fetch_retrieve_from", new Object[]
+                                { src.getDbName() })));
                 dfetch.add(fetchr);
                 comp++;
               }
@@ -5019,9 +5013,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
                         .toArray(new DbSourceProxy[0]);
                 // fetch all entry
                 DbSourceProxy src = otherdb.get(0);
-                fetchr = new JMenuItem(MessageManager.formatMessage(
-                        "label.fetch_all_param",
-                        new Object[] { src.getDbSource() }));
+                fetchr = new JMenuItem(MessageManager
+                        .formatMessage("label.fetch_all_param", new Object[]
+                        { src.getDbSource() }));
                 fetchr.addActionListener(new ActionListener()
                 {
                   @Override
@@ -5059,30 +5053,33 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
                 fetchr.setToolTipText(JvSwingUtils.wrapTooltip(true,
                         MessageManager.formatMessage(
                                 "label.fetch_retrieve_from_all_sources",
-                                new Object[] {
-                                    Integer.valueOf(otherdb.size())
-                                            .toString(), src.getDbSource(),
-                                    src.getDbName() })));
+                                new Object[]
+                                { Integer.valueOf(otherdb.size())
+                                        .toString(),
+                                    src.getDbSource(), src.getDbName() })));
                 dfetch.add(fetchr);
                 comp++;
                 // and then build the rest of the individual menus
                 ifetch = new JMenu(MessageManager.formatMessage(
-                        "label.source_from_db_source",
-                        new Object[] { src.getDbSource() }));
+                        "label.source_from_db_source", new Object[]
+                        { src.getDbSource() }));
                 icomp = 0;
                 String imname = null;
                 int i = 0;
                 for (DbSourceProxy sproxy : otherdb)
                 {
                   String dbname = sproxy.getDbName();
-                  String sname = dbname.length() > 5 ? dbname.substring(0,
-                          5) + "..." : dbname;
-                  String msname = dbname.length() > 10 ? dbname.substring(
-                          0, 10) + "..." : dbname;
+                  String sname = dbname.length() > 5
+                          ? dbname.substring(0, 5) + "..."
+                          : dbname;
+                  String msname = dbname.length() > 10
+                          ? dbname.substring(0, 10) + "..."
+                          : dbname;
                   if (imname == null)
                   {
-                    imname = MessageManager.formatMessage(
-                            "label.from_msname", new Object[] { sname });
+                    imname = MessageManager
+                            .formatMessage("label.from_msname", new Object[]
+                            { sname });
                   }
                   fetchr = new JMenuItem(msname);
                   final DbSourceProxy[] dassrc = { sproxy };
@@ -5121,8 +5118,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
                     }
 
                   });
-                  fetchr.setToolTipText("<html>"
-                          + MessageManager.formatMessage(
+                  fetchr.setToolTipText(
+                          "<html>" + MessageManager.formatMessage(
                                   "label.fetch_retrieve_from", new Object[]
                                   { dbname }));
                   ifetch.add(fetchr);
@@ -5197,7 +5194,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   protected void showUnconservedMenuItem_actionPerformed(ActionEvent e)
   {
     viewport.setShowUnconserved(showNonconservedMenuItem.getState());
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(false, false);
   }
 
   /*
@@ -5286,7 +5283,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     {
       PaintRefresher.Refresh(this, viewport.getSequenceSetId());
       alignPanel.updateAnnotation();
-      alignPanel.paintAlignment(true);
+      alignPanel.paintAlignment(true, true);
     }
   }
 
@@ -5298,7 +5295,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       viewport.getAlignment().setSeqrep(null);
       PaintRefresher.Refresh(this, viewport.getSequenceSetId());
       alignPanel.updateAnnotation();
-      alignPanel.paintAlignment(true);
+      alignPanel.paintAlignment(true, true);
     }
   }
 
@@ -5307,6 +5304,10 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   {
     if (avc.createGroup())
     {
+      if (applyAutoAnnotationSettings.isSelected())
+      {
+        alignPanel.updateAnnotation(true, false);
+      }
       alignPanel.alignmentChanged();
     }
   }
@@ -5327,17 +5328,14 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
    */
   public void setDisplayedView(AlignmentPanel alignmentPanel)
   {
-    if (!viewport.getSequenceSetId().equals(
-            alignmentPanel.av.getSequenceSetId()))
+    if (!viewport.getSequenceSetId()
+            .equals(alignmentPanel.av.getSequenceSetId()))
     {
-      throw new Error(
-              MessageManager
-                      .getString("error.implementation_error_cannot_show_view_alignment_frame"));
+      throw new Error(MessageManager.getString(
+              "error.implementation_error_cannot_show_view_alignment_frame"));
     }
-    if (tabbedPane != null
-            && tabbedPane.getTabCount() > 0
-            && alignPanels.indexOf(alignmentPanel) != tabbedPane
-                    .getSelectedIndex())
+    if (tabbedPane != null && tabbedPane.getTabCount() > 0 && alignPanels
+            .indexOf(alignmentPanel) != tabbedPane.getSelectedIndex())
     {
       tabbedPane.setSelectedIndex(alignPanels.indexOf(alignmentPanel));
     }
@@ -5391,7 +5389,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     this.alignPanel.av.setSortAnnotationsBy(getAnnotationSortOrder());
     this.alignPanel.av
             .setShowAutocalculatedAbove(isShowAutoCalculatedAbove());
-    alignPanel.paintAlignment(true);
+    alignPanel.paintAlignment(false, false);
   }
 
   /**
@@ -5416,7 +5414,7 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     {
       return;
     }
-    List<SequenceI> cdnaSeqs = new ArrayList<SequenceI>();
+    List<SequenceI> cdnaSeqs = new ArrayList<>();
     for (SequenceI aaSeq : alignment.getSequences())
     {
       for (AlignedCodonFrame acf : mappings)
@@ -5440,15 +5438,15 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       // show a warning dialog no mapped cDNA
       return;
     }
-    AlignmentI cdna = new Alignment(cdnaSeqs.toArray(new SequenceI[cdnaSeqs
-            .size()]));
+    AlignmentI cdna = new Alignment(
+            cdnaSeqs.toArray(new SequenceI[cdnaSeqs.size()]));
     GAlignFrame alignFrame = new AlignFrame(cdna, AlignFrame.DEFAULT_WIDTH,
             AlignFrame.DEFAULT_HEIGHT);
     cdna.alignAs(alignment);
     String newtitle = "cDNA " + MessageManager.getString("label.for") + " "
             + this.title;
-    Desktop.addInternalFrame(alignFrame, newtitle,
-            AlignFrame.DEFAULT_WIDTH, AlignFrame.DEFAULT_HEIGHT);
+    Desktop.addInternalFrame(alignFrame, newtitle, AlignFrame.DEFAULT_WIDTH,
+            AlignFrame.DEFAULT_HEIGHT);
   }
 
   /**
@@ -5481,8 +5479,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       al = dna.reverseCdna(complement);
       viewport.addAlignment(al, "");
       addHistoryItem(new EditCommand(
-              MessageManager.getString("label.add_sequences"),
-              Action.PASTE, al.getSequencesArray(), 0, al.getWidth(),
+              MessageManager.getString("label.add_sequences"), Action.PASTE,
+              al.getSequencesArray(), 0, al.getWidth(),
               viewport.getAlignment()));
     } catch (Exception ex)
     {
@@ -5509,12 +5507,10 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
       } catch (Exception ex)
       {
         System.err.println((ex.toString()));
-        JvOptionPane
-                .showInternalMessageDialog(Desktop.desktop, MessageManager
-                        .getString("label.couldnt_run_groovy_script"),
-                        MessageManager
-                                .getString("label.groovy_support_failed"),
-                        JvOptionPane.ERROR_MESSAGE);
+        JvOptionPane.showInternalMessageDialog(Desktop.desktop,
+                MessageManager.getString("label.couldnt_run_groovy_script"),
+                MessageManager.getString("label.groovy_support_failed"),
+                JvOptionPane.ERROR_MESSAGE);
       }
     }
     else
@@ -5554,9 +5550,9 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
   {
     // include key modifier check in case user selects from menu
     avc.markHighlightedColumns(
-            (actionEvent.getModifiers() & ActionEvent.ALT_MASK) != 0,
-            true,
-            (actionEvent.getModifiers() & (ActionEvent.META_MASK | ActionEvent.CTRL_MASK)) != 0);
+            (actionEvent.getModifiers() & ActionEvent.ALT_MASK) != 0, true,
+            (actionEvent.getModifiers() & (ActionEvent.META_MASK
+                    | ActionEvent.CTRL_MASK)) != 0);
   }
 
   /**
@@ -5571,8 +5567,8 @@ public class AlignFrame extends GAlignFrame implements DropTargetListener,
     colourMenu.add(textColour);
     colourMenu.addSeparator();
 
-    ColourMenuHelper.addMenuItems(colourMenu, this,
-            viewport.getAlignment(), false);
+    ColourMenuHelper.addMenuItems(colourMenu, this, viewport.getAlignment(),
+            false);
 
     colourMenu.addSeparator();
     colourMenu.add(conservationMenuItem);