private static final String STRAND = "STRAND";
+ // private key for Phase designed not to conflict with real GFF data
+ private static final String PHASE = "!Phase";
+
private static final String ATTRIBUTES = "ATTRIBUTES";
public int begin;
}
/**
- * Used for getting values which are not in the basic set. eg STRAND, FRAME
+ * Used for getting values which are not in the basic set. eg STRAND, PHASE
* for GFF file
*
* @param key
setValue(STRAND, strand);
}
+ public void setPhase(String phase)
+ {
+ setValue(PHASE, phase);
+ }
+
+ public String getPhase()
+ {
+ return (String) getValue(PHASE);
+ }
+
+ /**
+ * Readable representation, for debug only, not guaranteed not to change
+ * between versions
+ */
+ @Override
+ public String toString()
+ {
+ return String.format("%d %d %s %s", getBegin(), getEnd(), getType(),
+ getDescription());
+ }
}
}
/**
- * Answers true unless the feature type is 'exon' (or a sub-type of exon in
- * the Sequence Ontology). Exon features are only retrieved in order to
- * identify the exon sequence loci, and are redundant information on the exon
- * sequence itself.
+ * Answers true unless the feature type is 'transcript' or 'exon' (or a
+ * sub-type in the Sequence Ontology). These features are only retrieved in
+ * order to identify the exon sequence loci, and are redundant information on
+ * the exon sequence itself.
*/
@Override
protected boolean retainFeature(SequenceFeature sf, String accessionId)
{
- if (SequenceOntology.getInstance().isA(sf.getType(),
- SequenceOntology.EXON))
+ SequenceOntology so = SequenceOntology.getInstance();
+ String type = sf.getType();
+
+ if (isTranscript(type) || so.isA(type, SequenceOntology.EXON))
{
return false;
}
- return super.retainFeature(sf, accessionId);
+ return featureMayBelong(sf, accessionId);
}
/**
{
return false;
}
- return super.retainFeature(sf, accessionId);
+ return featureMayBelong(sf, accessionId);
}
/**
package jalview.ext.ensembl;
-import jalview.datamodel.AlignedCodonFrame;
import jalview.datamodel.AlignmentI;
+import jalview.datamodel.Sequence;
import jalview.datamodel.SequenceFeature;
import jalview.datamodel.SequenceI;
import jalview.io.gff.SequenceOntology;
import jalview.util.MapList;
import java.util.ArrayList;
+import java.util.Arrays;
import java.util.List;
/**
@Override
public AlignmentI getSequenceRecords(String query) throws Exception
{
+ // TODO ? if an ENST identifier is supplied, convert to ENSG?
AlignmentI al = super.getSequenceRecords(query);
if (al.getHeight() > 0)
{
}
/**
- * Find and fetch all transcripts for the gene, as identified by "transcript"
- * features whose Parent is the requested gene
+ * Constructs all transcripts for the gene, as identified by "transcript"
+ * features whose Parent is the requested gene. The coding transcript
+ * sequences (i.e. with introns omitted) are added to the alignment.
*
* @param al
* @param accId
throws Exception
{
SequenceI gene = al.getSequenceAt(0);
- List<String> transcriptIds = getTranscriptIds(accId, gene);
+ List<SequenceFeature> transcriptFeatures = getTranscriptFeatures(accId,
+ gene);
- // TODO: could just use features and genomic sequence
- // to generate the transcript sequences - faster
- // could also grab "Name" as transcript description (gene name)
- for (String transcriptId : transcriptIds)
+ for (SequenceFeature transcriptFeature : transcriptFeatures)
{
- /*
- * fetch and map the transcript sequence; we can pass in the gene
- * sequence with features marked to save fetching it again
- */
- EnsemblCdna cdnaFetcher = new EnsemblCdna();
- AlignmentI al2 = cdnaFetcher.getSequenceRecords(transcriptId,
- gene);
- for (SequenceI seq : al2.getSequences())
- {
- /*
- * build mapping from gene sequence to transcript
- */
- MapList mapping = cdnaFetcher.getGenomicRanges(gene, transcriptId,
- seq.getStart());
-
- /*
- * align the transcript to the gene
- */
- AlignedCodonFrame acf = new AlignedCodonFrame();
- acf.addMap(gene, seq, mapping);
- char gap = al.getGapCharacter();
- // AlignmentUtils.alignSequenceAs(seq, gene, acf, String.valueOf(gap),
- // gap, false, false);
-
- al.addSequence(seq);
- }
+ makeTranscript(transcriptFeature, al, gene);
}
}
/**
- * Returns a list of the ids of transcript features on the sequence whose
- * Parent is the gene for the accession id
+ * Constructs a spliced transcript sequence by finding 'exon' features for the
+ * given id (or failing that 'CDS'). Copies features on to the new sequence.
+ * 'Aligns' the new sequence against the gene sequence by padding with gaps,
+ * and adds it to the alignment.
*
- * @param accId
- * @param geneSequence
+ * @param transcriptFeature
+ * @param al
+ * the alignment to which to add the new sequence
+ * @param gene
+ * the parent gene sequence, with features
* @return
*/
- protected List<String> getTranscriptIds(String accId, SequenceI geneSequence)
+ SequenceI makeTranscript(SequenceFeature transcriptFeature,
+ AlignmentI al, SequenceI gene)
{
- SequenceOntology so = SequenceOntology.getInstance();
- List<String> transcriptIds = new ArrayList<String>();
+ String accId = (String) transcriptFeature.getValue("transcript_id");
+ if (accId == null)
+ {
+ return null;
+ }
/*
- * scan for transcript features belonging to our gene;
- * also remove any which belong to other genes
+ * NB we are mapping from gene sequence (not genome), so do not
+ * need to check for reverse strand (gene and transcript sequences
+ * are in forward sense)
*/
- SequenceFeature[] sfs = geneSequence.getSequenceFeatures();
+
+ /*
+ * make a gene-length sequence filled with gaps
+ * we will fill in the bases for transcript regions
+ */
+ char[] seqChars = new char[gene.getLength()];
+ Arrays.fill(seqChars, al.getGapCharacter());
+
+ /*
+ * look for exon features of the transcript, failing that for CDS
+ * (for example ENSG00000124610 has 1 CDS but no exon features)
+ */
+ String parentId = "transcript:" + accId;
+ List<SequenceFeature> splices = findFeatures(gene,
+ SequenceOntology.EXON, parentId);
+ if (splices.isEmpty())
+ {
+ splices = findFeatures(gene, SequenceOntology.CDS, parentId);
+ }
+
+ int transcriptLength = 0;
+ final char[] geneChars = gene.getSequence();
+ int offset = gene.getStart(); // to convert to 0-based positions
+ List<int[]> mappedFrom = new ArrayList<int[]>();
+
+ for (SequenceFeature sf : splices)
+ {
+ int start = sf.getBegin() - offset;
+ int end = sf.getEnd() - offset;
+ int spliceLength = end - start + 1;
+ System.arraycopy(geneChars, start, seqChars, start, spliceLength);
+ transcriptLength += spliceLength;
+ mappedFrom.add(new int[] { sf.getBegin(), sf.getEnd() });
+ }
+
+ Sequence transcript = new Sequence(accId, seqChars, 1, transcriptLength);
+ transcript.createDatasetSequence();
+
+ al.addSequence(transcript);
+
+ /*
+ * transfer features to the new sequence; we use EnsemblCdna to do this,
+ * to filter out unwanted features types (see method retainFeature)
+ */
+ List<int[]> mapTo = new ArrayList<int[]>();
+ mapTo.add(new int[] { 1, transcriptLength });
+ MapList mapping = new MapList(mappedFrom, mapTo, 1, 1);
+ new EnsemblCdna().transferFeatures(gene.getSequenceFeatures(),
+ transcript.getDatasetSequence(), mapping, parentId);
+
+ /*
+ * and finally fetch the protein product and save as a cross-reference
+ */
+ addProteinProduct(transcript);
+
+ return transcript;
+ }
+
+ /**
+ * Returns a list of the transcript features on the sequence whose Parent is
+ * the gene for the accession id. Also removes all transcript features from
+ * the gene sequence, as we have no further need for them and they obscure
+ * more useful features on the display.
+ *
+ * @param accId
+ * @param geneSequence
+ * @return
+ */
+ protected List<SequenceFeature> getTranscriptFeatures(String accId,
+ SequenceI geneSequence)
+ {
+ List<SequenceFeature> transcriptFeatures = new ArrayList<SequenceFeature>();
+
List<SequenceFeature> keptFeatures = new ArrayList<SequenceFeature>();
- boolean featureDropped = false;
String parentIdentifier = "gene:" + accId;
- for (SequenceFeature sf : sfs)
+ SequenceFeature[] sfs = geneSequence.getSequenceFeatures();
+
+ if (sfs != null)
{
- if (so.isA(sf.getType(), SequenceOntology.TRANSCRIPT))
+ for (SequenceFeature sf : sfs)
{
- String parent = (String) sf.getValue(PARENT);
- if (parentIdentifier.equals(parent))
+ if (isTranscript(sf.getType()))
{
- transcriptIds.add((String) sf.getValue("transcript_id"));
- keptFeatures.add(sf);
+ String parent = (String) sf.getValue(PARENT);
+ if (parentIdentifier.equals(parent))
+ {
+ transcriptFeatures.add(sf);
+ }
}
else
{
- featureDropped = true;
+ keptFeatures.add(sf);
}
}
- else
- {
- keptFeatures.add(sf);
- }
- }
- if (featureDropped)
- {
- geneSequence.getDatasetSequence().setSequenceFeatures(
- keptFeatures.toArray(new SequenceFeature[keptFeatures
- .size()]));
}
- return transcriptIds;
+ SequenceFeature[] featuresRetained = keptFeatures.toArray(new SequenceFeature[keptFeatures.size()]);
+ geneSequence.getDatasetSequence().setSequenceFeatures(featuresRetained);
+
+ return transcriptFeatures;
}
@Override
@Override
public String getTestQuery()
{
- return "ENSG00000157764"; // reverse strand
- // ENSG00000090266 // forward strand
+ return "ENSG00000157764"; // BRAF, 5 transcripts, reverse strand
+ // ENSG00000090266 // NDUFB2, 15 transcripts, forward strand
+ // ENSG00000101812 // H2BFM histone, 3 transcripts, forward strand
+ // ENSG00000123569 // H2BFWT histone, 2 transcripts, reverse strand
}
/**
}
/**
- * Answers true unless feature type is 'gene'. We need the gene features to
- * identify the range, but it is redundant information on the gene sequence.
+ * Answers true unless feature type is 'gene', or 'transcript' with a parent
+ * which is a different gene. We need the gene features to identify the range,
+ * but it is redundant information on the gene sequence. Checking the parent
+ * allows us to drop transcript features which belong to different
+ * (overlapping) genes.
*/
@Override
protected boolean retainFeature(SequenceFeature sf, String accessionId)
{
- return !SequenceOntology.getInstance().isA(sf.getType(),
- SequenceOntology.GENE);
+ if (SequenceOntology.getInstance().isA(sf.getType(),
+ SequenceOntology.GENE))
+ {
+ return false;
+ }
+
+ if (isTranscript(sf.getType()))
+ {
+ String parent = (String) sf.getValue(PARENT);
+ if (!("gene:" + accessionId).equals(parent))
+ {
+ return false;
+ }
+ }
+ return true;
+ }
+
+ /**
+ * Answers false. This allows an optimisation - a single 'gene' feature is all
+ * that is needed to identify the positions of the gene on the genomic
+ * sequence.
+ */
+ @Override
+ protected boolean isSpliceable()
+ {
+ return false;
}
}
package jalview.ext.ensembl;
import jalview.datamodel.SequenceFeature;
-import jalview.io.gff.SequenceOntology;
public class EnsemblGenome extends EnsemblSeqProxy
{
*/
private static final EnsemblFeatureType[] FEATURES_TO_FETCH = {
EnsemblFeatureType.transcript, EnsemblFeatureType.exon,
- EnsemblFeatureType.cds, EnsemblFeatureType.variation };
+ EnsemblFeatureType.cds /*, EnsemblFeatureType.variation */};
public EnsemblGenome()
{
@Override
protected boolean retainFeature(SequenceFeature sf, String accessionId)
{
- if (SequenceOntology.getInstance().isA(sf.getType(),
- SequenceOntology.TRANSCRIPT))
+ if (isTranscript(sf.getType()))
{
return false;
}
- return super.retainFeature(sf, accessionId);
+ return featureMayBelong(sf, accessionId);
}
/**
@Override
protected boolean identifiesSequence(SequenceFeature sf, String accId)
{
- if (SequenceOntology.getInstance().isA(sf.getType(),
- SequenceOntology.TRANSCRIPT))
+ if (isTranscript(sf.getType()))
{
String id = (String) sf.getValue(ID);
if (("transcript:" + accId).equals(id))
import jalview.datamodel.AlignmentI;
import jalview.datamodel.SequenceFeature;
+import jalview.datamodel.SequenceI;
public class EnsemblProtein extends EnsemblSeqProxy
{
* applicable to the protein product sequence
*/
@Override
- protected void addFeaturesAndProduct(String accId, AlignmentI alignment)
+ protected void addFeaturesAndProduct(String accId, AlignmentI alignment,
+ SequenceI genomicSequence)
{
}
*/
public abstract class EnsemblSeqProxy extends EnsemblRestClient
{
+ protected static final String CONSEQUENCE_TYPE = "consequence_type";
+
protected static final String PARENT = "Parent";
protected static final String ID = "ID";
+ /*
+ * this needs special handling, as it isA sequence_variant in the
+ * Sequence Ontology, but behaves in Ensembl as if it isA transcript
+ */
+ protected static final String NMD_VARIANT = "NMD_transcript_variant";
+
public enum EnsemblSeqType
{
/**
}
- /*
- * genomic sequence, with features retrieved from the REST overlap service
- */
- private SequenceI genomicSequence;
-
/**
* Constructor
*/
/**
* Makes the sequence queries to Ensembl's REST service and returns an
- * alignment consisting of the returned sequences
+ * alignment consisting of the returned sequences. This overloaded method
+ * allows the genomic sequence (with features) to be passed in if it has
+ * already been retrieved, to avoid repeat calls to fetch it.
*/
- @Override
- public AlignmentI getSequenceRecords(String query) throws Exception
+ public AlignmentI getSequenceRecords(String query,
+ SequenceI genomicSequence) throws Exception
{
long now = System.currentTimeMillis();
// TODO use a String... query vararg instead?
// danger: accession separator used as a regex here, a string elsewhere
// in this case it is ok (it is just a space), but (e.g.) '\' would not be
- List<String> allIds = Arrays.asList(query.split(getAccessionSeparator()));
+ List<String> allIds = Arrays.asList(query
+ .split(getAccessionSeparator()));
AlignmentI alignment = null;
inProgress = true;
*/
for (String accId : allIds)
{
- addFeaturesAndProduct(accId, alignment);
+ addFeaturesAndProduct(accId, alignment, genomicSequence);
}
inProgress = false;
* @param accId
* @param alignment
*/
- protected void addFeaturesAndProduct(String accId, AlignmentI alignment)
+ protected void addFeaturesAndProduct(String accId, AlignmentI alignment,
+ SequenceI genomicSequence)
{
try
{
features);
if (geneFeatures.getHeight() > 0)
{
- /*
- * transfer features to the query sequence
- */
genomicSequence = geneFeatures.getSequenceAt(0);
}
}
if (genomicSequence != null)
{
+ /*
+ * transfer features to the query sequence
+ */
SequenceI querySeq = alignment.findName(accId);
if (transferFeatures(accId, genomicSequence, querySeq))
{
* dna here since the retrieved sequence is as transcribed (reverse
* complement for reverse strand), i.e in the same sense as the peptide.
*/
+ boolean fivePrimeIncomplete = false;
for (SequenceFeature sf : sfs)
{
/*
*/
if (so.isA(sf.getType(), SequenceOntology.CDS))
{
- ranges.add(new int[] { sf.getBegin(), sf.getEnd() });
- mappedDnaLength += Math.abs(sf.getEnd() - sf.getBegin()) + 1;
+ int phase = 0;
+ try {
+ phase = Integer.parseInt(sf.getPhase());
+ } catch (NumberFormatException e)
+ {
+ // ignore
+ }
+ /*
+ * phase > 0 on first codon means 5' incomplete - skip to the start
+ * of the next codon; example ENST00000496384
+ */
+ int begin = sf.getBegin();
+ int end = sf.getEnd();
+ if (ranges.isEmpty() && phase > 0)
+ {
+ fivePrimeIncomplete = true;
+ begin += phase;
+ if (begin > end)
+ {
+ continue; // shouldn't happen?
+ }
+ }
+ ranges.add(new int[] { begin, end });
+ mappedDnaLength += Math.abs(end - begin) + 1;
}
}
int proteinLength = proteinSeq.getLength();
List<int[]> proteinRange = new ArrayList<int[]>();
- proteinRange.add(new int[] { 1, proteinLength });
+ int proteinStart = 1;
+ if (fivePrimeIncomplete && proteinSeq.getCharAt(0) == 'X')
+ {
+ proteinStart = 2;
+ proteinLength--;
+ }
+ proteinRange.add(new int[] { proteinStart, proteinLength });
/*
- * dna length should map to protein (or protein minus stop codon)
+ * dna length should map to protein (or protein plus stop codon)
*/
- if (mappedDnaLength == 3 * proteinLength
- || mappedDnaLength == 3 * (proteinLength + 1))
+ int codesForResidues = mappedDnaLength / 3;
+ if (codesForResidues == proteinLength
+ || codesForResidues == (proteinLength + 1))
{
return new MapList(ranges, proteinRange, 3, 1);
}
}
/*
- * generously size for initial number of cds regions
+ * generously initial size for number of cds regions
* (worst case titin Q8WZ42 has c. 313 exons)
*/
List<int[]> regions = new ArrayList<int[]>(100);
- int sourceLength = sourceSequence.getLength();
int mappedLength = 0;
int direction = 1; // forward
boolean directionSet = false;
}
mappedLength += Math.abs(sf.getEnd() - sf.getBegin() + 1);
- if (mappedLength >= sourceLength)
+ if (!isSpliceable())
{
/*
- * break for the case of matching gene features v gene sequence
- * - only need to locate the 'gene' feature for accId
+ * 'gene' sequence is contiguous so we can stop as soon as its
+ * identifying feature has been found
*/
break;
}
}
/**
+ * Answers true if the sequence being retrieved may occupy discontiguous
+ * regions on the genomic sequence.
+ */
+ protected boolean isSpliceable()
+ {
+ return true;
+ }
+
+ /**
* Returns true if the sequence feature marks positions of the genomic
* sequence feature which are within the sequence being retrieved. For
* example, an 'exon' feature whose parent is the target transcript marks the
String accId);
/**
- * Transfers the sequence feature to the target sequence, adjusting its start
- * and end range based on the 'overlap' ranges. Features which do not overlap
- * the target sequence are ignored, as are features with a parent other than
- * the target sequence id.
+ * Transfers the sequence feature to the target sequence, locating its start
+ * and end range based on the mapping. Features which do not overlap the
+ * target sequence are ignored.
*
* @param sf
* @param targetSequence
- * @param overlap
+ * @param mapping
+ * mapping from the sequence feature's coordinates to the target
+ * sequence
*/
protected void transferFeature(SequenceFeature sf,
- SequenceI targetSequence, MapList overlap)
+ SequenceI targetSequence, MapList mapping)
{
int start = sf.getBegin();
int end = sf.getEnd();
- int[] mappedRange = overlap.locateInTo(start, end);
+ int[] mappedRange = mapping.locateInTo(start, end);
if (mappedRange != null)
{
*/
if (SequenceOntology.getInstance().isSequenceVariant(sf.getType()))
{
- String consequence = (String) sf.getValue("consequence_type");
+ String consequence = (String) sf.getValue(CONSEQUENCE_TYPE);
if (consequence != null)
{
SequenceFeature sf2 = new SequenceFeature("consequence",
}
}
}
-
}
/**
}
SequenceFeature[] sfs = sourceSequence.getSequenceFeatures();
- MapList overlap = getGenomicRanges(sourceSequence, accessionId,
+ MapList mapping = getGenomicRanges(sourceSequence, accessionId,
targetSequence.getStart());
- if (overlap == null)
+ if (mapping == null)
{
return false;
}
- final boolean forwardStrand = overlap.isFromForwardStrand();
+ return transferFeatures(sfs, targetSequence, mapping, accessionId);
+ }
+
+ /**
+ * Transfer features to the target sequence. The start/end positions are
+ * converted using the mapping. Features which do not overlap are ignored.
+ * Features whose parent is not the specified identifier are also ignored.
+ *
+ * @param features
+ * @param targetSequence
+ * @param mapping
+ * @param parentId
+ * @return
+ */
+ protected boolean transferFeatures(SequenceFeature[] features,
+ SequenceI targetSequence, MapList mapping, String parentId)
+ {
+ final boolean forwardStrand = mapping.isFromForwardStrand();
/*
* sort features by start position (descending if reverse strand)
* before transferring (in forwards order) to the target sequence
*/
- Arrays.sort(sfs, new Comparator<SequenceFeature>()
+ Arrays.sort(features, new Comparator<SequenceFeature>()
{
@Override
public int compare(SequenceFeature o1, SequenceFeature o2)
});
boolean transferred = false;
- for (SequenceFeature sf : sfs)
+ for (SequenceFeature sf : features)
{
- if (retainFeature(sf, accessionId))
+ if (retainFeature(sf, parentId))
{
- transferFeature(sf, targetSequence, overlap);
+ transferFeature(sf, targetSequence, mapping);
transferred = true;
}
}
}
/**
- * Answers true if the feature is one to attach to the retrieved sequence
+ * Answers true if the feature type is one we want to keep for the sequence.
+ * Some features are only retrieved in order to identify the sequence range,
+ * and may then be discarded as redundant information (e.g. "CDS" feature for
+ * a CDS sequence).
+ */
+ @SuppressWarnings("unused")
+ protected boolean retainFeature(SequenceFeature sf, String accessionId)
+ {
+ return true; // override as required
+ }
+
+ /**
+ * Answers true if the feature has a Parent which refers to the given
+ * accession id, or if the feature has no parent. Answers false if the
+ * feature's Parent is for a different accession id.
*
- * @param type
+ * @param sf
+ * @param identifier
* @return
*/
- protected boolean retainFeature(SequenceFeature sf, String accessionId)
+ protected boolean featureMayBelong(SequenceFeature sf, String identifier)
{
String parent = (String) sf.getValue(PARENT);
- if (parent != null && !parent.contains(accessionId))
+ // using contains to allow for prefix "gene:", "transcript:" etc
+ if (parent != null && !parent.contains(identifier))
{
// this genomic feature belongs to a different transcript
return false;
+ " sequence with variant features";
}
- public AlignmentI getSequenceRecords(String transcriptId,
- SequenceI geneSeq) throws Exception
+ @Override
+ public AlignmentI getSequenceRecords(String identifier) throws Exception
+ {
+ return getSequenceRecords(identifier, null);
+ }
+
+ /**
+ * Returns a (possibly empty) list of features on the sequence which have the
+ * specified sequence ontology type (or a sub-type of it), and the given
+ * identifier as parent
+ *
+ * @param sequence
+ * @param type
+ * @param parentId
+ * @return
+ */
+ protected List<SequenceFeature> findFeatures(SequenceI sequence,
+ String type, String parentId)
+ {
+ List<SequenceFeature> result = new ArrayList<SequenceFeature>();
+
+ SequenceFeature[] sfs = sequence.getSequenceFeatures();
+ if (sfs != null) {
+ SequenceOntology so = SequenceOntology.getInstance();
+ for (SequenceFeature sf :sfs) {
+ if (so.isA(sf.getType(), type))
+ {
+ String parent = (String) sf.getValue(PARENT);
+ if (parent.equals(parentId))
+ {
+ result.add(sf);
+ }
+ }
+ }
+ }
+ return result;
+ }
+
+ /**
+ * Answers true if the feature type is either 'NMD_transcript_variant' or
+ * 'transcript' or one of its sub-types in the Sequence Ontology. This is
+ * needed because NMD_transcript_variant behaves like 'transcript' in Ensembl
+ * although strictly speaking it is not (it is a sub-type of
+ * sequence_variant).
+ *
+ * @param featureType
+ * @return
+ */
+ public static boolean isTranscript(String featureType)
{
- this.genomicSequence = geneSeq;
- return getSequenceRecords(transcriptId);
+ return NMD_VARIANT.equals(featureType)
+ || SequenceOntology.getInstance().isA(featureType, SequenceOntology.TRANSCRIPT);
}
}
private static final String NOTE = "Note";
- protected static final String FRAME = "FRAME";
-
protected static final String TAB = "\t";
protected static final String GFF_VERSION = "##gff-version";
out.append(strand == 1 ? "+" : (strand == -1 ? "-" : "."));
out.append(TAB);
- out.append(sf.getValue(FRAME, "."));
+ String phase = sf.getPhase();
+ out.append(phase == null ? "." : phase);
// miscellaneous key-values (GFF column 9)
String attributes = sf.getAttributes();
import jalview.datamodel.MappingType;
import jalview.datamodel.SequenceFeature;
import jalview.datamodel.SequenceI;
+import jalview.ext.ensembl.EnsemblSeqProxy;
import jalview.util.MapList;
import jalview.util.StringUtils;
/*
* Ensembl returns gene name as 'Name' for a transcript
*/
- if (SequenceOntology.getInstance().isA(sf.getType(),
- SequenceOntology.TRANSCRIPT))
+ if (EnsemblSeqProxy.isTranscript(sf.getType()))
{
desc = StringUtils.listToDelimitedString(attributes.get("Name"), ",");
}
sf.setStrand(gff[STRAND_COL]);
+ sf.setPhase(gff[PHASE_COL]);
+
if (attributes != null)
{
/*
git://source.jalview.org / jalview.git / commitdiff