Merge branch 'develop' into features/r2_11_2/JAL-3829_3dbeacons
authorJim Procter <j.procter@dundee.ac.uk>
Thu, 2 Sep 2021 14:53:01 +0000 (15:53 +0100)
committerJim Procter <j.procter@dundee.ac.uk>
Thu, 2 Sep 2021 14:53:01 +0000 (15:53 +0100)
1  2 
src/jalview/gui/SequenceFetcher.java
src/jalview/structures/models/AAStructureBindingModel.java

@@@ -27,7 -27,6 +27,7 @@@ import jalview.datamodel.DBRefEntry
  import jalview.datamodel.SequenceI;
  import jalview.fts.core.GFTSPanel;
  import jalview.fts.service.pdb.PDBFTSPanel;
 +import jalview.fts.service.threedbeacons.TDBeaconsFTSPanel;
  import jalview.fts.service.uniprot.UniprotFTSPanel;
  import jalview.io.FileFormatI;
  import jalview.io.gff.SequenceOntologyI;
@@@ -196,11 -195,6 +196,11 @@@ public class SequenceFetcher extends JP
            frame.dispose();
            new UniprotFTSPanel(SequenceFetcher.this);
          }
 +        else if ("3d-beacons".equalsIgnoreCase(currentSelection))
 +        {
 +          frame.dispose();
 +          new TDBeaconsFTSPanel(SequenceFetcher.this);
 +        }
          else
          {
            otherSourceAction();
    {
      return "Retrieved from " + database.getSelectedItem();
    }
 -
 -  AlignmentI parseResult(AlignmentI al, String title,
 +  /**
 +   * constructs an alignment frame given the data and metadata
 +   * @param al
 +   * @param title
 +   * @param currentFileFormat
 +   * @param preferredFeatureColours
 +   * @return the alignment 
 +   */
 +  public AlignmentI parseResult(AlignmentI al, String title,
            FileFormatI currentFileFormat,
            FeatureSettingsModelI preferredFeatureColours)
    {
            }
          }
  
-         if (preferredFeatureColours != null)
-         {
-           af.getViewport().applyFeaturesStyle(preferredFeatureColours);
-         }
+         af.getViewport().applyFeaturesStyle(preferredFeatureColours);
          if (Cache.getDefault("HIDE_INTRONS", true))
          {
            af.hideFeatureColumns(SequenceOntologyI.EXON, false);
@@@ -1096,10 -1096,7 +1096,10 @@@ public abstract class AAStructureBindin
          for (StructureCommandI cmd : cmds)
          {
            List<String> replies = executeCommand(cmd, true);
 -          response.addAll(replies);
 +          if (replies != null)
 +          {
 +            response.addAll(replies);
 +          }
          }
          return response;
        } finally
    }
  
    /**
-    * Returns the FeatureRenderer for the given alignment view, or null if
-    * feature display is turned off in the view.
+    * Returns the FeatureRenderer for the given alignment view
     * 
     * @param avp
     * @return
      {
        return null;
      }
-     return ap.getAlignViewport().isShowSequenceFeatures()
-             ? ap.getFeatureRenderer()
-             : null;
+     return ap.getFeatureRenderer();
    }
  
    protected void setStructureCommands(StructureCommandsI cmd)