JAL-2424 fixme’s removed
authorJim Procter <jprocter@issues.jalview.org>
Tue, 2 May 2017 13:17:23 +0000 (14:17 +0100)
committerJim Procter <jprocter@issues.jalview.org>
Tue, 2 May 2017 13:17:26 +0000 (14:17 +0100)
test/jalview/analysis/scoremodels/FeatureDistanceModelTest.java

index 6df8a66..0577fae 100644 (file)
@@ -264,9 +264,6 @@ public class FeatureDistanceModelTest
     assertEquals(distances.getValue(0, 0), 0d);
     assertEquals(distances.getValue(1, 1), 0d);
 
-    // these left to fail pending resolution of
-    // JAL-2424 (computing score as 5/6, should be 5/5)
-    // see also PCATest.testComputeSimilarity_featureDistances()
     assertEquals(distances.getValue(0, 1), 1d,
             "expected identical pairs. (check normalisation for similarity score)");
     assertEquals(distances.getValue(1, 0), 1d);
@@ -305,7 +302,6 @@ public class FeatureDistanceModelTest
     /*
      * exclude gaps
      * score = 3 + 3 + 0 + 0 + 0 + 0 = 6/6
-    // FIXME out by 1 error in cpwidth JAL-2424 - dividing by 7
      */
     params = new SimilarityParams(true, true, false, true);
     distances = sm.findDistances(view, params);